[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 CC||lu...@bywatersolutions.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #32 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

David Nind  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

--- Comment #31 from David Nind  ---
Patch now applies - have changed status back to Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #141284|0   |1
is obsolete||

--- Comment #30 from Katrin Fischer  ---
Created attachment 141286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141286=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-shelves.tt
 - opac-user.tt

Refer to David Nind's test notes from Comment 23 for a more detailed
plan for acessing these pages.

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #29 from Tomás Cohen Arazi  ---
Please rebase ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #140237|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 141284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141284=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-shelves.tt
 - opac-user.tt

Refer to David Nind's test notes from Comment 23 for a more detailed
plan for acessing these pages.

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #27 from Katrin Fischer  ---
Just realized that I tested this for the first time in 2017... ouch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds the
  release notes||class "itypetext" around
   ||item type descriptions so
   ||they can be hidden with
   ||CSS. To hide the
   ||descriptions, add
   ||.itypetext { display:none;
   ||} to the OPACUserCSS (for
   ||the OPAC) or
   ||IntranetUserCSS (for the
   ||staff interface) system
   ||preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

David Nind  changed:

   What|Removed |Added

 Attachment #140217|0   |1
is obsolete||

--- Comment #26 from David Nind  ---
Created attachment 140237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140237=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-shelves.tt
 - opac-user.tt

Refer to David Nind's test notes from Comment 23 for a more detailed
plan for acessing these pages.

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #25 from Aleisha Amohia  ---
Have rebased and addressed:

(In reply to David Nind from comment #23)
> I've tested, but haven't signed off.
> 

> 3. For the staff interface and with the CSS to hide the text description:
>. catalogue/detail.tt: see note for staff interface and
> catalogue/detail.tt - can't hide text description for 'Itemtype' shown on
> the details page before the holdings tab
> 

Fixed this

> 4. For the OPAC, I'm not sure how to test opac-results-grouped.tt: there is
> no opac-results-grouped.tt file, item type icon and text show for normal
> OPAC search results when OPACnoItemTypeImages system preference is set to
> 'Show', with OPAC CSS to hide no text description is shown in search results
> (but icon is).
>

From an old version of Koha, have removed this from the test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #137760|0   |1
is obsolete||

--- Comment #24 from Aleisha Amohia  ---
Created attachment 140217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140217=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-shelves.tt
 - opac-user.tt

Refer to David Nind's test notes from Comment 23 for a more detailed
plan for acessing these pages.

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #23 from David Nind  ---
I've tested, but haven't signed off.

Notes from testing (using koha-testing-docker):

1. Some icons only display for some pages if the item-level_itypes system
preference is set to bibliographic record.

2. May also need to set the noItemTypeImages (for staff interface) or
OpacNoItemTypeImages system preferences to 'Show'.

3. For the staff interface and with the CSS to hide the text description:
   . catalogue/detail.tt: see note for staff interface and catalogue/detail.tt
- can't hide text description for 'Itemtype' shown on the details page before
the holdings tab

4. For the OPAC, I'm not sure how to test opac-results-grouped.tt: there is no
opac-results-grouped.tt file, item type icon and text show for normal OPAC
search results when OPACnoItemTypeImages system preference is set to 'Show',
with OPAC CSS to hide no text description is shown in search results (but icon
is).

5. How to access pages to test, along with some notes: 

= STAFF INTERFACE =
 - catalogue/advsearch.tt (Home page > Advanced search)
 - catalogue/detail.tt (view the details page for a record with items - note: 
   . if item-level_itypes = specific item and noItemTypeImages set to 'Don't
show' ==> text only descriptions shown for both
   . if item-level_itypes = specific item and noItemTypeImages set to 'Show'
==> icons and text description shown for both
   . if item-level_itypes = bibliographic record and noItemTypeImages set to
'Show' ==> icons and text description only shown for the record, the Item types
column under the holdings tab is not shown
. if item-level_itypes = bibliographic record and noItemTypeImages set to
'Don't show' ==> text description only for the record,  the Item types column
under the holdings tab is not shown
 - catalogue/results.tt (set noItemTypeImages system preference to 'Show',
search in the staff interface)
 - reserve/request.tt (place a hold for a record, select a patron, item type
column displayed for specific items) 
 - virtualshelves/shelves.tt (set noItemTypeImages to 'Show', set
item-level_itypes to bibliographic record: create and add items to a public
list, Lists > select the list)

= OPAC =
 - opac-advsearch.tt (advanced search page)
 - opac-detail.tt (view the details page for a record with items)
 - opac-readingrecord.tt (check out some items for a patron, go to Your account
> your checkout history for that patron)
 - opac-reserve.tt (place a hold for a record, select 'a specific item', table
lists the item type)
 - opac-results-grouped.tt (not sure how to test this on, no longer an
opac-results-grouped.tt file; item type icon and text show on normal OPAC
search results when OPACnoItemTypeImages system preference set to 'Show')
 - opac-shelves.tt (set OPACnoItemTypeImages to 'Show', set item-level_itypes
to bibliographic record: add items to a list, view list More > Lists > select
the list)
 - opac-user.tt (set OPACnoItemTypeImages to 'Show', set item-level_itypes to
bibliographic record: check some items to a patron, go to Your account >
summary for the patron)

6. Personally, I think enhancing the existing system preferences
item-level_itypes, noItemTypeImages and OpacNoItemTypeImages would be a better
way to go. But having some way to do it is better than no way...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] Choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer  changed:

   What|Removed |Added

Summary|choice to not show the text |Choice to not show the text
   |labels for item types   |labels for item types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Nick Clemens  changed:

   What|Removed |Added

  Attachment #98778|0   |1
is obsolete||

--- Comment #22 from Nick Clemens  ---
Created attachment 137760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137760=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #21 from David Nind  ---
Hi Aleisha.

Everything looks okay to me except for the details page for records on the
staff interface from search results.

I think this is this file about line 269:
koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt

Note for testing:
- Some icons only display for some pages if the item-level_itypes system
preference is set to bibliographic record

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #84219|0   |1
is obsolete||

--- Comment #20 from Aleisha Amohia  ---
Created attachment 98778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98778=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Josef Moravec  changed:

   What|Removed |Added

 QA Contact||josef.mora...@gmail.com
 CC||josef.mora...@gmail.com
 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #19 from Josef Moravec  ---
Comment on attachment 84219
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84219
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

Review of attachment 84219:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=7960=84219)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt
@@ +121,4 @@
>  
>  [% FOREACH itemtypeloo IN advsearchloo.code_loop %]
>  [% UNLESS ( noItemTypeImages ) %][% IF ( itemtypeloo.imageurl ) %] src="[% itemtypeloo.imageurl | html %]" alt="[% itemtypeloo.description | 
> html %]" />[% END %][% END %]
> +[% itemtypeloo.description | html 
> %]

Bad ending tag - missing "/"

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ +534,4 @@
>  [% IF ( 
> onloan_items_loo.itemcallnumber ) %][ href="/cgi-bin/koha/catalogue/search.pl?idx=callnumq=%22[% 
> onloan_items_loo.itemcallnumber |uri %]%22">[% 
> onloan_items_loo.itemcallnumber | html %]][% END %]
>  ([% onloan_items_loo.count | html 
> %][% IF ( onloan_items_loo.longoverdue ) %], [% onloan_items_loo.longoverdue 
> | html %] long overdue[% END %]) date due: [% onloan_items_loo.due_date | 
> $KohaDates %]
>  [% IF item_level_itypes && 
> onloan_items_loo.description %]
> +<<< HEAD

Merge markers

@@ +566,4 @@
>  [% IF ( other_items_loo.notforloan ) 
> %][% other_items_loo.notforloan | html %][% END %]
>  ([% other_items_loo.count | html %])
>  [% IF item_level_itypes && 
> other_items_loo.description %]
> +<<< HEAD

Merge markers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Charles Farmer  changed:

   What|Removed |Added

  Attachment #83853|0   |1
is obsolete||

--- Comment #18 from Charles Farmer  ---
Created attachment 84219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84219=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #76608|0   |1
is obsolete||

--- Comment #17 from Aleisha Amohia  ---
Created attachment 83853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83853=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||charles.far...@inlibro.com

--- Comment #16 from Charles Farmer  ---
Seems to unfortunately not apply anymore because of additional '| html' filters
in the most recent templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #15 from Aleisha Amohia  ---
Forgot to make original patches obsolete. Ready to test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #62933|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #62932|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #14 from Aleisha Amohia  ---
Created attachment 76608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76608=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #13 from Fridolin SOMERS  ---
Or maybe one could change the existing preference noItemTypeImages to use
choices : image and text, image only, text only.
My2c

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin SOMERS  ---
> add a class to make it easy to hide with css.
+1

Not another system preference please :(

Actually you may use a trick by painting text with background color :
  #holdings_table .itype { color: #F3F3F3; }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #11 from Nick Clemens  ---
Agreeing with other QA here, moving to failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #9)
> (In reply to Aleisha Amohia from comment #8)
> > (In reply to Marcel de Rooy from comment #7)
> > > Have the impression that we should not hide labels with a syspref but
> > > resolve this with custom css. Please convince me that I am wrong.
> > 
> > The syspref just provides the functionality for the library to hide or show
> > the text, without having to play around with css or ask us to do it for
> > them. I don't think it's fair to assume that librarians know how to write
> > css.
> 
> We have to find a balance between adding a syspref for showing/hiding
> elements and css customization. Yes, not each librarian writes css. I will
> not block this patch and change the status to Signed off again. Another QA
> opinion please.

I must agree, my first thought was to ask why not just add a class to make it
easy to hide with css.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #9 from Marcel de Rooy  ---
(In reply to Aleisha Amohia from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> > Have the impression that we should not hide labels with a syspref but
> > resolve this with custom css. Please convince me that I am wrong.
> 
> The syspref just provides the functionality for the library to hide or show
> the text, without having to play around with css or ask us to do it for
> them. I don't think it's fair to assume that librarians know how to write
> css.

We have to find a balance between adding a syspref for showing/hiding elements
and css customization. Yes, not each librarian writes css. I will not block
this patch and change the status to Signed off again. Another QA opinion
please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #8 from Aleisha Amohia  ---
(In reply to Marcel de Rooy from comment #7)
> Have the impression that we should not hide labels with a syspref but
> resolve this with custom css. Please convince me that I am wrong.

The syspref just provides the functionality for the library to hide or show the
text, without having to play around with css or ask us to do it for them. I
don't think it's fair to assume that librarians know how to write css.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #7 from Marcel de Rooy  ---
Have the impression that we should not hide labels with a syspref but resolve
this with custom css. Please convince me that I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Nice one to test!

2 notes:
- In order to see some of the changes you need to set item-level_itypes to
'biblio record'. 
- In the OPAC the 'most popular' page currently displays the biblio level
itemtype description. A later patch could make it show the icon and add support
for the system preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #5 from Katrin Fischer  ---
Created attachment 62933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62933=edit
[SIGNED OFF] Bug 7960: [FOLLOW-UP] Adding to places missed in first patch

This patch adds the use of the syspref to:
= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #62344|0   |1
is obsolete||
  Attachment #62807|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 62932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62932=edit
[SIGNED OFF] Bug 7960: Add syspref to hide/show item type text labels in
catalog

To test:
1) Apply patch and update database
2) Go to Admin -> Sysprefs -> Find system preference 'ItemTypeText'
3) Should have default value 'Show'. Change to 'Don't show'.
4) Make sure 'noItemTypeImages' is enabled.
5) Search for a record in catalog on staff client. Go to detail page.
6) Confirm the text label for the item type is hidden, but the item type
image still shows.
7) Search for a record in catalog on OPAC. Go to detail page.
8) Confirm the text label for the item type is hidden, but the item type
image still shows.
9) Go back to sysprefs and set 'ItemTypeText' to 'Show'.
10) Confirm text labels now show on detail pages.

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #3 from Aleisha Amohia  ---
Created attachment 62807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62807=edit
Bug 7960: [FOLLOW-UP] Adding to places missed in first patch

This patch adds the use of the syspref to:
= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
This looks fine to me but it doesn't cover all item type image instances.
Searching the templates for ".imageurl" shows several others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||alei...@catalyst.net.nz
   Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #1 from Aleisha Amohia  ---
Created attachment 62344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62344=edit
Bug 7960: Add syspref to hide/show item type text labels in catalog

To test:
1) Apply patch and update database
2) Go to Admin -> Sysprefs -> Find system preference 'ItemTypeText'
3) Should have default value 'Show'. Change to 'Don't show'.
4) Make sure 'noItemTypeImages' is enabled.
5) Search for a record in catalog on staff client. Go to detail page.
6) Confirm the text label for the item type is hidden, but the item type
image still shows.
7) Search for a record in catalog on OPAC. Go to detail page.
8) Confirm the text label for the item type is hidden, but the item type
image still shows.
9) Go back to sysprefs and set 'ItemTypeText' to 'Show'.
10) Confirm text labels now show on detail pages.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7960] choice to not show the text labels for item types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Helen Linda helen.li...@goddard.edu changed:

   What|Removed |Added

 CC||helen.li...@goddard.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/