[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 --- Comment #16 from Bouzid --- Ok Jonathan. thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976
Jonathan Druart changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|--- |FIXED
Blocks||16447
--- Comment #15 from Jonathan Druart
---
(In reply to Bouzid from comment #14)
> Hi all,
> The borrow permission is removed, but it existing in this files:
>
> opac/opac-idref.pl:40:flagsrequired => { borrow => 1 },
> opac/opac-news-rss.pl:37:flagsrequired => { borrow => 1 },
> opac/opac-restrictedpage.pl:43:flagsrequired => { borrow => 1 },
> opac/svc/login:46 checkauth( $query, 1, { borrow => 1 }, 'opac',
> $decoded_json->{'email'} );
>
> I think, it's a bug.
>
> Bouzid.
Yes it is, it always better to open a new bug report, especially when the
original one is marked as resolved.
See bug 16447
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16447
[Bug 16447] "Borrow Permission" should not be used anymore
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976
Bouzid changed:
What|Removed |Added
Status|RESOLVED|REOPENED
CC||bouzid.ferg...@inlibro.com
Resolution|FIXED |---
--- Comment #14 from Bouzid ---
Hi all,
The borrow permission is removed, but it existing in this files:
opac/opac-idref.pl:40:flagsrequired => { borrow => 1 },
opac/opac-news-rss.pl:37:flagsrequired => { borrow => 1 },
opac/opac-restrictedpage.pl:43:flagsrequired => { borrow => 1 },
opac/svc/login:46 checkauth( $query, 1, { borrow => 1 }, 'opac',
$decoded_json->{'email'} );
I think, it's a bug.
Bouzid.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Kyle M Hall changed: What|Removed |Added Attachment #38901|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 38974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38974&action=edit [PASSED QA] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #38900|0 |1 is obsolete|| --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 38901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38901&action=edit [SIGNED-OFF] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #37944|0 |1 is obsolete|| --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 38900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38900&action=edit [SIGNED-OFF] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 --- Comment #8 from Jonathan Druart --- Created attachment 37944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37944&action=edit Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Should we also adjust the borrowres.flags for staff users who had borrows > permission? Any negative side effects if we don't? Yes you are right, to be safe it's certainly better :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #7 from Katrin Fischer --- Should we also adjust the borrowres.flags for staff users who had borrows permission? Any negative side effects if we don't? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What|Removed |Added Attachment #37914|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 37925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37925&action=edit [PASSED QA] Bug 7976: Remove the borrow permission The borrow permission was used but uselessly. For instance, at the opac, the flagsrequired parameter was set to 'borrow' but the 'authnotrequired' was set also (which means no auth required). At the end, this permission was used at only 1 place: for the basket, intranet side. This can be replaced with the catalogue permission (which is used to search). Test plan: 1/ Confirm that you are able to show/download/sent the cart (intranet side) with the catalogue permission. 2/ At the OPAC, you should be able to access the same pages as before with any other permissions. Concretely it is quite difficult to test this patch, you should have a look at the code. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What|Removed |Added Summary|"Borrow Permission" is not |"Borrow Permission" is not |useless and can be removed |used and can be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
