[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #29 from Marcel de Rooy  ---
This should be first Koha report using the REST API at the intranet side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #28 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #27 from Nick Clemens  ---
Created attachment 55448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55448=edit
Bug 8030 - (QA Folllowup) Use Koha::Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #26 from Kyle M Hall  ---
This patch uses GetBranchesLoop which has been removed. Please provide followup
to use Koha::Libraries!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #53508|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #54659|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #54712|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #24 from Katrin Fischer  ---
Created attachment 55201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55201=edit
[PASSED QA] Bug 8030 (QA Followup) - Use REST api and provide feedback

Use REST API
If cancelled return to previous selection
If fail return to previous selection
Use fa spinning icon while waiting
Disable select while waiting

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #25 from Katrin Fischer  ---
Created attachment 55202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55202=edit
[PASSED QA] Bug 8030 - (QA followup) Remove svc file no longer user Use
animated gif for waiting as elsewhere Remove confirmation

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #23 from Katrin Fischer  ---
Created attachment 55200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55200=edit
[PASSED QA] Bug 8030 - Change pickup location of a hold from patron record

To test:
1 - Place some holds for a patron
2 - Load the patron into checkout module
3 - View thier holds tab, should have a dropdwon for location
4 - Alter the location
5 - You should recieve a confirmation box
6 - Confirm that pressing cancel does not update holds
7 - Confirm that pressing Yes does update the hold
8 - Confirm that waiting holds are not updateable

Signed-off-by: Jason M. Burds 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Kyle M Hall  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #22 from Katrin Fischer  ---
Marking 'BLOCKED' for now - please swich back once dependencies have been
cleared!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #21 from Katrin Fischer  ---
We've concluded to wait for this until bug 14868 is sorted out and not to
backport REST API patches for now to the stable releases until we have worked
out the structure of things a bit more.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Depends on||14868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #20 from Katrin Fischer  ---
I am adding this to the agenda of the next dev meeting - I think if we make the
API mandatory, we need to take other steps too (amending installation
instructions for exapmle) and we should be aware of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #19 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #18)
> Hm, I haven't installed the RESTful API or activated it. I didn't suspect it
> to be a mandatory thing at this point in time, am I mistaken?
> Owen had the same error message testing this.

As of bug 17030 the REST API should be activated by default for new
installs/upgrades and this feature is based on that assumption.

If you add Mirko's nightly builds to your apt sources and upgrade then all
should be running:
https://apt.abunchofthings.net/koha-nightly/

you can test by accessing the staff url of your site at
http://localhost:8081/api/v1/holds

Updating hostname/port as necessary

If all is working you will get a JSON blob of the holds in your system

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #18 from Katrin Fischer  ---
Hm, I haven't installed the RESTful API or activated it. I didn't suspect it to
be a mandatory thing at this point in time, am I mistaken?
Owen had the same error message testing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #17 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #13)
> 3) After confirming the message, I get an error alert: There was an
> error:error Method Not Allowed

I don't see this one, do you have the REST API running?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #16 from Nick Clemens  ---
Created attachment 54712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54712=edit
Bug 8030 - (QA followup) Remove svc file no longer user Use animated
gif for waiting as elsewhere Remove confirmation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #15 from Owen Leonard  ---
(In reply to Nick Clemens from comment #11)

> Use fa spinning icon while waiting

Do you have a plan to replace other spinners in the interface with this
version? We need to keep things consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #14 from Katrin Fischer  ---
Ah, one more small thing, could we use "updated" instead of "set" to indicate a
change? "set" is quite hard to translate correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Katrin Fischer  ---
Hi Nick,

some issues here:
1) You forgot to remove the update_location file form svc that is no longer
used.
2) when changing the pickup location I get an alert "You want to change the
pickup location?" - I am not sure this kind of message is necessary, we usually
only seem to ask for confirmation when something is deleted.
3) After confirming the message, I get an error alert: There was an error:error
Method Not Allowed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #12 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #10)
> Nick, can you please take a look at the questions and comments? Thx!
All set

I did an admittedly rough job of inserting the icon, some feedback from Owen on
placement and preferred icon would be apreciated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #11 from Nick Clemens  ---
Created attachment 54659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54659=edit
Bug 8030 (QA Followup) - Use REST api and provide feedback

Use REST API
If cancelled return to previous selection
If fail return to previous selection
Use fa spinning icon while waiting
Disable select while waiting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #10 from Katrin Fischer  ---
Nick, can you please take a look at the questions and comments? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
Why don't you use the REST API (bug 13903)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
(In reply to Owen Leonard from comment #6)
> Would it be possible to return the branch  to its original choice if
> you choose "cancel" after changing it?

I think that's a good idea. It would also be nice to have a spinner next to the
pulldown while it's being updated. Right now I'm not seeing any real visual
feedback that the update is in process or has completed. Take a look at the
Animated Icons section here: http://fontawesome.io/examples/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53047|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 53508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53508=edit
[SIGNED-OFF] Bug 8030 - Change pickup location of a hold from patron record

To test:
1 - Place some holds for a patron
2 - Load the patron into checkout module
3 - View thier holds tab, should have a dropdwon for location
4 - Alter the location
5 - You should recieve a confirmation box
6 - Confirm that pressing cancel does not update holds
7 - Confirm that pressing Yes does update the hold
8 - Confirm that waiting holds are not updateable

Signed-off-by: Jason M. Burds 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #6 from Owen Leonard  ---
Would it be possible to return the branch  to its original choice if
you choose "cancel" after changing it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nicole C. Engard  changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

  Attachment #53046|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 53047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53047=edit
Bug 8030 - Change pickup location of a hold from patron record

To test:
1 - Place some holds for a patron
2 - Load the patron into checkout module
3 - View thier holds tab, should have a dropdwon for location
4 - Alter the location
5 - You should recieve a confirmation box
6 - Confirm that pressing cancel does not update holds
7 - Confirm that pressing Yes does update the hold
8 - Confirm that waiting holds are not updateable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #4 from Nick Clemens  ---
needs to adjust for in transit holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #3 from Nick Clemens  ---
Created attachment 53046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53046=edit
Bug 8030 - Change pickup location of a hold from patron record

To test:
1 - Place some holds for a patron
2 - Load the patron into checkout module
3 - View thier holds tab, should have a dropdwon for location
4 - Alter the location
5 - You should recieve a confirmation box
6 - Confirm that pressing cancel does not update holds
7 - Confirm that pressing Yes does update the hold
8 - Confirm that waiting holds are not updateable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Nick Clemens  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

--- Comment #2 from Nick Clemens  ---
Work to be done:
1) Modify the pickup location on holds table to be a pulldown of pickup
locations
2) Add new svc/rest script to update hold pickup locations
3) Modify javascript such that change the pickup location first asks for
confirmation,
if change is confirmed, pickup location will be updated via ajax process
if change is canceled, previous pickup location will be set for pulldown

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Assignee|koha.sek...@gmail.com   |koha-b...@lists.koha-commun
   ||ity.org
Summary|edit hold from patron   |Change pickup location of a
   |record  |hold from patron record

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/