[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

David Cook  changed:

   What|Removed |Added

 CC||jwag...@ptfs.com

--- Comment #90 from David Cook  ---
*** Bug 4283 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||15682


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15682
[Bug 15682] Merging records from cataloguing search only allows to merge 2
records
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||15358


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358
[Bug 15358] merge.pl does not populate values to merge
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Ian Palko  changed:

   What|Removed |Added

 CC||libr...@stas.org

--- Comment #89 from Ian Palko  ---
These patches seems to break authority merging.

I have opened a new Bug report in Bug 15358 regarding this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #88 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

  Attachment #35905|0   |1
is obsolete||

--- Comment #86 from Julian Maurice  ---
Created attachment 44638
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44638=edit
[PASSED QA] Bug 8064 [QA Followup] - Remove trailing whitespace

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

  Attachment #35904|0   |1
is obsolete||

--- Comment #85 from Julian Maurice  ---
Created attachment 44637
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44637=edit
[PASSED QA] Bug 8064: Fix unit tests for createMergeHash

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

  Attachment #35903|0   |1
is obsolete||

--- Comment #84 from Julian Maurice  ---
Created attachment 44636
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44636=edit
[PASSED QA] Bug 8064: Little fix for 003, 005, 008 in MARC21

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #87 from Julian Maurice  ---
updatedatabase.pl entry moved into atomicupdate/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

  Attachment #35901|0   |1
is obsolete||

--- Comment #82 from Julian Maurice  ---
Created attachment 44634
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44634=edit
[PASSED QA] Bug 8064: Change the way target record is built.

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

  Attachment #35900|0   |1
is obsolete||

--- Comment #81 from Julian Maurice  ---
Created attachment 44633
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44633=edit
[PASSED QA] Bug 8064: Merge several biblios

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

  Attachment #35902|0   |1
is obsolete||

--- Comment #83 from Julian Maurice  ---
Created attachment 44635
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44635=edit
[PASSED QA] Bug 8064: Fix issues with control fields and non-repeatable check

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Jenny Dallas  changed:

   What|Removed |Added

 CC||limbo...@gmail.com

--- Comment #80 from Jenny Dallas  ---
Invaluable writing - Apropos , if others is interested in merging of some PDF
files , I encountered a tool here  http://www.altomerge.com and also here
http://pdf.ac/3v1u8M

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #79 from Tomás Cohen Arazi  ---
Please rebase against master. Better put the updatedatabase.pl entry on an
atomicupdate file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8411

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

jdem...@roseville.ca.us jdem...@roseville.ca.us changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10551

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #73 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35901
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35901action=edit
[PASSED QA] Bug 8064: Change the way target record is built.

Instead of copying/removing a piece of DOM in target record each time a
checkbox is checked/unchecked, the target record is *entirely* rebuilt
each time a checkbox is checked/unchecked.
This is slower but allow for a more consistent and less error-prone
behaviour.

This patch also fix the mandatory check for subfields

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #76 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35904
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35904action=edit
[PASSED QA] Bug 8064: Fix unit tests for createMergeHash

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35738|0   |1
is obsolete||
  Attachment #35739|0   |1
is obsolete||
  Attachment #35740|0   |1
is obsolete||
  Attachment #35741|0   |1
is obsolete||
  Attachment #35742|0   |1
is obsolete||

--- Comment #72 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35900
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35900action=edit
[PASSED QA] Bug 8064: Merge several biblios

This patch improves the existing merging tool by adding possibility to
merge more than 2 biblios.
There is no functional changes:
  - Add some biblios to a list
  - In the list check some biblios and click on 'Merge selected records'
  - Choose the biblio which will be kept, all others will be deleted
  - On the next page you have all biblios you chose in tabs (left side
of the screen) and the preview of result (right side)
  - Pick some fields or subfields from records that will be deleted or
delete some fields from reference record.
  - Click on 'Merge', if there is no errors you are redirected to the
biblio view.

Added checks for non-repeatable subfields
Added checks for mandatory fields and subfields before submitting the
form.
Added a final report which display deleted records (see syspref
MergeReportFields)

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #77 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35905
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35905action=edit
[PASSED QA] Bug 8064 [QA Followup] - Remove trailing whitespace

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #75 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35903
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35903action=edit
[PASSED QA] Bug 8064: Little fix for 003, 005, 008 in MARC21

I found a little bug in the patch. Subfield '@' of tags 003, 005, 008 in
MARC21 were not correctly handled by function check_mandatory() in
merge.tt. I fixed the problem. In my opinion, the patch can be signed
off.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #74 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35902
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35902action=edit
[PASSED QA] Bug 8064: Fix issues with control fields and non-repeatable check

Fields  010 were systematically unchecked during target rebuild because
they have no subfields (unchecking manually all subfields of a field
automatically uncheck the field)
When user check a field or a subfield, we have to uncheck it before
calling (sub)field_can_be_added. Otherwise, field is treated as if it
was already in target record, and this is a problem for non-repeatable
fields.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #78 from Kyle M Hall k...@bywatersolutions.com ---
QA Note: holds are merged in a very odd, un-good way, but the behavior exists
on master, so the issue predates this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29922|0   |1
is obsolete||

--- Comment #68 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35739
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35739action=edit
[SIGNED-OFF] Bug 8064: Change the way target record is built.

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29921|0   |1
is obsolete||

--- Comment #67 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35738
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35738action=edit
[SIGNED-OFF] Bug 8064: Merge several biblios

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29924|0   |1
is obsolete||

--- Comment #70 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35741
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35741action=edit
[SIGNED-OFF] Bug 8064: Little fix for 003, 005, 008 in MARC21

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29925|0   |1
is obsolete||

--- Comment #71 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35742
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35742action=edit
[SIGNED-OFF] Bug 8064: Fix unit tests for createMergeHash

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29923|0   |1
is obsolete||

--- Comment #69 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35740
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35740action=edit
[SIGNED-OFF] Bug 8064: Fix issues with control fields and non-repeatable check

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #66 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Sorry, couldn't apply this feature and the reject files didn't make much sense
to me. I worked on Bug 4283 and tried to sign this one off as a target of
opportunity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=4283

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29324|0   |1
is obsolete||

--- Comment #61 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 29921
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29921action=edit
[SIGNED-OFF] Bug 8064: Merge several biblios

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29325|0   |1
is obsolete||

--- Comment #62 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 29922
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29922action=edit
[SIGNED-OFF] Bug 8064: Change the way target record is built.

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29326|0   |1
is obsolete||

--- Comment #63 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 29923
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29923action=edit
[SIGNED-OFF] Bug 8064: Fix issues with control fields and non-repeatable check

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29327|0   |1
is obsolete||

--- Comment #64 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 29924
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29924action=edit
[SIGNED-OFF] Bug 8064: Little fix for 003, 005, 008 in MARC21

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29328|0   |1
is obsolete||

--- Comment #65 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 29925
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29925action=edit
[SIGNED-OFF] Bug 8064: Fix unit tests for createMergeHash

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #60 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Patch doesn't apply currently:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 8064: Merge several biblios
Applying: Bug 8064: Change the way target record is built.
Using index info to reconstruct a base tree...
Mkoha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc
Mkoha-tmpl/intranet-tmpl/prog/en/js/merge-record.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/merge-record.js
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/js/merge-record.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/merge-record-strings.inc
Failed to merge in the changes.
Patch failed at 0001 Bug 8064: Change the way target record is built.
The copy of the patch that failed is found in:
   /home/katrin/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Patch left in
/tmp/SIGNED-OFF-Bug-8064-Change-the-way-target-record-i-ze4drL.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #28829|0   |1
is obsolete||

--- Comment #55 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29324
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29324action=edit
[SIGNED-OFF] Bug 8064: Merge several biblios

This patch improves the existing merging tool by adding possibility to
merge more than 2 biblios.
There is no functional changes:
  - Add some biblios to a list
  - In the list check some biblios and click on 'Merge selected records'
  - Choose the biblio which will be kept, all others will be deleted
  - On the next page you have all biblios you chose in tabs (left side
of the screen) and the preview of result (right side)
  - Pick some fields or subfields from records that will be deleted or
delete some fields from reference record.
  - Click on 'Merge', if there is no errors you are redirected to the
biblio view.

Added checks for non-repeatable subfields
Added checks for mandatory fields and subfields before submitting the
form.
Added a final report which display deleted records (see syspref
MergeReportFields)

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Tested on MARC21, works as decribed.
Mergind 3 records, uncheking some field on target, adding fields from
deleted records.
Add bug number to updatedatabase message.

All test pass. No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #28833|0   |1
is obsolete||

--- Comment #59 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29328
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29328action=edit
[SIGNED-OFF] Bug 8064: Fix unit tests for createMergeHash

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #28831|0   |1
is obsolete||

--- Comment #57 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29326
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29326action=edit
[SIGNED-OFF] Bug 8064: Fix issues with control fields and non-repeatable check

Fields  010 were systematically unchecked during target rebuild because
they have no subfields (unchecking manually all subfields of a field
automatically uncheck the field)
When user check a field or a subfield, we have to uncheck it before
calling (sub)field_can_be_added. Otherwise, field is treated as if it
was already in target record, and this is a problem for non-repeatable
fields.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #28832|0   |1
is obsolete||

--- Comment #58 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29327
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29327action=edit
[SIGNED-OFF] Bug 8064: Little fix for 003, 005, 008 in MARC21

I found a little bug in the patch. Subfield '@' of tags 003, 005, 008 in
MARC21 were not correctly handled by function check_mandatory() in
merge.tt. I fixed the problem. In my opinion, the patch can be signed
off.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #28830|0   |1
is obsolete||

--- Comment #56 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29325
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29325action=edit
[SIGNED-OFF] Bug 8064: Change the way target record is built.

Instead of copying/removing a piece of DOM in target record each time a
checkbox is checked/unchecked, the target record is *entirely* rebuilt
each time a checkbox is checked/unchecked.
This is slower but allow for a more consistent and less error-prone
behaviour.

This patch also fix the mandatory check for subfields

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #26055|0   |1
is obsolete||

--- Comment #50 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28829
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28829action=edit
Bug 8064: Merge several biblios

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #26056|0   |1
is obsolete||

--- Comment #51 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28830
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28830action=edit
Bug 8064: Change the way target record is built.

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28726|0   |1
is obsolete||

--- Comment #54 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28833
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28833action=edit
Bug 8064: Fix unit tests for createMergeHash

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #26057|0   |1
is obsolete||

--- Comment #52 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28831
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28831action=edit
Bug 8064: Fix issues with control fields and non-repeatable check

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #26058|0   |1
is obsolete||

--- Comment #53 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28832
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28832action=edit
Bug 8064: Little fix for 003, 005, 008 in MARC21

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #47 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28726
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28726action=edit
Bug 8064: Fix unit tests for createMergeHash

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #48 from Julian Maurice julian.maur...@biblibre.com ---
Unit tests were wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #49 from Paola Rossi paola.ro...@cineca.it ---
I try to apply against master 3.17.00.007

Applying: Bug 8064: Merge several biblios
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 8064: Merge several biblios

I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
With these patches some unit tests fail, they are ok on master:

t/Koha_MetadataRecord.t   (Wstat: 512 Tests: 4 Failed: 2)
  Failed tests:  3-4
  Non-zero exit status: 2
t/Koha_Util_MARC.t(Wstat: 512 Tests: 4 Failed: 2)
  Failed tests:  2-3
  Non-zero exit status: 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Stefano Bargioni bargi...@pusc.it changed:

   What|Removed |Added

  Attachment #24078|0   |1
is obsolete||

--- Comment #39 from Stefano Bargioni bargi...@pusc.it ---
Created attachment 26055
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26055action=edit
Bug 8064: Merge several biblios

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Stefano Bargioni bargi...@pusc.it changed:

   What|Removed |Added

  Attachment #24080|0   |1
is obsolete||

--- Comment #41 from Stefano Bargioni bargi...@pusc.it ---
Created attachment 26057
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26057action=edit
Bug 8064: Fix issues with control fields and non-repeatable check

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #42 from Stefano Bargioni bargi...@pusc.it ---
Created attachment 26058
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26058action=edit
8064-Little fix for 003 005 008 in MARC21

This patch adds one line to the check_mandatory function

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

 CC||z.taj...@cineca.it

--- Comment #43 from Zeno Tajoli z.taj...@cineca.it ---
Stefano signed off for MARC21 records.
So now the patch is working for Unimarc and MARC21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #44 from Magnus Enger mag...@enger.priv.no ---
(In reply to Zeno Tajoli from comment #43)
 Stefano signed off for MARC21 records.
 So now the patch is working for Unimarc and MARC21

I think MARC21 and NORMARC are similar enough that testing with NORMARC is not
necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #45 from Julian Maurice julian.maur...@biblibre.com ---
This patch (attachment 26058) bypass mandatory check for fields  010. But at
least the merge is not blocked anymore. So I think it could be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #37 from mathieu saby mathsaby...@gmail.com ---
nobody to test that on MARC21?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #36 from Paola Rossi paola.ro...@cineca.it ---
I test against master 3.15.00.012 , unimarc, icu, italian version.

All the items of all the merged records are kept in the output record (OK).
In 005 time is the time of the merge (OK).
The use of pref MergeReportFields is OK too. Report shows all the required
columns (except the ones whose values are empty for all the records involved in
the merge, OK).

So my test is OK for unimarc, italian version.

I let you complete the test on marc21. I shall not work on bugzilla in the next
weeks.

I keep the Needs Signoff status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #23708|0   |1
is obsolete||

--- Comment #33 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 24078
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24078action=edit
Bug 8064: Merge several biblios

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #23710|0   |1
is obsolete||

--- Comment #35 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 24080
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24080action=edit
Bug 8064: Fix issues with control fields and non-repeatable check

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #23709|0   |1
is obsolete||

--- Comment #34 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 24079
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24079action=edit
Bug 8064: Change the way target record is built.

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #22749|0   |1
is obsolete||

--- Comment #31 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23709
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23709action=edit
Bug 8064: Change the way target record is built.

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #21351|0   |1
is obsolete||

--- Comment #30 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23708
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23708action=edit
Bug 8064: Merge several biblios

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #32 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23710
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23710action=edit
Bug 8064: Fix issues with control fields and non-repeatable check

Fields  010 were systematically unchecked during target rebuild because
they have no subfields (unchecking manually all subfields of a field
automatically uncheck the field)
When user check a field or a subfield, we have to uncheck it before
calling (sub)field_can_be_added. Otherwise, field is treated as if it
was already in target record, and this is a problem for non-repeatable
fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #29 from Paola Rossi paola.ro...@cineca.it ---
Against master 3.13.00.042, updatedatabase.pl needs to be rebased.
So I pass the patch to Failed QA status.
If I install marc21, then 001/003/005/008 are always required by koha; The four
fields are displayed and are unchecked, but they are not selectable in any way.
So I can't merge the records in any way.
If I install unimarc, I can merge.
If a mandatory field of a merging record is unchecked by user, and it isn't a
repeatable field, the user can't add it in any way: koha says The field is
non-repeatable and already exists in the destination record. Therefore, you
cannot add it..
Now I can copy the LAST field of a merging record to the destination record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #28 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 22749
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22749action=edit
Bug 8064: Change the way target record is built.

Instead of copying/removing a piece of DOM in target record each time a
checkbox is checked/unchecked, the target record is *entirely* rebuilt
each time a checkbox is checked/unchecked.
This is slower but allow for a more consistent and less error-prone
behaviour.

This patch also fix the mandatory check for subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||paola.ro...@cineca.it

--- Comment #25 from Paola Rossi paola.ro...@cineca.it ---
As it was written in comment 19, I still get the following message when I click
the Merge button:
Following required subfields are missing:
- 003$@
- 008$@
- 005$@
As it was written in comment 18, there is a problem when you try to copy the
LAST field of the record you destroy to the destination record.
So I don't sign off, and pass the patch to Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #26 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Hi
I don't remember having the fist issue you mentionned when I tested with
UNIMARC records.
Jonathan, is it possible that the patch does not work well with MARC21 records?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #27 from Paola Rossi paola.ro...@cineca.it ---
I as worked with MARC21 en.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #18923|0   |1
is obsolete||
  Attachment #19413|0   |1
is obsolete||

--- Comment #22 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 21351
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21351action=edit
Bug 8064: Merge several biblios

This patch improves the existing merging tool by adding possibility to
merge more than 2 biblios.
There is no functional changes:
  - Add some biblios to a list
  - In the list check some biblios and click on 'Merge selected records'
  - Choose the biblio which will be kept, all others will be deleted
  - On the next page you have all biblios you chose in tabs (left side
of the screen) and the preview of result (right side)
  - Pick some fields or subfields from records that will be deleted or
delete some fields from reference record.
  - Click on 'Merge', if there is no errors you are redirected to the
biblio view.

Added checks for non-repeatable subfields
Added checks for mandatory fields and subfields before submitting the
form.
Added a final report which display deleted records (see syspref
MergeReportFields)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #23 from Julian Maurice julian.maur...@biblibre.com ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||git...@bugs.koha-community.
   ||org
   When did the bot||2013-09-24
last check this||

--- Comment #24 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Julian and Mathieu,
bit confused here - there is no sign-off on the latest bug report and also it
looks like Jared found a problem while testing - I am setting this to Failed
QA. Julian - please check if you can reproduce Jared's problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #21 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I wanted to test it again, but there is a conflict, the main patch does not
apply anymore.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #19 from Jared Camins-Esakov jcam...@cpbibliography.com ---
I just tested the most recent version of this patch (which has not been signed
off), and I'm not sure it works. I get the following message when I click the
Merge button:
Following required subfields are missing:
- 003$@
- 008$@
- 005$@

However, all three fields are in my target record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #18 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Kyle, there is a problem in master when you try to copy the LAST field of the
record you destroy to the destination record (942 field in your example).
The problem occur even withou this patch.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
This does not appear to be working correctly. The field merging seems to be the
problem. Video: http://screencast.com/t/9T9SMPut7wjT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #15 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19411
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19411action=edit
Screenshot of merge form

Hi Kyle,

I think you did not apply the patch correctly.
On the merge page you can normally see (ref) in one tab and a text box at the
bottom of the page (see attached screenshot).
Could you confirm, please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #16 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19413
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19413action=edit
Bug 8064: Merge several biblios

This patch improves the existing merging tool by adding possibility to
merge more than 2 biblios.
There is no functional changes:
  - Add some biblios to a list
  - In the list check some biblios and click on 'Merge selected records'
  - Choose the biblio which will be kept, all others will be deleted
  - On the next page you have all biblios you chose in tabs (left side
of the screen) and the preview of result (right side)
  - Pick some fields or subfields from records that will be deleted or
delete some fields from reference record.
  - Click on 'Merge', if there is no errors you are redirected to the
biblio view.

Added checks for non-repeatable subfields
Added checks for mandatory fields and subfields before submitting the
form.
Added a final report which display deleted records (see syspref
MergeReportFields)

This patch is built on top of Bug 9755

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #17 from Julian Maurice julian.maur...@biblibre.com ---
Patch rebased on Bug 9755

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #12 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I applied 9755, then 8064.
I launched perl updatedatabase.pl for creating the new syspref.
I put 20 records in a list and merge them.
Everything works fine : 
- all items are moved,
- holds and checkouts are not lost,
- I could move some fields of merged records in destination record
- I could remove some fields of reference record from destination record
- the report table is nice
Ex : with Syspref MergeReportFields 200af,210a,600 the result is : 
Biblionumber 200$a 200$f 210$a 606$2 606$3 606$9
606$a 606$x 606$y 606$z

I have only one comment, regarding the syspref and its description : 
example: '001,245ab,600' displays:
value of 001
subfields a and b of fields 245
all subfields of fields 600

Maybe the mention of 001 should be removed, as your report table always
contains a first column with biblionumber.
(I assume here 001 always contains biblionumber. Maybe it is not the case
everywhere?)

But this is a detail, so I sign off.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

  Attachment #18840|0   |1
is obsolete||

--- Comment #13 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 18923
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18923action=edit
[SIGNED OFF] Bug 8064: Merge several biblios

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Depends on||9755

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #18433|0   |1
is obsolete||

--- Comment #10 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 18840
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18840action=edit
Bug 8064: Merge several biblios

This patch improves the existing merging tool by adding possibility to
merge more than 2 biblios.
There is no functional changes:
  - Add some biblios to a list
  - In the list check some biblios and click on 'Merge selected records'
  - Choose the biblio which will be kept, all others will be deleted
  - On the next page you have all biblios you chose in tabs (left side
of the screen) and the preview of result (right side)
  - Pick some fields or subfields from records that will be deleted or
delete some fields from reference record.
  - Click on 'Merge', if there is no errors you are redirected to the
biblio view.

Added checks for non-repeatable subfields
Added checks for mandatory fields and subfields before submitting the
form.
Added a final report which display deleted records (see syspref
MergeReportFields)

This patch is built on top of Bug 9755

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8064] Merge several biblio records

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #11 from Julian Maurice julian.maur...@biblibre.com ---
Please apply all patches from Bug 9755 before testing this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/