[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #17 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #16 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #15 from Mason James --- (In reply to comment #14) > Created attachment 14932 [details] > Bug 8108 [Follow-up, revised] Remove unused OPAC images > > Signed-off-by: Jonathan Druart > Signed-off-by: Mason James testing 1 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp var') passing QA - awesome patch Owen :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Mason James changed: What|Removed |Added Attachment #14081|0 |1 is obsolete|| --- Comment #14 from Mason James --- Created attachment 14932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14932&action=edit Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images Signed-off-by: Jonathan Druart Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Jonathan Druart changed: What|Removed |Added Attachment #14080|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 14081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14081&action=edit Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Attachment #13944|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 14080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14080&action=edit Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #11 from Jonathan Druart --- I found some references to these files: koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css:background-image: url(../../images/tag-small-disabled.png); koha-tmpl/opac-tmpl/ccsr/en/css/opac.css:background-image: url(../../images/tag-small.png); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #10 from Owen Leonard --- I have submitted a patch for Bug 9278 which removes sanop.css. This should eliminate the references noted in Comment 9. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Depends on||9278 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108
--- Comment #9 from Kyle M Hall ---
It looks like some of these images are still referenced in some css files. I
imagine that's a problem.
$ git grep "addtobasket.gif"
koha-tmpl/opac-tmpl/ccsr/en/css/sanop.css: background-image:
url(../images/addtobasket.gif);
koha-tmpl/opac-tmpl/prog/en/css/sanop.css: background-image:
url(../images/addtobasket.gif);
git grep "cart-small.gif"
koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css:background:
transparent url("../../img/cart-small.gif") 0 3px no-repeat;
koha-tmpl/opac-tmpl/ccsr/en/css/sanop.css:background-image :
url(../images/cart-small.gif);
koha-tmpl/opac-tmpl/prog/en/css/sanop.css: background-image :
url(../images/cart-small.gif);
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Attachment #13600|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 13944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13944&action=edit Bug 8108 [Follow-up, revised] Remove unused images from the OPAC This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revision: Rebased on current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||k...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Version|3.10|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Attachment #9654|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 13600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13600&action=edit Bug 8108 [Follow-up] Remove unused images from the OPAC This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Status|Pushed to Master|ASSIGNED --- Comment #6 from Owen Leonard --- I'm moving this back to ASSIGNED because I see a couple images which are still present but I think unused. I think the star ratings images can now be safely removed as well now that they're replaced by a sprite. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Paul Poulain changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #5 from Paul Poulain --- I searched remaining references to some (not all) files removed. Could not find any problem. Patch pushed Patch could be backported to 3.8 but can also wait for 3.10 to avoid any regression in case we missed something -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 --- Comment #4 from Owen Leonard --- (In reply to comment #3) > Could one of you (chris / owen) let us know how you've got the list of > unused images ? I searched for references to each individual file in CSS and TT files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #3 from Paul Poulain --- Could one of you (chris / owen) let us know how you've got the list of unused images ? QA comments: remove-file only patch. passed QA (will push once I can be sure that the images are safely removed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Chris Cormack changed: What|Removed |Added Attachment #9619|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 9654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9654&action=edit Bug 8108 - Remove unused images from the OPAC Removing image files which are no longer used. Some have been replaced by a sprite, some by CSS gradients, and some are simply left behind from previous designs. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8108] Remove unused images from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 --- Comment #1 from Owen Leonard --- Created attachment 9619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9619&action=edit Bug 8108 - Remove unused images from the OPAC Removing image files which are no longer used. Some have been replaced by a sprite, some by CSS gradients, and some are simply left behind from previous designs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
