[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com QA Contact||paul.poul...@biblibre.com --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * 2 signoffs, great * passes koha-qa.pl * no side effect risk I can imagine, script related only to waitingreserves.pl passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #12837|0 |1 is obsolete|| --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 12875 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12875action=edit Bug 8213 - Cancel All button on holds over tab cancels both holds over and holds waiting Signed-off-by: Melia Meggs me...@test.bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #7 from Melia Meggs me...@bywatersolutions.com --- Created attachment 12837 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12837action=edit [Signed off] Bug 8213 - Cancel All button on holds over tab cancels both holds over and holds waiting Signed-off-by: Melia Meggs me...@test.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #8 from Melia Meggs me...@bywatersolutions.com --- I applied this patch and followed the test plan above. Before the patch, when I clicked cancel all both my holds over and holds waiting were cancelled. After the patch, when I clicked cancel all only the holds over were cancelled. I think this patch is working, and I will add my sign-off. I am leaving the status as needs sign-off - we need a second sign-off from a non-ByWater staff member, please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added Attachment #12623|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6039 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12623 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12623action=edit Bug 8213 - Cancel All button on holds over tab cancels both holds over and holds waiting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Test Plan: 1) Create two holds, and set them to waiting for two patrons. 2) Make the waitingdate for one of the holds longer than the value set in ReservesMaxPickUpDelay. 3) You should now see one reserve on each tab on waitingreserves.pl 4) Backup your database 5) On the Holds over tab, click 'Cancel all'. This should cancel both holds 6) Restore your database 7) Apply this patch 8) Repeat step 4, only the hold in the Holds over tab should be canceled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #4 from Melia Meggs me...@bywatersolutions.com --- They don't really need an Are you sure you want to do this? message if the button were working correctly. I can't think of any situation in which a library would want to cancel all of their holds waiting either. The button needs to cancel all of the holds over (which are past the ReserveMaxPickUpDelay anyway), and it should have no effect on the holds waiting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Albert Oller a...@bywatersolutions.com changed: What|Removed |Added CC||a...@bywatersolutions.com --- Comment #2 from Albert Oller a...@bywatersolutions.com --- I'm not sure if this needs a separate bug entry, but can there also be a confirmation pop-up? Are you sure you want to do this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, I can't think of a situation a library wants to delete all holds (maybe not inventive enough today). I think normally you only want to cancel the expired holds - so it would make sense to me for the button to do that. Maybe the description could be more clear? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8213] Cancel All button on holds over tab cancels both holds over and holds waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #1 from Melia Meggs me...@bywatersolutions.com --- Related to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
