[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10596 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10596action=edit Bug 8217: Followup: move code to the document.ready function [patch for 3.8] Hi Chris, Here is the patch for 3.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #18 from Chris Cormack ch...@bigballofwax.co.nz --- Thanks Jonathan. Pushed to stable, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #15 from Paul Poulain paul.poul...@biblibre.com --- Follow-up pushed on master branch directly, does not apply on new/bug_8217 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217
--- Comment #16 from Chris Cormack ch...@bigballofwax.co.nz ---
Follow up does not apply to 3.8.x
HEAD
$('#bibliodetails ul').tabs();
===
$('#bibliodetails').tabs();
$('#search-form').focus();
a4d2a99... Bug 8217: Followup: move code to the document.ready function
Please
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #10346|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl --- Followup: Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #13 from Mirko Tietgen 5...@gmx.de --- Created attachment 10443 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10443action=edit Bug 8217: Followup: move code to the document.ready function Signed-off-by: Mirko Tietgen 5...@gmx.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Mirko Tietgen 5...@gmx.de changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||5...@gmx.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|adrien.sau...@biblibre.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10021|0 |1 is obsolete|| Attachment #10162|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10346 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10346action=edit Bug 8217: Followup: move code to the document.ready function Oups, it's my fault. This one should be correct (First patch marked as obsolete. It's already pushed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Testing shows, that after applying the second patch, the focus is not in the search box. On current HEAD it's ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #6) It should be put in the coding guidelines that using body onload is not the best way to add load events to a page. Generally the event should be added to the jQuery $document(ready)() function. That lets jQuery handle all the onload events and helps prevent conflicts. I think a follow-up for this should be submitted to change this and ask that this not be pushed to 3.8. Done: http://wiki.koha-community.org/wiki/Coding_Guidelines#don.27t_use_js_in_.3Cbody_onload.3D3E -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed the first patch, the follow up looks fine to me, will push that to 3.8.x when it is pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10162 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10162action=edit Bug 8217: Followup: move code to the document.ready function I agree with Owen. Could you test this patch and verify it do the same thing as previous please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Pushed to Master|ASSIGNED CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Sorry, Monday morning, I have troubles with my grammar... I reformulate : Could you test this patch and verify that it does the same thing as previous please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- QA comment: tiny patch nothing specific to say from QA pov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- This tiny ENH could be ported to 3.8 safely would be useful I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #6 from Owen Leonard oleon...@myacpl.org --- It should be put in the coding guidelines that using body onload is not the best way to add load events to a page. Generally the event should be added to the jQuery $document(ready)() function. That lets jQuery handle all the onload events and helps prevent conflicts. I think a follow-up for this should be submitted to change this and ask that this not be pushed to 3.8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 10008 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10008action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #2 from Adrien SAURAT adrien.sau...@biblibre.com --- TEST PLAN : In staff interface, search for a biblio, then access its detail page. Once the page is loaded the focus should be on the search box. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217
--- Comment #3 from Marc Véron ve...@veron.ch ---
Created attachment 10021
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10021action=edit
Bug 8217:[SIGNED-OFF] Focus on search box in staff detail page
Signed-off-by: Marc Veron ve...@veron.ch
Works exactly as expected.
Adds onload=document.getElementById('search-form').focus() to HTMP body.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #10008|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
