[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14932


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932
[Bug 14932] serials/serials-collection.pl-page is very slow.
GetFullSubscription* checks permission for each serial!
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22626
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22626action=edit
Bug 8435: use a transaction for unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #53 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22625
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22625action=edit
Bug 8435: Followup add unit tests for can_edit_subscription

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #56 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22628
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22628action=edit
Bug 8435: Fix unit tests

C4::Serials::can_edit_subscription now deals with C4::Context-userenv.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21286|0   |1
is obsolete||
  Attachment #21287|0   |1
is obsolete||
  Attachment #21288|0   |1
is obsolete||
  Attachment #21289|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22624
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22624action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #55 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22627
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22627action=edit
Bug 8435: The unit tests should create the biblio

Previous version does not create the biblio.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #57 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #51)
 This, ultimately, is because the patch series makes it *required* that there
 is a valid userenv, which was not the case before. can_edit_subscription()
 should be revised so that it doesn't crash if there's no userenv.

Galen, I fixed that and added a new unit tests to check the userenv value.
The behavior is: without userenv, subscriptions cannot be edited.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #58 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||gmcha...@gmail.com

--- Comment #51 from Galen Charlton gmcha...@gmail.com ---
Marking as failed QA, sorry.

This patch series (after fixing merge) conflicts, blows up every nearly every
DB-dependent serials unit test that calls GetSubscription() with an error
similar to this:

Can't use an undefined value as a HASH reference at
/home/gmc/koha/C4/Serials.pm line 2808, DATA line 558.

This, ultimately, is because the patch series makes it *required* that there is
a valid userenv, which was not the case before. can_edit_subscription() should
be revised so that it doesn't crash if there's no userenv.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

   Keywords||rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #19260|0   |1
is obsolete||

--- Comment #47 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21286
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21286action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #48 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21287
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21287action=edit
Bug 8435: Followup add unit tests for can_edit_subscription

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #19268|0   |1
is obsolete||

--- Comment #49 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21288
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21288action=edit
Bug 8435: use a transaction for unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #19266|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #20536|0   |1
is obsolete||

--- Comment #50 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 21289
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21289action=edit
Bug 8435: The unit tests should create the biblio

Previous version does not create the biblio.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #16740|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

Bot Control|--- |Ignore this bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20536
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20536action=edit
Bug 8435: The unit tests should create the biblio

Previous version does not create the biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Blocks|7677|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19268
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19268action=edit
Bug 8435: use a transaction for unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16943|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19260
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19260action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16944|0   |1
is obsolete||

--- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19261
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19261action=edit
Bug 8435: Followup add unit tests for can_edit_subscription

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com ---
Rebased patches. Fix conflicts with bug 10080.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com ---
Only the last patch (unit tests) needs QA. The first one already passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #19261|0   |1
is obsolete||

--- Comment #44 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 19266
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19266action=edit
QAed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|3.14|master
 QA Contact|katrin.fisc...@bsz-bw.de|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16799|0   |1
is obsolete||
  Attachment #16801|0   |1
is obsolete||
  Attachment #16802|0   |1
is obsolete||
  Attachment #16803|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 16943
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16943action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 16944
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16944action=edit
Bug 8435: Followup add unit tests for can_edit_subscription

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com ---
attachment 16943 is a rebased and squashed patch.
Last patch is a new patch (introduced a little unit test for the
can_edit_subscription routine).
The last patch needs QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #16404|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|katrin.fisc...@bsz-bw.de

--- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Taking a look at this now :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This patches fail xt/permissions.t because the new permissions are missing in 2
files - can you please provide a follow up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Can we agree on amending the permissions description to indicate the
relationship with indybranches?

Suggestion:
Manage subscriptions from any branch (only applies when IndependantBranches is
used)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 16740
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16740action=edit
Screenshot - count on tab is wrong now

With indybranches = ON and user not having superserials permission the shown
subscriptions are alright, but the shown number on the tab is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 16750
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16750action=edit
Bug 8435: Followup Fix permission description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 16751
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16751action=edit
Bug 8435: Fix hide subscriptions if not allow

If a user does not have the superserials permission and the syspref
IndependantBranches is ON, he cannot show subscriptions from others
branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
Katrin, I don't know if you require another sign-off on these 2 last patches.
Feel free to switch to Needs Signed-off if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #31 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 16798
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16798action=edit
[PASSED QA] Bug 8435 [Follow-up] Check superserials permission on
subscription-add

So subscription creation is now possible for other branches when you
have this permission enabled.

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #15673|0   |1
is obsolete||
  Attachment #16462|0   |1
is obsolete||
  Attachment #16750|0   |1
is obsolete||
  Attachment #16751|0   |1
is obsolete||

--- Comment #32 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 16799
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16799action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #16798|0   |1
is obsolete||

--- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 16801
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16801action=edit
[PASSED QA] Bug 8435 [Follow-up] Check superserials permission on
subscription-add

So subscription creation is now possible for other branches when you
have this permission enabled.

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 16802
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16802action=edit
[PASSED QA] Bug 8435: Followup Fix permission description

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 16803
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16803action=edit
[PASSED QA] Bug 8435: Fix hide subscriptions if not allow

If a user does not have the superserials permission and the syspref
IndependantBranches is ON, he cannot show subscriptions from others
branches.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
Version|master  |3.14

--- Comment #36 from Jared Camins-Esakov jcam...@cpbibliography.com ---
These patches no longer apply and the merge conflict is too complex for me to
resolve on my own. Bumping for 3.14 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #22 from Paul Poulain paul.poul...@biblibre.com ---
Patch tested with a sandbox, by Frederic Durand frederic.dur...@unilim.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #23 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 16462
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16462action=edit
Bug 8435 [Follow-up] Check superserials permission on subscription-add

So subscription creation is now possible for other branches when you
have this permission enabled.

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Frederic Durand frederic.dur...@unilim.fr changed:

   What|Removed |Added

 CC||frederic.dur...@unilim.fr

--- Comment #18 from Frederic Durand frederic.dur...@unilim.fr ---
Tried to test it on sandbox, did not work :
Applying: Bug 8435: If IndependantBranches is on, Serials can't be manage from
others libraries Using index info to reconstruct a base tree... Falling back to
patching base and 3-way merge... Auto-merging
installer/data/mysql/de-DE/mandatory/userpermissions.sql Auto-merging
installer/data/mysql/en/mandatory/userpermissions.sql Auto-merging
installer/data/mysql/es-ES/mandatory/userpermissions.sql Auto-merging
installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql Auto-merging
installer/data/mysql/it-IT/necessari/userpermissions.sql Auto-merging
installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql Auto-merging
installer/data/mysql/pl-PL/mandatory/userpermissions.sql Auto-merging
installer/data/mysql/updatedatabase.pl Auto-merging serials/subscription-add.pl
Bug 8435 - new permissions on subscriptions superserials

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
No error, just warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Frederic Durand frederic.dur...@unilim.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Frederic Durand frederic.dur...@unilim.fr ---
Testing is ok, superserial let you see and manage every serials.
But I found a lack for serial creation. As a superserial you can only create a
subscription for your own site, no options to choose another library on
subscription-add.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #21 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 16404
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16404action=edit
Bug 8435 [Follow-up] Check superserials permission on subscription-add

So subscription creation is now possible for other branches when you
have this permission enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #13396|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 15673
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15673action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #16 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #13)
 Another option, I like less, is to add a note to the permission. But I think
 as the majority of libraries is not using independentbranches it might still
 be confusing.
Katrin,

Jonathan  I just spoke of this problem. We investigated many options, and feel
the only one that is consistent is to:
 * have the permission defaulted to 0
 * update the permission description to say For libraries with
systemPreference IndependantBranche=ON, Manage subscriptions from any branch

Thus:
 * libraries with IndependantBranches= OFF = no change, nothing to do
 * libraries with IndependantBranches=ON = default value for existing users is
correct, the description is clear for new librarians


Overall, we agree it's a little bit wobbly, because it mixes sysprefs and
permission. But all this stack of features activated or not when
IndependantBranches is set should probably be rewritten (and it's far from the
scope of this patch...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I really think the manual would not be enough for people to not get confused.
Would it make sense to make it not dependend on independent branches at all? I
guess then we would have to have it turned on by default for all staff members
with permissions to work with subscriptions?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #11411|0   |1
is obsolete||
  Attachment #11892|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 13396
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13396action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
rebased and squashed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
What is the behaviour with indybranches turned OFF?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #9)
 What is the behaviour with indybranches turned OFF?

Normally there is no change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ok, I think that is a problem.

Because if I have a permission, I expect it to do something. If there is a
dependence on another setting, we need to find a better way to implement this -
I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #11)
 Ok, I think that is a problem.
 
 Because if I have a permission, I expect it to do something. If there is a
 dependence on another setting, we need to find a better way to implement
 this - I think.

Hi Katrin,
What do you propose ?
I don't see a lot of ways.
I had 2 choices : 1 permission or yet another syspref.
I thought the fact to hide/show subscriptions is close to a permission than a
syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to comment #13)
 I am not sure. 
 
 Maybe it should do something if independant branches is OFF too?
 We would have to be careful not to introduce a change of behaviour. 
 
 Could the permission only be visible if the syspref is set to ON?

I don't like this option. We don't want to add this kind of tests in the
permissions management page. The permissions are enough complicated :)

 Another option, I like less, is to add a note to the permission. But I think
 as the majority of libraries is not using independentbranches it might still
 be confusing.

Yes and it is the same kind of tests.

Don't you think a short explanation in the manual would be enough ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11892
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11892action=edit
Bug 8435: Followup: FIX if IndependantBranches is OFF

 If IndependantBranches is off, you may not edit? Somewhat confusing. Please
 clarify..

Hi Marcel, 
Yes ! Good catch, thanks. Switch back to needs SO.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #11377|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 11411
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11411action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz
Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Alexandre Lengereau alexandre.lenger...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alexandre.lengereau@biblibr
   ||e.com

--- Comment #2 from Alexandre Lengereau alexandre.lenger...@biblibre.com ---
Sandbox test:

CONFLICT (content): Merge conflict in
installer/data/mysql/updatedatabase.plbr/
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.ttbr/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #10821|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 11377
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11377action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed:

   What|Removed |Added

 Blocks||8436

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||8438

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 10821
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10821action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8435] new permissions on subscriptions superserials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/