[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Blocks||13114 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #124 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 32426 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32426action=edit Bug 8446: (qa followup) Tests should be conditional on Test::DBIx::Class Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #125 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 32427 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32427action=edit Bug 8446: (qa followup) Patch reintroduces SolR stuff Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5010 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #126 from Tomás Cohen Arazi tomasco...@gmail.com --- Feature pushed to master. Thanks Matthias, Martin and Jesee! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32162|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32163|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32164|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32166|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32165|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32169|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32167|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32168|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #32170|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #114 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 32366
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32366action=edit
BUG8446, Follow up: Adds Shibboleth authentication
- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
work if koha is behind a reverse proxy.
- To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325
BUG8446, Follow up: Adds Shibboleth authentication
- Ensure user is returned to requested page after authentication
- Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345
BUG8446, Follow up: Remove unused imports from scripts
- Remove import of deprecated C4::Utils module from shibboleth
authentication module: Auth_with_shibboleth.pm
Signed-off-by: Jesse Weaver pianohac...@gmail.com
Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #115 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32367 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32367action=edit BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #116 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32368 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32368action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #119 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32371 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32371action=edit BUG8446, QA Followup: Cleanup tabs and license Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #120 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32372 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32372action=edit BUG8446, QA Followup: Minor Code Tidies Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #121 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32373 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32373action=edit BUG8446, QA Followup: Use DBIx::Class - Convert Auth_with_shibboleth to use dbic stanzas. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #118 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32370 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32370action=edit BUG8446, Follow up: Add Unit Tests Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #117 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32369 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32369action=edit BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context-new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #122 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32374 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32374action=edit BUG8446, QA Followup: Add Test::DBIx::Class to dependancies - To correct tests after converting module to dbic, we need to add the Test::DBIx::Class module as a dependancy. Signed-off-by: Katrin Fischer katrin.fischer...@web.de The dependency will probably need to be packaged by us until it can get into Debian proper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #123 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Minor rebase (database change as usual in first patch, which is then removed in second patch anyway). Added first patch back in to tree, as caits bz managed to nuke it during upload it seems. Should apply fine again now ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #113 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 32365
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32365action=edit
BUG8446: Adds Shibboleth authentication
- Use the shibbolethAuthentication syspref to enable Shibboleth authentication
- Configure the shibbolethLoginAttribute to specify which shibboleth user
attribute matches the koha login
- Make sure the OPACBaseURL is correctly set
BUG8446, Follow-up: Adds Shibboleth authentication
- Fix logout bug: shibboleth logout now occurs only when
the session is a shibboleth one.
- Do some refactoring: getting shibboleth username is now
done in C4::Auth_with_Shibboleth.pm (get_login_shib function)
BUG8446, Follow-up: Adds Shibboleth authentication
- Adds redirect to opac after logout
BUG8446, Follow-up: Adds Shibboleth authentication
- Shibboleth is not compatible with basic http authentication
in C4/Auth.pm. This patch fixes that.
BUG8446, Follow-up: Adds Shibboleth authentication
- Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
multiple vhosts.
BUG8446, Follow-up: Adds Shibboleth authentication
- Adds missing protocol for $ENV{'SERVER_NAME'}
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com
Signed-off-by: Jesse Weaver pianohac...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Tested with the feide idp.
- LDAP login and logout are working
- local login/logout are still working
- CAS login/logout are still working
Instructions for setup can be found on the wiki:
http://wiki.koha-community.org/wiki/Shibboleth_Configuration
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #100 from Martin Renvoize martin.renvo...@ptfs-europe.com --- :( It seems that mocking the database with DBD::Mock when using DBIx::Class is simply incompatible (DBIx::Class just complains about an unrecognised DBI driver, then proceeds to drop back to some default SQL and fails badly) I've been looking into alternatives, like Test::DBIx::Class (which is a module to create an in memory sql database to test against, but this route requires lots of work manually creating dummy data to test against). I then tried DBIx::Class::Sims (which is a module to automatically fill tables with randomly generated dummy data, but this approach also fails because our database schema has a large number of cyclic relationships and the Sims module doesn't cope with this well) Interesting enough, the problem I'm facing (Not wanting to have to populate the whole structure of a Borrowers Row and satisfy all constraints manually) is basically solved by the TestBuilder module we recently decided not to adopt! I'll keep battling with it, but I have a feeling the Test size will have to jump substantially as I add all the releated data in a transaction. It shouldn't be this Hard! Martin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #31907|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32125 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32125action=edit BUG8446, QA Followup: Use DBIx::Class - Convert Auth_with_shibboleth to use dbic stanzas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #102 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #103 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 32158 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32158action=edit BUG8446, QA Followup: Add Test::DBIx::Class to dependancies - To correct tests after converting module to dbic, we need to add the Test::DBIx::Class module as a dependancy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #31905|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #31906|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #31407|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #31408|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #30616|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #30617|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #30619|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32158|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32125|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #30618|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
--- Comment #104 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32162
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32162action=edit
[PASSED QA] BUG8446, Follow up: Adds Shibboleth authentication
- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
work if koha is behind a reverse proxy.
- To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325
BUG8446, Follow up: Adds Shibboleth authentication
- Ensure user is returned to requested page after authentication
- Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345
BUG8446, Follow up: Remove unused imports from scripts
- Remove import of deprecated C4::Utils module from shibboleth
authentication module: Auth_with_shibboleth.pm
Signed-off-by: Jesse Weaver pianohac...@gmail.com
Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Tested with the feide idp.
- LDAP login and logout are working
- local login/logout are still working
- CAS login/logout are still working
Instructions for setup can be found on the wiki:
http://wiki.koha-community.org/wiki/Shibboleth_Configuration
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #105 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32163 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32163action=edit [PASSED QA] BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #106 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32164 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32164action=edit [PASSED QA] BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #107 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32165 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32165action=edit [PASSED QA] BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context-new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #108 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32166 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32166action=edit [PASSED QA] BUG8446, followup: Add Unit Tests Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #112 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32170 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32170action=edit [PASSED QA] BUG8446, QA Followup: Add Test::DBIx::Class to dependancies - To correct tests after converting module to dbic, we need to add the Test::DBIx::Class module as a dependancy. Signed-off-by: Katrin Fischer katrin.fischer...@web.de The dependency will probably need to be packaged by us until it can get into Debian proper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #110 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32168 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32168action=edit [PASSED QA] BUG8446, QA Followup: Minor Code Tidies Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #109 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32167 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32167action=edit [PASSED QA] BUG8446, QA Followup: Cleanup tabs and license Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #111 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32169 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32169action=edit [PASSED QA] BUG8446, QA Followup: Use DBIx::Class - Convert Auth_with_shibboleth to use dbic stanzas. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #99 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Setting this to failed for now - Martin is working on a follow-up for the tests as I ran into some problems running them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #98 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 31907 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31907action=edit BUG8446, QA Followup: Use DBIx::Class - Convert Auth_with_shibboleth to use dbic stanzas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #96 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 31905 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31905action=edit BUG8446, QA Followup: Cleanup tabs and license -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #97 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 31906 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31906action=edit BUG8446, QA Followup: Minor Code Tidies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #31836|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #95 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 31836 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31836action=edit BUG8446, qa-followup: Cleanup tabs and license -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #30620|0 |1 is obsolete|| --- Comment #93 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 31407 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31407action=edit [SIGNED-OFF] BUG8446, Follow up: Refactor to clean up bad practice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #30684|0 |1 is obsolete|| --- Comment #94 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 31408 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31408action=edit [SIGNED-OFF] BUG8446, followup: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #92 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Hi Zeno, I'm pretty sure you can use testshib, and can verify you can definitely use fiede as that's what I used for allot of my own testing. The instructions on both sites seem pretty clear, but do let me know if you have any issues. Martin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #91 from Zeno Tajoli z.taj...@cineca.it --- There is a site that seems useful to test the patch: http://testshib.org/index.html But is not clear to me if it is possible to use it as IdP and my Koha install as Service Provider. For example, do you undestand how to create a user/pwd in the IdP of http://testshib.org/ ? Probably it is possible to use also this test service: https://openidp.feide.no/. But probably is better to be Norse. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30621|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30684 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30684action=edit BUG8446, followup: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||paola.ro...@cineca.it --- Comment #82 from Paola Rossi paola.ro...@cineca.it --- I've tried to apply the patches today against 3.17.00.013 Applying: MT8122: Adds Shibboleth authentication Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-user.pl Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging C4/Auth.pm Failed to merge in the changes. Patch failed at 0001 MT8122: Adds Shibboleth authentication So I pass the patch to Patch doesn't apply status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
Attachment #30353|0 |1
is obsolete||
--- Comment #83 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30616
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30616action=edit
[SIGNED OFF] MT8122: Adds Shibboleth authentication
- Use the shibbolethAuthentication syspref to enable Shibboleth authentication
- Configure the shibbolethLoginAttribute to specify which shibboleth user
attribute matches the koha login
- Make sure the OPACBaseURL is correctly set
MT8122, Follow-up: Adds Shibboleth authentication
- Fix logout bug: shibboleth logout now occurs only when
the session is a shibboleth one.
- Do some refactoring: getting shibboleth username is now
done in C4::Auth_with_Shibboleth.pm (get_login_shib function)
MT8122, Follow-up: Adds Shibboleth authentication
- Adds redirect to opac after logout
MT8122, Follow-up: Adds Shibboleth authentication
- Shibboleth is not compatible with basic http authentication
in C4/Auth.pm. This patch fixes that.
MT8122, Follow-up: Adds Shibboleth authentication
- Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
multiple vhosts.
MT8122, Follow-up: Adds Shibboleth authentication
- Adds missing protocol for $ENV{'SERVER_NAME'}
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com
Signed-off-by: Jesse Weaver pianohac...@gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30384|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30619 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30619action=edit [SIGNED OFF] BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
Attachment #30354|0 |1
is obsolete||
--- Comment #84 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30617
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30617action=edit
[SIGNED OFF] BUG8446, Follow up: Adds Shibboleth authentication
- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
work if koha is behind a reverse proxy.
- To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325
BUG8446, Follow up: Adds Shibboleth authentication
- Ensure user is returned to requested page after authentication
- Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345
BUG8446, Follow up: Remove unused imports from scripts
- Remove import of deprecated C4::Utils module from shibboleth
authentication module: Auth_with_shibboleth.pm
Signed-off-by: Jesse Weaver pianohac...@gmail.com
Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30604|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30620 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30620action=edit BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context-new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30605|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30621 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30621action=edit BUG8446, followup: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30355|0 |1 is obsolete|| --- Comment #85 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30618 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30618action=edit [SIGNED OFF] BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com Signed-off-by: Matthias Meusburger matthias.meusbur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #89 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Rebased again.. It's only a db change that is causing this conflict every time.. and said db change is backed out in a later patch in the series anyway. (It's only for attribution for Matthias that it's still there at all). I have however got a tracking github branch which I've suggested people use for testing.. this branch is re-based nightly against master. As for testing.. give me a shout if you need any help with the config.. it's the config outside of koha which is hardest to setup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #78 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30594 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30594action=edit BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context-new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30355|BUG8446, Follow up: Remove |[SIGNED OFF] BUG8446, description|unnecessary sysprefs, move |Follow up: Remove |to config |unnecessary sysprefs, move ||to config -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30354|BUG8446, Follow up: Adds|[SIGNED OFF] BUG8446, description|Shibboleth authentication |Follow up: Adds Shibboleth ||authentication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30353|MT8122: Adds Shibboleth |[SIGNED OFF] MT8122: Adds description|authentication |Shibboleth authentication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30384|BUG8446, Follow up: Improve |[SIGNED OFF] BUG8446, description|local login fallback|Follow up: Improve local ||login fallback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30594|0 |1 is obsolete|| --- Comment #79 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30604 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30604action=edit BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context-new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #80 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30605 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30605action=edit BUG8446, followup: Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #81 from Martin Renvoize martin.renvo...@ptfs-europe.com --- So, those last two patches are in need of signoff. The first one does some much needed re-factoring of the original code to meet better (but still not best) practice ;) The latter are some basic unit tests covering a fair range of the routines so far which will be needed at QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Blocks||12680 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Blocks||12681 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Blocks||12682 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #75 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Tested ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Attachment #30356|0 |1 is obsolete|| --- Comment #76 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 30384 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30384action=edit BUG8446, Follow up: Improve local login fallback Signed-off patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #77 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Matthias, can you add your sign off line to the other patches too please? And thx for signing off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #68 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Tested ok : - CAS and Shibboleth template coexistence (even though login won't work because of the OPACBaseURL protocol issue, but that is another problem, see bug 12398 and bug 7770). - Shib login / logout (with single sign out) - koha login / logout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30286|0 |1 is obsolete|| --- Comment #69 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30335 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30335action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implimented single sign out - This followup rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implimented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implimentation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template ruels so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embelished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authenticaion - Correcting of documentation to make it more clear to the current implimentation - Minor refactoring of code to reduce some code duplication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
Attachment #30283|0 |1
is obsolete||
--- Comment #70 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30353
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30353action=edit
MT8122: Adds Shibboleth authentication
- Use the shibbolethAuthentication syspref to enable Shibboleth authentication
- Configure the shibbolethLoginAttribute to specify which shibboleth user
attribute matches the koha login
- Make sure the OPACBaseURL is correctly set
MT8122, Follow-up: Adds Shibboleth authentication
- Fix logout bug: shibboleth logout now occurs only when
the session is a shibboleth one.
- Do some refactoring: getting shibboleth username is now
done in C4::Auth_with_Shibboleth.pm (get_login_shib function)
MT8122, Follow-up: Adds Shibboleth authentication
- Adds redirect to opac after logout
MT8122, Follow-up: Adds Shibboleth authentication
- Shibboleth is not compatible with basic http authentication
in C4/Auth.pm. This patch fixes that.
MT8122, Follow-up: Adds Shibboleth authentication
- Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
multiple vhosts.
MT8122, Follow-up: Adds Shibboleth authentication
- Adds missing protocol for $ENV{'SERVER_NAME'}
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com
http://bugs.koha-community.org/show_bug.cgi?id=8446
Signed-off-by: Jesse Weaver pianohac...@gmail.com
(ByWater employee.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30335|0 |1 is obsolete|| --- Comment #73 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30356 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30356action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implemented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implemented single sign out - This follow up rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implemented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implementation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template rules so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embellished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. BUG8446, Follow up: Enable configuration of match field - Added clearer, more flexible, configuration of shibboleth attribute to koha borrower field matching for authentication - Correcting of documentation to make it more clear to the current implementation - Minor refactoring of code to reduce some code duplication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
Attachment #30284|0 |1
is obsolete||
--- Comment #71 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30354
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30354action=edit
BUG8446, Follow up: Adds Shibboleth authentication
- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
work if koha is behind a reverse proxy.
- To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325
BUG8446, Follow up: Adds Shibboleth authentication
- Ensure user is returned to requested page after authentication
- Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345
BUG8446, Follow up: Remove unused imports from scripts
- Remove import of deprecated C4::Utils module from shibboleth
authentication module: Auth_with_shibboleth.pm
Signed-off-by: Jesse Weaver pianohac...@gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30285|0 |1 is obsolete|| --- Comment #72 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30355 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30355action=edit BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #74 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Right.. I think we're finally there guys! This last update to the final patch takes care of a configuration issue Matthias spotted whereby the config would be parsed incorrectly. To enable forward compatibility with bug 12026 (preventing us having to handle a nasty breaking config change when pushing that patch) and to bring the config in line with that of the way the ldap config currently works the minimum xml required has changed from: usesshibboleth1/usesshibboleth shibboleth matchpointuserid/matchpoint mapping useriduid/userid /mapping /shibboleth to: usesshibboleth1/usesshibboleth shibboleth matchpointuserid/matchpoint mapping userid is=uid/userid /mapping /shibboleth I'm told this is more 'standard' amongst this kind of xml based mapping file and am happy going with it. It also allows for a future form to look like the below without breaking compatibility: usesshibboleth1/usesshibboleth shibboleth matchpointuserid/matchpoint mapping userid is=uid regex=s/@school.ac.uk//g/userid firstname is=fndefault/firstname /mapping /shibboleth The above will hopefully give you a brief glimpse into what I'm thinking for enhancing bug 12026 once this is pushed. Cheers for everyone efforts so far! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
Attachment #30017|0 |1
is obsolete||
--- Comment #64 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30283
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30283action=edit
MT8122: Adds Shibboleth authentication
- Use the shibbolethAuthentication syspref to enable Shibboleth authentication
- Configure the shibbolethLoginAttribute to specify which shibboleth user
attribute matches the koha login
- Make sure the OPACBaseURL is correctly set
MT8122, Follow-up: Adds Shibboleth authentication
- Fix logout bug: shibboleth logout now occurs only when
the session is a shibboleth one.
- Do some refactoring: getting shibboleth username is now
done in C4::Auth_with_Shibboleth.pm (get_login_shib function)
MT8122, Follow-up: Adds Shibboleth authentication
- Adds redirect to opac after logout
MT8122, Follow-up: Adds Shibboleth authentication
- Shibboleth is not compatible with basic http authentication
in C4/Auth.pm. This patch fixes that.
MT8122, Follow-up: Adds Shibboleth authentication
- Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
multiple vhosts.
MT8122, Follow-up: Adds Shibboleth authentication
- Adds missing protocol for $ENV{'SERVER_NAME'}
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com
http://bugs.koha-community.org/show_bug.cgi?id=8446
Signed-off-by: Jesse Weaver pianohac...@gmail.com
(ByWater employee.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
Attachment #30018|0 |1
is obsolete||
--- Comment #65 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30284
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30284action=edit
BUG8446, Follow up: Adds Shibboleth authentication
- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
work if koha is behind a reverse proxy.
- To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325
BUG8446, Follow up: Adds Shibboleth authentication
- Ensure user is returned to requested page after authentication
- Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345
BUG8446, Follow up: Remove unused imports from scripts
- Remove import of deprecated C4::Utils module from shibboleth
authentication module: Auth_with_shibboleth.pm
Signed-off-by: Jesse Weaver pianohac...@gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30019|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30285 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30285action=edit BUG8446, Follow up: Remove unnecessary sysprefs, move to config Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #30020|0 |1 is obsolete|| Attachment #30021|0 |1 is obsolete|| Attachment #30022|0 |1 is obsolete|| Attachment #30023|0 |1 is obsolete|| Attachment #30030|0 |1 is obsolete|| Attachment #30031|0 |1 is obsolete|| Attachment #30033|0 |1 is obsolete|| --- Comment #67 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30286 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30286action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. BUG8446, Follow up: Correct filenames to match guidlines - Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match other files present on the system. BUG8446, Follow up: Correct paths after file rename BUG8446, Follow up: Implimented single sign out - This followup rebases the code against 3.16+ which managed to break some of the original logic. - As a side effect of the rebasing, we've also implimented the single sign out element. Upon logout, koha will request that the shibboleth session is destroyed, and then clear the local koha session upon return to koha. Due to the nature of shibboleth however, you will only truly be signed out of the IdP if they properly support Single Sign Out (which many do not). As a consequence, although you may appear to be logged out in koha, you might find that upon clicking 'login' the IdP does NOT request your login details again, but instead logs you silently back into your koha session. This is NOT a koha bug, but a shibboleth implimentation issue that is well known. BUG8446, Follow up: Fixed bootstrap login via modal - The bootstrap theme enable login from any opac page via modal. To enable this with shibboleth we had to make some template parameters globally accessible when shibboleth is enabled. BUG8446, Follow up: Add template rules for Shibboleth and CAS - Add template ruels so that CAS and Shibboleth can coexist. BUG8446, Follow up: Added default config to config file BUG8446, Follow up: Embelished perldoc documentation - Updated perldoc to correct detail about configuring shibboleth authentication. - Updated perldoc to include subroutines and their respective functions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446
Martin Renvoize martin.renvo...@ptfs-europe.com changed:
What|Removed |Added
Attachment #28898|0 |1
is obsolete||
--- Comment #51 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 30017
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30017action=edit
MT8122: Adds Shibboleth authentication
- Use the shibbolethAuthentication syspref to enable Shibboleth authentication
- Configure the shibbolethLoginAttribute to specify which shibboleth user
attribute matches the koha login
- Make sure the OPACBaseURL is correctly set
MT8122, Follow-up: Adds Shibboleth authentication
- Fix logout bug: shibboleth logout now occurs only when
the session is a shibboleth one.
- Do some refactoring: getting shibboleth username is now
done in C4::Auth_with_Shibboleth.pm (get_login_shib function)
MT8122, Follow-up: Adds Shibboleth authentication
- Adds redirect to opac after logout
MT8122, Follow-up: Adds Shibboleth authentication
- Shibboleth is not compatible with basic http authentication
in C4/Auth.pm. This patch fixes that.
MT8122, Follow-up: Adds Shibboleth authentication
- Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
multiple vhosts.
MT8122, Follow-up: Adds Shibboleth authentication
- Adds missing protocol for $ENV{'SERVER_NAME'}
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com
http://bugs.koha-community.org/show_bug.cgi?id=8446
Signed-off-by: Jesse Weaver pianohac...@gmail.com
(ByWater employee.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8446] Shibboleth authentication patch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #28901|0 |1 is obsolete|| --- Comment #54 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 30020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30020action=edit BUG8446, Follow up: Improve local login fallback - Local fallback was not very well implimented, this patch adds better handling for such cases allowing clearer failure messages - This patch also adds the ability to use single sign on via the top bar menu in the bootstrap theme. BUG8446, Follow up: Adds perldoc documentation - Add some documentation to the Auth_with_Shibboleth module including some guidance as to configuration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
