[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |MOVED --- Comment #41 from Paola Rossi paola.ro...@cineca.it --- I pass this bug to a Resolved - Moved status because this solution is a dead end. See bug 11909. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Mark was right, with the patch, every search with more than OPACnumSearchResults results will show a counter with OPACnumSearchResults search results. In my case 22. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11909 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #39 from M. Tompsett mtomp...@hotmail.com --- I haven't tested, so I can't say whether or not I am right or wrong. I'm just providing a test case in which I think it will fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|m...@kohaaloha.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #37 from M. Tompsett mtomp...@hotmail.com --- Please re-test on something with lots of results. Your result set size is 40 by default, I think. So your results are always going to be less than 40, even if there are thousands of matches. This is the case I am worried about, but don't have time to test. This is what the first tweak worries me about, the second line change looks fine to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Mark, should this be reset to 'needs signoff' then? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #35 from Paola Rossi paola.ro...@cineca.it --- I've applied against master 3.17.00.007 I set pref OpacHiddenItems to itemlost: [1] On OPAC the results count is 4 instead of 5, correct as required. So I pass the patch to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Attachment #28791|0 |1 is obsolete|| --- Comment #36 from Paola Rossi paola.ro...@cineca.it --- Created attachment 28823 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28823action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #27039|0 |1 is obsolete|| --- Comment #33 from M. Tompsett mtomp...@hotmail.com --- Created attachment 28791 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28791action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles test 1 through test 5 with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for test 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #34 from M. Tompsett mtomp...@hotmail.com --- All I did was rebase. The patch was obvious enough to fix conflicts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||paola.ro...@cineca.it --- Comment #32 from Paola Rossi paola.ro...@cineca.it --- I test against master 3.15.00.051 Applying: Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Failed to merge in the changes. Patch failed at 0001 Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #28 from Kyle M Hall k...@bywatersolutions.com --- This patch has been in discussion for over a year now with no movement. I'm going to QA this and let the RM make the final decision. It looks like nobody is interested in developing an alternative solutions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #29 from Kyle M Hall k...@bywatersolutions.com --- Well that didn't work out ; ) Patch no longer solves the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12590|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27038 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27038action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles test 1 through test 5 with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for test 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|fridolyn.som...@biblibre.co |k...@bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27038|0 |1 is obsolete|| --- Comment #31 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27039 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27039action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles test 1 through test 5 with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for test 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9778 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #27 from mathieu saby mathieu.s...@univ-rennes2.fr --- I am considering improvements for managing opac visibility (bz9778), but I will probably wait if somebody wants to map opacsuppress with biblio or biblioitems. M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #26 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #23) (In reply to comment #22) +1 for solution 2. I think indeed the best solution is to use Suppress index. The automatic suppress field could be updated in rebuild_zebra.pl. An idea for syspref : OpacAutoSuppressField. A better solution is to add a new column to biblio or bilioitems table, mapped with opacsuppress subfield. This can be used to forbid access to a biblio via URL direct edition. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #25 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- would that be overwritten too or can it be preserved by setting the flag automatically pre-indexing? I'd say yes. I propose to set suppress info in record during indexing (rebuild_zebra.pl already sets some infos in record before exporting to indexed files), so the record in database will not have the information, it can change like you want. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #22 from mathieu saby mathieu.s...@univ-rennes2.fr --- What about using zebra Suppress index to allow librarians to hide propely and automatically records when all items are hidden by OpacHiddenItems or Hidelostitems, without generating 404 error? When all items are hidden by OpacHiddenItems or Hidelostitems, Koha will put a 1 in a field of the record mapped with Suppress index. I see 2 possibilties : 1. We can use the field indexed in Suppress in the current record.abs of the library Drawback : if one item is added again to this record, or if the library change the value of OpacHiddenItems (to show again all items), librarians will have to change manually the value of this field = not good for me. 2. We can use an other field, so that 2 fields in zebra will be index in Suppress. For example, lets say 099$f and 099$k. 099$f will be used to change manually the visibiliy of record, 099$k to change it automatically if and only if all items are hidden by OpacHiddenItems or Hidelostitems. So a record could have 0-1, 1-1, 1-0, 0-0. I suppose we will need to store the value of this new field in a syspref (as it could be different in each library). Drawback : better, but need to rebuild zebra. Your opinion? (I had the begining of an other idea, with a new field in biblio table, but to complicated, and it is to fuzzy in my mind...) M. Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #23 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #22) +1 for solution 2. I think indeed the best solution is to use Suppress index. The automatic suppress field could be updated in rebuild_zebra.pl. An idea for syspref : OpacAutoSuppressField. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi, I am not sure I understand how the suppress index would work here, so I have a question. :) We regularly import records from our union catalog. It's an automatic process, so everytime a record is updated in the union catalog by any participating library the record will be overlayed in Koha during the next night. If a library chooses to suppress records by certain criteria (opachiddenitems) - would that be overwritten too or can it be preserved by setting the flag automatically pre-indexing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #21 from Mason James m...@kohaaloha.com --- (In reply to comment #1) I confirm. The Bug 6488 introduced to hide a record with only hidden items. This concerns only records managed in result page (depends on offset and results per page). But this causes several problems : - search hints (total number of results) returned by Zebra seems false when there are hidden records. That's what reports D Ruth Bavousett. - offset and results per page does not correspond to results displayed when there are hidden records. There can be only 2 results displayed in first page with a 20 results per page and clicking on next page will be offset=20. - when there is only one result and this one is hidden, leads to a 404 error page. (Because test is based on zebra total hints). Note that hiding records in OPAC can be managed with OpacSuppress syspref. In this case Zebra does not return hidden records, so everything is correct. So can we keep this feature ? I seems very difficult to correct. i did a patch for this issue 1.5 years ago, but i never committed it the method i used, was to fetch more records than needed from zebra (like 40 bibs, not 20) its obviously not a perfect solution, there is a chance that all 40 bibs fetched might be hidden, and you would still end up with 0 bibs displayed ^^despite that, in real life this patch worked well the only other solution, afaik, is to keep doing zebra queries until one page of non-hidden bibs is accumulated i'll upload my patch soon... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think hiding the record with the last item being hidden has been in Koha for a while now. While it's not good that the result count is off, I don't think we can just revert this behaviour that has been advertised and that library have been using in their collections. More so as the records being hidden now will just quietly reappear after the update (if I understand the change made here correctly). I think we need a way to control this - yes, maybe a new system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Passed QA |In Discussion CC||ch...@bigballofwax.co.nz --- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz --- I agree, this suddenly changes behaviour with utterly no warning and suddenly biblio records that used to be hidden are now visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #14 from Magnus Enger mag...@enger.priv.no --- (In reply to comment #12) I don't think we can just revert this behaviour that has been advertised and that library have been using in their collections. +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added CC||mi...@abunchofthings.net --- Comment #15 from Mirko Tietgen mi...@abunchofthings.net --- I agree with Katrin, I am opposed to taking away functionality that libraries are using. I would be less than happy to have that suddenly stop working if I relied on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #16 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- But what about the several bugs and strange behaviors due to this feature ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #17 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #16) But what about the several bugs and strange behaviors due to this feature ? We can't fix bugs by introducing other strange behaviors (biblios suddenly becoming unhidden). This removes a feature that is 7 months old without any warning, that libraries are using. If you want this in, I would suggest adding a systempreference to turn the hiding biblio feature off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #18 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #17) If you want this in, I would suggest adding a systempreference to turn the hiding biblio feature off. I agree, a syspref is a good idea. Maybe 'OpacHideRecordHiddenItems'. A suggestion on the name ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, maybe it can be grouped together for display with the OpacHidenItems pref. So that people find the new option easily. OpacHiddenItemsRecord maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #20 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #19) Hm, maybe it can be grouped together for display with the OpacHidenItems pref. So that people find the new option easily. OpacHiddenItemsRecord maybe? +1 OpacHiddenItemsHidesRecord ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Mason James m...@kohaaloha.com --- (In reply to comment #10) I think this works to avoid confusion for now and we should come up with a way to hide bib records later on. hmm, its a tricky one - do we want... 1/ hidden-bibs, but incorrect search-results count, or... 2/ hidden-bibs feature removed, and correct search-results count i think some people will be unhappy about this change, either way but now 2 sign-offs, so passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0a35b26) * b864e85 Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off C4/Search.pm * C4/Search.pm OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||neng...@gmail.com --- Comment #7 from Nicole C. Engard neng...@gmail.com --- I would like to sign off on this because this is confusing. But the patch doesn't apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Search.pm CONFLICT (content): Merge conflict in C4/Search.pm Failed to merge in the changes. Patch failed at 0001 Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. nengard@kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #12042|0 |1 is obsolete|| --- Comment #8 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 12586 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12586action=edit Proposed patch (rebased master) Patch rebased. The impacted lines had been rewritten. No change in behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #12586|0 |1 is obsolete|| --- Comment #9 from Nicole C. Engard neng...@gmail.com --- Created attachment 12590 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12590action=edit [SIGNED-OFF] Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Works as described and solves the problem for now. I'd say we need a way to make it work by hiding bib records if no items are available as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10 from Nicole C. Engard neng...@gmail.com --- I think this works to avoid confusion for now and we should come up with a way to hide bib records later on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com QA Contact||m...@kohaaloha.com --- Comment #4 from Mason James m...@kohaaloha.com --- (In reply to comment #3) Created attachment 12042 [details] Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Signed-off-by: Kyle M Hall k...@bywatersolutions.com patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 82c74b0 Bug 8462: OpacHiddenItems and hidelostitems hide items, but query C4/Search.pm * C4/Search.pm OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |ASSIGNED CC||paul.poul...@biblibre.com --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- i'm not sure i'm happy with this fix. It means you will get results without any items, right ? I'm asking for another signoff or someone opinion by switching back to need signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #5) i'm not sure i'm happy with this fix. It means you will get results without any items, right ? Right. I'm not against this feature. It is just that the way it works by now is very tricky for OPAC users, like explained Ruth Bavousett ; and causes several bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12004|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12042 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12042action=edit Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7690 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 12004 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12004action=edit Proposed patch Very small patch. Just restores previous behavior by not removing any record from search results. Beware that bug 7690 patch modifies the same lines. An other side-effect has been found : when search matches only one record and this record has only hidden items, you get a 404 error page :-/ Please test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Priority|P5 - low|P3 Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Component|OPAC|Searching Version|unspecified |master Assignee|oleon...@myacpl.org |gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
