[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #101 from Joy Nelson --- featurehancement not pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #100 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #99 from Jonathan Druart --- Created attachment 98712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98712=edit Bug 8643: Fix IsMarcStructureInternal tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #98 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart changed: What|Removed |Added Attachment #98607|0 |1 is obsolete|| Attachment #98608|0 |1 is obsolete|| --- Comment #96 from Jonathan Druart --- Created attachment 98702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98702=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Tested on update and new install, works as described. No errors. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Amended-patch: Remove the schema change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #97 from Jonathan Druart --- Created attachment 98703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98703=edit Bug 8643: code cleanup Merges "AreMandatoriesNotOk" and new "AreImportantsNotOk" into one function "AreFieldsNotOk". It can search for mandatory or important fields depending on the value of it's boolean "mandatory" parameter. To test: This patch should not change current behavior. Follow the test plan from previous patch and check that saving is still prevented for unfilled mandatory fields. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 David Nind changed: What|Removed |Added Attachment #97326|0 |1 is obsolete|| --- Comment #95 from David Nind --- Created attachment 98608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98608=edit Bug 8643: code cleanup Merges "AreMandatoriesNotOk" and new "AreImportantsNotOk" into one function "AreFieldsNotOk". It can search for mandatory or important fields depending on the value of it's boolean "mandatory" parameter. To test: This patch should not change current behavior. Follow the test plan from previous patch and check that saving is still prevented for unfilled mandatory fields. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 David Nind changed: What|Removed |Added Attachment #97325|0 |1 is obsolete|| --- Comment #94 from David Nind --- Created attachment 98607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98607=edit Bug 8643: Add important constraint to marc subfields This enhancement adds an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Update the database (perl installer/data/mysql/updatedatabase.pl) 3) Regenerate the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure (Default framework) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default framework) » Subfield » tag a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record 8) Confirm that this message is displayed: A few important fields are not filled: * tag 100 subfield a Personal name in tab 1 * Field 100 is important, at least one of its subfields must be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Tested on update and new install, works as described. No errors. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #93 from Maryse Simard --- (In reply to Jonathan Druart from comment #88) > 1. Who is the original author of this patch? Bernardo? Regarding the history > I do not think so. The author was lost when the patches were squashed. I changed it back to simith. > 2. Not blocker but, when a code is not nice, better refactore and improve it > than duplicate it ;) > I am referring to the JS code to test if a mandatory field is filled, it > would have been easier to make the function accepts an argument to check for > mandatories or importants. It's true this duplication is not very nice. I added a patch to try and reuse the current function instead of duplicating it. I followed your suggestion and used an argument to indicate whether we want a mandatory or important check. I've also set the bug back to Needs Signoff because of this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added Attachment #96627|0 |1 is obsolete|| --- Comment #91 from Maryse Simard --- Created attachment 97325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97325=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Tested on update and new install, works as described. No errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #92 from Maryse Simard --- Created attachment 97326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97326=edit Bug 8643: code cleanup Merges "AreMandatoriesNotOk" and new "AreImportantsNotOk" into one function "AreFieldsNotOk". It can search for mandatory or important fields depending on the value of it's boolean "mandatory" parameter. To test: This patch should not change current behavior. Follow the test plan from previous patch and check that saving is still prevented for unfilled mandatory fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #90 from Bernardo Gonzalez Kriegel --- (In reply to Bernardo Gonzalez Kriegel from comment #89) > (In reply to Jonathan Druart from comment #88) > > 1. Who is the original author of this patch? Bernardo? Regarding the history > > I do not think so. > I just signed, ~2015 first time, and now. All these people, from InLibro, seems to have worked on this bug Maxime Pelletier simith.doliveira@inlibro Rémi Mayrand-Provencher Mehdi Hamidi Philippe Audet-Fortin Charles Farmer Pierre-Marc Thibault Maryse Simard Arthur Bousquet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #89 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #88) > 1. Who is the original author of this patch? Bernardo? Regarding the history > I do not think so. I just signed, ~2015 first time, and now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #88 from Jonathan Druart --- I am quite ok with this patch, just a couple of things: 1. Who is the original author of this patch? Bernardo? Regarding the history I do not think so. 2. Not blocker but, when a code is not nice, better refactore and improve it than duplicate it ;) I am referring to the JS code to test if a mandatory field is filled, it would have been easier to make the function accepts an argument to check for mandatories or importants. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #87 from Jonathan Druart --- (In reply to Jonathan Druart from comment #86) > Does not work for me: > > Can't use an undefined value as an ARRAY reference at > /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088 > DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)', > 'HASH(0x5570f6dbc440)', undef) called at > /kohadevbox/koha/admin/marctagstructure.pl line 330 > > CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl:: > StringSearch(0, 'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl > line 284 > eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349 Sorry, I forgot the new DB column! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #86 from Jonathan Druart --- Does not work for me: Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088 DBD::_::st::fetchall_arrayref('DBI::st=HASH(0x5570f6dbc278)', 'HASH(0x5570f6dbc440)', undef) called at /kohadevbox/koha/admin/marctagstructure.pl line 330 CGI::Compile::ROOT::kohadevbox_koha_admin_marctagstructure_2epl::StringSearch(0, 'ACQ') called at /kohadevbox/koha/admin/marctagstructure.pl line 284 eval {...} at /kohadevbox/koha/admin/marctagstructure.pl line 349 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #96625|0 |1 is obsolete|| --- Comment #85 from Bernardo Gonzalez Kriegel --- Created attachment 96627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96627=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Tested on update and new install, works as described. No errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Arthur Bousquet changed: What|Removed |Added Attachment #92384|0 |1 is obsolete|| --- Comment #84 from Arthur Bousquet --- Created attachment 96625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96625=edit Bug 8643: Add important constraint to marc subfields I modified the MarcSubfieldStructure.pm file to match the new database shema (with the "important" column) This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added Attachment #92081|0 |1 is obsolete|| --- Comment #83 from Maryse Simard --- Created attachment 92384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92384=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added Attachment #91537|0 |1 is obsolete|| --- Comment #82 from Maryse Simard --- Created attachment 92081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92081=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #81 from Maryse Simard --- When I test myself, the message does appear. Though, it only appears once all the mandatory fields have been filled. Could it be what happened to you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||alexbuck...@catalyst.net.nz --- Comment #80 from Alex Buckley --- Hi Maryse, Thank you for your contribution. Unfortunately when testing this I am not getting a confirmation message when I set 100 tag as 'Important' and try to submit the Edit item with all 100 tag subfields empty. Similarly, I am not getting a confirmation message when I have set 100a as important and set try to submit the 'Edit item' form when 100a is blank. There does not appear to be JS errors in the console. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added CC||maryse.sim...@inlibro.com --- Comment #79 from Maryse Simard --- Rebased on current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Maryse Simard changed: What|Removed |Added Attachment #85982|0 |1 is obsolete|| --- Comment #78 from Maryse Simard --- Created attachment 91537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91537=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #77 from Pierre-Marc Thibault --- The patch has been fixed and can be applied on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #81032|0 |1 is obsolete|| --- Comment #76 from Pierre-Marc Thibault --- Created attachment 85982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85982=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #75 from Josef Moravec --- Comment on attachment 81032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81032 Bug 8643: Add important constraint to marc subfields Review of attachment 81032: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=8643=81032) - ::: installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql @@ +6,5 @@ > +-- $dbh->do("ALTER TABLE marc_subfield_structure ADD COLUMN important > TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory"); > +-- $dbh->do("ALTER TABLE marc_tag_structure ADD COLUMN important > TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory"); > +-- print "Upgrade to $DBversion done (Bug 8643 - Add important > constraint to marc subfields)\n"; > +-- SetVersion($DBversion); > +-- } The database update should be idempotent, make it all in perl and use column_exists helper function, like this: if( !column_exists( 'marc_subfield_structure', 'important' ) ) { $dbh->do("ALTER TABLE ... ADD COLUMN ..."); } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #74 from Pierre-Marc Thibault --- All the old patches have been merged to make tests easier. The new patch is rebased and solves the last problems mentioned. The tab char is gone, the style attributes too and the inputs order is now correct. It seems there is no problem with the alert message, it will be to confirme with other tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #73 from Pierre-Marc Thibault --- Created attachment 81032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81032=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 5) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74268|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74267|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74269|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74272|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added Attachment #74270|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Attachment #74273|0 |1 is obsolete|| --- Comment #72 from Pierre-Marc Thibault --- Comment on attachment 74273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74273 Bug 8643: (follow-up) Move input field up below mandatory This patch is set at obsolete since it contains no usable code and duplicated code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #71 from Josef Moravec --- Sent by accident before finished ;) ad 2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt 230Tab:[% subfield.tab %] | $[% subfield.tagsubfield %] koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt 791* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #70 from Josef Moravec --- Just started QA and found some issues: 1) qa test tools report: FAILadmin/marctagstructure.pl FAIL forbidden patterns forbidden pattern: tab char (line 125) 2) Sometimes you use attribute "style" for css - should be done using class koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt 588* koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt 348[% ELSIF ( ite.important ) %] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #69 from Katrin Fischer --- When you rebase you can usually set back to the status it had before. In this case it was signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #68 from Charles Farmer --- Rebased on current master. Should apply cleanly now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Attachment #74271|0 |1 is obsolete|| --- Comment #66 from Charles Farmer --- Created attachment 74272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74272=edit Bug 8643: (QA follow-up) Use paler yellow and better column order Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Attachment #73818|0 |1 is obsolete|| --- Comment #67 from Charles Farmer --- Created attachment 74273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74273=edit Bug 8643: (follow-up) Move input field up below mandatory Changes sequence of input fields to be more logical by grouping repeatable, mandatory, important, like it's already done for the subfield configuration. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Attachment #73817|0 |1 is obsolete|| --- Comment #65 from Charles Farmer --- Created attachment 74271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74271=edit Bug 8643: (QA follow-up) Use paler yellow and better column order Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Attachment #73814|0 |1 is obsolete|| --- Comment #62 from Charles Farmer --- Created attachment 74268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74268=edit Bug 8643: Add hint for important fields and implemented it for item fields Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Attachment #73813|0 |1 is obsolete|| --- Comment #61 from Charles Farmer --- Created attachment 74267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74267=edit Bug 8643: (follow-up) Atomic update Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Attachment #73816|0 |1 is obsolete|| --- Comment #64 from Charles Farmer --- Created attachment 74270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74270=edit Bug 8643: (QA follow-up) Fix alert, clean up patch, improve db update * Field 'important' now added after 'mandatory' in table marc_tag_structure * Removed modification on table serialitems in kohastructure.sql * Removed bogus line in marctagstructure.tt * Fixed the missing tag number in the alert message Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmerchanged: What|Removed |Added Attachment #73815|0 |1 is obsolete|| --- Comment #63 from Charles Farmer --- Created attachment 74269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74269=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: I Apply the patch II Run updatedatabase.pl 0) Define 100 as an "important" field ( Administration » MARC bibliographic framework » MARC structure ( Default Frameword) » Edit ) 1) Define 100$a as an "important" subfield (Administration » MARC bibliographic framework » MARC structure (Default Frameword) » Subfield » Onglet a) 2) Edit a record to clear the field 100 3) Save the record. 4) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? sponsored by the CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Bernardo Gonzalez Kriegel Work as described. Fixed small conflict Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Josef Moravecchanged: What|Removed |Added QA Contact||josef.mora...@gmail.com CC||josef.mora...@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #60 from Josef Moravec --- Sorry, does not apply on current master... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischerchanged: What|Removed |Added Summary|Add important constraint to |Add important constraint to |marc tags and subfields |MARC tags and subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #59 from Charles Farmer--- (In reply to Katrin Fischer from comment #58) > One thing for next time :) Please take care of always writing good commit > messages and the format of the subject line spefically: > https://wiki.koha-community.org/wiki/Commit_messages > > These patches have a lot of history, being started in 2012. It works alright > now in my eyes. You're right, I'll keep it in mind next time I rebase/submit a bug :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischerchanged: What|Removed |Added Text to go in the||This feature allows tags release notes||and subfields in ||bibliographic frameworks to ||be marked as important. The ||important attribute will ||trigger a confirmation ||message on saving the ||record, but will allow you ||to save the record without ||filling the fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to marc tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Katrin Fischerchanged: What|Removed |Added Summary|Add important constraint to |Add important constraint to |marc subfields |marc tags and subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/