[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #16 from Martin Renvoize martin.renvo...@ptfs-europe.com --- So i've been running through some customisations and patches that require rebuilding these dom config files... I'm using the script make_zebra_dom_cfg_from_record_abs as directed on http://wiki.koha-community.org/wiki/Switching_to_dom_indexing to create my new marc21 biblio-koha-indexdefs.xml config file: ~/kohaclone/misc/maintenance/make_zebra_dom_cfg_from_record_abs --input ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/record.abs --output ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xml However each time I run the script the ID line is removed from the resulting file and so this bug reasserts itself.. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 --- Comment #17 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #16) So i've been running through some customisations and patches that require rebuilding these dom config files... I'm using the script make_zebra_dom_cfg_from_record_abs as directed on http://wiki.koha-community.org/wiki/Switching_to_dom_indexing to create my new marc21 biblio-koha-indexdefs.xml config file: ~/kohaclone/misc/maintenance/make_zebra_dom_cfg_from_record_abs --input ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/record.abs --output ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xml However each time I run the script the ID line is removed from the resulting file and so this bug reasserts itself.. Am I missing something? Yes. You should not use the make_zebra_dom_cfg_from_record_abs script. I will update the wiki page to clarify that the script should not be used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #15 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA Version|master |rel_3_8 Assignee|gmcha...@gmail.com |jcam...@cpbibliography.com QA Contact||paul.poul...@biblibre.com --- Comment #13 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * small patch, xsl only, but a core one * fixes identifier for zebra by switching from 001 to where biblionumber is stored, because biblionumber is guaranteed to be unique ++ * fixes other minor mistakes -- to fix in the same patch, but not worth failing QA, it's a needed fix passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master (checked that it work in UNIMARC) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #12877|0 |1 is obsolete|| --- Comment #11 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 13085 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13085action=edit [SIGNED-OFF] Bug 8665: DOM indexing fails to index some bib records Use a user-specified field for z:id. This patch also fixes an excess space before the index in the MARC21 biblio index definitions, which someone fixed in the generated file but not in the source file it should have been fixed in. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||elli...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #13058|0 |1 is obsolete|| --- Comment #12 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 13086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13086action=edit [SIGNED-OFF] Bug 8665 follow-up: add missing line to XSLT The DOM transformer was missing a line from a previous development, resulting in the MARC21 authorities DOM indexing stylesheet being regenerated with a missing line. This patch readds the missing line to the transformer, and provides the corrected authority-zebra-indexdefs. Signed-off-by: Elliott Davis elli...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #8 from Paul Poulain paul.poul...@biblibre.com --- QA comment: * are the following lines related to this fix ?: - xslo:template mode=index_heading_conditional match=marc:datafield[@tag='450'] + xslo:template mode=index_heading_conditional ... + xslo:template match=text() mode=index_heading_conditional/ ... + xslo:apply-templates mode=index_heading_conditional/ * OK for -target_indexmaterials-specified :w/target_index +target_indexmaterials-specified:w/target_index * not sure I understand what does: -xslo:variable name=controlField001 select=normalize-space(marc:controlfield[@tag='001'])/ +xslo:variable name=idfield select=normalize-space(marc:controlfield[@tag='001'])/ z:record type=update xslo:attribute name=z:id -xslo:value-of select=$controlField001/ +xslo:value-of select=$idfield/ (in authority-zebra-indexdefs) : it does nothing except changing the variable to be consistent with biblio-zebra-indexdefs, right ? (for biblio, the change is in the variable name AND in what it is filled with: -xslo:variable name=controlField001 select=normalize-space(marc:controlfield[@tag='001'])/ +xslo:variable name=idfield select=normalize-space(marc:datafield[@tag='999']/marc:subfield[@code='c'])/ ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 --- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 13058 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13058action=edit Bug 8665 follow-up: add missing line to XSLT The DOM transformer was missing a line from a previous development, resulting in the MARC21 authorities DOM indexing stylesheet being regenerated with a missing line. This patch readds the missing line to the transformer, and provides the corrected authority-zebra-indexdefs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 --- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #8) QA comment: * are the following lines related to this fix ?: - xslo:template mode=index_heading_conditional match=marc:datafield[@tag='450'] + xslo:template mode=index_heading_conditional' A line was missing in the transformer. I fixed that in the follow-up. + xslo:template match=text() mode=index_heading_conditional/ ... + xslo:apply-templates mode=index_heading_conditional/ These others are no-ops, caused by the fact that I didn't retransform the bib stylesheets after adding index_heading_conditional. * OK for -target_indexmaterials-specified :w/target_index +target_indexmaterials-specified:w/target_index * not sure I understand what does: -xslo:variable name=controlField001 select=normalize-space(marc:controlfield[@tag='001'])/ +xslo:variable name=idfield select=normalize-space(marc:controlfield[@tag='001'])/ z:record type=update xslo:attribute name=z:id -xslo:value-of select=$controlField001/ +xslo:value-of select=$idfield/ (in authority-zebra-indexdefs) : it does nothing except changing the variable to be consistent with biblio-zebra-indexdefs, right ? Exactly. That's the point of the fix. (for biblio, the change is in the variable name AND in what it is filled with: -xslo:variable name=controlField001 select=normalize-space(marc:controlfield[@tag='001'])/ +xslo:variable name=idfield select=normalize-space(marc:datafield[@tag='999']/marc: subfield[@code='c'])/ ) Remember that the *-zebra-indexdefs.xsl files are all automatically generated. Any time the transformer is changed in a way that could cause side effects, all the *-zebra-indexdefs.xsl files must be regenerated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #12734|0 |1 is obsolete|| --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 12877 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12877action=edit Bug 8665: DOM indexing fails to index some bib records Use a user-specified field for z:id. This patch also fixes an excess space before the index in the MARC21 biblio index definitions, which someone fixed in the generated file but not in the source file it should have been fixed in. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #12684|0 |1 is obsolete|| --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 12734 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12734action=edit Bug 8665: DOM indexing fails to index some bib records Use a user-specified field for z:id. This patch also fixes an excess space before the index in the MARC21 biblio index definitions, which someone fixed in the generated file but not in the source file it should have been fixed in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 --- Comment #5 from Colin Campbell colin.campb...@ptfs-europe.com --- (In reply to comment #3) Colin, any chance you could describe what to change controlField001 *to* that can workaround this problem? Pleease? :) My kludge was to substitute this: xslo:attribute name=z:id xslo:value-of select=biblioitemnumber/ /xslo:attribute Not a thought out solution but assuming anything in the MARC record will be unique (even if theoretically so) is groundless. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 D Ruth Bavousett r...@bywatersolutions.com changed: What|Removed |Added CC||r...@bywatersolutions.com --- Comment #2 from D Ruth Bavousett r...@bywatersolutions.com --- It's a nice assumption, Paul, and in a perfect world, it would be so, but the assumption is a bit rash in the real world. In the GRS model of indexing, only 999$c is *required* to be unique, and (IMO) it should be the same way in DOM. Until this is fixed, I've got libraries that can't use DOM indexing, period. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 --- Comment #3 from D Ruth Bavousett r...@bywatersolutions.com --- Colin, any chance you could describe what to change controlField001 *to* that can workaround this problem? Pleease? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Paul A pau...@aandc.org changed: What|Removed |Added CC||pau...@aandc.org --- Comment #1 from Paul A pau...@aandc.org --- Although not specifically defined, we assume that 001 (Control Number) should be unique in Koha. Duplicates (for eventual correction) can be found by running a report: SELECT GROUP_CONCAT(biblionumber SEPARATOR ', ') AS biblionumbers, EXTRACTVALUE(marcxml,'//controlfield[@tag=001]') AS id FROM biblioitems GROUP BY id HAVING count(id) 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
