subject:"\[Koha\-bugs\] \[Bug 8753\] Add forgot password link to OPAC"

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2020-11-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||26941


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941
[Bug 26941] Missing OPAC password recovery error messages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2017-05-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

 Blocks||18653

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2017-05-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18616


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616
[Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use
their library card number in addition to username
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-12-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Katrin Fischer  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-12-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-11-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Eric Bégin  changed:

   What|Removed |Added

 CC|maxime.beaul...@inlibro.com |
   |,   |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-06-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16707


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707
[Bug 16707] Software Error in OPAC password recovery when leaving form fields
empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-06-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Julian Maurice  changed:

   What|Removed |Added

 Blocks||16471


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16471
[Bug 16471] Translatability: Fix issues in opac-password-recovery.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #213 from Katrin Fischer  ---
The patches here have been written for the next version 16.05 (3.24) and are
not supposed to work with any earlier code. It's a completely new feature that
will only be available in new versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Mubassir Ahsan  changed:

   What|Removed |Added

 CC||mahsa...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #212 from Mubassir Ahsan  ---
Comment on attachment 47164
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47164
Bug 8753 - Add forgot password link to OPAC

Review of attachment 47164:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=8753=47164)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ +357,3 @@
>  - pref: OPACPatronDetails
>choices:
>yes: Allow

When I am applying this (v.3.22.06), OPAC Global preference page
(cgi-bin/koha/admin/preferences.pl?tab=opac) is showing the following error 

Syck parser (line 356, column 0): syntax error at /usr/lib/perl5/YAML/Syck.pm
line 72.

I have also tried with changing the syntax as 
- pref: OpacResetPassword
  default: 1
  choices:
  yes: "can reset"
  no: "can not reset"
-The user can reset their password on OPAC. 
-
But no luck. 
Please review.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #211 from Charles Farmer  ---
The follow-up patch to change the namespace of this development is in bug 15585

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #47357|0   |1
is obsolete||

--- Comment #209 from Katrin Fischer  ---
Created attachment 47366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47366=edit
[PASSED QA] Bug 8753 [QA Followup] - Add notice to translations

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #210 from Brendan Gallagher  ---
Follow up Pushed (Jan 27 - 2016)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #206 from Marcel de Rooy  ---
Brendan
It seems that you forgot to move the atomicupdate revision to the code in
updatedatabase.
Currently, part of your job as RM :)

Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #207 from Brendan Gallagher  ---
(In reply to Marcel de Rooy from comment #206)
> Brendan
> It seems that you forgot to move the atomicupdate revision to the code in
> updatedatabase.
> Currently, part of your job as RM :)
> 
> Marcel

Yes thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #208 from Kyle M Hall  ---
Created attachment 47357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47357=edit
Bug 8753 [QA Followup] - Add notice to translations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #205 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #204)
> Blou - please don't forget the 2 follow-ups for the namespace and the
> notices (last comment from Marcel!)

Yes. Please add the bug number in the See also or Blocks too.
Thnx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15585

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Pushed to Master

--- Comment #203 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #204 from Katrin Fischer  ---
Blou - please don't forget the 2 follow-ups for the namespace and the notices
(last comment from Marcel!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #202 from Marcel de Rooy  ---
QA Comment:
With reference to the discussion above (and time passed), I am moving the
status to Passed QA. 
Looks good to me. Added a small follow-up.
An important detail to fix before the new release is: New notice should be
added in all language files! Please fix that asap in a follow-up report after
this one has been pushed. This would normally be a reason to Fail QA on
itself...
Note to RM: Watch the conflict with bug 15548 (Borrower vs Patron); and the
promised fix under 15585.

Minor points:
Spotted "FIXME: That ugly shift-grep contraption".
The term "Forgotten password recovery"  sounds funny to me (no native speaker
:) Is Password recovery not sufficient?
Are dots in the unique key (especially at the end) user friendly? 

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #201 from Marcel de Rooy  ---
Created attachment 47171
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47171=edit
Bug 8753: [QA Follow-up] Primary key and collation

This patch includes:
[1] Adds primary key borrowernumber to new table.
[2] Fixes collation.
[3] Removes manual PK in DBIx schema file.
[4] Fixes typo CompletePasswordRevovery.
[5] Removes use strict from opac-password-recovery; Modern::Perl is used.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #197 from Marcel de Rooy  ---
Created attachment 47167
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47167=edit
Bug 8753 - [followup] POD cleanup

Check to make sure the messages from the qa checker are gone.

Note I'm not sure about this one because my test tools are apparently broken,
and I can't get the error to manifest.

Amended patch by Jonathan Druart: Add a blank line before =head2
It now passes.

Signed-off-by: Marc Veron 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

--- Comment #193 from Marcel de Rooy  ---
QA: Working on this one..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45223|0   |1
is obsolete||
  Attachment #45224|0   |1
is obsolete||
  Attachment #45225|0   |1
is obsolete||
  Attachment #45226|0   |1
is obsolete||
  Attachment #45227|0   |1
is obsolete||
  Attachment #45228|0   |1
is obsolete||
  Attachment #45229|0   |1
is obsolete||
  Attachment #46379|0   |1
is obsolete||

--- Comment #194 from Marcel de Rooy  ---
Created attachment 47164
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47164=edit
Bug 8753 - Add forgot password link to OPAC

I've addressed a lot of Liz Rea's points.

1.  I have moved the code from updatedatabase.pl and kohastructure.sql to a
file in the atomicupdates directory.
1a. The feature is now off by default when the atomicupdate is run.

2.  The password reset link is now visible on the home page, in the modal box
and on opac-user.pl .

3.  The password recovery pages now use bootstrap markup.

4.  I am unsure here. I see "New Password:" and "Confirm new password:".

5.  This should still work :).

6.  I could not reproduce.

7.  I have added the userid field.
You can now reset the password by submitting either your useid or email
address.
Both fields can be filled, but the email address must be one of the
borrower's (email, emailpro or b_email).
When entering only the email address and two borrowers use that same
address, the system tells the user to try with another address or to specify
his userid.

8.  The text is in the atomicupdate file. Have at it, anyone.

Concerning the email. It is inconvenient for the use to have to wait X minutes
for the message queue the be processed.
Maybe we could add a sub in Letters.pm that:
Takes the same argments as EnqueueLetter
Sends the letter.
Saves the letter in the message queue with a 'sent' status.

 TEST PLAN:

Setup)
1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to
ON.
2b) make sure that OpacPasswordChange is also ON.
A)
1) refresh front page, click on 'Forgot your password' and enter a VALID
address
1b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
2) An email should be received at that address with a link.
3) Follow the link in the mail to fill the new password.
Until a satisfactory new password is entered, the old password is not
reset.
4) Go to main page try the new password.
B)
1) Repeat the password reset, this time use the userid (username) field.
2) Try to reset the password using a userid and an email not linked to the
account. An error appears.
3) Make sure the borrower has many available email addresses.
4) For each email, reset the password using both the userid and the email.
The link should be sent to the specified address
C)
1) Make sure two borrowers use the same email.
2) Repeat the reset procedure in test case A). An error message appears

http://bugs.koha-community.org/show_bug.cgi?id=13068

 Author:Maxime Beaulieu 

Followed test plan. Works as described.
Signed-off-by: Marc Veron 

New sign-off after testing all patches together
Signed-off-by: Marc Veron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #195 from Marcel de Rooy  ---
Created attachment 47165
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47165=edit
Bug 8753 - Followup - change value text on syspref

Followup changes text from "The user can reset | can not reset their password
on OPAC" to "Library users are allowed | not allowed to recover their password
via e-mail in the OPAC"

This change more clearly differentiates the purpose of this new preference from
OpacPasswordChange.

Bug 8753 - followup - update text for link to match common UI paradigms, fixes
OpacPublic disabled view

Also corrects OpacNav being included on the reset page on private catalogues.

Updated the link for forgotten passwords to more closely match common UI
paradigms, i.e. Facebook and Twitter

To test:
apply all patches, link should now be the less verbose "Forgot your password?"
disable OpacPublic, anything in opacnav should not appear (you may need to add
something to opacnav to test properly)

Bug 8753 - [followup] fix the title on opac-password-recovery.tt

The title stanza was missing a  around it, causing the extra
text to appear.

To test, apply all patches and make sure it looks ok and there is no extra text
at the top or bottom of the page.

Bug 8753 - [followup} Correcting spelling mistakes

Make sure it all still works

Bug 8753 - [followup] fix error when no information is provided

To test:

All normal checks plus make sure that a nice error is displayed when no data is
provided.

fixing the deprecated thing

Signed-off-by: Marc Veron 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #199 from Marcel de Rooy  ---
Created attachment 47169
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47169=edit
Bug 8753 - Various little things - removing new dependency, changes to errors,
textual updates

Koha already has a sub that creates salts, so lets use that instead of
math::Random::secure, so as not to add a new dependency.

Made the references to "Forgotten password" consistent, including adding it to
the title of the page.

Also removed the individual error for "this email doesn't belong to this
account" as that could expose the existence of a login, which I think we'd
rather not do.

Made some of the text more grammatically correct, and more library specific.

To test:

Apply on top of all of the other patches.

All the usual checks, plus make sure there are no typos in any text references.

Signed-off-by: Marc Veron 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #196 from Marcel de Rooy  ---
Created attachment 47166
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47166=edit
Bug 8753 - Use Koha::Borrowers instead of C4::Members

Use the new library to search for borrowers.
Changed how the $borrower variable is used since it is now a Koha::Borrower
object.

Removed the $protocol parameter from the generated link. It should be included
in the OPACBaseURL syspref.

modified:   C4/Passwordrecovery.pm
modified:   opac/opac-password-recovery.pl

Signed-off-by: Marc Veron 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #198 from Marcel de Rooy  ---
Created attachment 47168
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47168=edit
Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy,
Passwordrecovery.t

This is a collection of changes taken from different comments (but mostly
comment 21 and comment 122).

Passes qa and prove, on my machine at least.

There's also a new test file, Passwordrecovery.t, which covers every method of
C4::Passwordrecovery.

To test:

All normal checks plus :

1/ Receive the email
2/ Click on the link
3/ Change the pwd
4/ Click again on the link
5/ You should immediately get an error message

Problems with Math/Random/Secure.pm, is solved in following patch, signing off
Signed-off-by: Marc Veron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #200 from Marcel de Rooy  ---
Created attachment 47170
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47170=edit
Bug 8753 - propagating the changes to kohastructure.sql and sysprefs.sql

Signed-off-by: Liz Rea 
Looks good with a new install.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #183 from Jonathan Druart  
---
(In reply to Blou from comment #176)
> Of course, we're now at 180 comments and counting, so there's a side of me
> that would like to see that keep increasing and beat a record of some sort. 
> ;-)

Don't worry about that, we won't reach it (there are 247 comments on bug 7167
and it as been abandoned, there is another one with more than 500 comments
iirc).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #184 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #182)
> Kyle, can we imagine to make an exception for this one, open a new bug
> report to move the new module to the Koha namespace and ask for the author
> to commit to submit a patch?

Yes! I set this bug to in discussion while we were actually discussing the
issue. I purposefully did not set it to failed qa.

My fear is that if this is pushed as is, there is no impetus for the namespace
to be fixed. All I'd like to see is a commitment from someone that the patches
to move this to a better namespace *will be submitted*, preferably before the
next major release if possible. So far I haven't seen anyone make that
commitment. I should have written that more clearly than I had.

Philippe, if you can vouch that Charles or someone will submit the patch to
move this module to a new namespace, I have no problem with it proceeding as
is. Now would be the time to file the followup bug report and assign it to the
proper person. If this works for you please go ahead and reset the status to
Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #182 from Jonathan Druart  
---
Kyle, can we imagine to make an exception for this one, open a new bug report
to move the new module to the Koha namespace and ask for the author to commit
to submit a patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #188 from Katrin Fischer  ---
While I have put coding guideline additions on the agenda a lot of times in the
past, I don't believe that we can ever have a complete set of rules that will
fit every situation and possible question.

Another common practice we QA has used where they haven't been sure about
something is asking for more opinions - I think this has helped in a lot of
cases to get more views and a better picture of the problem and possible
solutions.

That said, I am happy with the 2 step approach here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #185 from Blou  ---
This is not a problem for us.  To be sure, just create the new bug and assign
it to me immediately.  I assure you you'll get a patch within a week after this
has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #186 from Kyle M Hall  ---
(In reply to Blou from comment #185)
> This is not a problem for us.  To be sure, just create the new bug and
> assign it to me immediately.  I assure you you'll get a patch within a week
> after this has been pushed to master.

Thanks! I'll go ahead and take care of that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #187 from Kyle M Hall  ---
(In reply to Chris Cormack from comment #179)
> Hopefully this new super strict QA standard will be across the board and I
> won't see people pushing patches they wrote skipping qa steps anymore.

I'd like to address this. I'm not in favor of super strict QA standards. What
I'm in favor of are transparent, standardized, and consistently applied QA
rules.

My experience as a developer has informed my work as a QA team member. I have
had to rewrite C4 modules as Koha modules, I've asked others to rewrite C4
modules as Koha modules. Code quality guidelines should be completely divorced
from the necessity or popularity of a bugfix or feature.

I think our coding guidelines need a bit of a revamp to make sure all of the
things we've taken for granted as being necessary to pass QA are actually in
the coding guidelines. If a QA team member fails QA on a patch, the QA'er
should be able to link directly to the reason and explanation for it failing
QA. If the QA'er believes the patch should fail QA but the reason is not part
of the coding guidelines, then a meeting should be called, a vote should be
made, and a new rule added to the guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15585


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585
[Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #189 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #188)
> While I have put coding guideline additions on the agenda a lot of times in
> the past, I don't believe that we can ever have a complete set of rules that
> will fit every situation and possible question.
> 
> Another common practice we QA has used where they haven't been sure about
> something is asking for more opinions - I think this has helped in a lot of
> cases to get more views and a better picture of the problem and possible
> solutions.

That simply highlights the problem. With this methodology, a developer will not
know if code will pass qa or not until it has been written and submitted.

I agree, we will never have a complete set of rules, but we can build that set
as we go. The more we have written down for developers to be aware in advance,
the better. We need documented guidelines. The approach of "this doesn't feel
right to me" just doesn't work any more. It can only lead to future frustration
for developers. We can't have one set of rules for bug A and another set of
rules for bug B.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #190 from Katrin Fischer  ---
I think we are actually not in disagreement - I just want to warn about wanting
to solve everything with rules. That will be trying for the impossible. And a
20 pages catalog of guidelines... is kind of scaring away devs too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #192 from Kyle M Hall  ---
I also want to add that the guidelines would be an explanation of they
something failed qa. Instead of "Here is a link to the community decided
reason" it is currently more of a "because I said so" situation. I personally
dislike failing qa on something without having those reasons. I'm far more apt
to submit follow ups to avoid doing so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #191 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #190)
> I think we are actually not in disagreement - I just want to warn about
> wanting to solve everything with rules. That will be trying for the
> impossible. And a 20 pages catalog of guidelines... is kind of scaring away
> devs too.

Lol, yeah, I agree with that too. I just think at the moment we have too few
guidelines on paper and too many guidelines only in the heads of the QA team ;
)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-15 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #181 from Chris Cormack  ---
(In reply to Marcel de Rooy from comment #180)
> (In reply to Chris Cormack from comment #179)
> > Hopefully this new super strict QA standard will be across the board and I
> > won't see people pushing patches they wrote skipping qa steps anymore.
> 
> I do not favor a super strict QA standard. Common_sense++

Neither do I, but if we are going to be super strict about this one, we need to
at least be consistent. That was my point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #180 from Marcel de Rooy  ---
(In reply to Chris Cormack from comment #179)
> Hopefully this new super strict QA standard will be across the board and I
> won't see people pushing patches they wrote skipping qa steps anymore.

I do not favor a super strict QA standard. Common_sense++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Chris Cormack  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #179 from Chris Cormack  ---
*sigh*

Oh well, can't be helped I guess. I will test the new patch as soon as it is
up.

Hopefully this new super strict QA standard will be across the board and I
won't see people pushing patches they wrote skipping qa steps anymore.

Switching back to assigned, while we wait for the new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #177 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #174)
> After thinking this over for a bit I would be in favor of pushing it as it
> is. This is a long needed development that probably predates most of the
> work in the Koha namespace. Changing the namespace now would require more
> testing and it might give us a lot of conflicts in other places. So it might
> be easier to fix the namespace separately after this is pushed.

If it doesn't get fixed now, it won't get fixed. This patch was submitted long
after the creation of the Koha namespace. Changing the namespace is not that
onerous a request. We can't allow code in that isn't fit just because we like
the feature itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-14 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #178 from Blou  ---
Noo!!!  Not the dreaded "In Discussion" !!

I would have prefered Failed QA.

Not sure what is left to discuss.  Everyone already chimed in.  But I respect
the QA's right to fail it.

At this point, since it would require "full retest", I will ask Charles to fix
it and SQUASH everything.  Considering the amount of support this feature has,
I suppose a re-signoff wouldn't be long.  *sigh*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-12 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #174 from Katrin Fischer  ---
After thinking this over for a bit I would be in favor of pushing it as it is.
This is a long needed development that probably predates most of the work in
the Koha namespace. Changing the namespace now would require more testing and
it might give us a lot of conflicts in other places. So it might be easier to
fix the namespace separately after this is pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-12 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #173 from Marc Véron  ---
+1 for getting it in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-12 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #175 from Magnus Enger  ---
+1 for getting this in ASAP. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-12 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #176 from Blou  ---
In the name of the whole personnel at inLibro, which I've cycled through to
support this patch in the past 2.5 years (so many good people fell on the
battlefield, see comment #102), I say "yeah! it's about time!".

Of course, we're now at 180 comments and counting, so there's a side of me that
would like to see that keep increasing and beat a record of some sort.  ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Karl Holten  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

JD@TeTakere  changed:

   What|Removed |Added

 CC|joan...@tetakere.org.nz |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #170 from Liz Rea  ---
May we have this heavily tested version in, and move it to the new namespace in
a follow up? This is an egregiously missing feature, and one that we have been
waiting a long, long time for.

It's for the users, let's get it in.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #171 from David Cook  ---
As the local pedant in the Koha community, I'm with Liz on this one.

While we shouldn't be adding anything to the C4 namespace, I think perhaps an
exception should be made for this particular patch set, as the feature is
rather important in modernizing Koha.

Out in the world, there's pretty much no service where you can't reset your own
password. Yet, you can't do it in Koha. Surely this frustrates users and puts a
burden on librarians. It's an aspect of the modern web experience which Koha
fails at.

This patch set has been a long time coming. While it should be fairly easy to
do a search and replace through the patches, mistakes do happen, and we'd
probably need to re-test all the patches again to make sure that nothing was
missed. It seems like it's already been tested to the Nth degree, so perhaps a
pass should be made this one time.

I suppose it would qualify as technical debt, and I hate technical debt. But
this does seem to be an extraordinary case. If it were anything but a password
reset, I'd say change the namespace. But this is such a missing piece of
functionality in Koha, that I think the faster we get it in the better. 

Of course, I defer to the QA team and the RM. But just adding that perspective
to the comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #172 from Tim Hannah  ---
As a librarian I can confirm that the lack of this feature frustrates me, my
colleagues and our users. We've been waiting for this for a while and would
dearly love to have it sooner rather than later.

I can't pretend to understand the ramifications of an imperfect namespace
choice, but I know we currently lose users due to them being locked out and
going elsewhere rather than approaching us for resets or reminders.

If it can be released as is and fixed later, as Liz suggests, I for one would
be very grateful.

(And thanks for everyone's work on it. Looking forward to it, whenever we get
it).

Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-11 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #169 from Jonathan Druart  
---
Koha::Patron please :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-08 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #168 from Kyle M Hall  ---
I don't think C4::Passwordrecovery is a good namespace. Should this not be
something like Koha::Patron::Password::Recovery or
Koha::Borrower::Password::Recovery? We should not be adding modules to the C4
namespace at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2016-01-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Liz Rea  changed:

   What|Removed |Added

  Attachment #45230|0   |1
is obsolete||

--- Comment #167 from Liz Rea  ---
Created attachment 46379
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46379=edit
Bug 8753 - propagating the changes to kohastructure.sql and sysprefs.sql

Signed-off-by: Liz Rea 
Looks good with a new install.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #45210|0   |1
is obsolete||

--- Comment #159 from Charles Farmer  ---
Created attachment 45224
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45224=edit
Bug 8753 - Followup - change value text on syspref

Followup changes text from "The user can reset | can not reset their password
on OPAC" to "Library users are allowed | not allowed to recover their password
via e-mail in the OPAC"

This change more clearly differentiates the purpose of this new preference from
OpacPasswordChange.

Bug 8753 - followup - update text for link to match common UI paradigms, fixes
OpacPublic disabled view

Also corrects OpacNav being included on the reset page on private catalogues.

Updated the link for forgotten passwords to more closely match common UI
paradigms, i.e. Facebook and Twitter

To test:
apply all patches, link should now be the less verbose "Forgot your password?"
disable OpacPublic, anything in opacnav should not appear (you may need to add
something to opacnav to test properly)

Bug 8753 - [followup] fix the title on opac-password-recovery.tt

The title stanza was missing a  around it, causing the extra
text to appear.

To test, apply all patches and make sure it looks ok and there is no extra text
at the top or bottom of the page.

Bug 8753 - [followup} Correcting spelling mistakes

Make sure it all still works

Bug 8753 - [followup] fix error when no information is provided

To test:

All normal checks plus make sure that a nice error is displayed when no data is
provided.

fixing the deprecated thing

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #45211|0   |1
is obsolete||

--- Comment #160 from Charles Farmer  ---
Created attachment 45225
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45225=edit
Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt

I could only reproduce the forbidden pattern error from jonathan Druart's
comment#97 locally, so I fixed it.

TEST PLAN

1)Apply all patches
2)Forbidden pattern error should not be there anymore

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #45215|0   |1
is obsolete||

--- Comment #164 from Charles Farmer  ---
Created attachment 45229
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45229=edit
Bug 8753 - Various little things - removing new dependency, changes to errors,
textual updates

Koha already has a sub that creates salts, so lets use that instead of
math::Random::secure, so as not to add a new dependency.

Made the references to "Forgotten password" consistent, including adding it to
the title of the page.

Also removed the individual error for "this email doesn't belong to this
account" as that could expose the existence of a login, which I think we'd
rather not do.

Made some of the text more grammatically correct, and more library specific.

To test:

Apply on top of all of the other patches.

All the usual checks, plus make sure there are no typos in any text references.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #45209|0   |1
is obsolete||

--- Comment #158 from Charles Farmer  ---
Created attachment 45223
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45223=edit
Bug 8753 - Add forgot password link to OPAC

I've addressed a lot of Liz Rea's points.

1.  I have moved the code from updatedatabase.pl and kohastructure.sql to a
file in the atomicupdates directory.
1a. The feature is now off by default when the atomicupdate is run.

2.  The password reset link is now visible on the home page, in the modal box
and on opac-user.pl .

3.  The password recovery pages now use bootstrap markup.

4.  I am unsure here. I see "New Password:" and "Confirm new password:".

5.  This should still work :).

6.  I could not reproduce.

7.  I have added the userid field.
You can now reset the password by submitting either your useid or email
address.
Both fields can be filled, but the email address must be one of the
borrower's (email, emailpro or b_email).
When entering only the email address and two borrowers use that same
address, the system tells the user to try with another address or to specify
his userid.

8.  The text is in the atomicupdate file. Have at it, anyone.

Concerning the email. It is inconvenient for the use to have to wait X minutes
for the message queue the be processed.
Maybe we could add a sub in Letters.pm that:
Takes the same argments as EnqueueLetter
Sends the letter.
Saves the letter in the message queue with a 'sent' status.

 TEST PLAN:

Setup)
1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to
ON.
2b) make sure that OpacPasswordChange is also ON.
A)
1) refresh front page, click on 'Forgot your password' and enter a VALID
address
1b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
2) An email should be received at that address with a link.
3) Follow the link in the mail to fill the new password.
Until a satisfactory new password is entered, the old password is not
reset.
4) Go to main page try the new password.
B)
1) Repeat the password reset, this time use the userid (username) field.
2) Try to reset the password using a userid and an email not linked to the
account. An error appears.
3) Make sure the borrower has many available email addresses.
4) For each email, reset the password using both the userid and the email.
The link should be sent to the specified address
C)
1) Make sure two borrowers use the same email.
2) Repeat the reset procedure in test case A). An error message appears

http://bugs.koha-community.org/show_bug.cgi?id=13068

 Author:Maxime Beaulieu 

Followed test plan. Works as described.
Signed-off-by: Marc Véron 

New sign-off after testing all patches together
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #45214|0   |1
is obsolete||

--- Comment #163 from Charles Farmer  ---
Created attachment 45228
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45228=edit
Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy,
Passwordrecovery.t

This is a collection of changes taken from different comments (but mostly
comment 21 and comment 122).

Passes qa and prove, on my machine at least.

There's also a new test file, Passwordrecovery.t, which covers every method of
C4::Passwordrecovery.

To test:

All normal checks plus :

1/ Receive the email
2/ Click on the link
3/ Change the pwd
4/ Click again on the link
5/ You should immediately get an error message

Problems with Math/Random/Secure.pm, is solved in following patch, signing off
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #45213|0   |1
is obsolete||

--- Comment #162 from Charles Farmer  ---
Created attachment 45227
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45227=edit
Bug 8753 - [followup] POD cleanup

Check to make sure the messages from the qa checker are gone.

Note I'm not sure about this one because my test tools are apparently broken,
and I can't get the error to manifest.

Amended patch by Jonathan Druart: Add a blank line before =head2
It now passes.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #165 from Charles Farmer  ---
Created attachment 45230
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45230=edit
Bug 8753 - propagating the changes to kohastructure.sql and sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #45212|0   |1
is obsolete||

--- Comment #161 from Charles Farmer  ---
Created attachment 45226
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45226=edit
Bug 8753 - Use Koha::Borrowers instead of C4::Members

Use the new library to search for borrowers.
Changed how the $borrower variable is used since it is now a Koha::Borrower
object.

Removed the $protocol parameter from the generated link. It should be included
in the OPACBaseURL syspref.

modified:   C4/Passwordrecovery.pm
modified:   opac/opac-password-recovery.pl

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-30 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #166 from Charles Farmer  ---
(In reply to Josef Moravec from comment #157)
> I think that files kohastructure.sql and sysprefs.sql, should be updated
> too, not only to add atomicupdate sql file...

The changes brought by the atomicupdate file are now visible in the
kohastructure and sysprefs files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #147 from Josef Moravec  ---
I agree, but rebase needed...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #44323|0   |1
is obsolete||

--- Comment #149 from Charles Farmer  ---
Created attachment 45209
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45209=edit
Bug 8753 - Add forgot password link to OPAC

I've addressed a lot of Liz Rea's points.

1.  I have moved the code from updatedatabase.pl and kohastructure.sql to a
file in the atomicupdates directory.
1a. The feature is now off by default when the atomicupdate is run.

2.  The password reset link is now visible on the home page, in the modal box
and on opac-user.pl .

3.  The password recovery pages now use bootstrap markup.

4.  I am unsure here. I see "New Password:" and "Confirm new password:".

5.  This should still work :).

6.  I could not reproduce.

7.  I have added the userid field.
You can now reset the password by submitting either your useid or email
address.
Both fields can be filled, but the email address must be one of the
borrower's (email, emailpro or b_email).
When entering only the email address and two borrowers use that same
address, the system tells the user to try with another address or to specify
his userid.

8.  The text is in the atomicupdate file. Have at it, anyone.

Concerning the email. It is inconvenient for the use to have to wait X minutes
for the message queue the be processed.
Maybe we could add a sub in Letters.pm that:
Takes the same argments as EnqueueLetter
Sends the letter.
Saves the letter in the message queue with a 'sent' status.

 TEST PLAN:

Setup)
1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to
ON.
2b) make sure that OpacPasswordChange is also ON.
A)
1) refresh front page, click on 'Forgot your password' and enter a VALID
address
1b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
2) An email should be received at that address with a link.
3) Follow the link in the mail to fill the new password.
Until a satisfactory new password is entered, the old password is not
reset.
4) Go to main page try the new password.
B)
1) Repeat the password reset, this time use the userid (username) field.
2) Try to reset the password using a userid and an email not linked to the
account. An error appears.
3) Make sure the borrower has many available email addresses.
4) For each email, reset the password using both the userid and the email.
The link should be sent to the specified address
C)
1) Make sure two borrowers use the same email.
2) Repeat the reset procedure in test case A). An error message appears

http://bugs.koha-community.org/show_bug.cgi?id=13068

 Author:Maxime Beaulieu 

Followed test plan. Works as described.
Signed-off-by: Marc Véron 

New sign-off after testing all patches together
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #152 from Charles Farmer  ---
Created attachment 45212
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45212=edit
Bug 8753 - Use Koha::Borrowers instead of C4::Members

Use the new library to search for borrowers.
Changed how the $borrower variable is used since it is now a Koha::Borrower
object.

Removed the $protocol parameter from the generated link. It should be included
in the OPACBaseURL syspref.

modified:   C4/Passwordrecovery.pm
modified:   opac/opac-password-recovery.pl

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #155 from Charles Farmer  ---
Created attachment 45215
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45215=edit
Bug 8753 - Various little things - removing new dependency, changes to errors,
textual updates

Koha already has a sub that creates salts, so lets use that instead of
math::Random::secure, so as not to add a new dependency.

Made the references to "Forgotten password" consistent, including adding it to
the title of the page.

Also removed the individual error for "this email doesn't belong to this
account" as that could expose the existence of a login, which I think we'd
rather not do.

Made some of the text more grammatically correct, and more library specific.

To test:

Apply on top of all of the other patches.

All the usual checks, plus make sure there are no typos in any text references.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #153 from Charles Farmer  ---
Created attachment 45213
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45213=edit
Bug 8753 - [followup] POD cleanup

Check to make sure the messages from the qa checker are gone.

Note I'm not sure about this one because my test tools are apparently broken,
and I can't get the error to manifest.

Amended patch by Jonathan Druart: Add a blank line before =head2
It now passes.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #154 from Charles Farmer  ---
Created attachment 45214
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45214=edit
Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy,
Passwordrecovery.t

This is a collection of changes taken from different comments (but mostly
comment 21 and comment 122).

Passes qa and prove, on my machine at least.

There's also a new test file, Passwordrecovery.t, which covers every method of
C4::Passwordrecovery.

To test:

All normal checks plus :

1/ Receive the email
2/ Click on the link
3/ Change the pwd
4/ Click again on the link
5/ You should immediately get an error message

Problems with Math/Random/Secure.pm, is solved in following patch, signing off
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #151 from Charles Farmer  ---
Created attachment 45211
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45211=edit
Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt

I could only reproduce the forbidden pattern error from jonathan Druart's
comment#97 locally, so I fixed it.

TEST PLAN

1)Apply all patches
2)Forbidden pattern error should not be there anymore

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Charles Farmer  changed:

   What|Removed |Added

  Attachment #44324|0   |1
is obsolete||
  Attachment #44325|0   |1
is obsolete||
  Attachment #44326|0   |1
is obsolete||
  Attachment #44327|0   |1
is obsolete||
  Attachment #44329|0   |1
is obsolete||
  Attachment #44330|0   |1
is obsolete||

--- Comment #150 from Charles Farmer  ---
Created attachment 45210
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45210=edit
Bug 8753 - Followup - change value text on syspref

Followup changes text from "The user can reset | can not reset their password
on OPAC" to "Library users are allowed | not allowed to recover their password
via e-mail in the OPAC"

This change more clearly differentiates the purpose of this new preference from
OpacPasswordChange.

Bug 8753 - followup - update text for link to match common UI paradigms, fixes
OpacPublic disabled view

Also corrects OpacNav being included on the reset page on private catalogues.

Updated the link for forgotten passwords to more closely match common UI
paradigms, i.e. Facebook and Twitter

To test:
apply all patches, link should now be the less verbose "Forgot your password?"
disable OpacPublic, anything in opacnav should not appear (you may need to add
something to opacnav to test properly)

Bug 8753 - [followup] fix the title on opac-password-recovery.tt

The title stanza was missing a  around it, causing the extra
text to appear.

To test, apply all patches and make sure it looks ok and there is no extra text
at the top or bottom of the page.

Bug 8753 - [followup} Correcting spelling mistakes

Make sure it all still works

Bug 8753 - [followup] fix error when no information is provided

To test:

All normal checks plus make sure that a nice error is displayed when no data is
provided.

fixing the deprecated thing

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #156 from Charles Farmer  ---
I had to resubmit every patches because the first one had the merge conflicts.

If anybody knows how to obsolete the first patch of a queue without messing the
queue order, let me know, it would be appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #148 from Blou  ---
Will be done today.

We will never surrender...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-27 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #157 from Josef Moravec  ---
I think that files kohastructure.sql and sysprefs.sql, should be updated too,
not only to add atomicupdate sql file...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-26 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Liz Rea  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

--- Comment #146 from Liz Rea  ---
This is a must for 3.24.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-23 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

sally.hea...@cheshirewestandchester.gov.uk changed:

   What|Removed |Added

 CC||sally.healey@cheshirewestan
   ||dchester.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-18 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #44307|0   |1
is obsolete||

--- Comment #141 from Marc Véron  ---
Created attachment 44325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44325=edit
Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt

I could only reproduce the forbidden pattern error from jonathan Druart's
comment#97 locally, so I fixed it.

TEST PLAN

1)Apply all patches
2)Forbidden pattern error should not be there anymore

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #44308|0   |1
is obsolete||

--- Comment #142 from Marc Véron  ---
Created attachment 44326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44326=edit
Bug 8753 - Use Koha::Borrowers instead of C4::Members

Use the new library to search for borrowers.
Changed how the $borrower variable is used since it is now a Koha::Borrower
object.

Removed the $protocol parameter from the generated link. It should be included
in the OPACBaseURL syspref.

modified:   C4/Passwordrecovery.pm
modified:   opac/opac-password-recovery.pl

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #44305|0   |1
is obsolete||

--- Comment #139 from Marc Véron  ---
Created attachment 44323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44323=edit
Bug 8753 - Add forgot password link to OPAC

 I've addressed a lot of Liz Rea's points.

1.  I have moved the code from updatedatabase.pl and kohastructure.sql to a
file in the atomicupdates directory.
1a. The feature is now off by default when the atomicupdate is run.

2.  The password reset link is now visible on the home page, in the modal box
and on opac-user.pl .

3.  The password recovery pages now use bootstrap markup.

4.  I am unsure here. I see "New Password:" and "Confirm new password:".

5.  This should still work :).

6.  I could not reproduce.

7.  I have added the userid field.
You can now reset the password by submitting either your useid or email
address.
Both fields can be filled, but the email address must be one of the
borrower's (email, emailpro or b_email).
When entering only the email address and two borrowers use that same
address, the system tells the user to try with another address or to specify
his userid.

8.  The text is in the atomicupdate file. Have at it, anyone.

Concerning the email. It is inconvenient for the use to have to wait X minutes
for the message queue the be processed.
Maybe we could add a sub in Letters.pm that:
Takes the same argments as EnqueueLetter
Sends the letter.
Saves the letter in the message queue with a 'sent' status.

 TEST PLAN:

Setup)
1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to
ON.
2b) make sure that OpacPasswordChange is also ON.
A)
1) refresh front page, click on 'Forgot your password' and enter a VALID
address
1b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
2) An email should be received at that address with a link.
3) Follow the link in the mail to fill the new password.
Until a satisfactory new password is entered, the old password is not
reset.
4) Go to main page try the new password.
B)
1) Repeat the password reset, this time use the userid (username) field.
2) Try to reset the password using a userid and an email not linked to the
account. An error appears.
3) Make sure the borrower has many available email addresses.
4) For each email, reset the password using both the userid and the email.
The link should be sent to the specified address
C)
1) Make sure two borrowers use the same email.
2) Repeat the reset procedure in test case A). An error message appears

http://bugs.koha-community.org/show_bug.cgi?id=13068

 Author:Maxime Beaulieu 

Followed test plan. Works as described.
Signed-off-by: Marc Véron 

New sign-off after testing all patches together
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #44311|0   |1
is obsolete||

--- Comment #145 from Marc Véron  ---
Created attachment 44330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44330=edit
Bug 8753 - Various little things - removing new dependency, changes to errors,
textual updates

Koha already has a sub that creates salts, so lets use that instead of
math::Random::secure, so as not to add a new dependency.

Made the references to "Forgotten password" consistent, including adding it to
the title of the page.

Also removed the individual error for "this email doesn't belong to this
account" as that could expose the existence of a login, which I think we'd
rather not do.

Made some of the text more grammatically correct, and more library specific.

To test:

Apply on top of all of the other patches.

All the usual checks, plus make sure there are no typos in any text references.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #44310|0   |1
is obsolete||

--- Comment #144 from Marc Véron  ---
Created attachment 44329
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44329=edit
Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy,
Passwordrecovery.t

This is a collection of changes taken from different comments (but mostly
comment 21 and comment 122).

Passes qa and prove, on my machine at least.

There's also a new test file, Passwordrecovery.t, which covers every method of
C4::Passwordrecovery.

To test:

All normal checks plus :

1/ Receive the email
2/ Click on the link
3/ Change the pwd
4/ Click again on the link
5/ You should immediately get an error message

Problems with Math/Random/Secure.pm, is solved in following patch, signing off
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #44309|0   |1
is obsolete||

--- Comment #143 from Marc Véron  ---
Created attachment 44327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44327=edit
Bug 8753 - [followup] POD cleanup

Check to make sure the messages from the qa checker are gone.

Note I'm not sure about this one because my test tools are apparently broken,
and I can't get the error to manifest.

Amended patch by Jonathan Druart: Add a blank line before =head2
It now passes.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #44306|0   |1
is obsolete||

--- Comment #140 from Marc Véron  ---
Created attachment 44324
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44324=edit
Bug 8753 - Followup - change value text on syspref

Followup changes text from "The user can reset | can not reset their password
on OPAC" to "Library users are allowed | not allowed to recover their password
via e-mail in the OPAC"

This change more clearly differentiates the purpose of this new preference from
OpacPasswordChange.

Bug 8753 - followup - update text for link to match common UI paradigms, fixes
OpacPublic disabled view

Also corrects OpacNav being included on the reset page on private catalogues.

Updated the link for forgotten passwords to more closely match common UI
paradigms, i.e. Facebook and Twitter

To test:
apply all patches, link should now be the less verbose "Forgot your password?"
disable OpacPublic, anything in opacnav should not appear (you may need to add
something to opacnav to test properly)

Bug 8753 - [followup] fix the title on opac-password-recovery.tt

The title stanza was missing a  around it, causing the extra
text to appear.

To test, apply all patches and make sure it looks ok and there is no extra text
at the top or bottom of the page.

Bug 8753 - [followup} Correcting spelling mistakes

Make sure it all still works

Bug 8753 - [followup] fix error when no information is provided

To test:

All normal checks plus make sure that a nice error is displayed when no data is
provided.

fixing the deprecated thing

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

  Attachment #41192|0   |1
is obsolete||

--- Comment #138 from Marc Véron  ---
Comment on attachment 41192
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41192
Stray text appears above header

This is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Liz Rea  changed:

   What|Removed |Added

  Attachment #39166|0   |1
is obsolete||
  Attachment #39168|0   |1
is obsolete||
  Attachment #39827|0   |1
is obsolete||
  Attachment #41181|0   |1
is obsolete||
  Attachment #41193|0   |1
is obsolete||
  Attachment #41686|0   |1
is obsolete||
  Attachment #41687|0   |1
is obsolete||
  Attachment #41706|0   |1
is obsolete||
  Attachment #43017|0   |1
is obsolete||
  Attachment #43183|0   |1
is obsolete||
  Attachment #43576|0   |1
is obsolete||

--- Comment #130 from Liz Rea  ---
Created attachment 44305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44305=edit
Bug 8753 - Add forgot password link to OPAC

I've addressed a lot of Liz Rea's points.

1.  I have moved the code from updatedatabase.pl and kohastructure.sql to a
file in the atomicupdates directory.
1a. The feature is now off by default when the atomicupdate is run.

2.  The password reset link is now visible on the home page, in the modal box
and on opac-user.pl .

3.  The password recovery pages now use bootstrap markup.

4.  I am unsure here. I see "New Password:" and "Confirm new password:".

5.  This should still work :).

6.  I could not reproduce.

7.  I have added the userid field.
You can now reset the password by submitting either your useid or email
address.
Both fields can be filled, but the email address must be one of the
borrower's (email, emailpro or b_email).
When entering only the email address and two borrowers use that same
address, the system tells the user to try with another address or to specify
his userid.

8.  The text is in the atomicupdate file. Have at it, anyone.

Concerning the email. It is inconvenient for the use to have to wait X minutes
for the message queue the be processed.
Maybe we could add a sub in Letters.pm that:
Takes the same argments as EnqueueLetter
Sends the letter.
Saves the letter in the message queue with a 'sent' status.

 TEST PLAN:

Setup)
1) apply the patch
2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to
ON.
2b) make sure that OpacPasswordChange is also ON.
A)
1) refresh front page, click on 'Forgot your password' and enter a VALID
address
1b) Also try an INVALID address (valid yet not in your koha db).  An error
message will show up.
2) An email should be received at that address with a link.
3) Follow the link in the mail to fill the new password.
Until a satisfactory new password is entered, the old password is not
reset.
4) Go to main page try the new password.
B)
1) Repeat the password reset, this time use the userid (username) field.
2) Try to reset the password using a userid and an email not linked to the
account. An error appears.
3) Make sure the borrower has many available email addresses.
4) For each email, reset the password using both the userid and the email.
The link should be sent to the specified address
C)
1) Make sure two borrowers use the same email.
2) Repeat the reset procedure in test case A). An error message appears

http://bugs.koha-community.org/show_bug.cgi?id=13068

 Author:Maxime Beaulieu 

Followed test plan. Works as described.
Signed-off-by: Marc Véron 


 Current status: Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-02 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #133 from Liz Rea  ---
Created attachment 44308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44308=edit
Bug 8753 - Use Koha::Borrowers instead of C4::Members

Use the new library to search for borrowers.
Changed how the $borrower variable is used since it is now a Koha::Borrower
object.

Removed the $protocol parameter from the generated link. It should be included
in the OPACBaseURL syspref.

modified:   C4/Passwordrecovery.pm
modified:   opac/opac-password-recovery.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 >

1 - 100 of 274 matches

Mail list logo