[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Julian Maurice changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED --- Comment #15 from Julian Maurice --- Ok in 3.8.x, 3.10.x and master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.8.x and 3.10.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Elliott Davis changed: What|Removed |Added Status|Signed Off |Passed QA CC||elli...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Elliott Davis changed: What|Removed |Added Attachment #14290|0 |1 is obsolete|| --- Comment #12 from Elliott Davis --- Created attachment 14574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14574&action=edit [Passed QA] Bug 9126: Do not return from Check too early. If there is no errors, it should continue instead of returning true. + move a block of code at the end of Check function. This avoid detaching and re-attaching a HTML block if there are errors. Signed-off-by: Jonathan Druart The following queries show us the issues: select count(*) from items; select * from aqorders_items where ordernumber=XX; Signed-off-by: Katrin Fischer To test: AcqCreateItem = receive UniqueItemFields = barcode 1) Create a new basket 2) Create a new order with quantity > 1 3) Close the basket and create a new invoice/shipment 4) Receive only 1 item. - Fill out the first item form with item type only. Click add. - Don't change second item form at all. - Click save. Before patch: 2 items are created on the record, both with the selected itemtype. After patch: Only 1 item is created, which is correct. Signed-off-by: Elliott Davis Seems to work as described by the test plan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Katrin Fischer changed: What|Removed |Added Attachment #13764|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 14290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14290&action=edit [SIGNED-OFF] Bug 9126: Do not return from Check too early. If there is no errors, it should continue instead of returning true. + move a block of code at the end of Check function. This avoid detaching and re-attaching a HTML block if there are errors. Signed-off-by: Jonathan Druart The following queries show us the issues: select count(*) from items; select * from aqorders_items where ordernumber=XX; Signed-off-by: Katrin Fischer To test: AcqCreateItem = receive UniqueItemFields = barcode 1) Create a new basket 2) Create a new order with quantity > 1 3) Close the basket and create a new invoice/shipment 4) Receive only 1 item. - Fill out the first item form with item type only. Click add. - Don't change second item form at all. - Click save. Before patch: 2 items are created on the record, both with the selected itemtype. After patch: Only 1 item is created, which is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #10 from Julian Maurice --- Hello Kyle, I think the additional item is not created because of "unique key" on items.barcode. You may see in log file something like this: DBD::mysql::st execute failed: Duplicate entry '013' for key 'itembarcodeidx at /home/julian/koha/src/C4/Items.pm line 2105 DBD::mysql::st execute failed: Column 'itemnumber' cannot be null at /home/julian/koha/src/C4/Acquisition.pm line 1094. Try the following steps: - create order with quantity=2 and go to receipt page - fill the item form for the first item with a unique barcode and click 'add' - in the new item form change barcode so it is unique too but do not click on 'add' - click 'Save' - you should have 2 items created but parcel.pl indicates only 1 item received. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- I'm unable to reproduce this bug on master. Perhaps a video of the bug in action would be helpful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #8 from Katrin Fischer --- Hi Julian, I think that was the crucial bit of information - I had started testing with a partial receive and that was probably the one time I could reproduce the problem. If someone else could sign this off... I could QA it later... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #7 from Julian Maurice --- Hi Katrin, there's a thing I forgot to mention: it must be a partial receipt, so you can test by creating an order with quantity=2, and receive only one item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #6 from Katrin Fischer --- Hi Julian and Jonathan, I tested on master and on 3.8 - I can't reproduce it apart from that one time I thought it happened. What am I missing? AcqCreateItem = receive UniqueItemFields = barcode - I create a new basket, ordered quantity = 1 - I close the basket and start a new chipment - I receive the items, I tried - only filling out the barcode - only filling out the itemtype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #5 from Katrin Fischer --- I had managed to create 2 items during one of my first tests, but have not been able to reproduce it since. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Katrin Fischer changed: What|Removed |Added Version|3.8 |master --- Comment #4 from Katrin Fischer --- I can reproduce this on master - changing version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Jonathan Druart changed: What|Removed |Added Attachment #13601|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 13764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13764&action=edit Bug 9126: Do not return from Check too early. If there is no errors, it should continue instead of returning true. + move a block of code at the end of Check function. This avoid detaching and re-attaching a HTML block if there are errors. Signed-off-by: Jonathan Druart The following queries show us the issues: select count(*) from items; select * from aqorders_items where ordernumber=XX; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #2 from Katrin Fischer --- Hi all, this is a critical bug in 3.10 - it would be awesome if someone could test and sign-off on this soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Julian Maurice changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 --- Comment #1 from Julian Maurice --- Created attachment 13601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13601&action=edit Bug 9126: Do not return from Check too early. If there is no errors, it should continue instead of returning true. + move a block of code at the end of Check function. This avoid detaching and re-attaching a HTML block if there are errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9126] Receiving orders create too much items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9126 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
