[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.10.x and 3.8.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 --- Comment #6 from Marc Véron ve...@veron.ch --- I agree with Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: With the agreement of Paul, I pass qa on this patch. Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #13857|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 14418 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14418action=edit Bug 9141 - Untranslatable strings on pay an amount... page Moving text of an error message from the script into the template. To test, submit an amount which is greater than the amount due. You should see an error message displayed correctly with a properly-formatted currency amount. Signed-off-by: Marc Veron ve...@veron.ch Patch behaves as expected. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 --- Comment #4 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #3) Your opinion ? ping... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 --- Comment #5 from Owen Leonard oleon...@myacpl.org --- (In reply to comment #3) Your opinion ? Your version is simpler, but I think what we lose is the readability of the template. Seeing that an error message is displayed if total_due 0 doesn't mean anything unless you examine the script and see under what condition the variable is being set. The more verbose version makes it clear that the script sets an error variable. I don't think it's a big deal, but I prefer my version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
QA Contact||paul.poul...@biblibre.com
--- Comment #3 from Paul Poulain paul.poul...@biblibre.com ---
QA comment: tiny patch, but I think it could be even simpler. Instead of using
a error_over = 1, why not use total_due =
-[% IF ( error ) %]
+[% IF (total_due 0 ) %]
should achieve the same result, isn't it ?
In this case the patch would just be:
-[% IF ( error ) %]
+[% IF (total_due 0 ) %]
-[% error %]
+You must pay a value less than or equal to [% total_due | format('%.2f')
%].
-error = sprintf( 'You must pay a value less than or equal to
%f.2',
-$total_due )
+total_due = $total_due
Your opinion ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #13665|0 |1 is obsolete|| --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 13857 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13857action=edit [SIGNED-OFF] Bug 9141 - Untranslatable strings on pay an amount... page Moving text of an error message from the script into the template. To test, submit an amount which is greater than the amount due. You should see an error message displayed correctly with a properly-formatted currency amount. Signed-off-by: Marc Veron ve...@veron.ch Patch behaves as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 13665 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13665action=edit [PATCH] Bug 9141 - Untranslatable strings on pay an amount... page Moving text of an error message from the script into the template. To test, submit an amount which is greater than the amount due. You should see an error message displayed correctly with a properly-formatted currency amount. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9141] Untranslatable strings on pay an amount... page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9141 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
