[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #28 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #27 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #26 from Jonathan Druart --- Created attachment 97192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97192=edit Bug 9156: Clarify order in the syspref Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #25 from Jonathan Druart --- Created attachment 97191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97191=edit Bug 9156: (follow-up) Simpliy code The MARC::Field as_string method can join multiple subfield using a delimiter, this simplifies the code here Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Jonathan Druart changed: What|Removed |Added Attachment #96486|0 |1 is obsolete|| Attachment #96766|0 |1 is obsolete|| Attachment #96792|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 97190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97190=edit Bug 9156: itemcallnumber not pulling more than 2 subfields When the itemcallnumber system preference is defined, the item add form pulls data from the specified tag and subfield(s) to pre-populate the call number field. This update makes it possible to build the prepopulated callnumber from more than just the first two subfields. To test, apply the patch and update the itemcallnumber system preference so that it includes more than two subfields. For instance, "092abef" - Edit a bibliographic record and populate the specified subfields. e.g. subfield a -> "One", b-> "Two", e-> "Three", f-> "Four". - Save the record and go to the add/edit items screen. - The call number field should contain a string which contains each of the subfields you populated, concatenated with spaces: "One Two Three Four." - Test with other numbers of subfields. - Test with an empty itemcallnumber preference. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #23 from Katrin Fischer --- (In reply to Nick Clemens from comment #22) > We can't both preserve record order and obey syspref order. > > Talking it over with Andrew and the educators we agreed the record order > should be preserved Order in the recod with a clear note on the pref like done here makes sense to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #22 from Nick Clemens --- We can't both preserve record order and obey syspref order. Talking it over with Andrew and the educators we agreed the record order should be preserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #21 from Jonathan Druart --- (In reply to Nick Clemens from comment #13) > (In reply to Andrew Fuerste-Henry from comment #11) > > After Nick's change, this is misbehaving slightly, not getting the right > > order in the item record. > > > > My syspref says: 082abmqA > > > > My bib says: > > 082 $a a > > $b b > > $m m > > $q q > > $A A > > > > The item call number generates as: a A b m q > > I cannot recreate this - the code for MARC::Field->as_string should preserve > the order in the record. Can you share your sample record? It preserves the order in the record, but not the one from the syspref. From the test plan, if I edit the pref and set 082$efab it does not change anything. Should not we follow the order of the syspref? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens changed: What|Removed |Added Attachment #96767|0 |1 is obsolete|| --- Comment #20 from Nick Clemens --- Created attachment 96792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96792=edit Bug 9156: Clarify order in the syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #19 from Katrin Fischer --- Comment on attachment 96767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96767 Bug 9156: Clarify order in the syspref Review of attachment 96767: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=9156=96767) - ::: C4/Reserves.pm @@ +1195,5 @@ > # FIXME - a lot of places in the code do this > # or something similar - need to be > # consolidated > +my $itemtype = Koha::ItemTypes->find( $item->effective_itemtype ); > +my $notforloan_per_itemtype = defined $itemtype ? $itemtype->notforloan > : 0; I think this got in by accident - can you please resubmit the patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 ByWater Sandboxes changed: What|Removed |Added Attachment #96764|0 |1 is obsolete|| --- Comment #17 from ByWater Sandboxes --- Created attachment 96767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96767=edit Bug 9156: Clarify order in the syspref Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #18 from Andrew Fuerste-Henry --- signing off again based on clarification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 ByWater Sandboxes changed: What|Removed |Added Attachment #96499|0 |1 is obsolete|| --- Comment #16 from ByWater Sandboxes --- Created attachment 96766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96766=edit Bug 9156: (follow-up) Simpliy code The MARC::Field as_string method can join multiple subfield using a delimiter, this simplifies the code here Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #15 from Nick Clemens --- (In reply to Katrin Fischer from comment #12) > Failing QA because of Andrew's comment. Spoke with Andrew, we agreed order in record should preserved, attached a follow-up to be explicit about this in the pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #14 from Nick Clemens --- Created attachment 96764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96764=edit Bug 9156: Clarify order in the syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #13 from Nick Clemens --- (In reply to Andrew Fuerste-Henry from comment #11) > After Nick's change, this is misbehaving slightly, not getting the right > order in the item record. > > My syspref says: 082abmqA > > My bib says: > 082 $a a > $b b > $m m > $q q > $A A > > The item call number generates as: a A b m q I cannot recreate this - the code for MARC::Field->as_string should preserve the order in the record. Can you share your sample record? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Katrin Fischer changed: What|Removed |Added Summary|itemcallnumber not pulling |System preference |more than 2 subfields |itemcallnumber not pulling ||more than 2 subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
