[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38122|0 |1 is obsolete|| --- Comment #28 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38515 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38515action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS NOTE: Re-worked by Mark Tompsett, that's why I removed sign-offs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38123|0 |1 is obsolete|| --- Comment #26 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38513 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38513action=edit Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. NOTE: Mark Tompsett removed sign off, since he completely reworked it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38124|0 |1 is obsolete|| --- Comment #27 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38514 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38514action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the default value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38513|0 |1 is obsolete|| --- Comment #29 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38516 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38516action=edit Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. NOTE: Mark Tompsett removed sign off, since he completely reworked it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38514|0 |1 is obsolete|| --- Comment #30 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38517 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38517action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the default value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #31 from M. Tompsett mtomp...@hotmail.com --- Leaving in discussion as per comments #17, #18, and #19. Which I raised in comment #24. Even though Marc V. suggested that 'In Discussion' was not required in his opinion in comment #25. These other attachments in between were because he pointed out a typo I believe I may have made in rescuing the patch. Apply the latest and follow any test plans given in comments #28, #29, and #30. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254
Marc Véron ve...@veron.ch changed:
What|Removed |Added
CC||ve...@veron.ch
--- Comment #25 from Marc Véron ve...@veron.ch ---
There is a typo in koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc line
81
Koha.Preferences('EnhancedMessagingPreferencesOPAC')
should be:
Koha.Preference('EnhancedMessagingPreferencesOPAC')
(Preferences - Preference)
I tested after locally fixing the issue. IMO status 'In Discussion' could be
removed.
Regarding comment #19: '...display as it currently is might be a bit confusing
to patrons...':
Maybe there could be some explanation like in the tab 'your privacy'.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #20332|0 |1 is obsolete|| --- Comment #23 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38124 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38124action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the default value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #15765|0 |1 is obsolete|| --- Comment #22 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38123 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38123action=edit Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. NOTE: Mark Tompsett removed sign off, since he completely reworked it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Patch doesn't apply |In Discussion --- Comment #24 from M. Tompsett mtomp...@hotmail.com --- I set this to 'In Discussion', because it looked like Katrin Fischer and Jonathan Druart were discussing some raised issues in comment #17, comment #18, and comment #19. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #15764|0 |1 is obsolete|| --- Comment #21 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38122 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38122action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS NOTE: Re-worked by Mark Tompsett, that's why I removed sign-offs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Koha Team AMU koha.aixmarsei...@gmail.com changed: What|Removed |Added CC||koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #20 from Koha Team AMU koha.aixmarsei...@gmail.com --- We wanted to test this patch but it doesn't apply on a sandbox : Applying: Bug 9254: Problem with EnhancedMessagingPreferences\nUsing index info to reconstruct a base tree...\nFalling back to patching base and 3-way merge...\nAuto-merging C4/Auth.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl\nFailed to merge in the changes.\nPatch failed at 0001 Bug 9254: Problem with EnhancedMessagingPreferences\nWhen you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort.\nBug 9254 - Problem with EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am not sure if there is a legal requirement here, but if there is it might also differ from country to country. We already have some prefs/privacy critical features, that you can opt in to use or not. I think as long as this is a switch, every library can decide what to do. Resetting to 'Needs Signoff' - Jonathan, please set back to 'In Discussion' if you disagree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- I think the patron should, at least, be allow see the screen with read only rights. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, the display as it currently is might be a bit confusing to patrons. Maybe we also need to think about how to pretty it up a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- A customer asked me the same request then I developed a patch and completely forgot this one. So I will provide a followup with what I needed some months ago :) But after a little reflexion, I don't know if it is relevant. I think it is not pleasant not to let the choice to the user. Are you sure it is legal not to let the user deactivate notifications? Switch to in discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20332 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20332action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think if we got the page access fixed, this would be very close to go in from reading the comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m --- Comment #13 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- As described in Koha Manual, 1.12.12. EnhancedMessagingPreferences Default: Allow Asks: ___ patrons to choose which notices they receive and when they receive them. Values: Allow Don't allow Important This only applies to certain kinds of notices, overdue notices will be sent based on the library's rules, not the patron's choice. So this syspref is defined to allow patrons to choose the notifications they want to receive. What Victor describes as a problem is not one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- There is a typo in the first patch: 6380 A -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #15010|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15764 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15764action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Rebased on master (2013-02-01) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #15011|0 |1 is obsolete|| --- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15765 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15765action=edit Bug 9254 - Problem with EnhancedMessagingPreferences - Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #11 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to comment #8) There is a typo in the first patch: 6380 A Ouch! My mistake. Fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: (In reply to comment #10) Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. For me this behevior is blocker. If you introduce a restriction for a page, you have to display an error message if the user try to access directly to this page. The issue existed before your patch but it is the good time to do it (a simple test in the pl file and 3 lines in the template file should fix the issue). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #14244|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15010 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15010action=edit [SIGNED-OFF] Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Rebased on master (2013-02-01) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #14246|0 |1 is obsolete|| --- Comment #7 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 15011 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15011action=edit [SIGNED-OFF] Bug 9254 - Problem with EnhancedMessagingPreferences - Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Last patch needs a signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14199|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14244 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14244action=edit [SIGNED-OFF] Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14246 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14246action=edit Bug 9254 - Problem with EnhancedMessagingPreferences - Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |vfernan...@keep.pt |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #2 from Vitor Fernandes vfernan...@keep.pt --- Created attachment 14199 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14199action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #1 from Nicole C. Engard neng...@gmail.com --- I agree, it would be nice is there was a way for this preference to be split in to two. One for the staff and one for the OPAC - I'd add that it would be nice if this preference were a list of messages you could offer. So if you wanted to only allow holds and advanced notices to be options you could put 'hold|advanced|' or something like that in the preference. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Vitor Fernandes vfernan...@keep.pt changed: What|Removed |Added Priority|P5 - low|P2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
