[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|20.05.00,19.11.06 |20.05.00,19.11.06, 19.05.11 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00,19.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #11 from Joy Nelson --- Backported to 19.11.x branch for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- This one has languished long enough, I think it's a reasonable patch and trivial code.. upgrading my earlier signoff to a PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Katrin Fischer --- I'd like to throw the rebased patch out there - I didn't find an example for a page with a message in staff. Stock rotation for example behaves the same as this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Katrin Fischer changed: What|Removed |Added Attachment #85021|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 102039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102039=edit Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off In addition to checking the patron image upload permission, this adds a check for the patronimages system preference to the tools home page and sidebar. To test: - Check that the patron image upload tool only displays when - system preference patronimages is set to 'Allow' and user is either - superlibrarian or - has bath_upload_patron_images permission - Save URL of patron image uploader page - Turn off patronimages - Verify you get redirected to the home page of Koha when trying to access the page Note: this redirect is already used by the stock rotation feature. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Bug 9422 depends on bug 8387, which changed state. Bug 8387 Summary: Hide headings in tools when user has no permissions for any listed below https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 --- Comment #5 from Katrin Fischer --- I was looking for an example for that. I will have another look. Maybe just push a variable to the template and wrap it all in if-else? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Katrin Fischer changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #6 from Katrin Fischer --- ... or just use the TT plugin. I will try it out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #4 from Josef Moravec --- Wouldn't be better to display warning on top of patron image upload page? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Seems sound, works for me. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Martin Renvoize changed: What|Removed |Added Attachment #84946|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 85021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85021=edit Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off In addition to checking the patron image upload permission, this adds a check for the patronimages system preference to the tools home page and sidebar. To test: - Check that the patron image upload tool only displays when - system preference patronimages is set to 'Allow' and user is either - superlibrarian or - has bath_upload_patron_images permission - Save URL of patron image uploader page - Turn off patronimages - Verify you get redirected to the home page of Koha when trying to access the page Note: this redirect is already used by the stock rotation feature. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 --- Comment #1 from Katrin Fischer --- Created attachment 84946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84946=edit Bug 9422: Don't allow access to 'Upload patron images' when patronimages syspref is off In addition to checking the patron image upload permission, this adds a check for the patronimages system preference to the tools home page and sidebar. To test: - Check that the patron image upload tool only displays when - system preference patronimages is set to 'Allow' and user is either - superlibrarian or - has bath_upload_patron_images permission - Save URL of patron image uploader page - Turn off patronimages - Verify you get redirected to the home page of Koha when trying to access the page Note: this redirect is already used by the stock rotation feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Katrin Fischer changed: What|Removed |Added Depends on||8387 Assignee|indr...@l2c2.co.in |katrin.fisc...@bsz-bw.de CC||katrin.fisc...@bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 [Bug 8387] Hide headings in tools when user has no permissions for any listed below -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9422] Patron picture uploader ignores patronimages syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |indr...@gmail.com CC||indr...@gmail.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
