[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- This patch has been pushed to 3.8.x, and will be in 3.08.20. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 --- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz --- Tomas, Ive checked this is ok on 3.12.x too. So if you want to push it to that, it should be fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #12 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #18267|0 |1 is obsolete|| --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18323 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18323action=edit Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml Add a delimeter option to SIPConfig.xml, choices for 'delimeter' are 'CR' or 'CRLF'. The default continues to be 'CRLF' if 'delimeter' is undefined. Test Plan: 1) Apply patch 2) Start SIP server 3) Run C4/SIP/t/04patron_status.t 4) Stop SIP server 5) Add terminator=CR for account login 'term1' 6) Run 04patron_status.t again, you should see no change Signed-off-by: Frédéric Demians f.demi...@tamil.fr Signed-off-by: Adrien Saurat adrien.sau...@biblibre.com Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #18193|0 |1 is obsolete|| --- Comment #10 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 18267 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18267action=edit Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml Signed off. With my own SIP testing scripts, I get good results (ie. no change) with CRLF. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15204|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18193 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18193action=edit Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml Add a delimeter option to SIPConfig.xml, choices for 'delimeter' are 'CR' or 'CRLF'. The default continues to be 'CRLF' if 'delimeter' is undefined. Test Plan: 1) Apply patch 2) Start SIP server 3) Run C4/SIP/t/04patron_status.t 4) Stop SIP server 5) Add terminator=CR for account login 'term1' 6) Run 04patron_status.t again, you should see no change Signed-off-by: Frédéric Demians f.demi...@tamil.fr Make sense. With this patch, starting 2 SIP2 servers, it is possible to serve heterogeneous Self check devices. Shouldn't we need some doc somewhere about this parameter? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, could you perhaps provide a little follow up for the tabulation characters? * C4/SIP/Sip/MsgType.pm FAIL pod OK forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (869) The patch introduces a forbidden pattern: tabulation character (793) The patch introduces a forbidden pattern: tabulation character (781) valid OK critic OK Apart from this all tests and the QA script pass. SIP is hard to test and I am still not familiar with it. Therefore I would like to call for a second sign off on this and then it can pass QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- I was under the assumption that the line I altered was an example. I can post a followup to change that if you wish. (In reply to comment #6) Tested OK. No big deal but I'm wondering: if the default mode is still CRLF when the parameter is not set, shouldn't we set the default line in SIPconfig.xml to CRLF instead of CR? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added CC||adrien.sau...@biblibre.com --- Comment #6 from Adrien SAURAT adrien.sau...@biblibre.com --- Tested OK. No big deal but I'm wondering: if the default mode is still CRLF when the parameter is not set, shouldn't we set the default line in SIPconfig.xml to CRLF instead of CR? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Blocks||9865 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Frédéric, since the behavior is controlled at the accounts level, 1 SIP server instance can handle both styles! Yes, I think I will alert Nicole to add this to the manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 --- Comment #5 from Frédéric Demians frede...@tamil.fr --- (En réponse au commentaire 4) Frédéric, since the behavior is controlled at the accounts level, 1 SIP server instance can handle both styles! Yes, I think I will alert Nicole to add this to the manual. Yes, even better. Whatever am I thinking of? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #15014|0 |1 is obsolete|| --- Comment #3 from Frédéric Demians frede...@tamil.fr --- Created attachment 15204 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15204action=edit Signed-off patch Make sense. With this patch, starting 2 SIP2 servers, it is possible to serve heterogeneous Self check devices. Shouldn't we need some doc somewhere about this parameter? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|enhancement |normal --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- I'm upgrading this to a bug, as the existing behavior causes incompatibility with many SIP devices and services ( such as Overdrive ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7619 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15014action=edit Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml Add a delimeter option to SIPConfig.xml, choices for 'delimeter' are 'CR' or 'CRLF'. The default continues to be 'CRLF' if 'delimeter' is undefined. Test Plan: 1) Apply patch 2) Start SIP server 3) Run C4/SIP/t/04patron_status.t 4) Stop SIP server 5) Add terminator=CR for account login 'term1' 6) Run 04patron_status.t again, you should see no change -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
