subject:"\[Koha\-bugs\] \[Bug 9573\] Ability to download items lost report"

[Koha-bugs] [Bug 9573] Ability to download items lost report

2019-03-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||22601


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22601
[Bug 22601] Table filters link cant be translated
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||18433


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433
[Bug 18433] Allow to select results to export in item search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-07-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-06-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||20774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20774
[Bug 20774] Trivial HTML error in itemslost.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-05-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Josef Moravec  changed:

   What|Removed |Added

 Blocks|20806   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806
[Bug 20806] Column settings issues for holdshistory-table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-05-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Josef Moravec  changed:

   What|Removed |Added

 Blocks||20831


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20831
[Bug 20831] (Bug 9573 follow-up) Pass id as first parameter instead of selector
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-05-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Josef Moravec  changed:

   What|Removed |Added

 Blocks||20806


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806
[Bug 20806] Column settings issues for holdshistory-table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-05-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20807

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #67 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|19467   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19467
[Bug 19467] Display location and itemtype description on lost items report
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573
Bug 9573 depends on bug 20236, which changed state.

Bug 20236 Summary: Show descriptions instead of codes for locations and item 
types on item lost report result list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20236

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #66 from Katrin Fischer  ---
I realized (while testing) that I did the original sign-off here. But as we
have a second sign-off I hope the RM will be happy to have me QA as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71880|0   |1
is obsolete||

--- Comment #64 from Katrin Fischer  ---
Created attachment 71894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71894=edit
Bug 9573: Add missing KOHA_VERSION in js paths

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71875|0   |1
is obsolete||

--- Comment #59 from Katrin Fischer  ---
Created attachment 71889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71889=edit
Bug 9573: Lost items report - Add a new itemlost_on column

This patch adds a new "Lost on" column to the result table

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71874|0   |1
is obsolete||

--- Comment #58 from Katrin Fischer  ---
Created attachment 71888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71888=edit
Bug 9573: Lost items report - add KohaTable to itemlost

Before this patch set, we used KohaTable to display a table with the
column visibility plugin, and an usual dataTable initialisation for the
filters.
For the lost items report table we will need both.
To do so we need to reorganize the code a bit

We cannot pass a selector but the id of the node which represents the
table. Indeed it is how works currently the filters (we may want to
improve that later)

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71873|0   |1
is obsolete||

--- Comment #57 from Katrin Fischer  ---
Created attachment 71887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71887=edit
Bug 9573: Lost items report - Move filters code to a separate js file

For the next patches we will need to reuse what is already done on the
bibliographic record detail page. This patch moves the code to make it
reusable easily and avoid copy and paste.

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71878|0   |1
is obsolete||

--- Comment #62 from Katrin Fischer  ---
Created attachment 71892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71892=edit
Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #65 from Katrin Fischer  ---
Created attachment 71895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71895=edit
Bug 9573: (QA follow-up) Add missing include back

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71879|0   |1
is obsolete||

--- Comment #63 from Katrin Fischer  ---
Created attachment 71893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71893=edit
Bug 9573: Add missing use statement

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71876|0   |1
is obsolete||

--- Comment #60 from Katrin Fischer  ---
Created attachment 71890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71890=edit
Bug 9573: Lost items report - Add a new "Export selected items" link

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71877|0   |1
is obsolete||

--- Comment #61 from Katrin Fischer  ---
Created attachment 71891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71891=edit
Bug 9573: Lost items report - Add the CSV export ability

Finally we add the ability to export the list of lost items.
The items will be export in CSV format using a CSV profile defined.

Test plan:
0/ Apply all the patches from this patch set
1/ Define a CSV profile (type=SQL, Usage=Export lost items in report)
Try something like that to get the same columns as the default table:
Title=biblio.title
|Author=biblio.author
|Lost status=items.itemlost
|Lost on=items.itemlost_on
|Barcode=items.barcode
|Call number=items.itemcallnumber
|Date last seen=items.datelastseen
|Price=items.price
|Rep. price=items.replacementprice
|Library=items.homebranch
|item type=items.itype
|Current location=items.holdingbranch
|Location=items.location
|Not for loan status=items.notforloan
|Notes=items.itemnotes
2/ Use the filters and select items to export
3/ Export the list of items you want and make sure the CSV is correctly
formatted and contains the items you selected

QA Notes:
- I think we should add default CSV profiles for the different "usage",
but I would consider it as a separate enhancement since none of them is
defined yet
- Most of the code to export CSV is no reusable. We should make
Koha::Exporter::Record support CSV export for type=SQL (it only
supports MARC type so far).

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||20236


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20236
[Bug 20236] Show descriptions instead of codes for locations and item types on
item lost report result list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #56 from Katrin Fischer  ---
Much better, but one error remains:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   FAIL   valid_template
options_for_libraries: not found

Maybe accidental removal of the include line? Will continue testing later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #55 from Katrin Fischer  ---
Argh, you are right... I had installed those and forgot to clean up. Will
retest.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #54 from Jonathan Druart  
---
Katrin,
You should double check your branch, you get errors on gb-GB files, they are
not supposed to be committed (and so checked by the tests).
I have rebased and added a patch to add the KOHA_VERSION part.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #50 from Jonathan Druart  
---
Created attachment 71877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71877=edit
Bug 9573: Lost items report - Add the CSV export ability

Finally we add the ability to export the list of lost items.
The items will be export in CSV format using a CSV profile defined.

Test plan:
0/ Apply all the patches from this patch set
1/ Define a CSV profile (type=SQL, Usage=Export lost items in report)
Try something like that to get the same columns as the default table:
Title=biblio.title
|Author=biblio.author
|Lost status=items.itemlost
|Lost on=items.itemlost_on
|Barcode=items.barcode
|Call number=items.itemcallnumber
|Date last seen=items.datelastseen
|Price=items.price
|Rep. price=items.replacementprice
|Library=items.homebranch
|item type=items.itype
|Current location=items.holdingbranch
|Location=items.location
|Not for loan status=items.notforloan
|Notes=items.itemnotes
2/ Use the filters and select items to export
3/ Export the list of items you want and make sure the CSV is correctly
formatted and contains the items you selected

QA Notes:
- I think we should add default CSV profiles for the different "usage",
but I would consider it as a separate enhancement since none of them is
defined yet
- Most of the code to export CSV is no reusable. We should make
Koha::Exporter::Record support CSV export for type=SQL (it only
supports MARC type so far).

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #51 from Jonathan Druart  
---
Created attachment 71878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71878=edit
Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #48 from Jonathan Druart  
---
Created attachment 71875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71875=edit
Bug 9573: Lost items report - Add a new itemlost_on column

This patch adds a new "Lost on" column to the result table

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #53 from Jonathan Druart  
---
Created attachment 71880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71880=edit
Bug 9573: Add missing KOHA_VERSION in js paths

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #52 from Jonathan Druart  
---
Created attachment 71879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71879=edit
Bug 9573: Add missing use statement

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #49 from Jonathan Druart  
---
Created attachment 71876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71876=edit
Bug 9573: Lost items report - Add a new "Export selected items" link

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #47 from Jonathan Druart  
---
Created attachment 71874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71874=edit
Bug 9573: Lost items report - add KohaTable to itemlost

Before this patch set, we used KohaTable to display a table with the
column visibility plugin, and an usual dataTable initialisation for the
filters.
For the lost items report table we will need both.
To do so we need to reorganize the code a bit

We cannot pass a selector but the id of the node which represents the
table. Indeed it is how works currently the filters (we may want to
improve that later)

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #46 from Jonathan Druart  
---
Created attachment 71873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71873=edit
Bug 9573: Lost items report - Move filters code to a separate js file

For the next patches we will need to reuse what is already done on the
bibliographic record detail page. This patch moves the code to make it
reusable easily and avoid copy and paste.

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #71275|0   |1
is obsolete||
  Attachment #71276|0   |1
is obsolete||
  Attachment #71277|0   |1
is obsolete||
  Attachment #71278|0   |1
is obsolete||
  Attachment #71279|0   |1
is obsolete||
  Attachment #71280|0   |1
is obsolete||
  Attachment #71281|0   |1
is obsolete||
  Attachment #71282|0   |1
is obsolete||

--- Comment #45 from Jonathan Druart  
---
Created attachment 71872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71872=edit
Bug 9573: Lost items report - Add items.notforloan as a filter

This patch adds a new "Not for loan" status filter to the lost items
report.

Test plan:
0/ Apply all patches from this patch set
1/ Use the new "Not for loan" filter to search lost items
2/ The table result must be consistent and a new "Not for loan" column
should be there
3/ Confirm that you are able to hide/show this column with the column
settings tool.

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #44 from Katrin Fischer  ---
Hi Jonathan,

there are some conflicts about the new VERSION variable for .js files. I've
tried to resolve those, but get tons of errors in the QA scripts. Can you
please take a look? I will paste some examples below:


 FAIL   koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/sco/help.tt
   FAIL   forbidden patterns
forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 13)

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/opac-user.tt
   FAIL   forbidden patterns
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 742)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 719)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 862)
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 46)
   OK git manipulation
   FAIL   spelling
 transfered  ==> transferred

   FAIL   valid
(Missing operator before shelfbrowser?)
String found where operator expected 
syntax error 
(Missing operator before  'shelfbrowser.inc'?)
koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/shelfbrowser.tt
had compilation errors.
Bareword found where operator expected 
Unquoted string "shelfbrowser" may clash with future reserved
word 

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt
   FAIL   critic
Code before strictures are enabled at line 1, column 1. See
page 429 of PBP.
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
Bareword found where operator expected 
(Missing operator before  'doc-head-open.inc'?)
(Missing operator before  'doc-head-close.inc'?)
koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt
had compilation errors.
Unquoted string "render" may clash with future reserved word 
(Missing semicolon on previous line?)
(Missing operator before suggestion?)
(Missing operator before divider?)
syntax error 
Unquoted string "label" may clash with future reserved word 
(Missing operator before Koha?)
(Missing operator before jsinclude?)
Unquoted string "html" may clash with future reserved word 
(Missing operator before  'opac-bottom.inc'?)
Unknown regexp modifier "/v" 
Unquoted string "divider" may clash with future reserved word 
String found where operator expected 
Unquoted string "opac" may clash with future reserved word 
Unknown regexp modifier "/n" 
Unquoted string "jsinclude" may clash with future reserved word 
Unquoted string "suggestions" may clash with future reserved
word 
Unquoted string "cssinclude" may clash with future reserved
word 
Unquoted string "koha" may clash with future reserved word 
Unquoted string "title" may clash with future reserved word 
(Missing operator before cssinclude?)
Unquoted string "pl" may clash with future reserved word

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #42 from Jonathan Druart  
---
Created attachment 71281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71281=edit
Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #41 from Jonathan Druart  
---
Created attachment 71280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71280=edit
Bug 9573: Lost items report - Add the CSV export ability

Finally we add the ability to export the list of lost items.
The items will be export in CSV format using a CSV profile defined.

Test plan:
0/ Apply all the patches from this patch set
1/ Define a CSV profile (type=SQL, Usage=Export lost items in report)
Try something like that to get the same columns as the default table:
Title=biblio.title
|Author=biblio.author
|Lost status=items.itemlost
|Lost on=items.itemlost_on
|Barcode=items.barcode
|Call number=items.itemcallnumber
|Date last seen=items.datelastseen
|Price=items.price
|Rep. price=items.replacementprice
|Library=items.homebranch
|item type=items.itype
|Current location=items.holdingbranch
|Location=items.location
|Not for loan status=items.notforloan
|Notes=items.itemnotes
2/ Use the filters and select items to export
3/ Export the list of items you want and make sure the CSV is correctly
formatted and contains the items you selected

QA Notes:
- I think we should add default CSV profiles for the different "usage",
but I would consider it as a separate enhancement since none of them is
defined yet
- Most of the code to export CSV is no reusable. We should make
Koha::Exporter::Record support CSV export for type=SQL (it only
supports MARC type so far).

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #40 from Jonathan Druart  
---
Created attachment 71279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71279=edit
Bug 9573: Lost items report - Add a new "Export selected items" link

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #43 from Jonathan Druart  
---
Created attachment 71282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71282=edit
Bug 9573: Add missing use statement

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #38 from Jonathan Druart  
---
Created attachment 71277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71277=edit
Bug 9573: Lost items report - add KohaTable to itemlost

Before this patch set, we used KohaTable to display a table with the
column visibility plugin, and an usual dataTable initialisation for the
filters.
For the lost items report table we will need both.
To do so we need to reorganize the code a bit

We cannot pass a selector but the id of the node which represents the
table. Indeed it is how works currently the filters (we may want to
improve that later)

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #39 from Jonathan Druart  
---
Created attachment 71278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71278=edit
Bug 9573: Lost items report - Add a new itemlost_on column

This patch adds a new "Lost on" column to the result table

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #37 from Jonathan Druart  
---
Created attachment 71276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71276=edit
Bug 9573: Lost items report - Move filters code to a separate js file

For the next patches we will need to reuse what is already done on the
bibliographic record detail page. This patch moves the code to make it
reusable easily and avoid copy and paste.

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68398|0   |1
is obsolete||
  Attachment #68399|0   |1
is obsolete||
  Attachment #68400|0   |1
is obsolete||
  Attachment #68401|0   |1
is obsolete||
  Attachment #68402|0   |1
is obsolete||
  Attachment #68403|0   |1
is obsolete||
  Attachment #68404|0   |1
is obsolete||
  Attachment #68405|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  
---
Created attachment 71275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71275=edit
Bug 9573: Lost items report - Add items.notforloan as a filter

This patch adds a new "Not for loan" status filter to the lost items
report.

Test plan:
0/ Apply all patches from this patch set
1/ Use the new "Not for loan" filter to search lost items
2/ The table result must be consistent and a new "Not for loan" column
should be there
3/ Confirm that you are able to hide/show this column with the column
settings tool.

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2018-02-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #35 from Katrin Fischer  ---
Patches no longer apply, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 9573: Lost items report - Add items.notforloan as a filter
Applying: Bug 9573: Lost items report - Move filters code to a separate js file
Applying: Bug 9573: Lost items report - add KohaTable to itemlost
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 9573: Lost items report - add KohaTable to itemlost
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-9573-Lost-items-report---add-KohaTable-to-item-M_2w8X.patc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #33 from sandbo...@biblibre.com  ---
Created attachment 68404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68404=edit
Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #34 from sandbo...@biblibre.com  ---
Created attachment 68405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68405=edit
Bug 9573: Add missing use statement

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #30 from sandbo...@biblibre.com  ---
Created attachment 68401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68401=edit
Bug 9573: Lost items report - Add a new itemlost_on column

This patch adds a new "Lost on" column to the result table

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #32 from sandbo...@biblibre.com  ---
Created attachment 68403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68403=edit
Bug 9573: Lost items report - Add the CSV export ability

Finally we add the ability to export the list of lost items.
The items will be export in CSV format using a CSV profile defined.

Test plan:
0/ Apply all the patches from this patch set
1/ Define a CSV profile (type=SQL, Usage=Export lost items in report)
Try something like that to get the same columns as the default table:
Title=biblio.title
|Author=biblio.author
|Lost status=items.itemlost
|Lost on=items.itemlost_on
|Barcode=items.barcode
|Call number=items.itemcallnumber
|Date last seen=items.datelastseen
|Price=items.price
|Rep. price=items.replacementprice
|Library=items.homebranch
|item type=items.itype
|Current location=items.holdingbranch
|Location=items.location
|Not for loan status=items.notforloan
|Notes=items.itemnotes
2/ Use the filters and select items to export
3/ Export the list of items you want and make sure the CSV is correctly
formatted and contains the items you selected

QA Notes:
- I think we should add default CSV profiles for the different "usage",
but I would consider it as a separate enhancement since none of them is
defined yet
- Most of the code to export CSV is no reusable. We should make
Koha::Exporter::Record support CSV export for type=SQL (it only
supports MARC type so far).

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #31 from sandbo...@biblibre.com  ---
Created attachment 68402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68402=edit
Bug 9573: Lost items report - Add a new "Export selected items" link

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #29 from sandbo...@biblibre.com  ---
Created attachment 68400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68400=edit
Bug 9573: Lost items report - add KohaTable to itemlost

Before this patch set, we used KohaTable to display a table with the
column visibility plugin, and an usual dataTable initialisation for the
filters.
For the lost items report table we will need both.
To do so we need to reorganize the code a bit

We cannot pass a selector but the id of the node which represents the
table. Indeed it is how works currently the filters (we may want to
improve that later)

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #28 from sandbo...@biblibre.com  ---
Created attachment 68399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68399=edit
Bug 9573: Lost items report - Move filters code to a separate js file

For the next patches we will need to reuse what is already done on the
bibliographic record detail page. This patch moves the code to make it
reusable easily and avoid copy and paste.

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #27 from sandbo...@biblibre.com  ---
Created attachment 68398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68398=edit
Bug 9573: Lost items report - Add items.notforloan as a filter

This patch adds a new "Not for loan" status filter to the lost items
report.

Test plan:
0/ Apply all patches from this patch set
1/ Use the new "Not for loan" filter to search lost items
2/ The table result must be consistent and a new "Not for loan" column
should be there
3/ Confirm that you are able to hide/show this column with the column
settings tool.

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68355|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68358|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68357|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68356|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68354|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68352|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68353|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68351|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com

--- Comment #26 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 Blocks||19507

--- Comment #25 from Katrin Fischer  ---
In my tests all works nicely now, I am filing a separate bug report for adding
a sample CSV profile to make it a bit easier. Also, we already have one for
claiming issues: bug 19507


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19507
[Bug 19507] Add a sample CSV profile for exporting lost items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68184|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 68357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68357=edit
Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68090|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 68356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68356=edit
Bug 9573: Lost items report - Add the CSV export ability

Finally we add the ability to export the list of lost items.
The items will be export in CSV format using a CSV profile defined.

Test plan:
0/ Apply all the patches from this patch set
1/ Define a CSV profile (type=SQL, Usage=Export lost items in report)
Try something like that to get the same columns as the default table:
Title=biblio.title
|Author=biblio.author
|Lost status=items.itemlost
|Lost on=items.itemlost_on
|Barcode=items.barcode
|Call number=items.itemcallnumber
|Date last seen=items.datelastseen
|Price=items.price
|Rep. price=items.replacementprice
|Library=items.homebranch
|item type=items.itype
|Current location=items.holdingbranch
|Location=items.location
|Not for loan status=items.notforloan
|Notes=items.itemnotes
2/ Use the filters and select items to export
3/ Export the list of items you want and make sure the CSV is correctly
formatted and contains the items you selected

QA Notes:
- I think we should add default CSV profiles for the different "usage",
but I would consider it as a separate enhancement since none of them is
defined yet
- Most of the code to export CSV is no reusable. We should make
Koha::Exporter::Record support CSV export for type=SQL (it only
supports MARC type so far).

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68087|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 68353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68353=edit
Bug 9573: Lost items report - add KohaTable to itemlost

Before this patch set, we used KohaTable to display a table with the
column visibility plugin, and an usual dataTable initialisation for the
filters.
For the lost items report table we will need both.
To do so we need to reorganize the code a bit

We cannot pass a selector but the id of the node which represents the
table. Indeed it is how works currently the filters (we may want to
improve that later)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68089|0   |1
is obsolete||

--- Comment #21 from Katrin Fischer  ---
Created attachment 68355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68355=edit
Bug 9573: Lost items report - Add a new "Export selected items" link

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68283|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 68358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68358=edit
Bug 9573: Add missing use statement

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68085|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 68351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68351=edit
Bug 9573: Lost items report - Add items.notforloan as a filter

This patch adds a new "Not for loan" status filter to the lost items
report.

Test plan:
0/ Apply all patches from this patch set
1/ Use the new "Not for loan" filter to search lost items
2/ The table result must be consistent and a new "Not for loan" column
should be there
3/ Confirm that you are able to hide/show this column with the column
settings tool.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68088|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 68354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68354=edit
Bug 9573: Lost items report - Add a new itemlost_on column

This patch adds a new "Lost on" column to the result table

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #68086|0   |1
is obsolete||

--- Comment #18 from Katrin Fischer  ---
Created attachment 68352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68352=edit
Bug 9573: Lost items report - Move filters code to a separate js file

For the next patches we will need to reuse what is already done on the
bibliographic record detail page. This patch moves the code to make it
reusable easily and avoid copy and paste.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #16 from Katrin Fischer  ---
Is Text::CSV (0.01) listed on your about page?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #15 from Katrin Fischer  ---
Maybe you are just missing a dependency on the one computer?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #14 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Séverine Queune from comment #11)
> > Everyting work well (set csv profile, filter the list on notforloen ou
> > itemlost, select items) until I try to export the selected items.
> > I always get this Software error :
> > Can't locate object method "new" via package "Text::CSV_XS" (perhaps you
> > forgot to load "Text::CSV_XS"?) at /home/koha/src/reports/itemslost.pl line
> > 68.
> > For help, please send mail to the webmaster ([no address given]), giving
> > this error message and the time and date of the error.
> 
> I did not recreate with my perl version, but indeed there was a missing use
> statement.

I first tried at home with my personal laptop when I had this message.

I just tried :
 - my professional computer + BULAC wired connexion : it works
 - my personal laptop + BULAC wifi for guests : it works

I'll try again tonight with home wifi + laptop and will sign the patch if
everything is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||19467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19467
[Bug 19467] Display location and itemtype description on lost items report
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #13 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #11)
> Everyting work well (set csv profile, filter the list on notforloen ou
> itemlost, select items) until I try to export the selected items.
> I always get this Software error :
> Can't locate object method "new" via package "Text::CSV_XS" (perhaps you
> forgot to load "Text::CSV_XS"?) at /home/koha/src/reports/itemslost.pl line
> 68.
> For help, please send mail to the webmaster ([no address given]), giving
> this error message and the time and date of the error.

I did not recreate with my perl version, but indeed there was a missing use
statement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #12 from Jonathan Druart  
---
Created attachment 68283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68283=edit
Bug 9573: Add missing use statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from Séverine Queune  ---
Everyting work well (set csv profile, filter the list on notforloen ou
itemlost, select items) until I try to export the selected items.
I always get this Software error :
Can't locate object method "new" via package "Text::CSV_XS" (perhaps you forgot
to load "Text::CSV_XS"?) at /home/koha/src/reports/itemslost.pl line 68.
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #8)
> The patch appears to break the list of checkouts in the patron account:
> 
> Error: Syntax error, unrecognized expression: ##issues-table

Indeed, I git grepped on **/*.tt but there was an occurrence in a .js file.
Thanks for the catch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #9 from Jonathan Druart  
---
Created attachment 68184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68184=edit
Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Katrin Fischer  ---
The patch appears to break the list of checkouts in the patron account:

Error: Syntax error, unrecognized expression: ##issues-table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

Summary|ability to download items   |Ability to download items
   |lost report |lost report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19467
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #7 from Jonathan Druart  
---
Created attachment 68090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68090=edit
Bug 9573: Lost items report - Add the CSV export ability

Finally we add the ability to export the list of lost items.
The items will be export in CSV format using a CSV profile defined.

Test plan:
0/ Apply all the patches from this patch set
1/ Define a CSV profile (type=SQL, Usage=Export lost items in report)
Try something like that to get the same columns as the default table:
Title=biblio.title
|Author=biblio.author
|Lost status=items.itemlost
|Lost on=items.itemlost_on
|Barcode=items.barcode
|Call number=items.itemcallnumber
|Date last seen=items.datelastseen
|Price=items.price
|Rep. price=items.replacementprice
|Library=items.homebranch
|item type=items.itype
|Current location=items.holdingbranch
|Location=items.location
|Not for loan status=items.notforloan
|Notes=items.itemnotes
2/ Use the filters and select items to export
3/ Export the list of items you want and make sure the CSV is correctly
formatted and contains the items you selected

QA Notes:
- I think we should add default CSV profiles for the different "usage",
but I would consider it as a separate enhancement since none of them is
defined yet
- Most of the code to export CSV is no reusable. We should make
Koha::Exporter::Record support CSV export for type=SQL (it only
supports MARC type so far).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #3 from Jonathan Druart  
---
Created attachment 68086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68086=edit
Bug 9573: Lost items report - Move filters code to a separate js file

For the next patches we will need to reuse what is already done on the
bibliographic record detail page. This patch moves the code to make it
reusable easily and avoid copy and paste.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #5 from Jonathan Druart  
---
Created attachment 68088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68088=edit
Bug 9573: Lost items report - Add a new itemlost_on column

This patch adds a new "Lost on" column to the result table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #6 from Jonathan Druart  
---
Created attachment 68089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68089=edit
Bug 9573: Lost items report - Add a new "Export selected items" link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #4 from Jonathan Druart  
---
Created attachment 68087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68087=edit
Bug 9573: Lost items report - add KohaTable to itemlost

Before this patch set, we used KohaTable to display a table with the
column visibility plugin, and an usual dataTable initialisation for the
filters.
For the lost items report table we will need both.
To do so we need to reorganize the code a bit

We cannot pass a selector but the id of the node which represents the
table. Indeed it is how works currently the filters (we may want to
improve that later)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #2 from Jonathan Druart  
---
Created attachment 68085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68085=edit
Bug 9573: Lost items report - Add items.notforloan as a filter

This patch adds a new "Not for loan" status filter to the lost items
report.

Test plan:
0/ Apply all patches from this patch set
1/ Use the new "Not for loan" filter to search lost items
2/ The table result must be consistent and a new "Not for loan" column
should be there
3/ Confirm that you are able to hide/show this column with the column
settings tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Séverine Queune  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-09-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|--- |Seeking developer

--- Comment #1 from Séverine Queune  ---
The BULAC (http://www.bulac.fr/) would like to sponsore this development with
the following features.

On the form page :
  - add a new filter option on the “items.notforloan” field

On the result page :
  - items can be selected
  - there are options “Activate / Deactivate filters”, “Select all” and “Clear
all” (like on the “Holdings” tab on the bibliographic record)
  - a column display the “items.itemlost_on” timestamp
  - selected items can be exported ; different csv profiles can be chosen,
based on the existing “CSV profiles” on the “Tools” menu

As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to
quote us for the development of such a feature or just ask for more information
is welcome to write to us: .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-09-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

98 matches

Mail list logo