[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #15979|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 17055
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17055action=edit
[PASSED QA] Bug 9685: Allow sort baskets by number

In acqui/booksellers.pl, first column of baskets tables is name (#number).
This allows to sort by name but not by numnber.

This patch splits acutal first column into 2 columns number and name to
allow sorting on number.
Sets default sort on name like existing.

Test plan:
Look at page and use sorting on name and number columns.

Signed-off-by: Marc Sabin marc.sa...@sciencespo-grenoble.fr
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Nice change for better usability.
Sorting of both columns works nicely.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 16029
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16029action=edit
But 9791: Remove single pixel on datatable tables

Test plan:
Check on the 5 pages that pixels are disappears after applying this
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16029|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 16029
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16029
But 9791: Remove single pixel on datatable tables

Not the good report either...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15926|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 15926
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15926
Add robots txt file to deny all bots

not the good report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #15766|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Switch back to Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Paul Poulain paul.poul...@biblibre.com ---
Patch tested with a sandbox, by Marc Sabin marc.sa...@sciencespo-grenoble.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #15766|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

--- Comment #11 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 15979
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15979action=edit
Bug 9685: Allow sort baskets by number

In acqui/booksellers.pl, first column of baskets tables is name (#number).
This allows to sort by name but not by numnber.

This patch splits acutal first column into 2 columns number and name to allow
sorting on number.
Sets default sort on name like existing.

Test plan:
Look at page and use sorting on name and n° columns.

Signed-off-by: Marc Sabin marc.sa...@sciencespo-grenoble.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||paul.poul...@biblibre.com

--- Comment #5 from Paul Poulain paul.poul...@biblibre.com ---
Patch tested with a sandbox, by Marc Sabin marc.sa...@sciencespo-grenoble.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

  Attachment #15766|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

--- Comment #6 from Paul Poulain paul.poul...@biblibre.com ---
Created attachment 15926
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15926action=edit
Add robots txt file to deny all bots

Signed-off-by: Marc Sabin marc.sa...@sciencespo-grenoble.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-03-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #6)
 Created attachment 15926 [details] [review]
 Add robots txt file to deny all bots
 
 Signed-off-by: Marc Sabin marc.sa...@sciencespo-grenoble.fr

Looks like a mistake...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-02-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

The patch submitted by Owen does not apply (fatal: cannot convert from
UTF-8utf-8 to UTF-8).
Furthermore before this patch, the table is sorted on the basket name by
default, after by basketno. We have to keep the same order.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-02-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #15684|0   |1
is obsolete||

--- Comment #4 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 15766
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15766action=edit
Proposed patch (revised)

Added default sort on basket name.
Please re-signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-02-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-02-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #15588|0   |1
is obsolete||

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
Created attachment 15684
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15684action=edit
[SIGNED-OFF] Bug 9685: Allow sort baskets by number

In acqui/booksellers.pl, first column of baskets tables is name (#number).
This allows to sort by name but not by numnber.

This patch splits acutal first column into 2 columns number and name to allow
sorting on number.

Test plan:
Look at page and use sorting on name and n° columns.

Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9685] Allow sort baskets by number

2013-02-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9685

Fridolyn SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co
   |ity.org |m

--- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com ---
Created attachment 15588
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15588action=edit
Proposed patch

See commit message

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/