[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t ("alert" field)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26700 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Adrien! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19269|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19352 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19352action=edit Bug 9845: SIP tests : fixes in 08checkin.t The tests were too restrictive. It should be possible to pass a checkin/checkout test with different values defined for magnetic medias. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #16601|0 |1 is obsolete|| --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 19269 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19269action=edit Bug 9845: SIP tests : fixes in 08checkin.t The tests were too restrictive. It should be possible to pass a checkin/checkout test with different values defined for magnetic medias. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 --- Comment #4 from Adrien SAURAT adrien.sau...@biblibre.com --- The differences seem to come from different values we have in ILS.pm (with the default file magnetic media = 1 but maybe you modified this?) But anyway, it's in fact out of scope when it comes to testing a checkin. A library could use magnetic media or not, choose to desensitize or not, what we are testing here is the ability to checkin, and that is proved by the third character, 0 or 1. I'll thus make a patch allowing different configurations about magnetic madia. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Attachment #16397|0 |1 is obsolete|| --- Comment #5 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 16601 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16601action=edit proposed patch #2 New version of the patch. Will correct the tests being too restrictive about magnetic medias. But if you use the same barcode as before, you'll still get errors, it seemed to be an invalid item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||k...@bywatersolutions.com
--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
I'm getting the same results pre and post patch.
$ perl -I.. 08checkin.t
1..5
ok 1 - login
ok 2 - SC status
not ok 3 - match leader Checkin: prep: check out item (50232605)
# Failed test 'match leader Checkin: prep: check out item (50232605)'
# at SIPtest.pm line 204.
# Response '120NUN20130320
065359AOCPL|AA23529001000463|AB50232605|AJ|AH|AFInvalid Item|BLY|AY3AZE7E3'
doesn't match pattern '(?-xism:^121NNY\d{8} {4}\d{6})'
not ok 4 - match leader Checkin: Item (50232605) is checked out
# Failed test 'match leader Checkin: Item (50232605) is checked out'
# at SIPtest.pm line 204.
# Response '100NUY20130320065359AOCPL|AB50232605|CV99|AFItem not
checked out|AY4AZEA99' doesn't match pattern '(?-xism:^101YNN\d{8} {4}\d{6})'
not ok 5 - match leader Checkin: Item not checked out
# Failed test 'match leader Checkin: Item not checked out'
# at SIPtest.pm line 204.
# Response '100NUY20130320065359AOCPL|AB50232605|CV99|AFItem not
checked out|AY5AZEA98' doesn't match pattern '(?-xism:^100YN[NY]\d{8}
{4}\d{6})'
# Looks like you failed 3 tests of 5.
Any idea as to what I'm doing wrong?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 --- Comment #3 from Adrien SAURAT adrien.sau...@biblibre.com --- Well, my patch is actually design to correct the test named 'match leader Checkin: Item not checked out', but your run seems to crash before that, on the test named 'match leader Checkin: prep: check out item'. You have a response beginning with 120NUN and the test expects 121NNY. Two differences then, the main one being 120 instead of 121 (the checkin failed, and the AF field contains this message : Invalid Item. Looks like your barcode is wrong or something like that ?! Other difference, U instead of N for the magnetic media field. I never encountered this U, and the unit test does not expect this, I don't know yet why you're getting this response. From the 3M doc, about the magnetic media field: 1-char, fixed-length field: Y or N or U. A 'Y' in this field indicates that this article is magnetic media and the SC will then handle the security discharge accordingly. A 'N' in this field indicates that the article is not magnetic media. A 'U' indicates that the ACS does not identify magnetic media articles. ACS vendors are encouraged to store and provide article magnetic media identification. The following test which fails on your side is the direct consequence of the first fail. It's a checkout which can only success if the former checkin attempt succeeded. On the last failing test, we are working on the test modified by my patch. Here, you get : 100NUY The test awaits: 100YN[NY] Two fields make the test field: - resensitize is on N for you (but should this make the test fail? after all, you can configure this in SIPconfig.xml for a reason) - magnetic media, again you have U and I don't know why!! we should check the code for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 --- Comment #1 from Adrien SAURAT adrien.sau...@biblibre.com --- Created attachment 16397 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16397action=edit proposed patch #1 TEST PLAN : 1) In C4/SIP/t, configure the SIPtest.pm file. 2) Configure your SIPconfig.xml if needed. 3) Start your SIP server. 4) In C4/SIP/t, do a global make test or just launch the checkin test (see the README file for more informations) After the patch, the checkin test should run without error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t (alert field)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Adrien SAURAT adrien.sau...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
