[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-08-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #27 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Pushed to 3.14.x, will be in 3.14.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #26 from Galen Charlton gmcha...@gmail.com ---
Pushed to master, along with follow-ups to enable QueryParser to use the new
indexes.

Thanks, Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #24 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Ah yes, I remember the talk now, I was there.

Happy to pass QA on this now then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #25 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 26544
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26544action=edit
[PASSED QA] Bug 9972 Add/ change some zebra indexes (MARC21)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index
term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also
adds the »curriculum«-index to Search.pm.

Signed-off-by: Chris Cormack chr...@catalyst.net.nz
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #25769|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #23 from Mirko Tietgen mi...@abunchofthings.net ---
Hi Martin, thanks for taking a look!

The change for 521 is necessary in our case for levels of language learners
that come in not-only numeric values (like A1, A2, B1…). We use 658 for
language certificates (like TOEFL).

653 in our case is for a classification by language that we need to seperate
form the other subject fields, but it could be used in very different ways in
other libraries. We use 655 for another internal classification.

I did a talk about it in Edinburgh, maybe that is of interest to you (around
page 16
http://amor.cms.hu-berlin.de/~tietgemi/koha/tietgen-kohacon2012-koha.in.language.centres.pdf).

Does that answer your question?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #22 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Hi Mirko, 

I'm pretty happy that everything here works, and the code looks good. However,
I would like to have some clear reasoning behind why your adding these specific
indexes?  Mostly because, to me it's not clear how they are usful (I'm sure
they are.. but some context is always good).

Could you comment on this, and perhaps ammend your commit message to include
some examples of where the indexes are usefull?

Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #22030|0   |1
is obsolete||

--- Comment #20 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 25762
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25762action=edit
Bug 9972 Add/ change some zebra indexes (MARC21)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index
term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also
adds the »curriculum«-index to Search.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #25762|0   |1
is obsolete||

--- Comment #21 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 25769
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25769action=edit
Bug 9972 Add/ change some zebra indexes (MARC21)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index
term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also
adds the »curriculum«-index to Search.pm.

Signed-off-by: Chris Cormack chr...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2014-03-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-10-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot|2013-09-24 00:00:00 |2013-10-30
last check this||

--- Comment #19 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-10-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #17 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 22030
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22030action=edit
Bug 9972 Add/ change some zebra indexes (MARC21)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index
term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also
adds the »curriculum«-index to Search.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-10-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #21234|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-10-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #18 from Mirko Tietgen mi...@abunchofthings.net ---
To test:

1) Apply patch.
2) Create test DB (cf. INSTALL.debian, change user and pass)
mysqladmin -uroot -ppass create bug9972
mysql -uroot -ppass
grant all on bug9972.* to 'user'@'localhost' identified by 'pass';
flush privileges;
3) Run Makefile.PL, choose some local path for test installation, choose GRS-1
for biblio indexing.
4) Run make, make install.
5) symlink /etc/instancename/koha-httpd.conf to
/etc/apache2/sites-available/instancename, a2ensite instancename. disable other
koha instance if neccessary, 
5) Run webinstaller.
6) Catalogue a record with data in
-- 041$a (eg audio)
-- 041$j (eg subtitle)
-- 521$a (eg fivetwoone)
-- 653$a (eg sixfivethree)
-- 655$a (eg sixfivefive)
-- 658$a (eg sixfiveeight)
7) Reindex. Also check if zebrasrv for that instance is running, mine wasn't.
8) Try searches, change q= at the end to match your test record data.
http://YourOPAC/opac-search.pl?idx=ln-audioq=audio
http://YourOPAC/opac-search.pl?idx=ln-subtitleq=subtitle
http://YourOPAC/opac-search.pl?idx=lexq=fivetwoone
http://YourOPAC/opac-search.pl?idx=Index-term-genreq=sixfivefive
http://YourOPAC/opac-search.pl?idx=Index-term-uncontrolledq=sixfivethree
http://YourOPAC/opac-search.pl?idx=curriculumq=sixfiveeight
You should reach the correct record with each search.
9) Run Makefile.PL, choose the same local path as last time, choose DOM for
biblio indexing.
10) Run make, make install.
11) Reindex.
12) Try searches described in 8 again. You should find your test record for all
queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-10-01 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-09-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #16 from Mirko Tietgen mi...@abunchofthings.net ---
Reposting the test plan as it got lost in the comments:

1) Apply patch.
2) Create test DB (cf. INSTALL.debian, change user and pass)
mysqladmin -uroot -ppass create bug9972
mysql -uroot -ppass
grant all on bug9972.* to 'user'@'localhost' identified by 'pass';
flush privileges;
3) Run Makefile.PL, choose some local path for test installation, choose GRS-1
for biblio indexing.
4) Run make, make install.
5) symlink /etc/instancename/koha-httpd.conf to
/etc/apache2/sites-available/instancename, a2ensite instancename. disable other
koha instance if neccessary, 
5) Run webinstaller.
6) Catalogue a record with data in
-- 521$a (eg fivetwoone)
-- 653$a (eg sixfivethree)
-- 655$a (eg sixfivefive)
-- 658$a (eg sixfiveeight)
7) Reindex. Also check if zebrasrv for that instance is running, mine wasn't.
8) Try searches, change q= at the end to match your test record data.
http://YourOPAC/opac-search.pl?idx=lexq=fivetwoone
http://YourOPAC/opac-search.pl?idx=Index-term-genreq=sixfivefive
http://YourOPAC/opac-search.pl?idx=Index-term-uncontrolledq=sixfivethree
http://YourOPAC/opac-search.pl?idx=curriculumq=sixfiveeight
You should reach the same record with each search.
9) Run Makefile.PL, choose the same local path as last time, choose DOM for
biblio indexing.
10) Run make, make install.
11) Reindex.
12) Try searches described in 8 again. You should find your test record for all
queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-09-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot||2013-09-24
last check this||

--- Comment #15 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-09-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #17137|0   |1
is obsolete||

--- Comment #14 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 21234
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21234action=edit
9972 Add/ change some zebra indexes (MARC21) (GRS1)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653$a (Index term uncontrolled) and 655$a
(Index term Genre/Form). It also adds the »curriculum«-index to Search.pm.

9972 Follow-up: DOM version

A DOM version of the same indexes

Squashed both patches together.

Bug 9972 Follow-up

Follow-up to correct the mix-up of 653 and 655 in the DOM configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-09-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #19768|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-09-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-09-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||git...@bugs.koha-community.
   ||org

--- Comment #13 from I'm just a bot git...@bugs.koha-community.org ---
Applying: Bug 9972 Follow-up
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 9972 Follow-up
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Hi Mirko,
You seem to mix up 653 [uncontrolled] and 655 [genre] here:

@@ -587,6 +587,13 @@ definition file (probably something like
{biblio,authority}-koha-indexdefs.xml)
   xslo:template mode=index_subfields match=marc:datafield[@tag='653']
 xslo:for-each select=marc:subfield
+  xslo:if test=contains('a', @code)
+z:index name=Index-term-genre:w Index-term-genre:p Subject:w
Subject:p
+  xslo:value-of select=./
+/z:index
+  /xslo:if
+/xslo:for-each
+xslo:for-each select=marc:subfield

Also a question: You modify both files for DOM. But is that how it should be
done? Or is the change you submit a result of generating the other file again
with the script?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #10 from Mirko Tietgen mi...@abunchofthings.net ---
Marcel, thanks a lot for spotting the mix-up! You are right of course! I will
provide a revised patch.

About the DOM files, it was my understanding that they should both be changed
to have the indexes as part of the standard setup and in case someone rebuilds
the DOM indexes later.

I just asked Jared to be on the safe side and the correct way is to change one
file, generate the other and have both changes in the patch.
http://irc.koha-community.org/koha/2013-07-18#i_1349220

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #12 from Mirko Tietgen mi...@abunchofthings.net ---
I added a follow-up for easier testing. I can squash the patches if that is
preferred.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-07-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #11 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 19768
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19768action=edit
Bug 9972 Follow-up

Follow-up to correct the mix-up of 653 and 655 in the DOM configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #8 from Mirko Tietgen mi...@abunchofthings.net ---
There is an error in the last query, it should be
http://YourOPAC/opac-search.pl?idx=curriculumq=sixfiveeight

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #7 from Mirko Tietgen mi...@abunchofthings.net ---
Revised test plan based on Jared's comment at
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750#c5. I used a new
db and file path.

1) Apply patch.
2) Create test DB (cf. INSTALL.debian, change user and pass)
mysqladmin -uroot -ppass create bug9972
mysql -uroot -ppass
grant all on bug9972.* to 'user'@'localhost' identified by 'pass';
flush privileges;
3) Run Makefile.PL, choose some local path for test installation, choose GRS-1
for biblio indexing.
4) Run make, make install.
5) symlink /etc/instancename/koha-httpd.conf to
/etc/apache2/sites-available/instancename, a2ensite instancename. disable other
koha instance if neccessary, 
5) Run webinstaller.
6) Catalogue a record with data in
-- 521$a (eg fivetwoone)
-- 653$a (eg sixfivethree)
-- 655$a (eg sixfivefive)
-- 658$a (eg sixfiveeight)
7) Reindex. Also check if zebrasrv for that instance is running, mine wasn't.
8) Try searches, change q= at the end to match your test record data.
http://YourOPAC/opac-search.pl?idx=lexq=fivetwoone
http://YourOPAC/opac-search.pl?idx=Index-term-genreq=sixfivefive
http://YourOPAC/opac-search.pl?idx=Index-term-uncontrolledq=sixfivethree
http://YourOPAC/opac-search.pl?idx=curriculumq=sixfivethree
You should reach the same record with each search.
9) Run Makefile.PL, choose the same local path as last time, choose DOM for
biblio indexing.
10) Run make, make install.
11) Reindex.
12) Try searches described in 8 again. You should find your test record for all
queries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #6 from Mirko Tietgen mi...@abunchofthings.net ---
Kyle, thanks for trying. I built a package with master+patch to test it and
that worked fine for me.

I tried symlinking and ran into problems too. One is that there is a reference
to a marc.mar file that seems to be missing in my dev installation. I still
have errors after symlinking that. I have to take another look at this later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #5 from Kyle M Hall kyle.m.h...@gmail.com ---
I tried to test this patch and was only able to get
URL_to_your_OPAC/opac-search.pl?idx=lexq=VALUE1 to work. I symlinked all the
files to my koha-dev dir like this:
lrwxrwxrwx 1 koha koha 47 Apr  5 11:03 ../koha-dev/etc/zebradb/ccl.properties
- /home/koha/kohaclone/etc/zebradb/ccl.properties

lrwxrwxrwx 1 koha koha 53 Apr  5 12:25
../koha-dev/etc/zebradb/biblios/etc/bib1.att -
/home/koha/kohaclone/etc/zebradb/biblios/etc/bib1.att

lrwxrwxrwx 1 koha koha 83 Apr  5 11:05
../koha-dev/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml -
/home/koha/kohaclone/etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml

lrwxrwxrwx 1 koha koha 84 Apr  5 12:22
../koha-dev/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl -
/home/koha/kohaclone/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl

lrwxrwxrwx 1 koha koha 68 Apr  5 12:23
../koha-dev/etc/zebradb/marc_defs/marc21/biblios/record.abs -
/home/koha/kohaclone/etc/zebradb/marc_defs/marc21/biblios/record.abs

Did I miss anything?


(In reply to comment #4)
 Created attachment 17137 [details] [review]
 9972 Add/ change some zebra indexes (MARC21) (GRS1)
 
 This patch adds :w and :p versions to the index for »Lexile number« (it has
 only :n so far) and adds indexes for 653$a (Index term uncontrolled) and
 655$a (Index term Genre/Form). It also adds the »curriculum«-index to
 Search.pm.
 
 9972 Follow-up: DOM version
 
 A DOM version of the same indexes
 
 Squashed both patches together.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

Summary|Add/ change some zebra  |Add/ change some zebra
   |indexes (MARC21) (GRS1) |indexes (MARC21) (GRS1+DOM)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21) (GRS1+DOM)

2013-04-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #17126|0   |1
is obsolete||
  Attachment #17136|0   |1
is obsolete||

--- Comment #4 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 17137
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17137action=edit
9972 Add/ change some zebra indexes (MARC21) (GRS1)

This patch adds :w and :p versions to the index for »Lexile number« (it has
only :n so far) and adds indexes for 653$a (Index term uncontrolled) and 655$a
(Index term Genre/Form). It also adds the »curriculum«-index to Search.pm.

9972 Follow-up: DOM version

A DOM version of the same indexes

Squashed both patches together.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/