[Koha-bugs] [Bug 22264] Account expiration warning via notices and e-mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22264 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Christopher, there is already an email feature. Take a look at the MEMBERSHIP_EXPIRY notice: https://koha-community.org/manual/18.11/en/html/tools.html?highlight=notices#existing-notices-slips -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Permanent location should |Improve display of changed |show instead of cart|values on course reserves |location - |and show permanent location |course-details.tt |instead of cart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 Katrin Fischer changed: What|Removed |Added Attachment #84113|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 84676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84676&action=edit Bug 21446: Remove fix comment Fix is not needed. Signed-off-by: helene hickey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21446] Improve display of changed values on course reserves and show permanent location instead of cart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21446 --- Comment #11 from Katrin Fischer --- Created attachment 84675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84675&action=edit Bug 21446: Improve display of changed values on course reserves and show permanent location instead of cart TO TEST: 1) Set ReturnToShelvingCart on. 2) Create a Course Reserve and make inactive. 3) Add an item, changing Item type, Collection code, Shelving location, and Holding library. 4) Note these four fields in the item list. 5) Activate course reserve. 6) Note subtle/no difference in these fiels in the list. 7) Check in the item. 8) Go back to course reserves and note that the cart is listed in the field instead of permanent location. 9) Deactivate course reserve. 10) Reset permanent location on item manually. 11) Apply patch. 12) Repeat steps 4-9 noting that the permanent location is showing instead of current location. Also, if a change is assigned to the item, the change AND the regular state always show. The active state will be in bold. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21890] Patron password reset by category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Hi Tomas, I think I would have liked a workflow where the value from the global preference is inherited and can be overwritten on category level a little better as this is yet another thing to remember when setting up patron categories (adding more steps and clicks in most use cases). An example for the different behaviour would be: Block expired patrons. (something to consider) 2) NOT allowed = 1 for the column categories.can_reset_password seems counter intuitive? Please check values. 3) The new column is missing from the category overview page and column configuration. I know others appear to be missing too, but I'd consider this a bug as it means you have to open each one to see where you might have made a wrong choice. 4) The message is: +[% ELSIF errNoBorrowerFound %] +You are not allowed to reset your password. Contact library staff for assistance. [% END %] I think the is wrong here as we are not inside a list and the other message doesn't have it. I think it would be nice to add a span around the message with an id, so if libraries want to change the message it will be easy. The message might read a little harsh to some or they might want to explain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20912] Rental fees based on time period
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #72 from Katrin Fischer --- (In reply to Martin Renvoize from comment #55) > I have given this a thorough testing and added a few qa followups to fix > some failing test cases and improve test coverage. > > I also felt it important to add support for hourly loan periods and as such, > I've added a pair of follow-ups to add this. As such, although I'd PQA on > all work preceding my own, I've asked Tomas and Kyle to cast their eyes over > the followup as a final QA signoff. Are we waiting for Tomas or should this be moved on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Moving to failed QA as of Tomas last comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22254] t/db_dependent/Koha/Patrons.t contains a DateTime math error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22254 Katrin Fischer changed: What|Removed |Added Attachment #84600|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 84677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84677&action=edit Bug 22254: Correction to datehandling in test Adding 13 months is not always the same as adding 1 month and then adding 12 months in DateTime maths. This patch rectified the test to match the correct behaviour in koha. Test plan. 1) Modify the test (around line 268) to test against the suspect leap date of 2019-01-31 and watch the test fail. 2) Apply the patch (which also adds this modification to test for such a leap date) and watch the test now pass. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20171] Item search should honor syspref 'delimiter'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20171 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi all, I tested, but found 2 issues that we need to fix: - The QA script complains about missing filters - While most values of the system preference translate directly, tabulation does not: ;|tabulation|,|/|\|#||. So when tab is selected, the file exported is not usable as it has "tabulation" printed as a separator instead of the actual 'tab'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for item branch transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097 Katrin Fischer changed: What|Removed |Added Attachment #83774|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 84678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84678&action=edit Bug 22097: CataloguingLog should be suppressed for item branch transfers Bug 18816 missed the fact that a branch transfer triggers ModItem and thus generates an action log line. We should not be creating those action logs, especially considering the transfers table itself already documents the transfer. Test Plan: 1) Enable CataloguingLog 2) Transfer an item to another branch 3) Note the new action log line created 4) Apply this patch 5) Create another item transfer 6) No new action log line should be created! Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for item branch transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22097] CataloguingLog should be suppressed for item branch transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22097 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Behaviour of ModItem with and without the logging flag is already tested. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Katrin Fischer changed: What|Removed |Added Attachment #84101|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 84679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84679&action=edit Bug 21622: Adjust incorrect GROUP BY clauses in acqui script acqui/ordered.pl:GROUP BY aqorders.ordernumber acqui/spent.pl:GROUP BY aqorders.ordernumbe 'koha_kohadev.aqorders.biblionumber' isn't in GROUP BY Test plan: - Create orders for different basket and using different funds - Receive some of them - Hit the ordered and spent pages (from the acqui home page) => The tables must contain the same data with and without this patch Signed-off-by: Jasmine Amohia Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Katrin Fischer changed: What|Removed |Added Attachment #83833|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 84680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84680&action=edit Bug 16231: Correct permission handling in subscription edit This patch corrects the way subscription edit menu items are displayed according to the user's permissions settings. To test, apply the patch and log in to the staff client as a user who has permission to create, edit, and delete subscriptions. - Locate an subscription and view the details for it. - Confirm that each "Edit" menu item works correctly. - Repeat the process when logged in as a user with varying combinations of create, edit, and delete permissions. - Test as a user limited by IndependentBranches. Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I am not even sure if the current behaviour is correct: When requesting an article the pick-up branch is selected and it seems only libraries from the pick-up branch see the request... so the fact where the item actually is is not taken into account at all and libraries who might be able to fill the request are not notified? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 --- Comment #5 from Katrin Fischer --- My confusion was related to bug 22265. PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22265] New: Processing article requests requires borrowers permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22265
Bug ID: 22265
Summary: Processing article requests requires borrowers
permission
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs@lists.koha-community.org
Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Target Milestone: ---
I just noticed that you will only be able to see article requests if the staff
patron has "borrowers" permission. You can still access the article requests
page without the permission, but it will always show "no pending article
requests".
This dependency doesn't seem logical, especially since you can still access the
page and it just seems like there are no requests. The problem seems to come
from this part of the code:
Koha::ArticleRequests:
sub search_limited {
my ( $self, $params, $attributes ) = @_;
my $userenv = C4::Context->userenv;
my @restricted_branchcodes;
if ( $userenv and $userenv->{number} ) {
my $logged_in_user = Koha::Patrons->find( $userenv->{number} );
@restricted_branchcodes =
$logged_in_user->libraries_where_can_see_patrons;
}
# TODO This 'borrowernumber' relation name is confusing and needs to be
renamed
$params->{'borrowernumber.branchcode'} = { -in => \@restricted_branchcodes
} if @restricted_branchcodes;
$attributes->{join} = 'borrowernumber';
return $self->search( $params, $attributes );
}
Not sure yet what the best way would be:
Do we want to allow article request processing without borrowers?
If no, we could hide article requests from view if the staff user doesn't
have the required permission.
If yes, what would be the consequence? (stuck on that one)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Katrin Fischer changed: What|Removed |Added Attachment #83794|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 84681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84681&action=edit Bug 21907: Fix article requests count for non-superlibrarians The query generates "Column 'branchcode' in where clause is ambiguous" Test plan: 1 - Enable 'IndependentBranchesPatronModifications' and article requests 2 - Sign in as non-superlibrarian 3 - View plack log 4 - Refresh mainpage, see error in logs Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21907] Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- QA script: FAIL misc/maintenance/fix_tags_weight.pl OK critic FAIL forbidden patterns forbidden pattern: merge marker (===) (line 85) forbidden pattern: merge marker (===) (line 124) OK git manipulation Please fix! I also noticed that you can only tag an item with any emoticon once. If I try to add whale and then later add smiley I always get told I can't add the same twice. Is this related? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What|Removed |Added Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15774] Additional fields for baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #115 from Katrin Fischer --- I am sorry, but there are some conflicts. Please rebase, I'll try to come back to this soon: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15774: Add additional fields to order baskets Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt M serials/serials-search.pl M serials/subscription-add.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-add.pl CONFLICT (content): Merge conflict in serials/subscription-add.pl Auto-merging serials/serials-search.pl CONFLICT (content): Merge conflict in serials/serials-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc Auto-merging admin/additional-fields.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 15774: Add additional fields to order baskets The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15774-Add-additional-fields-to-order-baskets-LGaSot.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22266] New: Make layout name for patron card layouts a required field to avoid db error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22266 Bug ID: 22266 Summary: Make layout name for patron card layouts a required field to avoid db error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- When creating a new patron card layout the layout name is not a required field, but the layout won't save if it's left empty. There will also be an error in the log: Database returned the following error: Column 'layout_name' cannot be null at /home/vagrant/kohaclone/C4/Creators/Layout.pm line 183. Manage interface called an unsupported operation: save at /home/vagrant/kohaclone/patroncards/manage.pl line 103. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22266] Make layout name for patron card layouts a required field to avoid db error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22266 Katrin Fischer changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- I still see one: 1) Add a new patron layout, just entering the layout name 2) Change the Units CGI::param called in list context from /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. 3) Delete layout CGI::param called in list context from /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. I don't seem to be able to make them appear consistently. Can you take a look? (Marking failed QA, to get your attention ;) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17186] Error duplicate bibliography when saving new record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17186 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Hardware|PC |All Severity|enhancement |major Resolution|--- |WONTFIX OS|Windows |All --- Comment #1 from Katrin Fischer --- Koha version 3.18 is no longer maintained. Please reopen if this problem still occurs for you in newer versons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11031] Delete useless 9XX field in french unimarc public library default Framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11031 Katrin Fischer changed: What|Removed |Added CC||alex.arn...@biblibre.com, ||katrin.fisc...@bsz-bw.de, ||sonia.bo...@univ-lyon3.fr, ||victor.grous...@biblibre.co ||m --- Comment #1 from Katrin Fischer --- Adding some UNIMARC users I know - Is this bug still valid? Shoudl the 9xx be removed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7052] print button confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7052 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- The print button still shows, but as it's a pull down listing all available options, it seems clear enough to me. Please reopen if you think a change is still desirable. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22267] New: Warns in logs when adding and editing descriptions to batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267 Bug ID: 22267 Summary: Warns in logs when adding and editing descriptions to batches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswon...@foundations.edu Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Target Milestone: --- To test: Watch logs while: - Add new patron card batch - Fill in description - Save description - Edit batch - Change description text and click save description Use of uninitialized value $description in string eq at /home/vagrant/kohaclone/svc/creator_batches line 60. Use of uninitialized value in string eq at /home/vagrant/kohaclone/svc/creator_batches line 60. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5169] name/rename label batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5169 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- I think this has been resolved by the ability to add descriptions to batches with bug 15766. *** This bug has been marked as a duplicate of bug 15766 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added CC||neng...@gmail.com --- Comment #62 from Katrin Fischer --- *** Bug 5169 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Blocks||22267 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267 [Bug 22267] Warns in logs when adding and editing descriptions to batches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22267] Warns in logs when adding and editing descriptions to batches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22267 Katrin Fischer changed: What|Removed |Added Depends on||15766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 [Bug 15766] Give label and patron card batches a description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Katrin Fischer changed: What|Removed |Added Summary|Changes to holds priority |Changes to holds priority |list should be logged for |list should be logged for |accountability. |accountability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18614] Add useful CSS classes to the *detail.pl pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18614 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Mason, I think this bug is a bit too general as of now. I'll close it, please reopen if you have more information! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16627] Show library and date of patron requests for update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16627 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- The information now displays: koha - Board (Centerville) (42) - Requested on 03.02.2019 12:05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 --- Comment #2 from Katrin Fischer --- Still valid, holds log doesn't log changes to priority. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9598] Ability to split up shipping cost between all items and funds on an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9598 Katrin Fischer changed: What|Removed |Added Summary|pro-rate shipping |Ability to split up ||shipping cost between all ||items and funds on an ||invoice CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|17.05 |master Summary|Categories.pl allows users |Enrollment period date on |to set the |patron category can be set |enrolementperioddate to |in the past without any |before the current date |error/warning messages |without any error/warning | |messages| --- Comment #2 from Katrin Fischer --- Still valid, resetting to master and rephrasing/shortening bug title a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16487] Cataloging/Authority search: add link to number of times used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16487 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.20|master --- Comment #1 from Katrin Fischer --- I wonder, as this is in a pop-up if it would be possible to open results in a new tab in the 'origin' window? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all holds' button on holds over report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
Summary|Cancel all holds button |Make it easy to hide
|text needs .class or at |'Cancel all holds' button
|least an html tag. |on holds over report
--- Comment #2 from Katrin Fischer ---
You can already hide the button with:
form[name=cancelAllReserve] { display:none; }
But this leaves the text that and is a syntax not everyone might be familiar
with. I suggest to wrap both into a span that will make things easier.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5938] Maximum number of issues across a family group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5938 Mark Alexander changed: What|Removed |Added CC||ma...@pobox.com --- Comment #7 from Mark Alexander --- Our library may have an interest in a family group feature, but rather than having a system-level setting for maximum issues per group, we would need to have circulation rules for family groups. As an example, our library has an informal rule that says: no more than two issues of item type DVD allowed per household. There was no automated way to enforce this rule when we were using Mandarin, nor is there a way using Koha now. Instead, it depends on the librarian (or volunteer desk staff) knowing everybody in this small town and performing the restriction manually. In practice I have never seen this rule enforced. In any case, to implement this rule, we would need to add a field to the circulation rule for item type DVD that specifies maximum issues per family group.But implementing this seems rather complex. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #10) > Hi, > > there is one noticeable and big difference: With the patch you see the > optgroups of budgets, even if there are no funds listed below. That makes > the list grow long, especially as it also includes the inactive ones by > default. > > Combinations I tested: > - Active budget with multi-level funds - ok > - Inactive budget with fund - not ok, budget is listed > - Locked budget with fund - not ok, budget is listed > - Active budget with funds that are not accessible by permission > (restricted to owner) - not ok > This would for example be used to separate budgets and funds of different > libraries in a system and could also make the list quite long. > > I really like the idea of this improvement, but I think we are not there yet. Do you know if this is comparable to orderreceive.tt? My original plan was just to bring parcels.tt and newemptyorder.tt in line with that template. Did inactive and locked budgets not show before the patch? I'm not sure I understand the "accessible by permission" part. I think the code for that is identical before and after the patch? If the list were long, I would think having optgroup tags would be essential for organising them? Otherwise the select list would be difficult to navigate. I'm not sure that I understand this part of the feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #12 from David Cook --- This is a change that I already manage locally so I'm probably unlikely to revise this patch any time soon. I'll remove myself as Assignee, but re-add myself if I do find myself with some time to try again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22263] Command line script to populate or update items.cn_sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22263 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21447 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83406|0 |1 is obsolete|| --- Comment #69 from Aleisha Amohia --- Created attachment 84684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84684&action=edit Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326
Aleisha Amohia changed:
What|Removed |Added
Attachment #83410|0 |1
is obsolete||
--- Comment #73 from Aleisha Amohia ---
Created attachment 84688
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84688&action=edit
Bug 15326: (follow-up) Code review fixes
Addresses the following issues:
b) In opac-cmspages there is:
+flagsrequired => { borrow => 1 },
The borrow permission has been removed since. (blocker)
c) Comment was removed unnecessarily, just needs to be moved into
its right spot below again:
-# If GoogleIndicTransliteration system preference is On Set
parameter to load Google's javascript in OPAC search screens
d) One file uses qw( -utf-8) but another does not:
+use CGI;
+use CGI qw( -utf8 ); (blocker)
Signed-off-by: Michal Denar
Signed-off-by: Michal Denar
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #76 from Aleisha Amohia --- Created attachment 84691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84691&action=edit Bug 15326: Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #77 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #66) > Conflicts in the Schema changes part (should be a separate patch) Can you > please fix and maybe separate these changes out? > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 15326: Add CMS feature > Applying: Bug 15326: (follow-up) Add CMS feature > Using index info to reconstruct a base tree... > M Koha/Schema/Result/Branch.pm > Falling back to patching base and 3-way merge... > Removing t/Pages.t > Auto-merging Koha/Schema/Result/Branch.pm > CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 15326: (follow-up) Add CMS feature > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-15326-follow-up-Add-CMS-feature-E4XbRe.patch Rebased and moved schema fixes into a separate patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83407|0 |1 is obsolete|| --- Comment #70 from Aleisha Amohia --- Created attachment 84685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84685&action=edit Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83412|0 |1 is obsolete|| --- Comment #75 from Aleisha Amohia --- Created attachment 84690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84690&action=edit Bug 15326: (follow-up) Pages navigation fixes This is the best I've managed to do with the navigation. Would be happy for someone else to give it a go because I'm aware that some parent links repeat. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83408|0 |1 is obsolete|| --- Comment #71 from Aleisha Amohia --- Created attachment 84686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84686&action=edit Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83411|0 |1 is obsolete|| --- Comment #74 from Aleisha Amohia --- Created attachment 84689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84689&action=edit Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83404|0 |1 is obsolete|| --- Comment #67 from Aleisha Amohia --- Created attachment 84682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84682&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21447] Inventory lists incorrectly sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22263 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83405|0 |1 is obsolete|| --- Comment #68 from Aleisha Amohia --- Created attachment 84683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84683&action=edit Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What|Removed |Added Attachment #83409|0 |1 is obsolete|| --- Comment #72 from Aleisha Amohia --- Created attachment 84687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84687&action=edit Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21447] Inventory lists incorrectly sorted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21447 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > I feel if we agree this is a data issue, the bug could probably be closed? > I filed bug 22263 for adding a maintenance script. Sounds good to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22262] text/javascript responses should be compressed by Apache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22262 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21170] Warnings in MARCdetail.pl - isn't numeric in numeric eq (==)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21170 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15326] Add CMS feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #78 from Katrin Fischer --- Hi Aleisha, you can usually set back to "Signed off" after a rebase if it was before (unless you feel the changes were too heavy and should be retested) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #13 from Katrin Fischer --- I wrote difference because the behaviour is different to the already existing drop down on receive. This one works correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #14 from Katrin Fischer --- "By permission" would for example be a fund managed by another library in the system that is restricted to users, owners and staff patrons from this library. With you patch I seee the budget, even if I can't order from any fund below it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- I raised this issue many years ago but I don't think there was any interest in fixing it. My original idea was to implement row locking in the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22259] If two catalogers work on same record, one overwrites the other
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22259 Katrin Fischer changed: What|Removed |Added Hardware|Other |All Version|18.05 |master CC||katrin.fisc...@bsz-bw.de OS|Windows |All --- Comment #2 from Katrin Fischer --- (In reply to David Cook from comment #1) > I raised this issue many years ago but I don't think there was any interest > in fixing it. I think the problem is not interest, we can easily agree that this is not a good situation. But it will also need funding and agreeing on the right method in order to be able to fix it. I think it's good the problem is on bugzilla now, thx Karin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3514] Returning items through patron Details tab doesn't activate all circulation functions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #115 from Katrin Fischer --- Aleisha, did you mean to sign-off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643
--- Comment #75 from Josef Moravec ---
Comment on attachment 81032
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81032
Bug 8643: Add important constraint to marc subfields
Review of attachment 81032:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8643&attachment=81032)
-
::: installer/data/mysql/atomicupdate/bug-8643-add_important_constraint.sql
@@ +6,5 @@
> +-- $dbh->do("ALTER TABLE marc_subfield_structure ADD COLUMN important
> TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory");
> +-- $dbh->do("ALTER TABLE marc_tag_structure ADD COLUMN important
> TINYINT(4) NOT NULL DEFAULT 0 AFTER mandatory");
> +-- print "Upgrade to $DBversion done (Bug 8643 - Add important
> constraint to marc subfields)\n";
> +-- SetVersion($DBversion);
> +-- }
The database update should be idempotent, make it all in perl and use
column_exists helper function, like this:
if( !column_exists( 'marc_subfield_structure', 'important' ) ) {
$dbh->do("ALTER TABLE ... ADD COLUMN ...");
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Josef Moravec changed: What|Removed |Added URL||https://wiki.koha-community ||.org/wiki/Checkouts_endpoin ||t_RFC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
