[Koha-bugs] [Bug 13552] Add debar option to batch patron modification

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91951|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 92104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92104&action=edit
Bug 13552: (follow-up) Add debar option to batch patron modification

As per test feedback I've changed wording from debarrment to restriction

Added insertion into the borrower_debarments table and removal from
borrower_debarments table (and borrowers.debarred and
borrowers.debarredcomment) when either 'Restriction
expiration' or 'Restriction comment' are ticket to be disabled/deleted.

Test plan (please follow this instead of following test plan in the
first patch):

1. Go to Tools > Batch patron modification

2. Input the cardnumbers of several (undebarred/unrestricted) patrons
and submit

3. Notice there is no input for setting Restriction expiration date or
Restriction comment

Also notice in the list of matching borrowers at the top of the page
there is no display of the 'Restriction expiration' or 'Restriction
comment' values for the patron

4. Apply patch

5. Restart memcached and plack

6. Refresh the page notice 'Restriction expiration' (a date picker
input) and 'Restriction comment'are now input options

Also notice in the table at the top of the page 'Restriction
expiration' and 'Restriction comment' are shown on the far right of the table
(you may need
to scroll to see this)

7. Pick a date in the 'Restriction expired' datepicker and write in text into
the 'Restriction comment' field and submit

8. Notice in the next loaded page the selected patrons have the
'Restriction expiration' and 'Restriction comment' values you entered

9. Query the borrower_debarments database table and check that the new
debarments are added to this table

10. Go back to the Batch patron modification page and re-input the same
cardnumbers

11. Write text into the 'Restriction comment' field and don't pick a
'Restriction expiration' value and submit

12. Notice in the next loaded page the selected patrons have the
'Restriction expiration' value of -12-31 and 'Restriction comment'
value you just entered

13. Query the borrowers table and notice the borrowers.debarred value
for the modified patrons is '-12-31' and the
borrower.debarredcomment is what you inputted in step 11

14. Query the borrower_debarments table and notice the expiration value
is NULL and the comment value is set to what you entered in step 11

Also note the addition of the new debarment has not removed the existing
debarment on the patrons

15. Click on the cardnumber link of one of the patrons and notice the red
text on their patron account page informing you they are restricted
until the date you set

16. In the Koha home directory enter Koha shell:
sudo koha-shell 

17. Run: prove xt

18. All tests should pass

19. Repeat step 10 and tick the checkbox beside the 'Restriction
expiration' field and submit

20. In the next loaded screen notice the 'Restricted expiration'and
'Restricted comment' are empty

Check the borrower_debarments table and notice all restrictions for the
patron are removed.

Check the borrowers table and notice the debarred and debarredcomment
fields are empty for the patrons

21. Repeat steps 10 and 11 to make a new restriction

22. Repeat step 19 and this time check the 'Restriction comment' field
and submit and observe that also clears the restriction in the next
loaded page, in the borrower_debarments and borrowers table

23. Sign off

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13552] Add debar option to batch patron modification

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91950|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 92103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92103&action=edit
Bug 13552: Add debar option to batch patron modification

Test plan:
1. Go to Tools > Batch patron modification

2. Input the cardnumbers of several (undebarred/unrestricted) patrons and
submit

3. Notice there is no input for setting a debarred until (restriction
expiration) date or debar comment

Also notice in the list of matching borrowers at the top of the page
there is no display of the debarred or debarredcomment values for the
patron

4. Apply patch

5. Restart memcached and plack

6. Refresh the page notice 'Debarred till' (a date picker input) and
'Debarred comment' are now input options

Also notice in the table at the top of the page  'Debarred till' and
'Debarred comment' are shown on the far right of the table (you may need
to scroll to see this)

7. Pick a date in the 'Debarred till' datepicker and write in text into
the 'Debarred comment' field and submit

8. Notice in the next loaded page the selected patrons have the
'Debarred till' and 'Debarred comment' values you entered

9. Click on the cardnumber link of one of the patrons and notice the red
text on their patron account page informing you they are restricted
until the date you set

10. In the Koha home directory enter Koha shell:
sudo koha-shell 

11. Run: prove xt

12. Confirm all tests pass

13. Sign off

Sponsored-By: Brimbank Library, Australia

Signed-off-by: Josef Moravec 

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13552] Add debar option to batch patron modification

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91722|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91456|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272

--- Comment #8 from Katrin Fischer  ---
Celaned up the bug a bit as the same patch was attached several times and
something happened to the subject. Will apply a cleaned up patch with all
sign-off lines. 

Emmi, I notice that you use:
Emmi 

That will make you show up as "Emmi" without your last name in the release
notes. Not sure if this was intended or if you might like to update your git
configuration!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #91839|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 92105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92105&action=edit
Bug 22272: Calendar: When entering date ranges grey out dates in the past from
the start date

In "Calendar" tool it's possible to pick dates before start
date as end date.

This patch sets end date calendars "minDate" as picked start day
to grey out past dates. Also reindents datepicker code for
better readability.

Test plan:
- Apply this patch
- Set start date from first calendar
- Set end date from second calendar
=> Dates before start date are greyed out

Signed-off-by: Nadine Pierre 
Signed-off-by: Lucas Gass 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22272] Calendar: When entering date ranges grey out dates in the past from the start date

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22272

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23436] Undefined named save backend in advanced editor

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23436] Save to 'undefined' showing in Advanced cataloging editor

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436

Katrin Fischer  changed:

   What|Removed |Added

Summary|Undefined named save|Save to 'undefined' showing
   |backend in advanced editor  |in Advanced cataloging
   ||editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23436] Save to 'undefined' showing in Advanced cataloging editor

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23436] Save to 'undefined' showing in Advanced cataloging editor

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #92047|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 92106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92106&action=edit
Bug 23436: add a label for duplicate backend

Reproduce issue:
 - Enable "EnableAdvancedCatalogingEditor" preference
 - Go to cataloguing and click on advanced editor
 - Click on the down arrow in "Save to catalog" menu
 - You should see an undefined named save backend

Test patch:
 - Enable "EnableAdvancedCatalogingEditor" preference
 - Go to cataloguing and click on advanced editor to save preference to
   the cookie
 - Click on the down arrow in "Save to catalog" menu
 - You should see a "Duplicate" named backend

Test Bug 16232 for no regression:
 - Search for a biblio in catalog
 - Click in "Edit record"
 - Advanced editor should appear.
   SUCCESS => browser url ends with #duplicate/{original biblionumber}
   => Title above toolbar is "Editing duplicate record of
  #{original biblionumber}"
 - Save
   SUCCESS => browser url ends with #catalog/{new biblionumber}
   => Title above toolbar is "Editing catalog record #{new
biblionumber}"

More test:
 - Search for a biblio in catalog
 - Click on "Edit record"
 - Advanced editor should appear
 - Click on the down arrow in "Save to catalog" menu and click on
   Duplicate,
 - Record should be saved as a new one (same behavior)

Signed-off-by: cori 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23440] New: Advanced cataloging editor: Don't show 'Duplicate' as an option when working on a new record

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23440

Bug ID: 23440
   Summary: Advanced cataloging editor: Don't show 'Duplicate' as
an option when working on a new record
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When working on a new record the Save to > Duplicate action makes no sense. We
should only show that when working on an existing record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23436] Save to 'undefined' showing in Advanced cataloging editor

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||23440


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23440
[Bug 23440] Advanced cataloging editor: Don't show 'Duplicate' as an option
when working on a new record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23440] Advanced cataloging editor: Don't show 'Duplicate' as an option when working on a new record

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23440

Katrin Fischer  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com
 Depends on||23436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436
[Bug 23436] Save to 'undefined' showing in Advanced cataloging editor
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23436] Save to 'undefined' showing in Advanced cataloging editor

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436

--- Comment #6 from Katrin Fischer  ---
I've filed a new bug for not showing the "Duplicate" option when working on a
new record: bug 23440

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23341] Hold Notes should allow for HTML tags

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23341

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #5)
> This has one caveat - patrons can enter these notes, not just staff, so this
> would open possibility of XSS attack
> 
> Talking internally we think we could filter the patron note on entry
> 
> Alternatively, we can split the note into a public_note and private_note -
> filter the public and display it to patrons, but don't filter the
> private_note and keep it only for staff

Do we know more about the use case for this? If it's about handling line breaks
like in the example from Jessica we could handle this easily without allowing
line breaks.

Otherwise I really like the idea of splitting into internal and public notes as
this would allow for more flexible use. Right now if you use the note publicly,
you don't have any way to make internal notes and this could easily go wrong. 

Should we reset status here to "In discussion"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #5 from Magnus Enger  ---
I see these warnings for updates, on 18.11.05.000. When I do this:

  elsif ($self->_is_column_numeric($col)) {  # do a numeric comparison if
datatype allows it
warn $col;
return $old == $new;
  }

it seems that the privacy_guarantor_checkouts field is the culprit. All the
borrowers in the database have a 0 value for this column, do maybe there is a
false assumption that the new patron data will always have a numeric value for
this field, but in fact it is just empty if it is not included in the imported
data?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025

--- Comment #6 from Magnus Enger  ---
Could something like this be a solution? 

  elsif ($new && $self->_is_column_numeric($col)) {  # do a numeric comparison
if datatype allows it
return $old == $new;
  }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23307] Add columns configuration to cataloguing/z3950_search.tt

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #7 from Martin Renvoize  ---
(In reply to George Williams (NEKLS) from comment #4)
> I was able to follow the test plan without encountering any errors.
> 
> I'd add, though, that it would be nice if the "Actions" column could be
> dropped from the export (it's about 200 characters wide and there's no way
> to turn it off and it adds no value to the export) and if the "Additional
> fields" column could be included in options with the "Column settings"
> button if AdditionalFieldsInZ3950ResultSearch is configured.

This looks like a distinct bug to me.. lets get that recorded.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23441] New: Export should not include the 'actions' column in Z3950 results.

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23441

Bug ID: 23441
   Summary: Export should not include the 'actions' column in
Z3950 results.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

As mentioned in bug 23307 

It would be nice if the "Actions" column could be dropped from the export (it's
about 200 characters wide and there's no way to turn it off and it adds no
value to the export) and if the "Additional fields" column could be included in
options with the "Column settings" button if
AdditionalFieldsInZ3950ResultSearch is configured.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23307] Add columns configuration to cataloguing/z3950_search.tt

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307

--- Comment #8 from Martin Renvoize  ---
Submitted as bug 23441

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23441] Export should not include the 'actions' column in Z3950 results.

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23441

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23442] New: Add a 'refund' option to the 'Pay' screen

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Bug ID: 23442
   Summary: Add a 'refund' option to the 'Pay' screen
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Bug 23354 adds a 'Pay' screen as the beginning of a 'Point of Sale' system.
Currently, it only allows for payment of items, but there are occasions where
librarians may need to issue a refund.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||23442


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' option to the 'Pay' screen
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23442] Add a 'refund' option to the 'Pay' screen

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|23442   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' option to the 'Pay' screen
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||23442


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' option to the 'Pay' screen
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23442] Add a 'refund' option to the 'Pay' screen

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20307] Language overlay for authorized values

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #33 from Katrin Fischer  ---
Hi Jonathan, 

starting QA here - not only a RM priority, but one of mine as well. I will try
to come back at this as long as necessary:

1) QA test tools:

There are some about POD, but I think those are valid:

 FAIL   admin/authorised_values.pl
   FAIL   valid
Can't locate Carp/Always.pm in @INC (you may need to install
the Carp::Always module) (@INC contains: /home/vagrant/kohaclone
/home/vagrant/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/var/lib/koha/kohadev/plugins) 

 FAIL   Koha/AuthorisedValues.pm

   FAIL   valid
Name "Koha::Schema::Result::AuthorisedValue::LANGUAGE" used
only once: possible typo 

2) Code review

a) C4/Search.pm
+$facet_label_value = $av->count ?
$av->next->opac_translated_description : ''; # FIXME: Why are we displaying the
opac description for staff?

I believe you are right here - this is a bug. Could be fixed here or later. Why
are we not dealing with this in the templates?

b) Koha/AuthorisedValue.pm

opac_translated_description and tranlated_description seem to have a lot of
duplicated code. Coudl it make sense to merge them with an interface parameter?

+my $descriptions = {
+lib  => $av->translated_description, # Rename with
opac_translated_description to avoid confusion
+opac_description => $av->opac_translated_description # Same with
translated_description
+};

Not sure what you meant with your comments here?

3) Testing

The admin page currently explodes:

Could not compile /home/vagrant/kohaclone/admin/authorised_values.pl: Can't
locate Carp/Always.pm in @INC (you may need to install the Carp::Always module)
(@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer
/home/vagrant/kohaclone/lib/installer /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1
/usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base
/var/lib/koha/kohadev/plugins) at
/home/vagrant/kohaclone/admin/authorised_values.pl line 27.
BEGIN failed--compilation aborted at
/home/vagrant/kohaclone/admin/authorised_values.pl line 27.
 at /usr/share/perl5/CGI/Compile.pm line 132


As I understand it, this is just the 'base' and then we will have to work
through the different AV categories... that about right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23442] Add a 'refund' option to the 'Pay' screen

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|23355   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19814] Batch Check-in function

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Rob Corp  changed:

   What|Removed |Added

 CC||robcorp...@gmail.com

--- Comment #4 from Rob Corp  ---
We'd find this useful too

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #91464|0   |1
is obsolete||

--- Comment #5 from Andrew Isherwood  ---
Created attachment 92107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92107&action=edit
Bug 23173: Add ILLCheckAvailability syspref

This patch adds the new syspref "ILLCheckAvailability"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #91465|0   |1
is obsolete||

--- Comment #6 from Andrew Isherwood  ---
Created attachment 92108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92108&action=edit
Bug 23173: Provide core infrastructure

This patch adds the required infrastructure to enable ILL availability
plugins to intercept the request creation process and, using the
supplied metadata, search for and display possible relevant items from
whichever availability plugins are installed.

Currently two availability plugins exist:

z39.50 - Searches any number of the Koha instance's configured Z targets
https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950

Unpaywall - Searches the Unpaywall API for possible open access versions
of the requested item
https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall

The Unpaywall plugin is intended to serve as a "reference" plugin as the
API it deals with is extremely simple

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

--- Comment #7 from Andrew Isherwood  ---
Rebased on top of latest master and merge conflicts resolved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings to YAML

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #7 from Fridolin SOMERS  ---
misc/search_tools/export_elasticsearch_mappings.pl is missing exec permissions
: 
chmod a+x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23324] Need an ISBN normalization routine

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #4 from Marcel de Rooy  ---
What about NormalizeISBN in C4/Koha ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |BLOCKED

--- Comment #6 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

--- Comment #8 from Marcel de Rooy  ---
Created attachment 92114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92114&action=edit
Bug 16219: (follow-up) Nicer message if params missing and note that they are
not combined

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

--- Comment #9 from Marcel de Rooy  ---
Created attachment 92115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92115&action=edit
Bug 16219: (QA follow-up) Tiny regex change

The parameter <<>> does not work. There should be text inside.
The construction .*? does not look good completely.
Replacing it by the stricter [^>]+ So, no greater than's and at least one.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #90363|0   |1
is obsolete||
  Attachment #91668|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 92113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92113&action=edit
Bug 16219: Add 'params' parameter to runreport.pl

To test:
 1 - Apply patch
 2 - Write a report that takes no variables
 3 - Run this using runreport.pl
perl misc/cronjobs/runreport.pl 1
 4 - Confirm results as expected
 5 - Write a report that takes one or more variables
 6 - Run using runreport.pl, but pass no params
 7 - You should get a SQL error
 8 - Now run passing the correct number of params
perl misc/cronjobs/runreport.pl --param first --param=2nd 2
 9 - Verify results as expected
10 - call runreport with no parameters
perl misc/cronjobs/runreport.pl
11 - Verify documentation is correct and helpful

Signed-off-by: Claire Gravely 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23324] Need an ISBN normalization routine

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23324] Need an ISBN normalization routine

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324

--- Comment #5 from Nick Clemens  ---
Created attachment 92116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92116&action=edit
Bug 23324:(QA follow-up) Use existing NormalizeISBN function

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23324] Need an ISBN normalization routine

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23324

--- Comment #6 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #4)
> What about NormalizeISBN in C4/Koha ?

I didn't know about that!  I altered these patches to use it. I think
eventually the whole routine should be moved here, but I elected to keep this
smaller as it affects stable (using ES) and prevents matching imports on ISBN -
I added a FIXME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16219] Runreport.pl should allow SQL parameters to be passed on the command line

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16219

--- Comment #10 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #9)
> Created attachment 92115 [details] [review]
> Bug 16219: (QA follow-up) Tiny regex change
> 
> The parameter <<>> does not work. There should be text inside.
> The construction .*? does not look good completely.
> Replacing it by the stricter [^>]+ So, no greater than's and at least one.
> 
> Signed-off-by: Marcel de Rooy 

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258

--- Comment #17 from Nick Clemens  ---
(In reply to Alex Arnaud from comment #16)
> All is working here and i don't have any QA warning.
> 
> But i have concerns about Bug 20589. This last disable searching on _all and
> could make this one useless. Am i right ?
> 
> if (yes) {
> Ere, David: Is there something planned to build these 2 bugs together ?
> }

Bug 20589 allows for specifying whether a specific field will be included in a
keyword search, so it removes _all but preserve functionality

This patch just extends the formats allowed for storing marc in the
'marc_record' field of the ES document so will work well with 20589. This would
actually allow for querying the full record if desired, and then 20589 would
allow excluding it from general searches to not affect relevancy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23441] Export should not include the 'actions' column in Z3950 results.

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23441

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23441] Export should not include the 'actions' column in Z3950 results.

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23441

--- Comment #1 from Owen Leonard  ---
Created attachment 92117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92117&action=edit
Bug 23441: Export should not include the 'actions' column in Z3950 results.

This patch adds the "noExport" class to the table header for the Z39.50
search results "Actions" column. This class prevents the column from
being included in DataTables export operations.

To test, apply the patch and perform a Z39.50 search from Cataloging. On
the search results page, click the "Export or print" button. Choose one
of the export options and verify that in the resulting data there is no
"Actions" column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

--- Comment #5 from Fridolin SOMERS  ---
Created attachment 92118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92118&action=edit
Bug 22997: Unit text

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #92118|0   |1
is obsolete||

--- Comment #6 from Fridolin SOMERS  ---
Created attachment 92119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92119&action=edit
Bug 22997: Unit test

Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to oldstable |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23431] having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23431

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #8 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #45 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #44)
> (In reply to Jonathan Druart from comment #42)
> > > Keep one file == Do not make a copy of the original upload to yet another
> > > location.
> > 
> > It will complexity the code a bit more, but I can try that if it is enough
> > to get a PQA stamp.
> 
> Maybe ask first another QA opinion before spending too much time on that..

I would agree with Marcel here, I don't see the need for copying the file if
all we really achieve is a different URL for the user. It seems a rewrite rule
could achieve this, though it wouldn't automatically be used when linking file

I feel like this needs to merge with the other two bugs as they are all solving
very closely related needs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23415] Notify patron fines when renewing

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415

Emmi Takkinen  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23229] "Get all requests" API call fired when loading any ILL page

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23229

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23363] Clicking on shipping cost invoice link from spent.pl causes internal server error

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23363

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #6 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #92051|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

--- Comment #148 from Alex Arnaud  ---
Created attachment 92120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92120&action=edit
Bug 18823: Fix save button size and show searchable backends only in search
result

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23206] Batch patron modification from reports which return cardnumber

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23206

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

--- Comment #8 from Fridolin SOMERS  ---
Depends on Bug 23197 not in 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23316] GetFine needs updating for bug 22521

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23316

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22249] Error when submitting Mana comment

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #12 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573
Bug 11573 depends on bug 19919, which changed state.

Bug 19919 Summary: Writing off a Lost Item Fee marks as "Paid for by patron"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759
Bug 6759 depends on bug 11573, which changed state.

Bug 11573 Summary: Fine descriptions related to Rentals are untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED

--- Comment #74 from Fridolin SOMERS  ---
Depends on Bug 19919 not in 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22715] Searching for patrons with "" in the circulation note hangs patron search

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22715
Bug 22715 depends on bug 20891, which changed state.

Bug 20891 Summary: Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23217] Batch patron modification shows database errors when no Attribute provided

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23217

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|19.11.00|19.11.00,19.05.03
released in||

--- Comment #12 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23226] Remove type attribute from script tags: Cataloging

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23226

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23345] Wrong parameter name in koha-dump usage statement

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23345

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23251] EDI Order line incorrectly terminated when it ends with a quoted apostrophe

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23251

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21518] Material type "three-dimensional artifact" displays as "visual material"

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21518

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10492] Translation problems with TT directives in po files

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #10 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23396] Rancor fails to load: insert_copyright is not defined

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23396

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|19.11.00|19.11.00,19.05.03
released in||

--- Comment #9 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

Since Bug 17178 is not in 19.05.x I have added a commit :
  Bug 23396: (19.05.x) remove toggle_keyboard comming from Bug 17178

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14549] Hold not removed when item is checked out to patron who is not next in priority list

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14549

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.03
released in||

--- Comment #17 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #36 from Fridolin SOMERS  ---
Enhancement not pushed to 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Bug 23049 depends on bug 22610, which changed state.

Bug 22610 Summary: SIP Payment Types should be moved out of accountype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|RESOLVED

--- Comment #242 from Fridolin SOMERS  ---
Enhancement not pushed to 19.05.x

Nice job, thanks all ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166
Bug 4166 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4164] Way to Clone Keyword Mapping to other Frameworks

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164
Bug 4164 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7384] keyword to marc mapping in emails

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384
Bug 7384 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7074] keyword mapping on checkin and checkout screen

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074
Bug 7074 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14911] Serial Subscr. and Item search: Display additional 245 subfields in search results

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911
Bug 14911 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22699] Remove documentation on Keywords to MARC mapping

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22699
Bug 22699 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8265] Allow a better form of the title to be included in notices

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265
Bug 8265 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10953] Missing subtitle fieldmapping unless you use ru-RU or uk-UA

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10953
Bug 10953 depends on bug 11529, which changed state.

Bug 11529 Summary: Add subtitle, medium and part fields to biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23099] OPAC Search result sorting "go" button flashes on page load

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23099

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin SOMERS  ---
Small enhancement, I choose to backport.
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23386] Add language of original in advanced search - staff client

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23386

Fridolin SOMERS  changed:

   What|Removed |Added

 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #5 from Fridolin SOMERS  ---
Small enhancement, I choose to backport.
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.03
released in||

--- Comment #7 from Fridolin SOMERS  ---
Nice enhancement.
I choose to backport so than Koha Plugins can already be developed/updated with
this.

Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23339] Reindent addbooks.tt

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23339

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

--- Comment #10 from Fridolin SOMERS  ---
Enhancement not pushed to 19.05.x

(Does not apply on 19.05.x)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22741] Koha::Patron->store must not log updated_on changes (random failure of test BorrowerLogs and TrackLastPatronActivity)

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #35 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16357] Plack error logs are not time stamped

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357

Danielle Elder  changed:

   What|Removed |Added

 CC||danielle@bywatersolutions.c
   ||om

--- Comment #40 from Danielle Elder  ---
1+ split logs please

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23405] Circulation autocomplete for patron lookup broken if cardnumber is empty

2019-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23405

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.03
released in||
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >