[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What|Removed |Added Attachment #96812|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 102447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102447=edit Bug 20816: Make SIP tests pass under ES -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23349] Merge records from a search result (catalog/search.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 --- Comment #9 from Jonathan Druart --- It passes for me, sample data using koha-testing-docker. Maybe you have a circ rule or a pref that is blocking the checkin? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #23 from Jonathan Druart --- Created attachment 102458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102458=edit Bug 24964: [19.11.x] Do not filter patrons after they have been fetched The svc/members/search script is called in different places. In some places (Set owner for a fund, add users to a fund, or set a manager to a suggestion), we need patrons to be filtered depending on the permissions they have. For instance you can only set a fund's owner with a patron that has acquisition.order_manage. Currently we have fetching X (default 20) patrons, then filter them depending on their permission. Says you have 3 patrons that have the correct permissions but are not in the 20 first patrons, if you do not define a search term, the search result will be empty. This is not ideal and we should filter when requesting the DB. Test plan: - Have more than 20 patrons, remove them their permissions - Create 3 more: 1 superlibrarian 1 with the full acq permission 1 with acquisition.order_manage - Create a fund and set a owner - Search for patrons, without specifying a search term (to get them all) => Without this patch the new patrons you created are not displayed => With this patch they are! Same test plan apply to set a manager to a suggestion (freshly pushed, see bug 23590), with suggestions and suggestions.suggestions_manage Note: The code has been written that way to rely on C4::Auth::haspermission, but the SQL query is quite trivial and the gain is important. Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 didier changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #10 from didier --- (In reply to Devinim from comment #8) > This patch did not work for us when we applied it, in vagrant environment > with Firefox 74 . Hi Windows/Mac Firefox or Linux? I retested with linux firefox 74.0.1, 2020-04-06 kodadevbox and it works for me. One point, do you remember if you could collapse the fund tree in /cgi-bin/koha/admin/aqbudgets.pl ? I modified the test plan, replaced Add a child fund to fund Book With what is in the option: Book fund Actions: Edit, Delete, Add sub fund Add a sub-fund to fund Book -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #22 from Jonathan Druart --- Created attachment 102457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102457=edit Bug 24964: [19.11.x] Add tests Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772 --- Comment #4 from Hannah Olsen --- (In reply to Hannah Olsen from comment #3) > (In reply to Katrin Fischer from comment #2) > > I think this might be duplicate to bug 23727 > > We saw that one, but that bug involves trying to edit items within the > course reserve and have those changes reflected in the reserve without > removing the item and re-adding it. The behavior here is related to > deactivating and deleting courses and what happens to the values that were > changed in the reserves module. Reviewing that bug again and some of the later info, maybe it is related to the same problematic table? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 --- Comment #10 from Katrin Fischer --- Good question - not sure. Are there candidates? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25027] Result browser should not overload onclick event
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027 Nick Clemens changed: What|Removed |Added Attachment #102252|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 102446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102446=edit Bug 25027: Use localStorage instead of sessionStorage for results browser Staff side, when a search a done and a result clicked, a browser appears on the left, to navigate between the different results. We use sessionStorage to know the list of biblionumber from the result. As sessionStorage is only for the current tab, we do some ugly things, to catch the click events, then open the new tab, attach it to the current window, and put the focus back on the result list. We really should not do that, and let the user decide what they want to do with their clicks! To do so, let use the correct storage, localStorage, and have the results shared between the windows. We may need to clear that at some point, isn't it? Test plan: Launch a search, click result (left or middle), confirm you see the browser and that the window/tab opened like any other websites (depending on your web browser settings). Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #8 from Jonathan Druart --- Created attachment 102450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102450=edit Bug 22087: Add a no_line_break parameter to prevent new lines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #7 from Jonathan Druart --- Created attachment 102449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102449=edit Bug 22087: Add space between zipcode and country -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #24 from Jonathan Druart --- Created attachment 102459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102459=edit Bug 24964: [19.11.x] Prevent random failures sorting by borrowernumber Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #27 from Jonathan Druart --- (In reply to Joy Nelson from comment #17) > does not apply to 19.11.x branch. not backported > please rebase if needed. Patches rebased for 19.11.x. Please give them a try before pushing them. Let me know if you have any questions! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #25 from Jonathan Druart --- Created attachment 102460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102460=edit Bug 24964: [19.11.x] Fix perl critic warning Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #26 from Jonathan Druart --- Created attachment 102461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102461=edit Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only retrieve patrons with acq (order_manage) permissions. The original bug was hidden in the existing code, but the behavior was terrible. To prevent patrons matching the permissions contrainst to be hidden, we fetched ALL the patrons from the DB, then filtered them depending on their permissions. This might have awful performance on DB with lot of patrons. So basically with this patch we are adding the pagination back to the "owner/users for funds" feature, as the permission filtering is now done at DB level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Marcel de Rooy changed: What|Removed |Added Severity|normal |major --- Comment #16 from Marcel de Rooy --- Updating severity for potential data loss (although the C->B, B->A merge might not be that common, fortunately) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25071] New: Explain close budget vs make budget inactive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25071 Bug ID: 25071 Summary: Explain close budget vs make budget inactive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I noticed that if you try to close a budget with no unreceived orders, it doesn't work. You have to go edit the budget and make it inactive. I didn't test to see if you close a budget with unreceived orders, if it also makes it inactive or if you have to edit the budget to make it inactive after rolling over your unreceived orders. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Attachment #102064|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 102448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102448=edit Bug 22087: Use include file to display patrons address in search result In order to display the city and country in the patron search result, we need to use the member-display-address-style include file, to satisfy AddressFormat. Test plan: Modify some patrons and fill the different address info Search for them and notice that the city, zipcode and country are now displayed. Modify the value of AddressFormat and confirm that the display is modified according to its value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #9 from Jonathan Druart --- Created attachment 102451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102451=edit Bug 22087: DO NOT PUSH - CSS changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Jonathan Druart changed: What|Removed |Added Depends on||25070 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Keywords|Academy | --- Comment #10 from Jonathan Druart --- Hello David, could you test these patches? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 [Bug 25070] Include files to display address and contact must be refactored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Jonathan Druart changed: What|Removed |Added Blocks||22087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 [Bug 22087] It would be helpful to have City and State visible in member.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24772] Deactivating Course Reserves reverts Item's Shelving Location, then deleting the same course reverts Course Reserve Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24772 --- Comment #3 from Hannah Olsen --- (In reply to Katrin Fischer from comment #2) > I think this might be duplicate to bug 23727 We saw that one, but that bug involves trying to edit items within the course reserve and have those changes reflected in the reserve without removing the item and re-adding it. The behavior here is related to deactivating and deleting courses and what happens to the values that were changed in the reserves module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||and...@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- The ES patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24866] Display budget hierarchy in the budget dropdown menu used when placing a new order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24866 didier changed: What|Removed |Added Attachment #102399|0 |1 is obsolete|| --- Comment #9 from didier --- Created attachment 102453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102453=edit Bug 24866: Display budget hierarchy in the budget dropdown menu used when placing a new order The rendering of SELECT elements is up to the browser. But Bug 16123 CSS code 'style="padding-left: xx' doesn't work on modern browsers. This patch replace CSS style attribute with html entity. On supported platforms TEST PLAN : 1. Go to the Administration module 2. Add a new budget (ie : Budget 2020) 3. Add a fund to this budget (ie : Book) 4. Add a sub-fund to fund Book (ie : Adult fiction) You will have this hierarchy : Budget 2020 | Book |_ Adult fiction 5. Go to the Acquisition module 6. Select a vendor and create a new basket 7. Place an order 8. Check the budget dropdown menu BEFORE PATCH Book Adult fiction OR Book Adult fiction AFTER PATCH Book Adult fiction Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 Katrin Fischer changed: What|Removed |Added Attachment #100550|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 102452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102452=edit Bug 24800: Handle inexistent return date on self checking See bug 24800 comment 0 for a description of the problem. We do not want the SIP server to crash if it receives a checkin request with a return date that is not given. The option this patch chose is to parse it only if provided. Signed-off-by: Clemens Elmlinger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #19 from Andrew Nugged --- (In reply to Jonathan Druart from comment #18) > We should not reuse OpacMaxItemsToDisplay but create a new pref here. I will separate this ticket into two – First one, current, will be without GUI update, but to fix this "ModZebra" call with ElasticSearch enabled which takes really crazy amount of time to perform. Second one – I will create another ticket – with pref or with API/ajax pagination or some other solution (we will decide I will think + ask in IRC/etc), it's really separated update so ok to have major speed affecting this one ModZebra issue, publishing updated patch + explanation: ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25027] Result browser should not overload onclick event
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25027 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 --- Comment #4 from Katrin Fischer --- (In reply to Jonathan Druart from comment #3) > Katrin, do you think this patch fix correctly the problem you faced? We tested the patch and we think it's a clear improvement. It's not a complete fix for us missing an "undo" feature that would allow us to highlight the problematic returns, but it prevents SIP from dying, which I think is the most important for now. I suggest to file a separate enhancement request after this fix is pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25069] AddressFormat="fr" behavior is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25069
Owen Leonard changed:
What|Removed |Added
Attachment #102437|0 |1
is obsolete||
--- Comment #3 from Owen Leonard ---
Created attachment 102454
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102454=edit
Bug 25069: Fix AddressFormat="fr" behavior
Something went wrong during a rebase of bug 13618
commit dcd1f5d48c758aee17b6c6f069c6146b42efe117
Bug 13618: Add html filters to all the variables
Several changes related to AddressFormat are wrong:
-[% IF Koha.Preference( 'AddressFormat' ) %]
-[% INCLUDE "member-main-address-style-${ Koha.Preference(
'AddressFormat' ) }.inc" %]
-[% ELSE %]
-[% INCLUDE 'member-main-address-style-us.inc' %]
-[% END %]
+[% SWITCH Koha.Preference( 'AddressFormat' ) %]
+[% CASE 'de' %]
+[% INCLUDE 'member-main-address-style-de.inc' %]
+[% CASE # us %]
+[% INCLUDE 'member-main-address-style-us.inc' %]
+ [% END %]
Test plan:
Create a patron with all the address fields filled
Play with the 3 option values of AddressFormat, and confirm that the address is
displayed correctly
on the patron's view, and in the patron module (top left)
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25069] AddressFormat="fr" behavior is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25069 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25041] Links to 'pending' #ASKED tab in suggestions.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Nick Clemens changed: What|Removed |Added Attachment #102402|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 102462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102462=edit Bug 25041: Restore #ASKED anchor in suggestions table On commit 4494e8ba6ca7d28972fcc1161c680ecf0b091f62 Bug 23594: Batch modification for itemtypes on suggestions page The anchors of the tabs on suggestion.pl has been replaced with tab_$count instead of the status code. There was a need at the time, but I cannot remember it. I restored the previous behavior, and did not find any regressions. Test plan: 1 - Add several suggestions to Koha 2 - Set them in different status, leaving at least one pending 3 - Go to home page, note it shows count of pending 4 - Click the link on home page 5 - It takes you to correct tab Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25041] Links to 'pending' #ASKED tab in suggestions.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25041 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 --- Comment #1 from Owen Leonard --- Created attachment 102463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102463=edit Bug 24958: Remember last selected tab in SQL reports This patch modifies the saved reports page so that it remembers, for the duration of the browser session, the last active tab. To test you should have multiple reports in multiple report groups. Apply the patch and go to Reports -> Saved reports. - Select a tab to filter the table of saved reports to a particular report group. - Navigate away from the page - Return to the save reports page. The tab you previously selected should be selected again. - Restart your browser and return to the saved reports page. The tab should no longer be preselected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22437] Subsequent authority merges in cron may cause biblios to lose authority information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6393] Ability to pick which records to import from staged record lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6393 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 Katrin Fischer changed: What|Removed |Added Attachment #102452|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 102456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102456=edit Bug 24800: Handle inexistent return date on self checking See bug 24800 comment 0 for a description of the problem. We do not want the SIP server to crash if it receives a checkin request with a return date that is not given. The option this patch chose is to parse it only if provided. Signed-off-by: Clemens Elmlinger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 Katrin Fischer changed: What|Removed |Added Attachment #100549|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 102455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102455=edit Bug 24800: Add tests Signed-off-by: Clemens Elmlinger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24800] Koha does incomplete checkin when no return date is provided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24800 --- Comment #8 from Katrin Fischer --- As written before, this worked in our testing, but sadly the tests fail for me: t/db_dependent/SIP/Transaction.t .. 8/8 # Failed test 'Checkin should have been done successfully' # at t/db_dependent/SIP/Transaction.t line 323. # got: '1' # expected: '0' # Looks like you failed 2 tests of 8. t/db_dependent/SIP/Transaction.t .. 8/8 # Failed test 'do_checkin' # at t/db_dependent/SIP/Transaction.t line 324. # Looks like you failed 1 test of 8. t/db_dependent/SIP/Transaction.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests Keeping the sign off, but could you take a look please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24027] Adding multiple items is slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027
Andrew Nugged changed:
What|Removed |Added
Attachment #98252|0 |1
is obsolete||
Attachment #98253|0 |1
is obsolete||
--- Comment #20 from Andrew Nugged ---
Created attachment 102464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102464=edit
Bug 24027: Call ModZebra once after all items added/deleted in a batch
Issue description:
- call to ModZebra was unconditional inside 'store' method for Koha::Item,
so it was after each item added, or deleted.
- ModZebra called with param biblionumber, so it is the same parameter
across calls for each items with same biblionumber, especially when we
adding/removing in a batch.
- with ElasticSearch enabled this makes even more significant load
and it is also progressively grows when more items already in DB
Solution:
- to add extra parameter 'skip_modzebra_update' and propagate it down to
'store' method call to prevent call of ModZebra,
- but to call ModZebra once after the whole batch loop in the upper layer
Test plan / how to replicate:
- make sure that you have in the admin settings "SearchEngine" set to
"Elasticsearch" and your ES is configured and working
( /cgi-bin/koha/admin/preferences.pl?op=search=SearchEngine )
- select one of biblioitems without items
( /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXX )
- press button "add multiple copies of this item",
- enter 200 items, start measuring time and submit the page/form...
On my test machine when adding 200 items 3 times in a row (so 600 in
total, but to show that time grows with every next batch gradually):
WHEN ElasticSearch DISABLED (only Zebra queue):
- 9s, 12s, 13s
WHEN ElasticSearch ENABLED:
- 1.3m, 3.2m, 4.8m
WITH PATCH WHEN ElasticSearch ENABLED:
- 10s, 13s, 15s
Same slowness (because also same call to ModZebra) happens when you try
to delete items in a batch or delete all items ("op=delallitems"). And same
fix.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind changed: What|Removed |Added Text to go in the||This enhancement lets you release notes||place and an item level ||hold from a search results ||list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 David Nind changed: What|Removed |Added Attachment #102080|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 102465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102465=edit Bug 24820: Use 'date' instead of 'timestamp' for cashup Prior to this patch we were comparing cash register action timestamp to accountlines date fields to fetch the list of outstanding accountlines. accountlines.date is a transient field used as 'updated_on' and so this was a logical mistake. We should be using the 'date' field which is fixed 'created_on' time. To test, make sure the cash register and record cashup features works as expected. Test plan: 1) Enable EnablePointOfSale and UseCashRegisters system preferences. 2) Add a cash register (Koha Administration > Accounting > Cash registers > New cash register). 3) From the Point of sale screen add two new items for purchase (Point of sale > Administration > Configure items for purchase > add new debit types). 4) Add some transactions. 5) Record a cashup (Register details > Record cashup). 6) Repeat steps 4-5 at least once. 7) Everyting should work as expected. 8) Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr --- Comment #2 from Devinim --- Hi Owen, The previously selected tab became selected. However, the data is incorrect. The listed reports came from "All" tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #11 from David Roberts --- Created attachment 102466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102466=edit Mangled display of patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #12 from David Roberts --- Hi, I've tested but the search results screen is mangled. Firstly, there are no spaces between the address elements. This is also true when you display a single patron. Secondly, my search returns two users, but the usernames of each have got confused (see screenshot). Also, when I go to edit one of the users, I get an error: Software error: Template process failed: file error - member-alt-contact-style-us: not found at /home/david/kohaclone/C4/Templates.pm line 122. For help, please send mail to the webmaster (webmas...@ptfs-europe.co.uk), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 mada...@ckls.org changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 David Roberts changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 --- Comment #10 from David Nind --- Thanks Martin for fixing the cashup error! > I'm also getting an error when I try to display older transactions on the > Point of sale > Register details screen as well. There is still an error occurring in the 'Older transactions' section for the point of sale system on the register details screen - this error occurs when you select a date range for transactions: Template process failed: undef error - The given date (04/06/2020) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 168. at /kohadevbox/koha/C4/Templates.pm line 122 in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 122 119: 120: my $data; 121: binmode( STDOUT, ":utf8" ); 122: $template->process( $self->filename, $vars, \$data ) 123: || die "Template process failed: ", $template->error(); 124: return $data; 125: } Show function arguments in (eval) at /kohadevbox/koha/pos/register.pl line 146 143: } 144: } 145: 146: output_html_with_http_headers( $input, $cookie, $template->output ); in CGI::Compile::ROOT::kohadevbox_koha_pos_register_2epl::__ANON__ at /kohadevbox/koha/pos/register.pl line 2 1: #!/usr/bin/perl . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24740] use biblio title if available rather than biblio number in OPAC search result cover images tooltips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24740 --- Comment #12 from didier --- Hi, (In reply to Stina Hallin from comment #11) > Hi, yes I'm using Bywaters sandbox. I used it with my library's account with > syndetics to display covers. I haven't a syndetics account but have you an e-books or films' biblionumbers not showing tips? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24958] Remember last selected tab in SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25046] C4::Utils::DataTables::Members does not SELECT othernames from borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25046 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25046] C4::Utils::DataTables::Members does not SELECT othernames from borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25046 Devinim changed: What|Removed |Added Attachment #102304|0 |1 is obsolete|| --- Comment #2 from Devinim --- Created attachment 102467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102467=edit Bug 25046: Include borrowers.othernames in SELECT statement In C4/Utils/DataTables/Members.pm, the SELECT statement that fetches patron data from the database does not include borrowers.othernames in the field list. As a consequence, when the output is in the form of a DataTable, the Template Toolkit files that refer to .othernames (such as the patron-title.inc include) won't display the information from the 'Other name' input field if that field has been filled in. This patch fixes that. Test plan: 0) Have a few patrons with some data in the 'Other name' field. 1) Perform a generic search in Home > Patrons to ensure you will get a DataTable with results. 2) Observe that the 'Name' column does not include 'Other name' info. 3) Apply the patch, and restart Plack if necessary. 4) Repeat your search: this time you should see the information from the 'Other name' field, it will be next to the patron's First name and within parentheses. Sponsored-by: Eugenides Foundation Library Signed-off-by: Devinim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067 --- Comment #4 from Katrin Fischer --- Thx Julian. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111 Aleisha Amohia changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |alei...@catalyst.net.nz Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20359] Auto-Renew notice not able to pull branch information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20359 --- Comment #4 from Katrin Fischer --- (In reply to Jonathan Druart from comment #3) > Item's home branch:[% biblio.item.home_branch.branchname %] > Item's holding branch: [% biblio.item.holding_branch.branchname %] Thank you! Andrew, does this 'fix' the reported issue for you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #102447|0 |1 is obsolete|| --- Comment #10 from Andrew Fuerste-Henry --- Created attachment 102470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102470=edit Bug 20816: Make SIP tests pass under ES Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #96811|0 |1 is obsolete|| --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 102469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102469=edit Bug 20816: Add ability to define custom templated fields in SIP patron responses To test: 1 - You will need to enable SIP on your testing instance cp etc/SIPconfig.xml /etc/koha/sites/kohadev/ sudo koha-start-sip add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works) on koha-testing-docker you should be able to start sip with user koha/koha without any adjustments 2 - If you copied the above file you should be set to get custom field DE with dateexpiry Otherwise edit the sip login for the user to have a custom section like: 3 - send a status test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_status_request 4 - send an information test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_information 5 - confirm you receive the DE field with a dateexpiry 6 - Add your own custom fields and confirm it works with several 7 - prove -v t/db_dependent/SIP/Patron.t 8 - prove -v t/db_dependent/SIP/ Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25072] New: Printing details.tt is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25072 Bug ID: 25072 Summary: Printing details.tt is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When printing the details.tt page on the staff client there is a large amount of white space on the left side. Looking at print.css, we hide #menu but it (or something else) still looks to be taking up space on the left. TO RECREATE: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25046] C4::Utils::DataTables::Members does not SELECT othernames from borrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25046 Devinim changed: What|Removed |Added CC||kohadevi...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20359] Auto-Renew notice not able to pull branch information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20359 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Andrew Fuerste-Henry --- Works for me, thanks all! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23349] Add batch operations to staff interface catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 --- Comment #1 from Owen Leonard --- Created attachment 102468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102468=edit Bug 23349: Add batch operations to staff interface catalog search results This patch adds three new options to the staff interface catalog search results for users with cataloging permission: batch edit, batch delete, and merge. The choices are found in an "Edit" menu which is disabled by default. Checking any boxes in the search results table enables the button. To test, apply the patch and log in to Koha as a user with edit_catalogue permission. - Perform a search in the catalog - You should see a disabled "Edit" button in the toolbar at the top of the search results table. - Check a single checkbox. The button should become enabled. - Test the "Batch edit" and "Batch delete" menu items. They should work correctly. - Test the "Merge records" item. It should warn you that you must select at least two records. - Check more than one checkbox and test each menu item again. All should work as expected. - Log in to the staff client as a user who does not have edit_catalogue permission. The "Edit" menu should no longer appear on the search results page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23349] Add batch operations to staff interface catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #19 from Alex Buckley --- Many thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23349] Add batch operations to staff interface catalog search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED Summary|Merge records from a search |Add batch operations to |result (catalog/search.pl) |staff interface catalog ||search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25073] New: Pepeq
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25073 Bug ID: 25073 Summary: Pepeq Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dhittamva...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 102472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102472=edit Ppq -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 --- Comment #3 from David Roberts --- Created attachment 102471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102471=edit Bug 23119: MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a This patch makes the subfield i display before subfield a in the 246 and 730 fields To test: 1) Create a bibliographic record with data in several subfields in tags 246 and 730. 2) See that subfield i displays at the end of the field in the 246 field, and probably not at all in the 730 field. Check in both the OPAC and staff client 3) Apply the patch. 4) Check your bib record again in both clients. Subfield i should now display before subfield a. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 David Roberts changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #4 from David Roberts --- I've moved subfield i in the 246 field to the start of the field, and kept the existing punctuation (square brackets). I've also added subfield i to the 730 field as it previously didn't display. This subfield is delivered in the BK framework (although hidden by default), but not delivered at all in the Default framework. I have no idea if the punctuation is correct for this field - I've enclosed it in square brackets to be the same as the 246 field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25074] New: Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25074 Bug ID: 25074 Summary: Bug Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: denimardiansyah...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 102473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102473=edit Qimack -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23119] MARC21 added title 246, 730 subfield i displays out of order, and should display before subfield a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23119 --- Comment #2 from David Roberts --- I'm wrong, we do deliver it in the 246 (it displays in square brackets -no idea if this is correct or not), and it is in the Default framework. It's not in the framework for the 730 though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25069] AddressFormat="fr" behavior is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25069
--- Comment #1 from Jonathan Druart
---
Created attachment 102436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102436=edit
Bug 25069: Fix AddressFormat="fr" behavior
Something went wrong during a rebase of bug 13618
commit dcd1f5d48c758aee17b6c6f069c6146b42efe117
Bug 13618: Add html filters to all the variables
Several changes related to AddressFormat are wrong:
-[% IF Koha.Preference( 'AddressFormat' ) %]
-[% INCLUDE "member-main-address-style-${ Koha.Preference(
'AddressFormat' ) }.inc" %]
-[% ELSE %]
-[% INCLUDE 'member-main-address-style-us.inc' %]
-[% END %]
+[% SWITCH Koha.Preference( 'AddressFormat' ) %]
+[% CASE 'de' %]
+[% INCLUDE 'member-main-address-style-de.inc' %]
+[% CASE # us %]
+[% INCLUDE 'member-main-address-style-us.inc' %]
+ [% END %]
Test plan:
Create a patron with all the address fields filled
Play with the 3 option values of AddressFormat, and confirm that the address is
displayed correctly
on the patron's view, and in the patron module (top left)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25069] AddressFormat="fr" behavior is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25069 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25018] Jenkins is not running the test with $ENV{_} eq 'prove'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018 Jonathan Druart changed: What|Removed |Added Depends on||22001 --- Comment #5 from Jonathan Druart --- I forgot the dependency. This patch is a follow-up of bug 22001. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001 [Bug 22001] RaiseError and PrintError flags must be set for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22001] RaiseError and PrintError flags must be set for tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001
Jonathan Druart changed:
What|Removed |Added
Blocks||25018
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25018
[Bug 25018] Jenkins is not running the test with $ENV{_} eq 'prove'
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point of sale system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point of sale system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492 --- Comment #12 from Martin Renvoize --- Created attachment 102433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102433=edit Bug 24492: (RM follow-up) Varaible name corretion Bug 24492 was not correctly rebased after bug 23355 and did not account for a variable name change in the 'add_cashup' action. This patch deals with that. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 --- Comment #8 from Martin Renvoize --- The bug with cashup on the branch details page has now been corrected in master. Well spotted, it was a rebase error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #18 from Jonathan Druart --- Created attachment 102434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102434=edit Bug 24964: Do not fetch all patrons for owner/users of funds admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only retrieve patrons with acq (order_manage) permissions. The original bug was hidden in the existing code, but the behavior was terrible. To prevent patrons matching the permissions contrainst to be hidden, we fetched ALL the patrons from the DB, then filtered them depending on their permissions. This might have awful performance on DB with lot of patrons. So basically with this patch we are adding the pagination back to the "owner/users for funds" feature, as the permission filtering is now done at DB level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #19 from Jonathan Druart --- (In reply to Joy Nelson from comment #17) > does not apply to 19.11.x branch. not backported > please rebase if needed. I found something when rebasing this for 19.11. I will wait for the last follow-up to be pushed to master before submitting the rebased patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 Jonathan Druart changed: What|Removed |Added Attachment #102434|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 102435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102435=edit Bug 24964: Do not fetch all patrons for owner/users of funds admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only retrieve patrons with acq (order_manage) permissions. The original bug was hidden in the existing code, but the behavior was terrible. To prevent patrons matching the permissions contrainst to be hidden, we fetched ALL the patrons from the DB, then filtered them depending on their permissions. This might have awful performance on DB with lot of patrons. So basically with this patch we are adding the pagination back to the "owner/users for funds" feature, as the permission filtering is now done at DB level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences for OPAC and staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16547] Can't place item level hold directly from search results screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #18 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4944] Create separate noItemTypeImages preferences for OPAC and staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4944 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24183] Introduce `before_send_messages` hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24183 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24964] Do not filter patrons AFTER they have been fetched from the DB (when searching with permissions)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24964 --- Comment #21 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24699] Split items.uri on OPAC detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24699 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24871] Add new *-installer-*.po translation files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887
--- Comment #20 from Jonathan Druart
---
(In reply to Lari Taskula from comment #15)
> Comment on attachment 101890 [details] [review]
> Bug 22887: Warn if duplicates exist
>
> Review of attachment 101890 [details] [review]:
> -
>
> ::: installer/data/mysql/atomicupdate/bug_22887.perl
> @@ +7,5 @@
> > +GROUP BY category, authorised_value
> > +HAVING c > 1
> > +|, { Slice => {} });
> > +if ( @$duplicates ) {
> > +warn "WARNING - Cannot create unique constraint on
> > authorised_value(category, authorised_value)\n";
>
> Nice to give a warning. We should still make sure the constraint actually
> gets created for everyone.
>
> Perhaps delete the duplicates and print & log what was deleted?
>
> Or die instead of warn.
The idea is to not remove data that could be use by a fork in a different way.
I usually prefer to not remove the data, and warn, instead of remove them
and... sometimes people forgets to backup their DB... ;)
But I am not strongly attached to the approach here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24653] Failing tests in 19.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24653 Jonathan Druart changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch --- Comment #4 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > It looks like there is a patch with 2 sign-offs... but the status is new? > What happened here? It came from 11943. Not really clear to me why this really had to be moved at the time. It passed QA. Passing it to RM now for further judgement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
