[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845
Nick Clemens changed:
What|Removed |Added
Attachment #106210|0 |1
is obsolete||
--- Comment #2 from Nick Clemens ---
Created attachment 106421
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106421=edit
Bug 25845: Add 'api' to the log viewer interface options
This patch simply adds the API option to the log viewer.
To test:
1. Have BorrowersLog set
2. Update some patron using the API. For example
curl --location --request PUT
'http://koha:k...@kohadev-intra.mydnsname.org:8081/api/v1/patrons/1' \
--header 'Content-Type: application/json' \
--data-raw '{
"firstname": "Tomasito",
"surname": "None",
"address": "Address",
"category_id": "ST",
"city": "Córdoba",
"library_id": "MPL"
}'
3. Open the log viewer
=> FAIL: There's no way to filter on interface, choosing API
4. Apply this patch
5. Reload the log viewer
=> SUCCESS: There are options to filter by 'API' interface
=> SUCCESS: Filtering by 'API' works
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 --- Comment #16 from Victor Grousset/tuxayo --- == Test plan == 1. In /etc/hosts , add «127.0.0.1swagger.io» 2. try to load a page 3. it works 4. koha-plack --restart kohadev 5. try to load a page 6. endless or timeout loading 7. remove the sabotage from /etc/hosts 8. after a few seconds, the page will load Confirmed on master. It works on 19.05 (In reply to Mason James from comment #10) > hmm, this does look like a legitimate bug, caused by 22522 Possibly. Because 19.05.x doesn't have bug 22522 patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23653] Plack stopped working - JSON validation timeout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653 Victor Grousset/tuxayo changed: What|Removed |Added Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo --- (In reply to David Cook from comment #2) > I noticed recently that "lastseen" updates for "Patron logs into OPAC" and > "Patron is authenticated via SIP2" and that's it. IIUC all the data is already there albeit in various tables right? So, is the functionality achievable via a report? (which could be included by default & upgrades) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24353] [19.05] privacy_guarantor_checkouts incorrectly shows No on moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105301|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 106422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106422=edit Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens --- Trivial, passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25845] Cannot limit system logs to 'api' interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25845 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522
--- Comment #84 from Victor Grousset/tuxayo ---
(In reply to Magnus Enger from comment #10)
> This fixes a major security problem, I'm upping the importance and changing
> the component from ILL to "REST API".
Wow, I missed that.
After a quick test I confirm that I can't do this (on 19.05 and 18.11):
> Test plan:
> 1. Without being logged in to Koha, access an endpoint directly
(such as /api/v1/patrons/{patron_id})
> 2. Notice results are received (which is bad since we're not authenticated)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24353] [19.05] privacy_guarantor_checkouts incorrectly shows No on moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo --- It works! :) A guess of the continuation of the process would be: - QA as usual - instead of the RM to push to master, it would be the RMaint of 19.05.x (turns out to be me) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #15 from David Cook --- (In reply to Christopher Brannon from comment #13) > Folks, this is a rather important issue. Would love to see this progress > beyond 4 years of rare discussion. :D I agree that it's important, but it's not a priority for us at this time. I notice this issue is marked as "Seeking cosponsors". It might be worthwhile to send an email to the koha-devel list to see if someone wants to work on it, or if you have funds - look to hire someone to do the work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25292] L1 cache too long in Z3950 server (z3950-responder)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25292 --- Comment #7 from Victor Grousset/tuxayo --- After changing the syspref, I must restart ZOOM to have a different number of hits. Is that expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Christopher Brannon changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #13 from Christopher Brannon --- Folks, this is a rather important issue. Would love to see this progress beyond 4 years of rare discussion. :D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #14 from Christopher Brannon --- To add to this, it is really holding us back on tracking active patrons. We cannot clean out our patron databases on inactive accounts, because currently Koha is not tracking activity through 3rd party databases or computer checkouts via SIP authentication. This really needs some momentum. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25896] Missing closing tag in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Andrew Nugged changed: What|Removed |Added CC|julian.maur...@biblibre.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25897] Inventory table call number sort should use cn_sort value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 Andrew Nugged changed: What|Removed |Added Blocks|25896 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 [Bug 25896] Missing closing tag in smart-rules.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25896] Missing closing tag in smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 Andrew Nugged changed: What|Removed |Added Depends on|21395 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 [Bug 21395] Make perlcritic happy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24159] Allow daysMode for calculating due and renewal dates to be set at the circulation rules level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com --- Comment #71 from Andrew Nugged --- Small (below trivial :P) postfix: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25897] New: Inventory table call number sort should use cn_sort value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 Bug ID: 25897 Summary: Inventory table call number sort should use cn_sort value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Given items with barcodes like: B 29 V55 1998 B29 .C55 2008 B29 .L24 1983 B29 .L264 1998 B29 .P666 2004 The correct sort order should be: B29 .C55 2008 B29 .L24 1983 B29 .L264 1998 B29 .P666 2004 B 29 V55 1998 But instead it sorts in the order supplied first -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25801] Add itemnumber parameter to opac-detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25801 --- Comment #15 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #14) Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 Fridolin SOMERS changed: What|Removed |Added Attachment #106256|0 |1 is obsolete|| --- Comment #4 from Fridolin SOMERS --- Created attachment 106380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106380=edit Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Katrin Fischer changed: What|Removed |Added Summary|CalcDateDue freezes with|CalcDateDue freezes with |'useDaysMode' set to|'useDaysMode' set to |'Dayweek' and the due date |'Dayweek' and the due date |lands on a sunday. |lands on a Sunday -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #10 from Paul Poulain --- Suspecting the patch misses something. IIRC, Authorities does not handle unicode like biblios. Thus, we have UNIMARC and UNIMARCAUTH as available parameters. I suspect (without having checked) that the patch won't work for BNF unimarc authorities. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25695] Missing logging of $@ in onboarding.pl after eval block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 Martin Renvoize changed: What|Removed |Added Attachment #105999|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 106387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106387=edit Bug 25695: merge of similar code blocks after circulation_rules update In onboarding.pl we have second block with adding just one more rule parameter (maxissueqty) which can be merged to first one after all parameters now stored in circulation_rules table. Also this eliminates the need of adding forgotten "warn $@" after the second eval block. Mentored-by: Andrew Nugged Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25695] Missing logging of $@ in onboarding.pl after eval block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25695] Missing logging of $@ in onboarding.pl after eval block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- A nice bit of tidying up.. works as expected, thanks! Going straight for a QA here.. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25888] (Opac)SeparateHoldings functionality appears to be broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25888 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- The preferences are working correctly for me on master (I thought it wasn't for a moment, but there were no items for my current home branch). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Martin Renvoize changed: What|Removed |Added Attachment #106346|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 106381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106381=edit Bug 25850: Add tests for weekday holidays Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 --- Comment #10 from Martin Renvoize --- Created attachment 106382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106382=edit Bug 25850: Regression Test This patch adds a unit test to test for an infinite loop as highlighted by the bug. Test plan 1/ Run the test before applying the fix 2/ The test should fail for 'Sundays' 3/ Apply the subsquent patch 4/ Re-run the test 5/ It should now pass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Martin Renvoize changed: What|Removed |Added Attachment #106207|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 106383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106383=edit Bug 25850: Adapt day of week in Koha::Calendar::get_push_amt to 0..6 with 0 being Sunday. 1. Go to tools -> calendar and make sure Sundays are holidays by adding a holiday on a Sunday and selecting "Holiday repeated every same day of the week" and "Copy to all libraries" and save. 2. Go to administration -> system preferences and select "Use the calendar to push the due date to the next open matching weekday for weekly loan periods, or the next open day otherwise" for the system preference "useDaysMode" and save the system preferences. 3. Put the below code in a file name test.pl and execute it using the command "sudo koha-shell -c 'perl test.pl' kohadev" use Koha::Calendar; my $calendar = Koha::Calendar->new( branchcode => 'CPL' ); $dt = DateTime->new( year => 2020, month => 06, day=> 21 ); print "This is a sunday: " . $dt->day_of_week . "\n"; my $ndt = $calendar->next_open_days($dt, 0); print "This is a monday: " . $ndt->day_of_week . "\n"; 4. Without the patch applied, this script will freeze after printing "This is a sunday ...". Abort using ctrl-c. 5. Apply patch and run the script again. The test script will now complete. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Martin Renvoize changed: What|Removed |Added Attachment #106348|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 --- Comment #13 from Martin Renvoize --- Created attachment 106384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106384=edit Bug 25850: (QA follow-up) Match logic in is_holiday -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Jonathan Druart changed: What|Removed |Added Summary|Current directory not kept |Current directory not kept |when using koha-create |when using koha-shell -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #14 from Jonathan Druart --- > This patch also modify t/00-testcritic.t to check all Perl files using > the new .perlcriticrc. > I'm not sure if this test script is still useful as it is now equivalent > to `perlcritic --quiet .` and it looks like it is much slower > (approximatively 5 times slower on my machine) Are you sure about that? % time perlcritic --quiet . real2m10.957s % time prove t/00-testcritic.t real1m2.354s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #27 from Martin Renvoize --- Created attachment 106388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106388=edit Bug 25440: (QA follow-up) Correction for typo 'engthunit -> lengthunit Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25723] Improve efficiency of holiday calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart changed: What|Removed |Added Severity|major |minor --- Comment #33 from Jonathan Druart --- (In reply to Martin Renvoize from comment #32) > Whats the current state of this one? Still some left, but minor now: % git grep -l 2505|grep -v '.md\|.html\|.txt' cataloguing/value_builder/unimarc_field_105.pl cataloguing/value_builder/unimarc_field_110.pl cataloguing/value_builder/unimarc_field_120.pl cataloguing/value_builder/unimarc_field_130.pl cataloguing/value_builder/unimarc_field_140.pl cataloguing/value_builder/unimarc_field_225a.pl cataloguing/value_builder/unimarc_field_4XX.pl koha-tmpl/intranet-tmpl/lib/linters/jshint.js koha-tmpl/intranet-tmpl/lib/linters/jshint.min.js koha-tmpl/opac-tmpl/lib/verovio/verovio-toolkit.js misc/batchCompareMARCvsFrameworks.pl misc/batchDeleteUnusedSubfields.pl misc/batchImportMARCWithBiblionumbers.pl misc/batchRebuildBiblioTables.pl misc/cronjobs/build_browser_and_cloud.pl misc/exportauth.pl misc/kohalib.pl misc/migration_tools/22_to_30/missing090field.pl misc/migration_tools/22_to_30/move_marc_to_authheader.pl misc/migration_tools/22_to_30/rebuild_leader.pl misc/migration_tools/22_to_30/rebuild_unimarc_100.pl misc/migration_tools/buildCOUNTRY.pl misc/migration_tools/buildEDITORS.pl misc/migration_tools/buildLANG.pl misc/migration_tools/create_analytical_rel.pl misc/migration_tools/upgradeitems.pl misc/translator/tmpl_process3.pl t/db_dependent/Biblio/TransformHtmlToMarc.t t/db_dependent/data/marc21/zebraexport/biblio/exported_records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 --- Comment #34 from Jonathan Druart --- (should have excluded .js as well) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25890] New: Checkouts table not sorting on check out date correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 Bug ID: 25890 Summary: Checkouts table not sorting on check out date correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 21562 introduced a hidden column for sorting by date checked out Bug 20194 added a new column, but did not update the sorting property (iDataDort) in checkouts.js To recreate: Test plan: - Check some items out, all from different libraries - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, verify it is actually sorting on homebranch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 --- Comment #8 from Jonathan Druart --- Looks like it is impossible to add a new update DB entry to fix this problem :-/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25888] (Opac)SeparateHoldings functionality appears to be broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25888 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- I don't recreate on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Works as expected, no obvious regressions. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25752] Current directory not kept when using koha-create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Martin Renvoize changed: What|Removed |Added Attachment #105884|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 106386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106386=edit Bug 25752: Stay in cwd after koha-shell After bug 25538, after a koha-shell we are not longer in the current directory: root@cec7bffd8100:koha(master)$ pwd /kohadevbox/koha root@cec7bffd8100:koha(master)$ sudo koha-shell kohadev kohadev-koha@cec7bffd8100:~$ pwd /var/lib/koha/kohadev Test plan: Repeat the commands above and confirm that with this version of the script you get /kohadevbox/koha inside the koha-shell Search for possible regressions Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25440] Remove undef and CGI warnings and fix template variables list in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #28 from Andrew Nugged --- <3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 --- Comment #3 from Fridolin SOMERS --- (In reply to David Nind from comment #2) > Created attachment 106360 [details] > Bug 25868 - Screenshots of behavour > > Hi Fridolin. > > This change now works as expected. > > However, if you do two transfers (one after the other for different items) > the list of transfers shows: > - the last transfer entered, and > - the previous transfers show as "No title" and the link doesn't go anywhere > > See before and after screenshots. > > David Thanks a lot for testing, i'got a fix ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25885] Wait for OverDrive results before redirecting to single Koha result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a Sunday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 --- Comment #12 from Martin Renvoize --- I did a quick benchmark on '`Modulo` Vs `comparison + assignment`'. Rate Modulo Assign Modulo 23693859/s -- -22% Assign 30513086/s 29%-- So.. it looks like the test + assign is the quicker operation... I'll add a followup here to make that conversion to match the logic here to the logic in the is_holiday routine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25868] Transfers page must show effective itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25868 David Nind changed: What|Removed |Added Attachment #106380|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 106385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106385=edit Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfers 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25807] Version 3.008 of Template breaks smart-rules display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Jonathan Druart changed: What|Removed |Added URL||https://github.com/abw/Temp ||late2/issues/263 CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25723] Improve efficiency of holiday calculation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25850 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25850] CalcDateDue freezes with 'useDaysMode' set to 'Dayweek' and the due date lands on a sunday.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25850 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25723 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority --- Comment #19 from Jonathan Druart --- Yes it's failing with strict mode: 'koha_kohadev.reserve.reserve_id' isn't in GROUP BY Aleisa, if you could compare the performance on a production DB that would be really useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25888] (Opac)SeparateHoldings functionality appears to be broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25888 --- Comment #3 from Katrin Fischer --- Thx! I have an idea, I will double check and then probably this can be closed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #25 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #16 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23410] Add submenus to system preferences sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23410] Add submenus to system preferences sidebar menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23410 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6416] koha-remove fails when dropping user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416 --- Comment #6 from rainer.stowas...@zamg.ac.at --- It seems to have something to do with the restore script MariaDB [information_schema]> select * from USER_PRIVILEGES; 'koha_bibzamg'@'localhost' | def | USAGE | NO 'koha_zabibli'@'%' | def | USAGE | NO the user bibzamg was created with koha-create the user koha_zabibli'@'%'with koha-restore -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #21 from Julian Maurice --- Created attachment 106393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106393=edit Bug 21395: Fix creation of PO file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #22 from Julian Maurice --- Created attachment 106394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106394=edit Bug 21395: Ignore .perlcriticrc in t/Makefile.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542
--- Comment #12 from Fridolin SOMERS ---
Created attachment 106397
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106397=edit
Bug 23542: Fix SRU import encoding
When importing records from a SRU server, the diacritics have bad encoding.
I reproduce with BNF server so it may be a UNIMARC issue.
Tests show that difference between Z39.50 server and SRU is that leader
contains 'a' at postion 9.
Looking at MARC::Record->encoding() shows that encoding depends on leader even
for UNIMARC.
So this patch adds a call to MARC::Record->encoding('UTF-8') in case of a SRU
server in C4::Breeding.
Same use exists in Koha::MetadataRecord::Authority::get_from_breeding().
In case of import via Z3950, MarcToUTF8Record() is called,
which calls SetMarcUnicodeFlag(),
which calls MARC::Record->encoding('UTF-8')
Test plan :
1) Use a UNIMARC database
2) Configure a connexion to a UNIMARC SRU, for example BNF,
see
https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru#serveur_de_la_bnf
3) Go to cataloguing module
4) Click on 'New from Z39.50/SRU'
5) Choose only the SRU target
6) Search for ISBN 2266072889
7) Confirm you see good encoding : diacritic on 'a' of title 'Strate-a-gemmes'
8) Click on 'Marc preview'
9) Confirm you see good encoding
10) Click import
11) Confirm you see good encoding
12) Check also Authorities import via SRU
13) Check also SRU imports on a MARC21 database
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #24 from Julian Maurice --- Created attachment 106398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106398=edit Bug 21395: Fix misc/admin/koha-preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 --- Comment #7 from Alex Buckley --- Hey Nick, I see you set bug 25322 as a dependent patchset of this bug report. I was wondering did you mean to set something else instead? As Bug 25322 does not touch the Acquisitions module. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542
--- Comment #15 from Fridolin SOMERS ---
(In reply to Fridolin SOMERS from comment #11)
> Ah I think I found the correct same code :
>
> In Koha::MetadataRecord::Authority :
> get_from_breeding {
> my $record=eval
> {MARC::Record->new_from_xml(StripNonXmlChars($marcxml),'UTF-8',
> (C4::Context->preference("marcflavour") eq
> "UNIMARC"?"UNIMARCAUTH":C4::Context->preference("marcflavour")))};
> return if ($@);
> $record->encoding('UTF-8');
>
> So it is more "$record->encoding('UTF-8')" that is missing. It sets 'a' in
> leader position 9.
> This is called in SetMarcUnicodeFlag().
>
> See also Bug 18153.
Here you see that MARC::Records->new_from_usmarc() calls :
$marc->encoding() eq 'UTF-8'
https://metacpan.org/source/GMCHARLT/MARC-Record-2.0.7/lib/MARC/File/USMARC.pm#L172
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] ILL backends/plugins need hooks into checkin and checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 --- Comment #2 from Martin Renvoize --- Looks like Tomas has already started on this one :).. See bug 25885 for a post_renewal hook -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21468] ILL backends/plugins need hooks into checkin and checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21468 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25855 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25891] build_holds_queue can be daemonised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25891 --- Comment #1 from Katrin Fischer --- Hm, woudl this be optional or that you could still pick the schedule? If you use the randomized hold targetting it would mean that the holds information would likely change with every hold added (or whatever triggers the daemon) - I think that would not be generally wanted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add post_renewal_hook in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21468 CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #17 from Fridolin SOMERS --- Why keeping decodeURIComponent() for current_search.limit ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25891] build_holds_queue can be daemonised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25891 --- Comment #3 from Katrin Fischer --- Maybe to explain better: hold information = the library picked to get the item off the shelf. I think the reason it's on a slow schedule by default is that the idea was to give people time to fetch the items in a multi-library setting. I can see that it would work well for a single branch library if it showed immediately. Different use cases to think about! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18153] UNIMARC bib records exported with invalid 'a' char in label pos.9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18153 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23542 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542
--- Comment #11 from Fridolin SOMERS ---
Ah I think I found the correct same code :
In Koha::MetadataRecord::Authority :
get_from_breeding {
my $record=eval
{MARC::Record->new_from_xml(StripNonXmlChars($marcxml),'UTF-8',
(C4::Context->preference("marcflavour") eq
"UNIMARC"?"UNIMARCAUTH":C4::Context->preference("marcflavour")))};
return if ($@);
$record->encoding('UTF-8');
So it is more "$record->encoding('UTF-8')" that is missing. It sets 'a' in
leader position 9.
This is called in SetMarcUnicodeFlag().
See also Bug 18153.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25891] New: build_holds_queue can be daemonised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25891 Bug ID: 25891 Summary: build_holds_queue can be daemonised Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz We have customers who have come from systems where the holds queue is either dynamically built at query time or where it's being much more regularly updated. In their workflows, having to wait for an hour between runs is an annoyance. With the recent introduction of easy locking mechanisms via the Koha::Script class we should be able to utilise this functionality to allow the build_holds_queue job to be demonized such that it runs on a loop. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25891] build_holds_queue can be daemonised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25891 --- Comment #2 from Martin Renvoize --- Definitely optional Katrin :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #26 from Martin Renvoize --- Thanks for the quick followups Julian.. great to see this one having progressed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Nick Clemens changed: What|Removed |Added Blocks|25750 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 Nick Clemens changed: What|Removed |Added Depends on|25322 |23522 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 [Bug 23522] Show "Actual price" in basket when available https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 [Bug 25322] Adding a guarantor with no relationship defaults to first available relationship name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23522] Show "Actual price" in basket when available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Nick Clemens changed: What|Removed |Added Blocks||25750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25750 [Bug 25750] Fallback to ecost_tax_included, ecost_tax_excluded not happening when no 'Actual cost' entered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24533] Improved sorting in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 Nick Clemens changed: What|Removed |Added Depends on||25890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 [Bug 25890] Checkouts table not sorting on check out date correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25890] Checkouts table not sorting on check out date correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25890 --- Comment #1 from Nick Clemens --- Created attachment 106389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106389=edit Bug 25890: Update sorting column for checkouts table Test plan: - Check some items out, all from different libraries - Modify the checkout and due dates, like: 2018-10-22 2018-01-23 2018-05-27 - Sort by checkout date, verify it is actually sorting on homebranch - Apply patch - Reload page - Note you can now sort items correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25793] OAI 'Set' and 'Metadata' dropdowns broken by OPAC jQuery upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25793 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25858] Borrower permissions are broken by update from bug 22868
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25858 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user search if they have multiple sub permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 --- Comment #9 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25875] Patron displayed multiple times in add user search if they have multiple sub permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25875 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21395] Make perlcritic happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395 --- Comment #23 from Julian Maurice --- Created attachment 106395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106395=edit Bug 21395: Fix C4/Barcodes/ValueBuilder.pm $DEBUG variable was always set to 0, so it was useless -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797 --- Comment #7 from Owen Leonard --- Created attachment 106396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106396=edit Bug 23797: (follow-up) Increase the size of opac_news.lang This patch adds a database update to increase the size of the opac_news.lang column in order to accommodate longer values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23797] Convert OpacLoginInstructions system preference to news block
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23797 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542
Fridolin SOMERS changed:
What|Removed |Added
Attachment #106397|0 |1
is obsolete||
--- Comment #13 from Fridolin SOMERS ---
Created attachment 106399
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106399=edit
Bug 23542: Fix SRU import encoding
When importing records from a SRU server, the diacritics have bad encoding.
I reproduce with BNF server so it may be a UNIMARC issue.
Tests show that difference between Z39.50 server and SRU is that leader
contains 'a' at postion 9.
Looking at MARC::Record->encoding() shows that encoding depends on leader even
for UNIMARC.
So this patch adds a call to MARC::Record->encoding('UTF-8') in case of a SRU
server in C4::Breeding.
Same use exists in Koha::MetadataRecord::Authority::get_from_breeding().
In case of import via Z3950, MarcToUTF8Record() is called,
which calls SetMarcUnicodeFlag(),
which calls MARC::Record->encoding('UTF-8')
Patch also uses system preference marcflavor instead of SRU syntax to
build MARC::Record, like for z3950.
Test plan :
1) Use a UNIMARC database
2) Configure a connexion to a UNIMARC SRU, for example BNF,
see
https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru#serveur_de_la_bnf
3) Go to cataloguing module
4) Click on 'New from Z39.50/SRU'
5) Choose only the SRU target
6) Search for ISBN 2266072889
7) Confirm you see good encoding : diacritic on 'a' of title 'Strate-a-gemmes'
8) Click on 'Marc preview'
9) Confirm you see good encoding
10) Click import
11) Confirm you see good encoding
12) Check also Authorities import via SRU
13) Check also SRU imports on a MARC21 database
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25891] build_holds_queue can be daemonised
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25891 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6416] koha-remove fails when dropping user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- (In reply to rainer.stowasser from comment #6) > It seems to have something to do with the restore script > > MariaDB [information_schema]> select * from USER_PRIVILEGES; > > 'koha_bibzamg'@'localhost' | def | USAGE | NO > > 'koha_zabibli'@'%' | def | USAGE | NO > > the user bibzamg was created with koha-create > the user koha_zabibli'@'%'with koha-restore (In reply to Simon Story from comment #2) > The '%' wildcard seems to match when mysql is checking the host the > connection is being made, not when matching users to delete. > > I see in koha-create that 'koha_demo'@'localhost' shouldn't have been > created. Since the code is: > CREATE USER \`$mysqluser\`@'%' IDENTIFIED BY '$mysqlpwd' > > Perhaps Magnus you are mistaken as to the course of events? This is current code (20.05's): mysql_hostname="localhost" # Set up MySQL database for this instance. if [ "$op" = create ] then if [ ! -e /etc/mysql/debian.cnf ]; then MYSQL_OPTIONS="-u root" echo "WARNING: The koha-common.cnf file is a dead soft link!" else MYSQL_OPTIONS="--defaults-extra-file=/etc/mysql/koha-common.cnf" fi mysql $MYSQL_OPTIONS
[Koha-bugs] [Bug 23542] SRU import encoding issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23542 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18153 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
