[Koha-bugs] [Bug 14237] Allow bibs to be added to course without items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14237] Allow bibs to be added to course without items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 --- Comment #41 from Aleisha Amohia --- Created attachment 120652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120652=edit Bug 14237: (follow-up) Set course_items.biblionumber for existing rows This atomic update will run after the first atomic update which adds the biblionumber column to course_items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120373|0 |1 is obsolete|| --- Comment #319 from Victor Grousset/tuxayo --- Created attachment 120648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120648=edit Bug 15516: (follow-up) Remove other holds in hold_group from holds_queue When one hold is fulfilled or set waiting Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120370|0 |1 is obsolete|| --- Comment #316 from Victor Grousset/tuxayo --- Created attachment 120645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120645=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library has the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This feature only applies to the staff client. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Search for a patron 3. Check the 'Treat as hold group' checkbox 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a hold group)' in Details column. 6. Click on the "hold group" link. A modal window should appear with the content of the hold group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "hold group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Note: A hold group is counted as only one hold Sponsored-by: Catalyst IT Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120371|0 |1 is obsolete|| --- Comment #317 from Victor Grousset/tuxayo --- Created attachment 120646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120646=edit Bug 15516: Schema updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120372|0 |1 is obsolete|| --- Comment #318 from Victor Grousset/tuxayo --- Created attachment 120647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120647=edit Bug 15516: (follow-up) Add hold group message to holds queue A hold that is part of a hold group will be indicated as such in the holds queue. Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120369|0 |1 is obsolete|| --- Comment #315 from Victor Grousset/tuxayo --- Created attachment 120644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120644=edit Bug 15516: Relevant controller changes and tests Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120574|0 |1 is obsolete|| --- Comment #320 from Victor Grousset/tuxayo --- Created attachment 120649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120649=edit Bug 15516: (follow-up) Fixes for qa tools Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #322 from Aleisha Amohia --- Created attachment 120650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120650=edit Bug 15516: (follow-up) Fixing file permissions and title elements order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28296] Optionally show all checkins for day and branch on checkin screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28296 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- Would this be something that would be feasible for a large branch or only small branches? I like the idea. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120650|0 |1 is obsolete|| --- Comment #323 from Victor Grousset/tuxayo --- Created attachment 120651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120651=edit Bug 15516: (follow-up) Fixing file permissions and title elements order Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #321 from Victor Grousset/tuxayo --- Works as expected :) Note: maxreserves counts the number of holds in the group hold, i.e. it doesn't count it as one. It seems that was intentional. But highlighting that for QA to review. Holds per day and holds total circ rules count the group as 1. Signing off. Though above QA fixes still needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Version(s)||This enhancement allows you released in||to specify an estimated ||delivery date per order. ||The specified estimated ||delivery date is also ||considered (alongside the ||calculated estimated ||delivery date, if no date ||has been specified) when ||searching for late orders ||and exporting late orders. ||You can also edit the ||estimated delivery date ||from the late orders page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120368|0 |1 is obsolete|| --- Comment #314 from Victor Grousset/tuxayo --- Created attachment 120643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120643=edit Bug 15516: Database and installer updates Signed-off-by: Michal Denar Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Attachment #119297|0 |1 is obsolete|| --- Comment #24 from Aleisha Amohia --- Created attachment 120653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120653=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Attachment #119299|0 |1 is obsolete|| --- Comment #26 from Aleisha Amohia --- Created attachment 120655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120655=edit Bug 15348: trivial code simplification -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What|Removed |Added Attachment #119298|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 120654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120654=edit Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #27 from Aleisha Amohia --- Created attachment 120656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120656=edit Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #10 from Martin Renvoize --- I've not read enough of th background to understand why support was dropped for security reasons in the upstream library? It feels like if they've disabled it by default for a reason we shouldn't just re-enable it without considering the possible security ramifications. That said, I wouldn't be opposed to tying that constructor line to yet another system preference that defaults to enabled for upgrades and disabled for new installs.. That way we don't break anyone's setups but encourage the more secure form going forward? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28011] Add CLI script to update bibs from linked authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28011
--- Comment #3 from David Cook ---
Actually, I'd say it's probably better to just be inefficient than have a
custom implementation.
The simplest version is just to compile a list of unique authority IDs and then
run the following:
my $record = GetAuthority($authid);
merge({ mergefrom => $authid, MARCfrom => $record, mergeto => $authid, MARCto
=> $record });
It will be inefficient but it will be a CLI script which can just run as long
as it needs to.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #313 from David Cook --- Still failing the QA tools. I think the pod coverage one can be ignored, as I think that's a QA tool bug. You do need to "chmod +x reserve/hold-group.pl t/db_dependent/Reserves/HoldGroup.t". And it looks like the elements needs to be ordered specific to general. I recall that being a fairly recent requirement: https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC3:_Title_elements_should_contain_unique_information_information_first root@kohadevbox:koha(bug_15516)$ qa testing 7 commit(s) (applied to 640ba47 'cf Bug 28288: Prevent XSISBN.t to fai') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |>| 27 / 27 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 331. |>| 27 / 27 (100.00%) OK C4/Reserves.pm OK Koha/Hold.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK circ/view_holdsqueue.pl OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt FAIL forbidden patterns forbidden pattern: Title elements must start with the unique information (bug 26703) (line 2) OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl FAIL reserve/hold-group.pl FAIL file permissions File must have the exec flag OK reserve/placerequest.pl OK reserve/request.pl OK svc/holds OK t/db_dependent/Koha/Holds.t FAIL t/db_dependent/Reserves/HoldGroup.t FAIL file permissions File must have the exec flag Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #295 from Martin Renvoize --- Created attachment 120581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120581=edit Bug 14957: (QA follow-up) Update for bug 23271 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #255 from David Cook --- (In reply to David Cook from comment #254) > Going to set this back to "Needs Signoff" so it's clearer that someone other > than me should test it. But FYI it is passing the QA tools: root@kohadevbox:koha(bug_15565)$ qa testing 3 commit(s) (applied to 640ba47 'cf Bug 28288: Prevent XSISBN.t to fai') Processing files before patches |>| 7 / 7 (100.00%) Processing files after patches |>| 7 / 7 (100.00%) OK Koha/Biblio.pm OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt OK opac/opac-reserve.pl OK reserve/placerequest.pl OK reserve/request.pl OK t/db_dependent/Reserves/MultiplePerRecord.t Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #3 from Magnus Enger --- A test plan would also be great. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #23 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #22) > I'm stuck on that JS error, and it looks like the internal note and vendor > note also no longer open in pop up windows. Any thoughts on the datatables > error? -Total +Total Why? You are not adding a new column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17748] Show due date and availability in item search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17748 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #8 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #7) > (In reply to Owen Leonard from comment #6) > > This works well except for sorting: Sorting the results by Availability or > > by Date due doesn't work. The order changes, but not to the correct order. > > I have no idea why this is happening or how to fix it. Any datatables > experts know why the filtering and sorting doesn't work for these two > columns? You are not doing anything to sort correctly on those 2 columns. It's an AJAX-based table, the results are not sorted in JS client-side only. You certainly need to modify C4::Items::SearchItems to correctly deal with those 2 columns in the order by clause. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120534|0 |1 is obsolete|| --- Comment #297 from Martin Renvoize --- Created attachment 120583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120583=edit Bug 14957: Updated schema files Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120537|0 |1 is obsolete|| --- Comment #300 from Martin Renvoize --- Created attachment 120586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120586=edit Bug 14957: (QA follow-up) Add tooltips This patch adds an info-tooltip to the field rules in the table header to expand on their meaning to reduce the need to read the documentation each time you come to use the configuration tool Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120535|0 |1 is obsolete|| --- Comment #298 from Martin Renvoize --- Created attachment 120584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120584=edit Bug 14957: fix context for batchmod and batchimport Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120533|0 |1 is obsolete|| --- Comment #296 from Martin Renvoize --- Created attachment 120582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120582=edit Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Christian Stelzenmüller Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120536|0 |1 is obsolete|| --- Comment #299 from Martin Renvoize --- Created attachment 120585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120585=edit Bug 14957: (QA follow-up) Button styling This patch updates the action buttons to include btn-default and switched from btn-sm to btn-xs to match other similar UI's found in datatable based admin pages. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120539|0 |1 is obsolete|| --- Comment #302 from Martin Renvoize --- Created attachment 120588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120588=edit Bug 14957: Feature hidden in menues if no other 'cagaloguing' permissions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120541|0 |1 is obsolete|| --- Comment #304 from Martin Renvoize --- Created attachment 120590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120590=edit Bug 14957: (follow-up) marc_merge_rules_modules removed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120542|0 |1 is obsolete|| --- Comment #305 from Martin Renvoize --- Created attachment 120591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120591=edit Bug 14957: (QA follow-up) Clarify 'context' param This patch renames the (passed through) 'context' param for 'overlay_context'. I propose doing so, because in Koha-land 'context' has a special meaning, related to C4::Context and it reads ambigous. The patch itself is pretty trivial. Tests should pass: 1. Run: $ kshell k$ prove t/db_dependent/Biblio/MarcOverlayRules.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120543|0 |1 is obsolete|| --- Comment #306 from Martin Renvoize --- Created attachment 120592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120592=edit Bug 14957: (QA follow-up) Fix syntax error in atomicupdate Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120538|0 |1 is obsolete|| --- Comment #301 from Martin Renvoize --- Created attachment 120587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120587=edit Bug 14957: (QA follow-up) Rename 'merge' => 'overlay' This patch acknowledges the fact that 'merging' has a different meaning in Koha than the behavior this great patchset introduces. The more idiomatic way of describing the behavior is to talk about 'overlay rules'. This patch also: - Fixes kohastructure.sql missing table encoding a collation - Fixes the atomic update completely missing a table - Moves the syspref entry to 'Importing', probably a rebase issue Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120540|0 |1 is obsolete|| --- Comment #303 from Martin Renvoize --- Created attachment 120589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120589=edit Bug 14957: DBIC changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120545|0 |1 is obsolete|| --- Comment #308 from Martin Renvoize --- Created attachment 120594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120594=edit Bug 14957: (QA follow-up) Rename and move admin link This patch renames 'MARC overlay rules' to 'Record overlay rules' and moves it up the list to just below 'Record matching rules' to make it more contextually ordered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120547|0 |1 is obsolete|| --- Comment #310 from Martin Renvoize --- Created attachment 120596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120596=edit Bug 14957: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120544|0 |1 is obsolete|| --- Comment #307 from Martin Renvoize --- Created attachment 120593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120593=edit Bug 14957: (QA follow-up) Fix translation issues This patch fixes all the translation issues I could spot in the marc-overlay-rules template. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120546|0 |1 is obsolete|| --- Comment #309 from Martin Renvoize --- Created attachment 120595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120595=edit Bug 14957: (QA follow-up) Comment 'bulkmarcimport' temporarily It appears this patchset doesn't fully support bulkmarcimport (see bug 25539 for details). At this time, to get this bug moving I think we should comment out the ability to define rules that affect bulkmarcimport and then we can fix and re-enable that feature at a later date. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120548|0 |1 is obsolete|| --- Comment #311 from Martin Renvoize --- Created attachment 120597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120597=edit Bug 14957: (QA follow-up) Update for bug 26703 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120553|0 |1 is obsolete|| --- Comment #313 from Martin Renvoize --- Created attachment 120599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120599=edit Bug 14957: (QA follow-up) Update for bug 20053 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120555|0 |1 is obsolete|| --- Comment #315 from Martin Renvoize --- Created attachment 120601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120601=edit Bug 14957: (QA follow-up) Update for bug 27846 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120550|0 |1 is obsolete|| --- Comment #312 from Martin Renvoize --- Created attachment 120598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120598=edit Bug 14957: (QA follow-up) Update for bug 20054 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120557|0 |1 is obsolete|| --- Comment #316 from Martin Renvoize --- Created attachment 120602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120602=edit Bug 14957: (QA follow-up) Fix template indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120581|0 |1 is obsolete|| --- Comment #317 from Martin Renvoize --- Created attachment 120603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120603=edit Bug 14957: (QA follow-up) Update for bug 23271 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Attachment #120554|0 |1 is obsolete|| --- Comment #314 from Martin Renvoize --- Created attachment 120600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120600=edit Bug 14957: (QA follow-up) Update for bug 17858 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #319 from Martin Renvoize --- Created attachment 120605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120605=edit Bug 14957: (QA follow-up) Fix for jQuery undefined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #318 from Martin Renvoize --- Created attachment 120604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120604=edit Bug 14957: (QA follow-up) Fix script name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #320 from Martin Renvoize --- (In reply to Katrin Fischer from comment #294) > Seeing the last status change - what happened? I broke it with the moving the JS to the bottom of the page.. so whilst I was working to fix that I reset the status to FQA to stop anyone wasting time testing. I've now fixed it again.. and run through the whole test plan to check I didn't break anything else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28011] Add CLI script to update bibs from linked authority records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28011
--- Comment #2 from David Cook ---
It seems like there's a few ways this could be done.
One idea is to fetch every bib record that contains at least one $9 linkage and
then compiling a list of unique IDs for authority records.
Then I'll run the following:
my $record = GetAuthority($authid);
merge({ mergefrom => $authid, MARCfrom => $record, mergeto => $authid, MARCto
=> $record });
But that will involve double-handling bib records.
--
Alternatively, I suppose I could fetch every bib record that contains at least
one $9 linkage, and then run the following for each unique linkage:
my $record = GetAuthority($authid);
merge({ mergefrom => $authid, MARCfrom => $record, mergeto => $authid, MARCto
=> $record, biblionumbers => [$biblionumber] });
I could cache the $record object to reduce some database fetches, except that
merge() is super inefficient.
--
I suppose I could write a custom function...
It looks like the heading data is obtained using the following: "@record_to =
$MARCto->field($auth_tag_to_report_to)->subfields()"
Then create $field_to from @record_to, and then
$field->replace_with($field_to).
Of course, writing a new function adds complications, especially if I don't
want to refactor merge(), which is an intimidating task.
Maybe I will just maintain this locally as that is less risky.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #11 from David Cook --- (In reply to Martin Renvoize from comment #10) > I've not read enough of th background to understand why support was dropped > for security reasons in the upstream library? It feels like if they've > disabled it by default for a reason we shouldn't just re-enable it without > considering the possible security ramifications. That said, I wouldn't be > opposed to tying that constructor line to yet another system preference that > defaults to enabled for upgrades and disabled for new installs.. That way > we don't break anyone's setups but encourage the more secure form going > forward? Personally, I think their labelling it as a "security" change was overblown. My understanding is that they dropped support for the abbreviated format because it *might* be too easy to accidentally specify a more permissive range than one intends. I can see how 10.10 is much less explicit than 10.10.0.0/16 but I don't really see the problem. But at this point in the discussion I am OK with Koha dropping support for the abbreviated form. I suppose the question is do we leave it as a breaking change or do we automagically fix people's configuration? I don't mind manually fixing all my instances, but I also know this stuff really well. It looks like HEA doesn't capture the relevant ILS-DI syspref (https://hea.koha-community.org/systempreferences) so I don't know what people have used... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28200] Net::Netmask 1.9104-2 requires constructor change for backwards compatibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28200 --- Comment #12 from David Cook --- Maybe this is a good one for a warning in about.pl. I think a bad value in koha-conf.xml will make your Koha fail to start up so you'd find that pretty fast. And a bad ILS-DI value could be found in about.pl or by any API user.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement enables|This enhancement enables release notes|the use of rules for|the use of rules for |merging MARC records. For |merging MARC records. For |example, it can be used to |example, it can be used to |prevent field data from |prevent field data from |being overwritten. |being overwritten. | | |It is |It is |enabled using the new |enabled using the new |system preference |system preference |"MARCOverlayRules". Rules |"MARCOverlayRules". Rules |are added, edited and |are added, edited and |deleted in the staff|deleted in the staff |interface from Home > Koha |interface from Home > Koha |administration > Catalog > |administration > Catalog > |MARC overlay rules. |MARC overlay rules. || ||NOTE: ||A follow-up bug is being ||worked upon to add ||compatibility with ||bulkmarcimport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart changed: What|Removed |Added Attachment #120549|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 120607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120607=edit Bug 28220: Deal with merge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #11 from Jonathan Druart --- Created attachment 120608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120608=edit Bug 28220: Add tests to import failure expected, we need to add a transaction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #13 from Jonathan Druart --- Created attachment 120610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120610=edit Bug 28220: Handle InvalidType -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #14 from Jonathan Druart --- Created attachment 120611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120611=edit Bug 28220: Handle NonRepeatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #12 from Jonathan Druart --- Created attachment 120609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120609=edit Bug 28220: prevent patron to be created if attributes not stored Using a transaction -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539 --- Comment #22 from Martin Renvoize --- (In reply to David Gustafsson from comment #21) > I completely forgot to add why I brought the patch up. The reason being that > it's hard to fix the issue without exposing other bugs as mentioned in > comment #13. It would probably be better to perform a more thorough > refactor, but then there is the issue that we already did that but does not > have a clean patch-set to contribute. Perhaps I will have to take the time > to go through our current patch and verify that the current options are > still supported and the script behaves in more or less the same way, so no > or minimal API breakage. I'm more than happy to take a look at a bulkmarcimport patch.. even if it is initially large and unwieldy. We use that script a lot at PTFS-E and have been contemplating working on it to improve performance for some time.. though I'm not aware of any real bugs.. I'll ask the migrations team as they're the one's that utilise it.. perhaps they're using it in a different way from yourselves. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 --- Comment #2 from Jonathan Druart --- Created attachment 120606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120606=edit Bug 28293: (bug 20443 follow-up) Fix wrong key in Patrons::Import->generate_patron_attributes It generates warnings Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/Koha/Patrons/Import.pm line 550, <$fh> line 2. And does not sort correctly (no fallback on the attribute's value for repeatable attributes) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart changed: What|Removed |Added Depends on||28293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 Jonathan Druart changed: What|Removed |Added Blocks||28220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 [Bug 28220] Exception not caught when importing patrons with invalid attribute type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #17 from Jonathan Druart --- Created attachment 120614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120614=edit Bug 28220: UI changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25885] Show list of hits for one search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885 --- Comment #8 from Magnus Enger --- Created attachment 120615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120615=edit Bug 25885 - Show list of hits for one search result Default behaviour in Koha, for a bibliographic search that returns one hit is to skip the result list and go straight to the detail view of that one hit. This patch makes this behaviour configurable. To test: - Make sure you can do a search that returns exactly one hit - Apply this patch - Do the search and verify the default behaviour of skipping the result list and going straight to detail view is in place - Toggle the OPACShowResultListOfOne syspref and make sure the behaviour corresponds to the setting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #16 from Jonathan Druart --- Created attachment 120613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120613=edit Bug 28220: Add more tests * Add the transaction when a patron is created * The changes in merge_and_replace_with prevent the creation of the patron and so the attributes if several non-repeatable attributes are passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #15 from Jonathan Druart --- Created attachment 120612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120612=edit Bug 28220: Add test for updating an existing patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25885] Show list of hits for one search result
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25885 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28208] ModItemTransfer no longer updates item.datelastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 --- Comment #5 from Nick Clemens --- (In reply to Martin Renvoize from comment #4) > (In reply to Jonathan Druart from comment #3) > > What if the item is checked out? (before was bug 24446 date last seen was > > updated) > > Correct.. but it's by design. If the item is checked out when a transfer is > requested upon it.. then the item hasn't actually been seen has it ;) > Pretty sure I actually discussed this at the time.. perhaps I missed someone > relevant. > > Nick, what is the use case/bug resulting from this change I filed this simply because I noticed the change, I haven't heard any reports, but I wanted to confirm the change was intentional -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons with invalid attribute type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #18 from Jonathan Druart --- Please try this patch, I think it covers a lot of cases. Test plan (but be creative!): Use the import patron tool to 1. Create a new patron with: * 1 new normal (non-repeatable, not unique) attribute * several repeatable attribute * unique with unique value => all good 2. Create a new patron with: * several new-repeatable attribute => boom 3. Create a new patron with: * unique with non-unique value => boom 4. Create a new patron with: * an invalid patron attribute type code (does not exist) And do the same for an existing patron (with and without the "preserve patron attributes" option). If an error happened the patron will not be created/modified (attributes and other infos) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 Jonathan Druart changed: What|Removed |Added Summary|Exception not caught when |Exception not caught when |importing patrons with |importing patrons |invalid attribute type | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27787] Point of Sale Receipt extra line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27787 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27800] Make the ability to enter quantity more clear in Point of Sale module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27800 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement enables|This enhancement enables release notes|the use of rules for|the use of rules for |merging MARC records. For |merging MARC records. For |example, it can be used to |example, it can be used to |prevent field data from |prevent field data from |being overwritten. |being overwritten. | | |It is |It is |enabled using the new |enabled using the new |system preference |system preference |"MARCMergeRules". Rules are |"MARCOverlayRules". Rules |added, edited and deleted |are added, edited and |in the staff interface from |deleted in the staff |Home > Koha administration |interface from Home > Koha |> Catalog > MARC merge |administration > Catalog > |rules. |MARC overlay rules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20447] Add support for MARC holdings records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #449 from Joonas Kylmälä --- A new bug found: The holdings editor doesn't load by default the frameworkcode template defined in holdings.frameworkcode column, it always loads HLD / default framework regardless of this value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28293] New: Wrong key used in Patrons::Import->generate_patron_attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293
Bug ID: 28293
Summary: Wrong key used in
Patrons::Import->generate_patron_attributes
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: normal
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart+k...@gmail.com
Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 20443
Caused by
commit e37bfe3e4b395ef71a54c65226829248847cf1ce
Bug 20443: Remove extended_attributes_code_value_arrayref AND
C4::Members::Attributes
sort { $a->{code} cmp $b->{code} || $a->{value} cmp $b->{value} }
map {
my @arr = split /:/, $_, 2;
{ code => $arr[0], attribute => $arr[1] }
First line must be
sort { $a->{code} cmp $b->{code} || $a->{attribute} cmp $b->{attribute} }
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443
[Bug 20443] Move C4::Members::Attributes to Koha namespace
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What|Removed |Added Blocks||28293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28220] Exception not caught when importing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28220 --- Comment #19 from Jonathan Druart --- And, I should add, don't be afraid by the number of patches or their sizes, most of the changes is adding new unit tests and indentation (for transaction and exception handling). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #12 from Martin Renvoize --- OK, I've now discovered the issue here.. or rather a customer whose recently upgraded has. Test plan 1/ Check an item out from it's home library 2/ Check the item in at another library (with the return to home branch system preferences enabled) 2a/ Accept the transfer and note we now have a transfer present from the items check-in library to it's home library 3/ Check the item in at a third library 3a/ Note you are asked to return the item to it's home library (but the fact this is a WrongTransfer is not highlighted in any way) 4/ Go to the item record and note the holding library has been updated to reflect where the item was most recently checked in. 5/ Note, however, that the status continues to display that the item is in transit from the original check-in library to the home library.. this should have been updated to reflect that the item is now in transit from the new holding library to the home library. I'll work on clarifying the actions here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24567] Elasticsearch: CCL syntax does not allow for multiple indexes to be searched at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24567 Joonas Kylmälä changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28292 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28292] New: Searching with colon ":" in the end of query gives internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28292 Bug ID: 28292 Summary: Searching with colon ":" in the end of query gives internal server error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylm...@helsinki.fi CC: nug...@gmail.com, stalkern...@gmail.com Searching (SearchEngine=elasticsearch) the catalogue with anything that ends with just a colon ":" gives internal server error. E.g. searching "hello:" gives this error. The code that was modified in bug 24567 would need to be adapted so that it would strip also the colon when it ends the query and not just when there is whitespace around it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 --- Comment #1 from Jonathan Druart --- It generates warnings Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/Koha/Patrons/Import.pm line 550, <$fh> line 2. And does not sort correctly (no fallback on the attribute's value for repeatable attributes) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28293] Wrong key used in Patrons::Import->generate_patron_attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28293 --- Comment #3 from Jonathan Druart --- Tests on bug 28220 cover this (at least get rid of the warnings) Test plan: Apply patches from bug 28220. Without this patch you see warnings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 --- Comment #33 from Kyle M Hall --- Created attachment 120616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120616=edit Bug 27837: Check the MARC directly, not the transformed item If permanent location is mapped, it will exist in the MARC. However, when we are transforming our item hash to MARC, we are losing our permanent location mapping, at least in unit tests. By checking the original MARC for the permenent location, we remove the risk of losing it the "empty" permenent location through the transformation process. We only need to know that it existed in the original item marc to know we need to update it in the database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #76 from Agustín Moyano --- Created attachment 120622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120622=edit Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #75 from Agustín Moyano --- Created attachment 120621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120621=edit Bug 8179: Add syspref to database This patch adds the AcqReceiveMultipleOrderLines syspref by atomicupdate and in sysprefs.sql Sponsored-by: Virginia Polytechnic Institute and State University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8179] Receiving multiple order lines at once
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #77 from Agustín Moyano --- Created attachment 120623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120623=edit Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Summary|C4::Circulation::updateWron |C4::Circulation::updateWron |gTransfer is never called |gTransfer is never called |and should be removed |but should be -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 --- Comment #9 from Jonathan Druart --- Created attachment 120627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120627=edit Bug 28281: Add tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 Martin Renvoize changed: What|Removed |Added Attachment #99829|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 Jonathan Druart changed: What|Removed |Added Attachment #120484|0 |1 is obsolete|| Attachment #120486|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 120626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120626=edit Bug 28281: Remove double decoding when importing installation data The YAML::XS::Load and YAML::XS::LoadFile functions already decode the YAML to Perl objects/strings, therefore decoding the output yet another time is not needed and causes an error to happen. To test: 1. Go through the following steps and notice without this patch the error happens and with this patch it doesn't: $ koha-mysql kohadev < installer/data/mysql/kohastructure.sql $ restart_all $ ./translate update pl-PL $ ./translate install pl-PL $ restart_all --> Go to the Koha web installer page and select pl-PL as the installer language, click through it and notice it gives following error at the MARC21 step: Cannot decode string with wide characters at /usr/lib/x86_64-linux-gnu/perl/5.24/Encode.pm line 202 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28281] Installer doesn't work on some languages (pl-PL) because it double decodes installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28281 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28272] Definition files are missing additionalProperties: false
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28272 Jonathan Druart changed: What|Removed |Added Keywords||rel_21_05_candidate Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27837] Permanent location is reverted to location when location updated and permanent_location mapped to MARC field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27837 Kyle M Hall changed: What|Removed |Added Attachment #120628|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall --- Created attachment 120629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120629=edit Bug 27837: Always pass permanent location from items editor if it was defined By always passing permenent location from the items editor, we can know if permanent location was defined in the framework. This means we can know if we should update permanent location independently of location even if permenent location has an empty value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
