[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Medium patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165551|0 |1 is obsolete|| --- Comment #64 from Marcel de Rooy --- Created attachment 165599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165599&action=edit Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165552|0 |1 is obsolete|| --- Comment #65 from Marcel de Rooy --- Created attachment 165600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165600&action=edit Bug 35628: Schema update Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165553|0 |1 is obsolete|| --- Comment #66 from Marcel de Rooy --- Created attachment 165601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165601&action=edit Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165554|0 |1 is obsolete|| --- Comment #67 from Marcel de Rooy --- Created attachment 165602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165602&action=edit Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #16|0 |1 is obsolete|| --- Comment #68 from Marcel de Rooy --- Created attachment 165603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165603&action=edit Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165556|0 |1 is obsolete|| --- Comment #69 from Marcel de Rooy --- Created attachment 165604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165604&action=edit Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165557|0 |1 is obsolete|| --- Comment #70 from Marcel de Rooy --- Created attachment 165605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165605&action=edit Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165560|0 |1 is obsolete|| --- Comment #71 from Marcel de Rooy --- Created attachment 165606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165606&action=edit Bug 35628: Unit tests for addition to tickets API This patch updates the unit test for the ticket_updates api to catch both the missing test 'state' for the existing state change functionality and also the new 'status' functionality introduced with this patchset. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165563|0 |1 is obsolete|| --- Comment #72 from Marcel de Rooy --- Created attachment 165607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165607&action=edit Bug 35628: Add unit tests for Koha::Ticket addition We add a strings_map method to Koha::Ticket and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Marcel de Rooy changed: What|Removed |Added Attachment #165564|0 |1 is obsolete|| --- Comment #73 from Marcel de Rooy --- Created attachment 165608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165608&action=edit Bug 35628: Add unit tests for Koha::Ticket::Update addition We add a strings_map method to Koha::Ticketi::Update and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628
--- Comment #74 from Marcel de Rooy ---
Going to pass QA with some remarks (no blockers for me):
FAIL installer/data/mysql/atomicupdate/bug_35628.pl
FAIL file permissions
File must have the exec flag
WARN tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 11)
WARN t/db_dependent/api/v1/ticket_updates.t
WARN tidiness
The file is less tidy than before (bad/messy lines before: 57,
now: 58)
COMPARE
+ status:
+type:
+ - string
+ - "null"
+description: Current status of the ticket
+readOnly: true
WITH
+ status:
+type:
+ - string
+ - "null"
+description: Status of the ticket after this update
=> The first is readonly, the second is not. Just noting.
+# Update ticket status if needed
+if ( $ticket_update->{status} ) {
+my $ticket = $update->ticket;
+$ticket->set( { status => $ticket_update->{status} } )->store;
+}
Reading this the first time without deeper knowledge of the feature, these are
quite confusing variable names. $update ?
js
if (o["!="] === '[% st.authorised_value | html %]') {
additional_filters.status.push({ '!=': "[% st.authorised_value | html %]" });
No blocker. But using != here like this creates obscure code.
General:
Lots of patches here have no specific test plan.
When I want to add a concern, it is hard to find how to. Not intuitive. Under
the Concerns tab I should be able to add a new one.. (It is under New menu.)
Updating status with custom ones is confusing. Display of the custom status on
Ticket update looks suboptimal. If it is the intention to change the main
status, the feature does not work as expected?
Please improve on new follow-up reports?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #6 from Martin Renvoize --- Created attachment 165609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165609&action=edit Bug 35362: (follow-up) Fix preview close on guarantor add When adding a guarantor you are given a patron search modal. If you then preview a search result, the preview modal could not be closed. It's a simple update for 'close' to 'close_window' in the jQuery selector. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #7 from Martin Renvoize --- Created attachment 165610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165610&action=edit Bug 35362: (follow-up) Fix guaruntor preview modal close in test This patch updates the selenium test to correct the selector used to close the preview modal as it changed with this patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Marcel de Rooy changed: What|Removed |Added Attachment #165565|0 |1 is obsolete|| --- Comment #25 from Marcel de Rooy --- Created attachment 165611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165611&action=edit Bug 32435: Add TICKET_RESOLUTION authorized value Signed-off-by: David Nind Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Marcel de Rooy changed: What|Removed |Added Attachment #165566|0 |1 is obsolete|| --- Comment #26 from Marcel de Rooy --- Created attachment 165612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165612&action=edit Bug 32435: Add resolution states to Catalog concerns This patch adds resolution types to the catalog concerns feature. It allows libraries to define a list of 'TICKET_RESOLUTION' authorized values from which librarians can then pick at the point of resolving a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still resolve a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_RESOLUTION authorized values 6) Submit a new catalog concern 7) Confirm that the 'Resolve' button in the management modal is now a dropdown containing the list of resolution values defined above. Signed-off-by: David Nind Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Marcel de Rooy changed: What|Removed |Added Attachment #165567|0 |1 is obsolete|| --- Comment #27 from Marcel de Rooy --- Created attachment 165613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165613&action=edit Bug 32435: Unit tests for Ticket/Ticket::Update change We add a fallback to allow TICKET_RESOLUTIONS to be returned in the strings_map as additional TICKET_STATUS states. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32435] Add resolution types to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435
--- Comment #28 from Marcel de Rooy ---
Passing QA but with the following remarks:
WARN t/db_dependent/Koha/Ticket.t
WARN tidiness
The file is less tidy than before (bad/messy lines before: 44,
now: 48)
WARN t/db_dependent/Koha/Ticket/Update.t
WARN tidiness
The file is less tidy than before (bad/messy lines before: 10,
now: 14)
Added Resolved_2 status. Resolved a concern. Resolved_2 does not show up under
main status. But is listed (suboptimal) when clicking details.
my $av = Koha::AuthorisedValues->search(
{
category => 'TICKET_STATUS',
authorised_value => $self->status,
}
);
# Fall back to TICKET_RESOLUTION as needed
if ( !$av->count ) {
$av = Koha::AuthorisedValues->search(
{
category => 'TICKET_RESOLUTION',
authorised_value => $self->status,
}
);
}
No blocker. But not sure if we create maintainable code when we are going to
look for statuses in several AVs.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #36 from Marcel de Rooy --- [2024/04/26 07:34:03] [ERROR] GET /api/v1/tickets: unhandled exception (DBIx::Class::Exception)<> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Marcel de Rooy --- No unit tests here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 --- Comment #38 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #36) > [2024/04/26 07:34:03] [ERROR] GET /api/v1/tickets: unhandled exception > (DBIx::Class::Exception)< Exception: DBD::mysql::st execute failed: Unknown column 'me.assignee_id' in > 'field list' at /usr/share/koha/Koha/Objects.pm line 399>> A 500 when loading the staff detail page for a biblio with concerns. Hmm, this concerns me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #33 from Marcel de Rooy --- (In reply to Emily Lamancusa from comment #32) > It seems strange to me that even complete orders are cancelled when the > linked biblio record is deleted. Is there a reason they need to be > cancelled, rather than staying as "complete"? Good question. Looking now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu --- Comment #25 from Michaela Sieber --- (In reply to Pedro Amorim from comment #24) > Created attachment 165451 [details] [review] > Bug 35287: Rebase after follow-up to 35197 Thanks Pedro! We tested the additional fields for licenses and we wanted to sign off but have some problems with ktd and also with public sandboxes. Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111 --- Comment #45 from Katrin Fischer --- I accidentally pushed this to main, but will revert, I think easier and less confusing to push a clean patch later. Please let me know if I can help - I have done quite a bit of XSLT work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Attachment #165240|0 |1 is obsolete|| --- Comment #45 from David Nind --- Created attachment 165614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165614&action=edit Bug 23781: Database updates This patch adds RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM SMS notices and makes recalls notices available to be configured in patron messaging preferences. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Attachment #165241|0 |1 is obsolete|| --- Comment #46 from David Nind --- Created attachment 165615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165615&action=edit Bug 23781: Tests for Recalls messaging preferences - t/db_dependent/Koha/Recall.t - t/db_dependent/Koha/Recalls.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Attachment #165242|0 |1 is obsolete|| --- Comment #47 from David Nind --- Created attachment 165616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165616&action=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, restart services 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t 17) Confirm that 'Unknown' doesn't show in the the staff and OPAC messaging preferences tables when UseRecalls syspref is disabled Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23781] Recalls notices and messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 David Nind changed: What|Removed |Added Attachment #165593|0 |1 is obsolete|| --- Comment #48 from David Nind --- Created attachment 165617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165617&action=edit Bug 23781 (follow-up): Reorder atomic updates so they apply when run the first time. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36505] Allow updating patron attributes via PUT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 --- Comment #16 from Katrin Fischer --- This is just the tip of the iceberg, the dependency includes several "enh" bugs. Skipping for now (will be back later). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35669] Update check in message for a specific authorised value in the LOST authorised values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind --- I'me getting the sha1/fake ancestor error message when trying to apply the patch. git bz apply 35669 Bug 35669 - Update check in message for a specific authorised value in the LOST authorised values 165526 - Bug 35669: Update check in messages to match the lost authorised value. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35669: Update check in messages to match the lost authorised value. error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 35669: Update check in messages to match the lost authorised value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 --- Comment #8 from Martin Renvoize --- There's another selenium failure further down the patron search test.. but I can't seem to resolve that one :(. More eyes are needed, please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35362] Update patron module pop-up windows with consistent footer markup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35362 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@gmail.com, ||k...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36706] New: 'Add guarantor' - Patron preview 'close window' does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 Bug ID: 36706 Summary: 'Add guarantor' - Patron preview 'close window' does not work Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Depends on: 35329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35329] Move patron searches to a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 Pedro Amorim changed: What|Removed |Added Blocks||36706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 --- Comment #1 from Pedro Amorim --- Created attachment 165619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165619&action=edit Bug 36706: Fix close button 1) Visit http://localhost:8081/cgi-bin/koha/members/memberentry.pl 2) Click 'Search' 3) Click on any cardnumber of any of the search results 4) Click 'close window'. Notice it doesnt close. 5) Apply patch. Repeat test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 Pedro Amorim changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co |ity.org |m Patch complexity|--- |Trivial patch CC||jonathan.dru...@gmail.com, ||lu...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #75 from Martin Renvoize --- Thanks for your time here Marcel. The QA script failures confuse me a little as they passed locally.. perhaps a patch mix up.. I'll double check that here now. As for the other comments, they're all reasonable and I'll create bugs for them so I can work through.. thanks so much for the review. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #34 from Marcel de Rooy --- Created attachment 165620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165620&action=edit Bug 27893: (follow-up) Check orderstatus in orders->cancel Test plan: Run t/db_dependent/Koha/Acquisition/Orders.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36705] The 'Add new concern' button for catalog concerns is hidden away
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36705 Martin Renvoize changed: What|Removed |Added Depends on|31208 |31028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31208 [Bug 31208] "Check for embedded item record data" should default to "No" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize changed: What|Removed |Added Blocks||36705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36705 [Bug 36705] The 'Add new concern' button for catalog concerns is hidden away -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31208] "Check for embedded item record data" should default to "No"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31208 Martin Renvoize changed: What|Removed |Added Blocks|36705 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36705 [Bug 36705] The 'Add new concern' button for catalog concerns is hidden away -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 --- Comment #35 from Marcel de Rooy --- (In reply to Emily Lamancusa from comment #32) > It seems strange to me that even complete orders are cancelled when the > linked biblio record is deleted. Is there a reason they need to be > cancelled, rather than staying as "complete"? Have a look please at the follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36705] The 'Add new concern' button for catalog concerns is hidden away
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36705 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35628 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36705 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy changed: What|Removed |Added Attachment #165620|0 |1 is obsolete|| --- Comment #36 from Marcel de Rooy --- Created attachment 165621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165621&action=edit Bug 27893: (follow-up) Check orderstatus in orders->cancel Removed the results[0] test too in addbiblio, since there can be warnings without effectively cancelled order lines. Also reworded the warn (cancelled, not deleted). Test plan: Run t/db_dependent/Koha/Acquisition/Orders.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924 Aude Charillon changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #13 from Aude Charillon --- Added to the Manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36561] Inappropriate permission for "/api/v1/auth/password/validation"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36561 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #5 from David Nind --- Hi David. I'm not seeing the permission. All I see under "Add, modify and view patron information (borrowers)" are: Delete patrons (delete_borrowers) Add, modify and view patron information (edit_borrowers) Search, list and view patrons (list_borrowers) I see the new permission if I do a reset_all in KTD. Otherwise, as far as I can tell, step 2 of the test plan isn't doing anything (for me anyway). Does this means it needs a database update for existing installations? Not really sure how that should work... David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36599] Add table settings information to the ERM chapter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36599 --- Comment #1 from Aude Charillon --- Added cross-references in ERM chapter to the table settings for tables id: agreements, licenses, titles, packages (Merge request https://gitlab.com/koha-community/koha-manual/-/merge_requests/868). Awaiting clarification regarding tables id: usage_data_providers, counter_logs, monthly_usages and yearly_usages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165599|0 |1 is obsolete|| --- Comment #76 from Martin Renvoize --- Created attachment 165622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165622&action=edit Bug 35628: Add status to tickets This patch adds a new TICKET_STATUS authorized value category as well as adding the new 'status' field to both 'tickets' and 'ticket_updates' tables. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165600|0 |1 is obsolete|| --- Comment #77 from Martin Renvoize --- Created attachment 165623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165623&action=edit Bug 35628: Schema update Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165601|0 |1 is obsolete|| --- Comment #78 from Martin Renvoize --- Created attachment 165624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165624&action=edit Bug 35628: Add status to ticket definition Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165602|0 |1 is obsolete|| --- Comment #79 from Martin Renvoize --- Created attachment 165625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165625&action=edit Bug 35628: Add resolution states to Catalog concerns This patch adds ticket status to the catalog concerns feature. It allows libraries to define a list of 'TICKET_STATUS' authorized values from which librarians can then pick at the point of updateing a catalog concern. To test: 1) Apply the patches and run the database updates 2) Enable catalog concerns (staff or opac will do the trick) 3) Submit a catalog concern 4) Confirm that you can still update a concern from the catalog concerns management page as before. 5) Add some values to the new TICKET_STATUS authorized values 6) Submit a new catalog concern 7) Confirm that the 'Update' button in the management modal is now a split button with a dropdown containing the list of status values defined above. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165603|0 |1 is obsolete|| --- Comment #80 from Martin Renvoize --- Created attachment 165626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165626&action=edit Bug 35628: Display status strings instead of codes Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165604|0 |1 is obsolete|| --- Comment #81 from Martin Renvoize --- Created attachment 165627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165627&action=edit Bug 35628: Add current status as a class to table rows This patch adds the current status, if there is one set, to the table rows of the concerns interface. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165605|0 |1 is obsolete|| --- Comment #82 from Martin Renvoize --- Created attachment 165628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165628&action=edit Bug 35628: Add status filters to top bar This patch adds status filters to the top toolbar alongside the existing filter on resolved. Signed-off-by: Esther Melander Signed-off-by: Ray Delahunty Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165606|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize --- Created attachment 165629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165629&action=edit Bug 35628: Unit tests for addition to tickets API This patch updates the unit test for the ticket_updates api to catch both the missing test 'state' for the existing state change functionality and also the new 'status' functionality introduced with this patchset. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165607|0 |1 is obsolete|| --- Comment #84 from Martin Renvoize --- Created attachment 165630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165630&action=edit Bug 35628: Add unit tests for Koha::Ticket addition We add a strings_map method to Koha::Ticket and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 Martin Renvoize changed: What|Removed |Added Attachment #165608|0 |1 is obsolete|| --- Comment #85 from Martin Renvoize --- Created attachment 165631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165631&action=edit Bug 35628: Add unit tests for Koha::Ticket::Update addition We add a strings_map method to Koha::Ticket::Update and thus need to have corresponding unit tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35628] Add additional statuses to catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35628 --- Comment #86 from Martin Renvoize --- As suspected, the tidied and executable bit were fixed locally but somehow missed bugzilla.. I've redone them on your signed off set and re-uploaded.. QA script is now clean :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Marcel de Rooy changed: What|Removed |Added Attachment #165568|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 165632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165632&action=edit Bug 35348: Add cookies link to opac footer This patch adds a link that opens the cookies info dialogue to the opac footer when the CookieConsent feature is enabled. Test plan 1) Enable CookieConsent 2) On the OPAC you should now see a 'Cookies' link at the bottom of the page. 3) Clicking the link should open the "Cookie consent" modal where you can see the details of the cookies you have accepted and change your choices. 4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of 'Cookies' in the same footer bar. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Marcel de Rooy changed: What|Removed |Added Attachment #165569|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 165633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165633&action=edit Bug 35348: Ensure users can access cookie details in staff client We remove the check on JSConsents content so that when cookie consent is enabled we retain the option for users to get more information about what cookies are being used. Test plan 1) Enable CookieConsents 2) Do not add any tracking cookies for the staff client into CookieConsentedJS preference 3) Note that 'My consents' appears in the user menu 4) Clicking 'My consents' opens the 'Cookie consent' modal displaying information about the cookies used. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Marcel de Rooy changed: What|Removed |Added Attachment #165570|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 165634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165634&action=edit Bug 35348: Remove cookie consents link from opac consents The cookies details modal is now visible for all users from a footer link, we no longer need it under the 'Consents' tab for logged in users. Test plan 1) Enable CookieConsent and add a placholder tracker cookie to CookieConsentedJS preference 2) Log into the OPAC 3) Note that the 'Consents' link no longer appears in the users page. 4) Enable 'PrivacyPolicyConsent' 5) Note that the 'Consents' link now appears but on navigating to it there is no link for Cookie consents. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #19 from Marcel de Rooy --- Not sure about major btw? Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35134] cn_browser.pl pop-up size should be configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Pedro Amorim changed: What|Removed |Added Attachment #165381|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy changed: What|Removed |Added Status|Pushed to main |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35748] Allow holds to be suspended, unsuspended, or canceled in batches based on branch or patron category code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35748 pierre.ge...@biblibre.com changed: What|Removed |Added CC||pierre.ge...@biblibre.com --- Comment #2 from pierre.ge...@biblibre.com --- Isn't this ticket a duplication of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36135 ? Purpose of BZ36135 is to batch modify holds with following actions : - expiration date (not expiration date set by patron) - pick up library - suspend status (only if hold has no found status) - suspend until date (only if suspend status is set) - hold note Cancel and unsuspend should just be added to this list ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36567] Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 --- Comment #3 from Emmi Takkinen --- (In reply to David Nind from comment #2) > Tests fail for prove t/db_dependent/Circulation.t after applying the patches > (both tests pass before, only t/db_dependent/Circulation/dateexpiry.t passes > after): > > prove t/db_dependent/Circulation.t > t/db_dependent/Circulation.t .. 45/70 > # Failed test 'renew log successfully added' > # at t/db_dependent/Circulation.t line 4968. > # got: '2' > # expected: '3' > # Looks like you failed 1 test of 13. > t/db_dependent/Circulation.t .. 49/70 > # Failed test 'AddRenewal and AddIssuingCharge tests' > # at t/db_dependent/Circulation.t line 4987. > t/db_dependent/Circulation.t .. 66/70 # Looks like you failed 1 test of 70. > t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/70 subtests > > Test Summary Report > --- > t/db_dependent/Circulation.t (Wstat: 256 (exited 1) Tests: 70 Failed: 1) > Failed test: 49 > Non-zero exit status: 1 > Files=1, Tests=70, 26 wallclock secs ( 0.08 usr 0.01 sys + 17.25 cusr 5.89 > csys = 23.23 CPU) > Result: FAIL I'm unable to repeat this and I'm not even sure how these changes could affect those tests. Could this be caused by something in your testing environment? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36567] Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 Emmi Takkinen changed: What|Removed |Added Attachment #164609|0 |1 is obsolete|| --- Comment #4 from Emmi Takkinen --- Created attachment 165635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165635&action=edit Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year () and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36567] Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 --- Comment #5 from Emmi Takkinen --- Rebased patch, keeping this as Failed QA due comment 2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36567] Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 David Nind changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36567] Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 David Nind changed: What|Removed |Added Attachment #165635|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 165636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165636&action=edit Bug 36567: Get rid of Datetime warning in Circulation.t and dateexpiry.t Running either t/db_dependent/Circulation.t or t/db_dependent/Circulation/dateexpiry.t cause following error to be dispalyed: You are creating a DateTime object with a far future year () and a time zone (Europe/Helsinki). If the time zone you specified has future DST changes this will be very slow. Smallest allowed value is 4999, so we need to use that rather than in tests. To test prove t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36567] Datetime warning in t/db_dependent/Circulation.t and t/db_dependent/Circulation/dateexpiry.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36567 --- Comment #7 from David Nind --- Both tests now pass after applying the patch. Not sure whether it was something with my KTD or not... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159634|0 |1 is obsolete|| --- Comment #26 from Pedro Amorim --- Created attachment 165637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165637&action=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159635|0 |1 is obsolete|| --- Comment #27 from Pedro Amorim --- Created attachment 165638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165638&action=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159636|0 |1 is obsolete|| --- Comment #28 from Pedro Amorim --- Created attachment 165639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165639&action=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159637|0 |1 is obsolete|| --- Comment #29 from Pedro Amorim --- Created attachment 165640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165640&action=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159638|0 |1 is obsolete|| --- Comment #30 from Pedro Amorim --- Created attachment 165641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165641&action=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159639|0 |1 is obsolete|| --- Comment #31 from Pedro Amorim --- Created attachment 165642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165642&action=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159640|0 |1 is obsolete|| --- Comment #32 from Pedro Amorim --- Created attachment 165643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165643&action=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159641|0 |1 is obsolete|| --- Comment #33 from Pedro Amorim --- Created attachment 165644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165644&action=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159642|0 |1 is obsolete|| --- Comment #34 from Pedro Amorim --- Created attachment 165645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165645&action=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #159643|0 |1 is obsolete|| --- Comment #35 from Pedro Amorim --- Created attachment 165646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165646&action=edit Bug 35287: perltidy for green QA script Signed-off-by: Edith Speller Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Pedro Amorim changed: What|Removed |Added Attachment #165451|0 |1 is obsolete|| --- Comment #36 from Pedro Amorim --- Created attachment 165647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165647&action=edit Bug 35287: Rebase after follow-up to 35197 Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 David Nind changed: What|Removed |Added Attachment #165439|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 165648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165648&action=edit Bug 36678: Adjust unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36678] Include fields with non-filing characters removed when indexing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36678 David Nind changed: What|Removed |Added Attachment #165440|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 165649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165649&action=edit Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 David Nind changed: What|Removed |Added Attachment #165619|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 165650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165650&action=edit Bug 36706: Fix close button 1) Visit http://localhost:8081/cgi-bin/koha/members/memberentry.pl 2) Click 'Search' 3) Click on any cardnumber of any of the search results 4) Click 'close window'. Notice it doesnt close. 5) Apply patch. Repeat test plan. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36706] 'Add guarantor' - Patron preview 'close window' does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36706 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Go to add a new patron where guarantors are allowed (Patrons > New patron > Kid) 2. Click the 'Add guarantor' button (under the 'Patron guarantor' section). 3. Click the 'Search' button. 4. Click on any card number in the search results. 5. In the pop-up window with the patron summary details, click on the 'Close window' button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36676] SIP2 drops connection when using unknown patron id in fee paid message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36676 David Nind changed: What|Removed |Added CC||da...@davidnind.com Assignee|koha-b...@lists.koha-commun |bibliot...@th-wildau.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
