[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-246-ga2e8131dc2
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a2e8131dc2bd1e9b38e836744e0fc0fa67ebf6ce (commit) via df41ff4a9c54c0e958bbdb49acec671c024ec29e (commit) from e78231f3f63ed49fc65ac653e57159a8aba7fbe2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit a2e8131dc2bd1e9b38e836744e0fc0fa67ebf6ce Author: David Cook Date: Mon May 18 07:08:18 2020 + Bug 25524: Remove --line-regexp option in log4perl_component() The current grep expression uses -x|--line-regexp, but that causes the regexp to fail to match since we're not specifying a regexp that can match a whole line. We can either provide a better regexp, or remove that --line-regexp option. This patch removes the --line-regexp (ie -x) option from the grep in log4perl_component, so that it detects logger components correctly. To Test: 0) Apply patch 1) Build Koha package 2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing Koha instance (e.g. on koha-testing-docker), and note it has components for z3950, api, and sip 3) Install package 4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before 5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from /etc/koha/sites/kohadev/log4perl.conf 6) Reinstall package 7) Note that the missing lines have been appended to the file at /etc/koha/sites/kohadev/log4perl.conf Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit df41ff4a9c54c0e958bbdb49acec671c024ec29e Author: Kyle M Hall Date: Mon May 18 14:14:42 2020 -0400 Bug 25535: Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- Summary of changes: Koha/Hold.pm | 2 +- api/v1/swagger/definitions/hold.json | 2 +- api/v1/swagger/paths/holds.json | 2 +- debian/koha-common.postinst | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-244-ge78231f3f6
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via e78231f3f63ed49fc65ac653e57159a8aba7fbe2 (commit) via 448915cc3d8dcd92ce93736bea09a5a0a113dc03 (commit) from 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e78231f3f63ed49fc65ac653e57159a8aba7fbe2 Author: Tomas Cohen Arazi Date: Mon May 11 10:10:39 2020 -0300 Bug 24458: Use the ViewPolicy filter on search results This patch implements the use of the ViewPolicy record processor filter inside C4::Search::searchResults. The idea is that the $record_processor is instantiated once and reused inside the loop. This leaves options for further optimizations I will do on a follow-up bug. The filter is applied to the MARC data before it is passed to the XSLT processor. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: This is not implemented, tests fail 3. Apply this patch 4. Repeat 2 5. Feel the joy in your body from a long standing bug being solved 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson commit 448915cc3d8dcd92ce93736bea09a5a0a113dc03 Author: Tomas Cohen Arazi Date: Mon May 11 10:08:36 2020 -0300 Bug 24458: Regression tests This patch introduces tests for searchResults. The idea is to set a subfield as hidden in OPAC and another on the staff interface, and see if searchResults honours this on the XSLTResultsRecord contents. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: This is not really implemented Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- Summary of changes: C4/Search.pm| 11 +++ t/db_dependent/Search.t | 50 - 2 files changed, 60 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-242-g4178233de1
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2 (commit) via 0ab0f61657d7a93b5eab1fe4327b7254c10032e3 (commit) from dbcae29fa74f592deb8ef638179eae1bd451c076 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 4178233de18d8bb94ebc65e7a8d1f6afec6aeff2 Author: Tomas Cohen Arazi Date: Mon May 11 08:38:49 2020 -0300 Bug 25416: Unit tests This patch adds tests for the new 'feature': i.e. searchResults passes the added $xslt_variables to the XSLTParse4Display method. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson commit 0ab0f61657d7a93b5eab1fe4327b7254c10032e3 Author: Tomas Cohen Arazi Date: Thu May 7 14:23:40 2020 -0300 Bug 25416: Let OPAC XSLTs know if the context is an anonymous session This patch makes use of the 'variables' parameter in XSLTParse4Display method in the different places that it is used in the OPAC. It does by passing this parameter with anonymous_session => 1|0 The value will depend on the output from get_template_and_user (i.e. if there's a returned borrowernumber). A special case takes place in search results, as the call to XSLTParse4Display happens in C4::Search::searchResults. So a new parameter 'xslt_variables' is added to it. To test: 1. Apply the [DO NOT PUSH] patch 2. Open the OPAC in your browser 3. Try detail pages, search results, tags and lists/shelves pages with or without an active session => FAIL: It always says (somewhere) 'Anonymous session: Yes' 4. Apply this patch, restart_all 5. Repeat 3 => SUCCESS: It will tell the Yes/No correctly regarding anonymous sessions! 6. Sign off :-D Sponsored-by: Universidad ORT Uruguay Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens Signed-off-by: Joy Nelson --- Summary of changes: C4/Search.pm| 4 ++-- opac/opac-detail.pl | 11 --- opac/opac-search.pl | 6 -- opac/opac-shelves.pl| 14 +++--- opac/opac-tags.pl | 12 +--- t/db_dependent/Search.t | 12 +++- 6 files changed, 45 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-240-gdbcae29fa7
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via dbcae29fa74f592deb8ef638179eae1bd451c076 (commit) from a17ea63d028fe500f80ff75b42a4fa1a511fe708 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit dbcae29fa74f592deb8ef638179eae1bd451c076 Author: Joy Nelson Date: Wed May 20 17:11:03 2020 + Bug 24854: DBRev correction Signed-off-by: Joy Nelson --- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-239-ga17ea63d02
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via a17ea63d028fe500f80ff75b42a4fa1a511fe708 (commit) via 12b91faa040d9b0fd166074df587f7394959b0e9 (commit) from 8e51e6d968d2ceecfee298cb313ce74ae373d2f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit a17ea63d028fe500f80ff75b42a4fa1a511fe708 Author: Joy Nelson Date: Wed May 20 14:59:21 2020 + Bug 24854: DBRev 19.11.05.007 Signed-off-by: Joy Nelson commit 12b91faa040d9b0fd166074df587f7394959b0e9 Author: Jonathan Druart Date: Wed May 20 15:01:54 2020 +0200 Bug 24854: Disable IDreamBooks sysprefs Signed-off-by: Joy Nelson --- Summary of changes: Koha.pm| 2 +- installer/data/mysql/updatedatabase.pl | 17 + 2 files changed, 18 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch 19.11.x updated. v19.11.05-237-g8e51e6d968
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 19.11.x has been updated via 8e51e6d968d2ceecfee298cb313ce74ae373d2f0 (commit) via d4f6f65cb73d9c9e78cca16a8b246e72bb661f9d (commit) from ed219bda7e0ff0cbd888c2c8c4318201472fb17d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 8e51e6d968d2ceecfee298cb313ce74ae373d2f0 Author: David Cook Date: Mon May 18 06:23:07 2020 + Bug 25510: Put space between negation operator and function name This patch puts a space between the negation operator ! and the function name (ie log4perl_component). Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joy Nelson commit d4f6f65cb73d9c9e78cca16a8b246e72bb661f9d Author: Jonathan Druart Date: Fri May 15 10:12:46 2020 +0200 Bug 25510: Fix syntax error in koha-common.postinst Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joy Nelson --- Summary of changes: debian/koha-common.postinst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-commits
[koha-commits] main Koha release repository branch master updated. v19.11.00-2262-g5f9cc8ada9
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5f9cc8ada9a3186265f7c4fff1529775f03ac969 (commit) via d517453d95b3a16f9cdc61910a53433310ca2c7f (commit) via f342b0b617237f05287518b6bbf749c7db533a5c (commit) via 067f1b8b556015bbd0f35f36aac700d79467786b (commit) via c6ed5b5da125347ef95ae439eaf21858410f7edf (commit) from f8f890621e8ce99c36f4117eb018bbb3ec3da960 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 5f9cc8ada9a3186265f7c4fff1529775f03ac969 Author: Jonathan Druart Date: Tue May 19 14:26:56 2020 +0200 Bug 25284: chown /var/log/koha log files on koha-create To prevent Apache to create intranet-error.log and opac-error.log with root permission we chown them after it has been restarted (and so created them) when a new Koha instance is created Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit d517453d95b3a16f9cdc61910a53433310ca2c7f Author: David Cook Date: Mon May 18 05:41:34 2020 + Bug 25485: Remove tiny_mce symlink during pre install of deb package This patch removes the tiny_mce symlink before Koha package installation using the same method that we used when we removed the YUI symlink in 2015. Signed-off-by: David Cook Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit f342b0b617237f05287518b6bbf749c7db533a5c Author: David Cook Date: Mon May 18 03:28:56 2020 + Bug 25485: Remove all mention of tiny_mce in debian/rules This patch removes the removal of the following during the build process: /usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce Signed-off-by: David Cook Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit 067f1b8b556015bbd0f35f36aac700d79467786b Author: Kyle M Hall Date: Tue May 12 14:19:53 2020 -0400 Bug 25485: TinyMCE broken in Debian package installs When installing the Debian package of Koha, we install the Debian tinymce package and symlink over our own tinymce libs that are in the Koha codebase. This version of tinymce does not have the same files and because of this, tinymce does not get loaded. We should remove the use of the tinymce Debian package, and just use our own version of TinyMCE. Test Plan: 1) Install Koha 19.11 from package 2) Browse to the news editor 4) Note the WYSIWYG editor is missing 5) Build a new Koha package with this patch applied, install it 6) Reload the news editor 7) Note the WYSIWYG editor is back! Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize commit c6ed5b5da125347ef95ae439eaf21858410f7edf Author: David Cook Date: Mon May 18 07:08:18 2020 + Bug 25524: Remove --line-regexp option in log4perl_component() The current grep expression uses -x|--line-regexp, but that causes the regexp to fail to match since we're not specifying a regexp that can match a whole line. We can either provide a better regexp, or remove that --line-regexp option. This patch removes the --line-regexp (ie -x) option from the grep in log4perl_component, so that it detects logger components correctly. To Test: 0) Apply patch 1) Build Koha package 2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing Koha instance (e.g. on koha-testing-docker), and note it has components for z3950, api, and sip 3) Install package 4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before 5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from /etc/koha/sites/kohadev/log4perl.conf 6) Reinstall package 7) Note that the missing lines have been appended to the file at /etc/koha/sites/kohadev/log4perl.conf Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize --- Summary of changes: debian/control.in | 2 -- debian/koha-common.postinst | 2 +- debian/koha-common.preinst | 3 +++ debian/rules| 4 debian/scripts/koha-create | 2 ++ 5 files changed, 6 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository ___ koha-commits mailing list koha-commits@lists.koha-community.org
