Re: [Koha-devel] Last month before the release
Hi all. First of all, thanks everyone for looking after the problems. Things are almost green. About the 'random failure', I've gotta say it is pretty consistent the last weeks. El lun, 6 nov 2023 a las 11:06, Jonathan Druart via Koha-devel (< koha-devel@lists.koha-community.org>) escribió: > selenium/patrons_search.t has been failing randomly for a while. > Failures should be reported on bug 31199. > > Le lun. 6 nov. 2023 à 07:03, David Cook a > écrit : > >> Also, regarding >> https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/ >> : >> >> >> >> I’ve got a fix for “t_db_dependent_Koha_Patrons_Import_t.No warning >> raised by import_patrons” at >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 >> >> >> >> It looks like Katrin fixed >> “xt_author_valid_templates_t./kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/ >> circulation_batch_checkouts.tt” >> >> >> >> And I can’t reproduce the problem on master for >> “t_db_dependent_selenium_patrons_search_t.Search patrons”, so I’m guessing >> someone has already fixed that one? >> >> >> >> Hopefully the next run will be fail free :D >> >> >> >> David Cook >> >> Senior Software Engineer >> >> Prosentient Systems >> >> Suite 7.03 >> >> 6a Glen St >> >> Milsons Point NSW 2061 >> >> Australia >> >> >> >> Office: 02 9212 0899 >> >> Online: 02 8005 0595 >> >> >> >> *From:* David Cook >> *Sent:* Monday, 6 November 2023 10:32 AM >> *To:* 'Jonathan Druart' >> *Cc:* 'Tomas Cohen Arazi' ; 'koha-devel' < >> koha-devel@lists.koha-community.org> >> *Subject:* RE: [Koha-devel] Last month before the release >> >> >> >> Thanks, Jonathan. Yeah, I think having a live chat sounds like a plan. >> Communication is good. >> >> >> >> Timezones, especially mine, make it tough, but being able to point at >> documentation for policies and procedures is helpful. >> >> >> >> David Cook >> >> Senior Software Engineer >> >> Prosentient Systems >> >> Suite 7.03 >> >> 6a Glen St >> >> Milsons Point NSW 2061 >> >> Australia >> >> >> >> Office: 02 9212 0899 >> >> Online: 02 8005 0595 >> >> >> >> *From:* Jonathan Druart >> *Sent:* Friday, 3 November 2023 7:10 PM >> *To:* David Cook >> *Cc:* Tomas Cohen Arazi ; koha-devel < >> koha-devel@lists.koha-community.org> >> *Subject:* Re: [Koha-devel] Last month before the release >> >> >> >> David, if you don't know Jenkins and you are part of the QA team, I guess >> you are not alone to be lost with our CI structure and it means we have a >> big problem. Either motivation, or tools or communication. >> I am not answering you now but maybe we need to document a bit better how >> it works for the next release, responsibilize people (asking them to fix >> what they broke instead of fixing for them) and finally maybe have a live >> chat beginning of the cycle with RMaints and QA team to (re) explain how it >> works. >> >> Le vendredi 3 novembre 2023, David Cook via Koha-devel < >> koha-devel@lists.koha-community.org> a écrit : >> > It’s not clear to me though how you look at Jenkins runs. Is it going >> to https://dashboard.koha-community.org/ and then clicking on one of the >> badges to go to Jenkins like >> https://jenkins.koha-community.org/job/Koha_Master_U22/ and then >> clicking on “Latest Test Result”? >> > >> > >> > >> > David Cook >> > >> > Senior Software Engineer >> > >> > Prosentient Systems >> > >> > Suite 7.03 >> > >> > 6a Glen St >> > >> > Milsons Point NSW 2061 >> > >> > Australia >> > >> > >> > >> > Office: 02 9212 0899 >> > >> > Online: 02 8005 0595 >> > >> > >> > >> > From: Tomas Cohen Arazi >> > Sent: Friday, 3 November 2023 11:25 AM >> > To: David Cook >> > Cc: koha-devel >> > Subject: Re: [Koha-devel] Last month before the release >> > >> > >> > >> > The suggested sequence is: >> > >> > >> > >> > 1. You notice your stuff for pushed, yay! >> > >> > 2. You look at Jenkins runs for the
Re: [Koha-devel] Last month before the release
selenium/patrons_search.t has been failing randomly for a while. Failures should be reported on bug 31199. Le lun. 6 nov. 2023 à 07:03, David Cook a écrit : > Also, regarding > https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/ > : > > > > I’ve got a fix for “t_db_dependent_Koha_Patrons_Import_t.No warning raised > by import_patrons” at > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 > > > > It looks like Katrin fixed > “xt_author_valid_templates_t./kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/ > circulation_batch_checkouts.tt” > > > > And I can’t reproduce the problem on master for > “t_db_dependent_selenium_patrons_search_t.Search patrons”, so I’m guessing > someone has already fixed that one? > > > > Hopefully the next run will be fail free :D > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* David Cook > *Sent:* Monday, 6 November 2023 10:32 AM > *To:* 'Jonathan Druart' > *Cc:* 'Tomas Cohen Arazi' ; 'koha-devel' < > koha-devel@lists.koha-community.org> > *Subject:* RE: [Koha-devel] Last month before the release > > > > Thanks, Jonathan. Yeah, I think having a live chat sounds like a plan. > Communication is good. > > > > Timezones, especially mine, make it tough, but being able to point at > documentation for policies and procedures is helpful. > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* Jonathan Druart > *Sent:* Friday, 3 November 2023 7:10 PM > *To:* David Cook > *Cc:* Tomas Cohen Arazi ; koha-devel < > koha-devel@lists.koha-community.org> > *Subject:* Re: [Koha-devel] Last month before the release > > > > David, if you don't know Jenkins and you are part of the QA team, I guess > you are not alone to be lost with our CI structure and it means we have a > big problem. Either motivation, or tools or communication. > I am not answering you now but maybe we need to document a bit better how > it works for the next release, responsibilize people (asking them to fix > what they broke instead of fixing for them) and finally maybe have a live > chat beginning of the cycle with RMaints and QA team to (re) explain how it > works. > > Le vendredi 3 novembre 2023, David Cook via Koha-devel < > koha-devel@lists.koha-community.org> a écrit : > > It’s not clear to me though how you look at Jenkins runs. Is it going to > https://dashboard.koha-community.org/ and then clicking on one of the > badges to go to Jenkins like > https://jenkins.koha-community.org/job/Koha_Master_U22/ and then clicking > on “Latest Test Result”? > > > > > > > > David Cook > > > > Senior Software Engineer > > > > Prosentient Systems > > > > Suite 7.03 > > > > 6a Glen St > > > > Milsons Point NSW 2061 > > > > Australia > > > > > > > > Office: 02 9212 0899 > > > > Online: 02 8005 0595 > > > > > > > > From: Tomas Cohen Arazi > > Sent: Friday, 3 November 2023 11:25 AM > > To: David Cook > > Cc: koha-devel > > Subject: Re: [Koha-devel] Last month before the release > > > > > > > > The suggested sequence is: > > > > > > > > 1. You notice your stuff for pushed, yay! > > > > 2. You look at Jenkins runs for the relevant branches (e.g. > Koha_Master_* tasks) > > > > 3. If some test gets broken that day, you try too see if it was you. > Beware sometimes it is not obvious. > > > > > > > > Today there was a failure in the holds API tests, because of a bug that > didn't touch the API, but made the code stricter (?) so the loose tests we > had written had to be tweaked so they didn't trigger a silly error. > > > > > > > > So the devs did right, didn't introduce a bug, but made the tests fail. > But it is all of us, specially those who got patches pushed, who should be > looking after those failures. Team work > > > > > > > > Thanks! > > > > > > > > El jue, 2 nov 2023 21:15, David Cook > escribió: > > > > What’s the best way to do this? > > > > > > > > I think Jenkins might send emails, but I
Re: [Koha-devel] Last month before the release
Also, regarding https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/ : I’ve got a fix for “t_db_dependent_Koha_Patrons_Import_t.No warning raised by import_patrons” at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 It looks like Katrin fixed “xt_author_valid_templates_t./kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt” And I can’t reproduce the problem on master for “t_db_dependent_selenium_patrons_search_t.Search patrons”, so I’m guessing someone has already fixed that one? Hopefully the next run will be fail free :D David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: David Cook Sent: Monday, 6 November 2023 10:32 AM To: 'Jonathan Druart' Cc: 'Tomas Cohen Arazi' ; 'koha-devel' Subject: RE: [Koha-devel] Last month before the release Thanks, Jonathan. Yeah, I think having a live chat sounds like a plan. Communication is good. Timezones, especially mine, make it tough, but being able to point at documentation for policies and procedures is helpful. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Jonathan Druart mailto:jonathan.dru...@bugs.koha-community.org> > Sent: Friday, 3 November 2023 7:10 PM To: David Cook mailto:dc...@prosentient.com.au> > Cc: Tomas Cohen Arazi mailto:tomasco...@gmail.com> >; koha-devel mailto:koha-devel@lists.koha-community.org> > Subject: Re: [Koha-devel] Last month before the release David, if you don't know Jenkins and you are part of the QA team, I guess you are not alone to be lost with our CI structure and it means we have a big problem. Either motivation, or tools or communication. I am not answering you now but maybe we need to document a bit better how it works for the next release, responsibilize people (asking them to fix what they broke instead of fixing for them) and finally maybe have a live chat beginning of the cycle with RMaints and QA team to (re) explain how it works. Le vendredi 3 novembre 2023, David Cook via Koha-devel mailto:koha-devel@lists.koha-community.org> > a écrit : > It’s not clear to me though how you look at Jenkins runs. Is it going to > https://dashboard.koha-community.org/ and then clicking on one of the badges > to go to Jenkins like https://jenkins.koha-community.org/job/Koha_Master_U22/ > and then clicking on “Latest Test Result”? > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > From: Tomas Cohen Arazi mailto:tomasco...@gmail.com> > > Sent: Friday, 3 November 2023 11:25 AM > To: David Cook mailto:dc...@prosentient.com.au> > > Cc: koha-devel <mailto:koha-devel@lists.koha-community.org> > > Subject: Re: [Koha-devel] Last month before the release > > > > The suggested sequence is: > > > > 1. You notice your stuff for pushed, yay! > > 2. You look at Jenkins runs for the relevant branches (e.g. Koha_Master_* > tasks) > > 3. If some test gets broken that day, you try too see if it was you. Beware > sometimes it is not obvious. > > > > Today there was a failure in the holds API tests, because of a bug that > didn't touch the API, but made the code stricter (?) so the loose tests we > had written had to be tweaked so they didn't trigger a silly error. > > > > So the devs did right, didn't introduce a bug, but made the tests fail. But > it is all of us, specially those who got patches pushed, who should be > looking after those failures. Team work > > > > Thanks! > > > > El jue, 2 nov 2023 21:15, David Cook <mailto:dc...@prosentient.com.au> > escribió: > > What’s the best way to do this? > > > > I think Jenkins might send emails, but I think my mail server blocked it ages > ago as spam. > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > From: Koha-devel <mailto:koha-devel-boun...@lists.koha-community.org> > On Behalf Of Tomas > Cohen Arazi via Koha-devel > Sent: Friday, 3 November 2023 12:31 AM > To: koha-devel <mailto:koha-devel@lists.koha-community.org> > > Subject: [Koha-devel] Last month before the release > > > &g
Re: [Koha-devel] Last month before the release
Thanks, Jonathan. Yeah, I think having a live chat sounds like a plan. Communication is good. Timezones, especially mine, make it tough, but being able to point at documentation for policies and procedures is helpful. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Jonathan Druart Sent: Friday, 3 November 2023 7:10 PM To: David Cook Cc: Tomas Cohen Arazi ; koha-devel Subject: Re: [Koha-devel] Last month before the release David, if you don't know Jenkins and you are part of the QA team, I guess you are not alone to be lost with our CI structure and it means we have a big problem. Either motivation, or tools or communication. I am not answering you now but maybe we need to document a bit better how it works for the next release, responsibilize people (asking them to fix what they broke instead of fixing for them) and finally maybe have a live chat beginning of the cycle with RMaints and QA team to (re) explain how it works. Le vendredi 3 novembre 2023, David Cook via Koha-devel mailto:koha-devel@lists.koha-community.org> > a écrit : > It’s not clear to me though how you look at Jenkins runs. Is it going to > https://dashboard.koha-community.org/ and then clicking on one of the badges > to go to Jenkins like https://jenkins.koha-community.org/job/Koha_Master_U22/ > and then clicking on “Latest Test Result”? > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > From: Tomas Cohen Arazi mailto:tomasco...@gmail.com> > > Sent: Friday, 3 November 2023 11:25 AM > To: David Cook mailto:dc...@prosentient.com.au> > > Cc: koha-devel <mailto:koha-devel@lists.koha-community.org> > > Subject: Re: [Koha-devel] Last month before the release > > > > The suggested sequence is: > > > > 1. You notice your stuff for pushed, yay! > > 2. You look at Jenkins runs for the relevant branches (e.g. Koha_Master_* > tasks) > > 3. If some test gets broken that day, you try too see if it was you. Beware > sometimes it is not obvious. > > > > Today there was a failure in the holds API tests, because of a bug that > didn't touch the API, but made the code stricter (?) so the loose tests we > had written had to be tweaked so they didn't trigger a silly error. > > > > So the devs did right, didn't introduce a bug, but made the tests fail. But > it is all of us, specially those who got patches pushed, who should be > looking after those failures. Team work > > > > Thanks! > > > > El jue, 2 nov 2023 21:15, David Cook <mailto:dc...@prosentient.com.au> > escribió: > > What’s the best way to do this? > > > > I think Jenkins might send emails, but I think my mail server blocked it ages > ago as spam. > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > From: Koha-devel <mailto:koha-devel-boun...@lists.koha-community.org> > On Behalf Of Tomas > Cohen Arazi via Koha-devel > Sent: Friday, 3 November 2023 12:31 AM > To: koha-devel <mailto:koha-devel@lists.koha-community.org> > > Subject: [Koha-devel] Last month before the release > > > > Hi all. > > > > We are almost done with the release, a couple medium/big things to push > today/tomorrow and then bug fixing. > > > > I wanted to ask y'all to please view the Jenkins tasks status anytime after > your stuff has been pushed. I know I said this many times, but some devs > clearly break some tests that are trivially fixable and the team needs you to > take care of your breakages. > > > > I'm doing my best to track things and fix, but you should all be worried > about that. > > > > -- > > Tomás Cohen Arazi > > Theke Solutions (https://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Last month before the release
Because of 26170, I left a comment there. Le ven. 3 nov. 2023 à 13:49, Tomas Cohen Arazi via Koha-devel a écrit : > > Hi all, this is master's latest failures: > > https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/ > > The selenium failure has been there for a while, and the other ones are > recent. > > El jue, 2 nov 2023 a las 10:30, Tomas Cohen Arazi () > escribió: >> >> Hi all. >> >> We are almost done with the release, a couple medium/big things to push >> today/tomorrow and then bug fixing. >> >> I wanted to ask y'all to please view the Jenkins tasks status anytime after >> your stuff has been pushed. I know I said this many times, but some devs >> clearly break some tests that are trivially fixable and the team needs you >> to take care of your breakages. >> >> I'm doing my best to track things and fix, but you should all be worried >> about that. >> >> -- >> Tomás Cohen Arazi >> Theke Solutions (https://theke.io) >> ✆ +54 9351 3513384 >> GPG: B2F3C15F > > > > -- > Tomás Cohen Arazi > Theke Solutions (https://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F > ___ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : https://www.koha-community.org/ > git : https://git.koha-community.org/ > bugs : https://bugs.koha-community.org/ ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Last month before the release
Hi all, this is master's latest failures: https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/ The selenium failure has been there for a while, and the other ones are recent. El jue, 2 nov 2023 a las 10:30, Tomas Cohen Arazi () escribió: > Hi all. > > We are almost done with the release, a couple medium/big things to push > today/tomorrow and then bug fixing. > > I wanted to ask y'all to please view the Jenkins tasks status anytime > after your stuff has been pushed. I know I said this many times, but some > devs clearly break some tests that are trivially fixable and the team needs > you to take care of your breakages. > > I'm doing my best to track things and fix, but you should all be worried > about that. > > -- > Tomás Cohen Arazi > Theke Solutions (https://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F > -- Tomás Cohen Arazi Theke Solutions (https://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Last month before the release
David, if you don't know Jenkins and you are part of the QA team, I guess you are not alone to be lost with our CI structure and it means we have a big problem. Either motivation, or tools or communication. I am not answering you now but maybe we need to document a bit better how it works for the next release, responsibilize people (asking them to fix what they broke instead of fixing for them) and finally maybe have a live chat beginning of the cycle with RMaints and QA team to (re) explain how it works. Le vendredi 3 novembre 2023, David Cook via Koha-devel < koha-devel@lists.koha-community.org> a écrit : > It’s not clear to me though how you look at Jenkins runs. Is it going to https://dashboard.koha-community.org/ and then clicking on one of the badges to go to Jenkins like https://jenkins.koha-community.org/job/Koha_Master_U22/ and then clicking on “Latest Test Result”? > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > From: Tomas Cohen Arazi > Sent: Friday, 3 November 2023 11:25 AM > To: David Cook > Cc: koha-devel > Subject: Re: [Koha-devel] Last month before the release > > > > The suggested sequence is: > > > > 1. You notice your stuff for pushed, yay! > > 2. You look at Jenkins runs for the relevant branches (e.g. Koha_Master_* tasks) > > 3. If some test gets broken that day, you try too see if it was you. Beware sometimes it is not obvious. > > > > Today there was a failure in the holds API tests, because of a bug that didn't touch the API, but made the code stricter (?) so the loose tests we had written had to be tweaked so they didn't trigger a silly error. > > > > So the devs did right, didn't introduce a bug, but made the tests fail. But it is all of us, specially those who got patches pushed, who should be looking after those failures. Team work > > > > Thanks! > > > > El jue, 2 nov 2023 21:15, David Cook escribió: > > What’s the best way to do this? > > > > I think Jenkins might send emails, but I think my mail server blocked it ages ago as spam. > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > From: Koha-devel On Behalf Of Tomas Cohen Arazi via Koha-devel > Sent: Friday, 3 November 2023 12:31 AM > To: koha-devel > Subject: [Koha-devel] Last month before the release > > > > Hi all. > > > > We are almost done with the release, a couple medium/big things to push today/tomorrow and then bug fixing. > > > > I wanted to ask y'all to please view the Jenkins tasks status anytime after your stuff has been pushed. I know I said this many times, but some devs clearly break some tests that are trivially fixable and the team needs you to take care of your breakages. > > > > I'm doing my best to track things and fix, but you should all be worried about that. > > > > -- > > Tomás Cohen Arazi > > Theke Solutions (https://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Last month before the release
It’s not clear to me though how you look at Jenkins runs. Is it going to https://dashboard.koha-community.org/ and then clicking on one of the badges to go to Jenkins like https://jenkins.koha-community.org/job/Koha_Master_U22/ and then clicking on “Latest Test Result”? David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Tomas Cohen Arazi Sent: Friday, 3 November 2023 11:25 AM To: David Cook Cc: koha-devel Subject: Re: [Koha-devel] Last month before the release The suggested sequence is: 1. You notice your stuff for pushed, yay! 2. You look at Jenkins runs for the relevant branches (e.g. Koha_Master_* tasks) 3. If some test gets broken that day, you try too see if it was you. Beware sometimes it is not obvious. Today there was a failure in the holds API tests, because of a bug that didn't touch the API, but made the code stricter (?) so the loose tests we had written had to be tweaked so they didn't trigger a silly error. So the devs did right, didn't introduce a bug, but made the tests fail. But it is all of us, specially those who got patches pushed, who should be looking after those failures. Team work Thanks! El jue, 2 nov 2023 21:15, David Cook mailto:dc...@prosentient.com.au> > escribió: What’s the best way to do this? I think Jenkins might send emails, but I think my mail server blocked it ages ago as spam. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel mailto:koha-devel-boun...@lists.koha-community.org> > On Behalf Of Tomas Cohen Arazi via Koha-devel Sent: Friday, 3 November 2023 12:31 AM To: koha-devel mailto:koha-devel@lists.koha-community.org> > Subject: [Koha-devel] Last month before the release Hi all. We are almost done with the release, a couple medium/big things to push today/tomorrow and then bug fixing. I wanted to ask y'all to please view the Jenkins tasks status anytime after your stuff has been pushed. I know I said this many times, but some devs clearly break some tests that are trivially fixable and the team needs you to take care of your breakages. I'm doing my best to track things and fix, but you should all be worried about that. -- Tomás Cohen Arazi Theke Solutions (https://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Last month before the release
The suggested sequence is: 1. You notice your stuff for pushed, yay! 2. You look at Jenkins runs for the relevant branches (e.g. Koha_Master_* tasks) 3. If some test gets broken that day, you try too see if it was you. Beware sometimes it is not obvious. Today there was a failure in the holds API tests, because of a bug that didn't touch the API, but made the code stricter (?) so the loose tests we had written had to be tweaked so they didn't trigger a silly error. So the devs did right, didn't introduce a bug, but made the tests fail. But it is all of us, specially those who got patches pushed, who should be looking after those failures. Team work Thanks! El jue, 2 nov 2023 21:15, David Cook escribió: > What’s the best way to do this? > > > > I think Jenkins might send emails, but I think my mail server blocked it > ages ago as spam. > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* Koha-devel *On > Behalf Of *Tomas Cohen Arazi via Koha-devel > *Sent:* Friday, 3 November 2023 12:31 AM > *To:* koha-devel > *Subject:* [Koha-devel] Last month before the release > > > > Hi all. > > > > We are almost done with the release, a couple medium/big things to push > today/tomorrow and then bug fixing. > > > > I wanted to ask y'all to please view the Jenkins tasks status anytime > after your stuff has been pushed. I know I said this many times, but some > devs clearly break some tests that are trivially fixable and the team needs > you to take care of your breakages. > > > > I'm doing my best to track things and fix, but you should all be worried > about that. > > > > -- > > Tomás Cohen Arazi > > Theke Solutions (https://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F > ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Last month before the release
What’s the best way to do this? I think Jenkins might send emails, but I think my mail server blocked it ages ago as spam. David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 From: Koha-devel On Behalf Of Tomas Cohen Arazi via Koha-devel Sent: Friday, 3 November 2023 12:31 AM To: koha-devel Subject: [Koha-devel] Last month before the release Hi all. We are almost done with the release, a couple medium/big things to push today/tomorrow and then bug fixing. I wanted to ask y'all to please view the Jenkins tasks status anytime after your stuff has been pushed. I know I said this many times, but some devs clearly break some tests that are trivially fixable and the team needs you to take care of your breakages. I'm doing my best to track things and fix, but you should all be worried about that. -- Tomás Cohen Arazi Theke Solutions (https://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
[Koha-devel] Last month before the release
Hi all. We are almost done with the release, a couple medium/big things to push today/tomorrow and then bug fixing. I wanted to ask y'all to please view the Jenkins tasks status anytime after your stuff has been pushed. I know I said this many times, but some devs clearly break some tests that are trivially fixable and the team needs you to take care of your breakages. I'm doing my best to track things and fix, but you should all be worried about that. -- Tomás Cohen Arazi Theke Solutions (https://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
