[Koha-devel] QA Tools change

[Renvoize, Martin]

Hi all,

tl;dr: Changed unit tests now run be default when using the QA test tools.
--no-tests can be used to disable this functionality at runtime.

The longer version.

I recently submitted a merge request for the QA tool to enable running
changed unit tests by default and it's just been merged.

In the merge request we remove the --run-tests flag we used to require to
run tests and instead replace it with a --no-tests option allowed users to
skip the tests explicitly.

I've also got another merge request open that's being worked on that
attempts to identify related unit tests for a patchset and run those too.
This will certainly be behind a --more-tests switch to start with whilst we
refine the guesswork in identifying such tests.

Martin
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/

[Koha-devel] QA tools

[Marcel de Rooy]

Tiny bug in QohA/File/Template.pm for template dir (OPAC)
sub check_valid_template
$template_dir =
  File::Spec->rel2abs("koha-tmpl/$interface/prog/en/modules");
This is wrong, but the variable is no longer used. Can be removed.
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/

[Koha-devel] QA Tools

[Marcel de Rooy]

Hi Jonathan,

Got this warning from qa tools:
POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666

Looking at the code in qa tools, I come across:

} elsif ( $before->{rating} > $after->{rating} ) {
# Not sure we can reach this
@diff = ('POD coverage was greater before, try perl 
-MPod::Coverage=PackageName -e666');

When I removed a routine from C4::Biblio, this happens:
Before
C4::Biblio has a Pod::Coverage rating of 0.96078431372549
After
C4::Biblio has a Pod::Coverage rating of 0.96

If we have N subroutines and 2 without POD and a score of 2/N, and I remove one 
routine, we will now have 2 / N - 1.
This means that the before > after test does not work here. Raises a false 
negative.

Marcel


___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/