Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins
Hi Victor, I will be addressing your question on the bug itself. Marcel T/m 18 jaar gratis Kijk hier de nieuwste aflevering van Rijksmuseum Unlocked x! xxx Please think before you print Van: Koha-devel namens Victor Grousset/tuxayo Verzonden: maandag 29 maart 2021 18:25 Aan: koha-devel Onderwerp: [Koha-devel] Second look needed on a few (2!) lines related to plugins Hi :) It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl There are two lines in the patch that are out of my knowledge to QA: https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2Fbugzilla3%2Fshow_bug.cgi%3Fid%3D25476%23c6data=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7Cda29eb3d4cc44518a79c08d8f2cf5089%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637526320837790151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000sdata=xWTrVvwASSdQOcGNYASiAzNI2V%2BmsOUtUQUXGkjQvog%3Dreserved=0 [% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): () Does this look familiar to anyone? Cheers, -- Victor Grousset/tuxayo ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.koha-community.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fkoha-develdata=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7Cda29eb3d4cc44518a79c08d8f2cf5089%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637526320837790151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000sdata=%2Bbf1TDlsBHWdbKt126zZZTrCg4xTlhytwxHqdlkeL1s%3Dreserved=0 website : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.koha-community.org%2Fdata=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7Cda29eb3d4cc44518a79c08d8f2cf5089%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637526320837790151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000sdata=zckKFPnc16akmymn%2B%2FPTD6eYFWk9F%2B0kiGYxwvatPgQ%3Dreserved=0 git : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.koha-community.org%2Fdata=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7Cda29eb3d4cc44518a79c08d8f2cf5089%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637526320837790151%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000sdata=R3KpCZJD2DRWosflnurbPmIPHTJtXYITr2loYRdjOjQ%3Dreserved=0 bugs : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2Fdata=04%7C01%7Cm.de.rooy%40rijksmuseum.nl%7Cda29eb3d4cc44518a79c08d8f2cf5089%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C637526320837800139%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000sdata=KRdrh%2BkNsTQ2TvA%2BVOzOusXKlqlB9CeZBmTdZV42UB0%3Dreserved=0 ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins
I wrote the patch close to a year ago so I have no idea why I used the syntax
that I did. I think maybe I was copying what was already there for the search
feature at the time.
But I'm happy for people to change it!
And thanks for the compliment. I do like this feature!
David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia
Office: 02 9212 0899
Online: 02 8005 0595
-Original Message-
From: Koha-devel On Behalf Of
Fridolin SOMERS
Sent: Tuesday, 30 March 2021 6:08 PM
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] Second look needed on a few (2!) lines related to
plugins
Hi,
In my opinion this syntax looks strange.
I'd prefer :
my $filter = { uploadcategorycode => $browsecategory };
$filter{public} = 1 if $plugin;
$uploads = Koha::UploadedFiles->search($filter)->unblessed;
Super cool enhancement BTW ;)
Best regards,
Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
> Hi :)
>
> It's about Bug 25476 - Uploaded files can't be easily browsed via
> upload.pl
>
> There are two lines in the patch that are out of my knowledge to QA:
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
>
> [% PROCESS plugin_pars %]
> [...]
> $plugin? ( public => 1 ): ()
>
> Does this look familiar to anyone?
>
> Cheers,
>
--
Fridolin SOMERS Software and system maintainer 濾
BibLibre, France
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/ git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins
On 21-03-30 01:31, Mason James wrote: hiya, here's some info... https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm Indeed there is a trinary, but it's about if it makes sense to do "those things" related to plugins. Is that useful, is that valid, is that enough? Cheers, -- Victor Grousset/tuxayo ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins
Hi,
In my opinion this syntax looks strange.
I'd prefer :
my $filter = { uploadcategorycode => $browsecategory };
$filter{public} = 1 if $plugin;
$uploads = Koha::UploadedFiles->search($filter)->unblessed;
Super cool enhancement BTW ;)
Best regards,
Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
[% PROCESS plugin_pars %]
[...]
$plugin? ( public => 1 ): ()
Does this look familiar to anyone?
Cheers,
--
Fridolin SOMERS
Software and system maintainer 濾
BibLibre, France
___
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins
hiya, here's some info... https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm On 30/03/21 5:25 am, Victor Grousset/tuxayo wrote: Hi :) It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl There are two lines in the patch that are out of my knowledge to QA: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6 [% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): () Does this look familiar to anyone? Cheers, ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
[Koha-devel] Second look needed on a few (2!) lines related to plugins
Hi :) It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl There are two lines in the patch that are out of my knowledge to QA: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6 [% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): () Does this look familiar to anyone? Cheers, -- Victor Grousset/tuxayo ___ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
