Re: [kopete-devel] kopete waking up the CPU
Hi Will,
I wrote a patch to fix the smooth scrolling timers by disabling them
when the scroll bar is not moving, the UI works as before.
I did post it to the list once before, but I don't think my email
persuaded others of the severity of the problem.
My personal opinion, for what its worth, is that the smooth-scroll
code is an appalling hack.
Regards,
Robert.
On 13/05/07, Will Stephenson <[EMAIL PROTECTED]> wrote:
On Sunday 13 May 2007 21:41:46 Martijn Klingens wrote:
> On Friday 11 May 2007, Will Stephenson wrote:
> > I've tried 2 and 3 so far, removing the code seems to bring a greater
> > reduction in activity as seen by strace than setting [ContactList]
> > SmoothScrolling=false. TBH I prefer option 3 because I'm a mean bastard
> > ;) - not really, but because I find that the feature, while cool,
> > introduces nonstandard UI behaviour - and would prefer to see this kind
> > of thing in an 'eyecandy' contactlist version. My apologies to Engin, of
> > course.
> >
> > What do you think?
>
> I've always hated smooth scrolling in all applications that have it, so
> guess what I'd choose :)
I'll sharpen my axe then.
Will
--
Will Stephenson
Software Engineer
[EMAIL PROTECTED]
+49- 911- 740 53 - 227
___
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
Index: libkopete/kopeteaway.cpp
===
--- libkopete/kopeteaway.cpp (revision 646242)
+++ libkopete/kopeteaway.cpp (working copy)
@@ -188,7 +188,7 @@
}
// init the timer
- d->timer = new QTimer(this, "AwayTimer");
+d->timer = new QTimer(this, "AwayTimer");
connect(d->timer, SIGNAL(timeout()), this, SLOT(slotTimerTimeout()));
d->timer->start(4000);
Index: libkopete/ui/kopetelistview.cpp
===
--- libkopete/ui/kopetelistview.cpp (revision 646242)
+++ libkopete/ui/kopetelistview.cpp (working copy)
@@ -33,6 +33,7 @@
#include
#include
+#include
namespace Kopete {
namespace UI {
@@ -101,7 +102,7 @@
//! The status of smooth scrolling, enabled or disabled.
bool smoothScrollingEnabled;
//! This will be the QTimer's ID which will be updating smooth scrolling animation.
- double smoothScrollingTimer;
+ int smoothScrollingTimer;
//! The time interval which the smooth scrolling will be updated.
double smoothScrollingTimerInterval;
//! This will be the target scroll bar position. Note that this value is in the sense of contents height in
@@ -324,17 +325,12 @@
{
// Intercept scrollbar's events
verticalScrollBar()->installEventFilter( this );
- // Install the timer
- d->smoothScrollingTimer = startTimer( (int)d->smoothScrollingTimerInterval );
// If we want to enable smooth scrolling when item has changed with keypresses etc, we need this
connect( this, SIGNAL( currentChanged( QListViewItem* ) ), this, SLOT( slotCurrentChanged(QListViewItem*) ) );
// Disable autoscroll, we will do it the smooth way.
d->smoothScrollDragAutoScroll = dragAutoScroll();
setDragAutoScroll( false );
- // Init the timers to simulate continuous press
- d->continuousLinePressTimer = startTimer( d->continuousLinePressTimerInterval );
- d->continuousPagePressTimer = startTimer( d->continuousPagePressTimerInterval );
-
+
}
else // If disabled
{
@@ -342,21 +338,61 @@
verticalScrollBar()->removeEventFilter( this );
// Restore line/page step sizes
verticalScrollBar()->setLineStep( d->smoothScrollingLineStep );
- // Kill the already started timer
- killTimer( (int)d->smoothScrollingTimer );
- d->smoothScrollingTimer = 0;
// We don't need to list currentChanged anymore
disconnect( this, SIGNAL( currentChanged( QListViewItem* ) ), this, SLOT( slotCurrentChanged(QListViewItem*) ) );
// Restore the autoscroll
setDragAutoScroll( d->smoothScrollDragAutoScroll );
// Kill the continuous press timers
- killTimer( d->continuousLinePressTimer );
- d->continuousLinePressTimer = 0;
- killTimer( d->continuousPagePressTimer );
- d->continuousPagePressTimer = 0;
+ setSmoothScrollTimersEnabled(false);
}
}
+void ListView::setSmoothScrollTimersEnabled(bool enableTimers)
+{
+ if ( enableTimers )
+ {
+ //kdDebug() << "smooth scrolling timers enabled" << endl;
+
+ // for each of the three timers used to manage smooth scrolling, check
+ // whether they are already enabled and if not, start them.
+
+ if ( d->smoothScrollingTimer == 0 )
+ d->smoothScrollingTimer = startTimer( (int)d->smoothScrollingTimerInterval );
+
+ // start the timers to simulate continuous press
+ if ( d->continuousLinePressTimer == 0 )
+ d->continuousLinePressTimer = startTimer( d->continuousLinePressTimerInterval );
+
+ if ( d->continuousPagePressTimer == 0 )
+ d->continuousPagePressTimer = startTimer( d->continuousPagePressTimerInterval );
+ }
+ else
+ {
+ //kdDebug() << "smooth scrolling timers di
[kopete-devel] [Bug 60931] presence signing with jabber does not work
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=60931 opensource till name changed: What|Removed |Added CC||opensource till name --- Additional Comments From opensource till name 2007-05-15 19:53 --- Message encryption for Jabber is described in http://www.xmpp.org/extensions/xep-0027.html, there is written: "[This method] does not include feature negotiation; instead, signed is used as an indicator of support." So when you support XEP-0027, then it should be indicated with a signed presence. ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] [Bug 57234] messages from people not in contact list should be filtered.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=57234 --- Additional Comments From andre duffeck de 2007-05-15 13:55 --- 1. you are not very well informed 2. you should maybe think about FOSS and the people developing it a bit 3. i'm not in the mood talking to people like you any longer ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] [Bug 57234] messages from people not in contact list should be filtered.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=57234 --- Additional Comments From admin eregion de 2007-05-15 12:06 --- 1. a plugin in "trunk" does not help the average user 2. nooone can tell for sure which features in trunk will be moved into a release version, and when, if at all. 3. the website doesnt really help. Not even a little bit of information how to grab that plugin from the svn and build it into a "release" kopete. ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] [Bug 145449] New: Extremely slow remote webcam motion when local webcam is sent.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=145449 Summary: Extremely slow remote webcam motion when local webcam is sent. Product: kopete Version: unspecified Platform: unspecified OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general AssignedTo: kopete-devel kde org ReportedBy: public mosteo com Version: 0.12.4 (using KDE 3.5.6, Kubuntu (feisty) 4:3.5.6-0ubuntu14) Compiler: Target: i486-linux-gnu OS:Linux (i686) release 2.6.20-15-lowlatency I don't have another webcam to test, so not sure how to pinpoint the problem to kopete or the drivers. Device: Pixart PAC207-BCA Steps to reproduce: Have a friend using MSN send its webcam to you. It is received normally. Start sending your own camera. Your framerate is ok. However, the remote webcam framerate drops to around one frame each three/four seconds or less. Worse still, its no longer synchronized: you see ALL frames, as they were taken in the remote side, but extremely slowly. That is, you can see like ten seconds of remote time in one minute of local time. If you close your webcam, the remote one starts working at full pace, or even quicker than real time, as if to "catch-up". ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] [Bug 123521] do not put focus on CANCEL by default in webcam window
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=123521 public mosteo com changed: What|Removed |Added Status|UNCONFIRMED |NEW everconfirmed|0 |1 --- Additional Comments From public mosteo com 2007-05-15 10:28 --- *** This bug has been confirmed by popular vote. *** ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] [Bug 123521] do not put focus on CANCEL by default in webcam window
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=123521 --- Additional Comments From public mosteo com 2007-05-15 10:27 --- Same observed here, how is this still UNCONFIRMED if 125621 was closed as DUPLICATED of this one? ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
[kopete-devel] [Bug 57234] messages from people not in contact list should be filtered.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=57234 andre duffeck de changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From andre duffeck de 2007-05-15 09:20 --- Kopete trunk has got a privacy plugin, allowing whitelisting, blacklisting, ignoring messages from contacts not on your contact list and filtering for keywords. See http://andredsblog.blogspot.com/2006/09/i-proudly-present-kopete-privacy.html for more information. ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
