Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/ --- (Updated Ott. 4, 2017, 11:22 p.m.) Status -- This change has been discarded. Review request for Kopete and Pali Rohár. Repository: kopete Description --- Skype API was shut down sometime before. Hence the currently provided URL goes to an unavailable webpage. This patch replaces it a URL that works. Diffs - protocols/skype/ui/skypeeditaccountbase.ui ff41acc764e08410f7c4ac08402dcbd2e11ea858 Diff: https://git.reviewboard.kde.org/r/123162/diff/1/ Testing --- Rebuilt from source, testing done. Works fine. Thanks, R.Harish Navnit
Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review103792 --- The old skype client is basically gone; the new version (5.x) is an electron application with no dbus support, so the entire plugin should be removed. This makes this change useless, and I'm going to abandon this. - Luigi Toscano On Mar. 28, 2015, 3:55 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123162/ > --- > > (Updated Mar. 28, 2015, 3:55 p.m.) > > > Review request for Kopete and Pali Rohár. > > > Repository: kopete > > > Description > --- > > Skype API was shut down sometime before. Hence the currently provided URL > goes to an unavailable webpage. This patch replaces it a URL that works. > > > Diffs > - > > protocols/skype/ui/skypeeditaccountbase.ui > ff41acc764e08410f7c4ac08402dcbd2e11ea858 > > > Diff: https://git.reviewboard.kde.org/r/123162/diff/1/ > > > Testing > --- > > Rebuilt from source, testing done. Works fine. > > > Thanks, > > R.Harish Navnit > >
Re: Review Request 123162: Replace outdated URL in add account settings
> On Feb. 26, 2017, 5:24 a.m., Albert Astals Cid wrote: > > I'll discard this in two weeks, noone has worked in this for almost 2 years. This year there's a GSoC project that aims to finish kopete's kf5 port(current state in kf5 branch of repo). If possible, I'd request to leave the open review requests untouched till a student either finishes or at least takes note of these. Would be useful IMO. - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review102618 --- On March 28, 2015, 8:25 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123162/ > --- > > (Updated March 28, 2015, 8:25 p.m.) > > > Review request for Kopete and Pali Rohár. > > > Repository: kopete > > > Description > --- > > Skype API was shut down sometime before. Hence the currently provided URL > goes to an unavailable webpage. This patch replaces it a URL that works. > > > Diffs > - > > protocols/skype/ui/skypeeditaccountbase.ui > ff41acc764e08410f7c4ac08402dcbd2e11ea858 > > Diff: https://git.reviewboard.kde.org/r/123162/diff/ > > > Testing > --- > > Rebuilt from source, testing done. Works fine. > > > Thanks, > > R.Harish Navnit > >
Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review102618 --- I'll discard this in two weeks, noone has worked in this for almost 2 years. - Albert Astals Cid On March 28, 2015, 2:55 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123162/ > --- > > (Updated March 28, 2015, 2:55 p.m.) > > > Review request for Kopete and Pali Rohár. > > > Repository: kopete > > > Description > --- > > Skype API was shut down sometime before. Hence the currently provided URL > goes to an unavailable webpage. This patch replaces it a URL that works. > > > Diffs > - > > protocols/skype/ui/skypeeditaccountbase.ui > ff41acc764e08410f7c4ac08402dcbd2e11ea858 > > Diff: https://git.reviewboard.kde.org/r/123162/diff/ > > > Testing > --- > > Rebuilt from source, testing done. Works fine. > > > Thanks, > > R.Harish Navnit > >
Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review79618 --- I'm against this change. Rather remove that URL from text box. - Pali Rohár On mar. 28, 2015, 3:55 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/ --- (Updated mar. 28, 2015, 3:55 popoludní) Review request for Kopete and Pali Rohár. Repository: kopete Description --- Skype API was shut down sometime before. Hence the currently provided URL goes to an unavailable webpage. This patch replaces it a URL that works. Diffs - protocols/skype/ui/skypeeditaccountbase.ui ff41acc764e08410f7c4ac08402dcbd2e11ea858 Diff: https://git.reviewboard.kde.org/r/123162/diff/ Testing --- Rebuilt from source, testing done. Works fine. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 123162: Replace outdated URL in add account settings
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/#review79617 --- Ship it! If url works. Ship it :) - Laurent Montel On mars 28, 2015, 2:55 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123162/ --- (Updated mars 28, 2015, 2:55 après-midi) Review request for Kopete and Pali Rohár. Repository: kopete Description --- Skype API was shut down sometime before. Hence the currently provided URL goes to an unavailable webpage. This patch replaces it a URL that works. Diffs - protocols/skype/ui/skypeeditaccountbase.ui ff41acc764e08410f7c4ac08402dcbd2e11ea858 Diff: https://git.reviewboard.kde.org/r/123162/diff/ Testing --- Rebuilt from source, testing done. Works fine. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
