Re: Review Request 124332: Compile without KDE3/Qt3 support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/#review82817 --- plugins/alias/CMakeLists.txt (line 13) https://git.reviewboard.kde.org/r/124332/#comment57134 runtime test for all plugins is required - Pali Rohár On júl 12, 2015, 4:14 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/ --- (Updated júl 12, 2015, 4:14 popoludní) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Some plugins have been ported and compile without KDE3/Qt3 support libraries. Diffs - plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff plugins/nowlistening/CMakeLists.txt d910afc14c00c4bac80b934753aadb70561d plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 Diff: https://git.reviewboard.kde.org/r/124332/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124332: Compile without KDE3/Qt3 support
On July 13, 2015, 11:18 a.m., Laurent Montel wrote: I didn't test compile so I hope that it's ok. Please commit in master Pali Rohár wrote: Compilation test is not enough, specially for plugins. On Linux when building shared libraries (=also plugins) gcc by default allows you to create library with unreferenced symbols. It means that gcc/ld does not check if every symbol (function, variable) is found in some linked library. So doing runtime test for any change which remove library dependency from plugins is *REQUIRED*. I'll check again. Thanks. - R.Harish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/#review82448 --- On July 12, 2015, 7:44 p.m., R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/ --- (Updated July 12, 2015, 7:44 p.m.) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Some plugins have been ported and compile without KDE3/Qt3 support libraries. Diffs - plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff plugins/nowlistening/CMakeLists.txt d910afc14c00c4bac80b934753aadb70561d plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 Diff: https://git.reviewboard.kde.org/r/124332/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124332: Compile without KDE3/Qt3 support
On júl 13, 2015, 7:48 dopoludnia, Laurent Montel wrote: I didn't test compile so I hope that it's ok. Please commit in master Compilation test is not enough, specially for plugins. On Linux when building shared libraries (=also plugins) gcc by default allows you to create library with unreferenced symbols. It means that gcc/ld does not check if every symbol (function, variable) is found in some linked library. So doing runtime test for any change which remove library dependency from plugins is *REQUIRED*. - Pali --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/#review82448 --- On júl 12, 2015, 4:14 popoludní, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/ --- (Updated júl 12, 2015, 4:14 popoludní) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Some plugins have been ported and compile without KDE3/Qt3 support libraries. Diffs - plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff plugins/nowlistening/CMakeLists.txt d910afc14c00c4bac80b934753aadb70561d plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 Diff: https://git.reviewboard.kde.org/r/124332/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
Re: Review Request 124332: Compile without KDE3/Qt3 support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/#review82448 --- Ship it! I didn't test compile so I hope that it's ok. Please commit in master - Laurent Montel On juil. 12, 2015, 2:14 après-midi, R.Harish Navnit wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124332/ --- (Updated juil. 12, 2015, 2:14 après-midi) Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kopete Description --- Some plugins have been ported and compile without KDE3/Qt3 support libraries. Diffs - plugins/alias/CMakeLists.txt ddfe3c24df9b3668e1b3194e626c22b2f6bb55b6 plugins/autoreplace/CMakeLists.txt a7a2e90402a503d5ced1166e55bcb82189f1f8ff plugins/nowlistening/CMakeLists.txt d910afc14c00c4bac80b934753aadb70561d plugins/texteffect/CMakeLists.txt 892e732004d371c9276040bd35d52d8f06e789e6 Diff: https://git.reviewboard.kde.org/r/124332/diff/ Testing --- Build succeeded. Thanks, R.Harish Navnit ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
