D8319: Split the UI initialization and fix the about box

[Luigi Toscano]

ltoscano added a project: Kopete.
ltoscano added a subscriber: Kopete.

REPOSITORY
  R434 Kopete

REVISION DETAIL
  https://phabricator.kde.org/D8319

To: ltoscano, pali, mlaurent
Cc: #kopete

D7635: Update History Plugin and create logs in xml format

[Laurent Montel]

mlaurent added a comment.


  qCDebug not only qDebug :)
  Otherwise we can't disable debug.
  thanks

REPOSITORY
  R434 Kopete

REVISION DETAIL
  https://phabricator.kde.org/D7635

To: vijaykrishnavanshi, pali, mlaurent
Cc: #kopete

D7635: Update History Plugin and create logs in xml format

[Vijay Krishnavanshi]

vijaykrishnavanshi updated this revision to Diff 21671.
vijaykrishnavanshi added a comment.
Restricted Application added a project: Kopete.
Restricted Application added a subscriber: Kopete.


  Tweaked UI and port kDebug

REPOSITORY
  R434 Kopete

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7635?vs=19024&id=21671

REVISION DETAIL
  https://phabricator.kde.org/D7635

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/history/CMakeLists.txt
  plugins/history/converter.cpp
  plugins/history/historydialog.cpp
  plugins/history/historyguiclient.cpp
  plugins/history/historyimport.cpp
  plugins/history/historylogger.cpp
  plugins/history/historyplugin.cpp
  plugins/history/historypreferences.cpp
  plugins/history/historyviewer.ui

To: vijaykrishnavanshi, pali, mlaurent
Cc: #kopete

D8319: Split the UI initialization and fix the about box

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R434 Kopete

BRANCH
  kf5-fix-aboutbox

REVISION DETAIL
  https://phabricator.kde.org/D8319

To: ltoscano, pali, mlaurent
Cc: #kopete

D8319: Split the UI initialization and fix the about box

[Luigi Toscano]

This revision was automatically updated to reflect the committed changes.
Closed by commit R434:d7dbacb48312: Split the UI initialization and fix the 
about box (authored by ltoscano).

REPOSITORY
  R434 Kopete

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8319?vs=20831&id=21509

REVISION DETAIL
  https://phabricator.kde.org/D8319

AFFECTED FILES
  kopete/kopeteapplication.cpp
  kopete/kopeteapplication.h
  kopete/main.cpp

To: ltoscano, pali, mlaurent
Cc: #kopete

D8319: Split the UI initialization and fix the about box

[Luigi Toscano]

ltoscano added a comment.


  ping! (Can you please check if this landed in the moderation queue of 
kopete-devel@ and maybe whitelist the emails from phabricator?)

REPOSITORY
  R434 Kopete

REVISION DETAIL
  https://phabricator.kde.org/D8319

To: ltoscano, pali, mlaurent
Cc: #kopete

Re: Review Request 124305: Remove K3 classes from kopete main application

[Pali Rohár]

> On okt. 3, 2017, 1:08 dopoludnia, Luigi Toscano wrote:
> > This was committed as 
> > https://commits.kde.org/kopete/ea461c02b22681ca50bca40e83c9da6ea517b582
> > 
> > but for some reason the git hook did not close it (maybe because not on the 
> > master branch? I don't remember).

Luigi, I let open all review requests which were not merged into master. And 
patch in this review request was not merged into master, because it has open 
issue.


- Pali


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124305/#review103774
---


On okt. 4, 2017, 11:22 popoludní, R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124305/
> ---
> 
> (Updated okt. 4, 2017, 11:22 popoludní)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Removes all occurences of the K3ListBox classes in the kopete main 
> application.
> 
> 
> Diffs
> -
> 
>   kopete/chatwindow/chatview.cpp f92d5fe8c58420ce2d7008d33441e26020cb9dd4 
>   kopete/contactlist/kopeteaddrbookexport.h 
> 4774ba8efe89cea5282a9566ec685a913012cece 
>   kopete/contactlist/kopeteaddrbookexport.cpp 
> 8f285bf23dcad7336bd05b2697a300e983ceca73 
>   kopete/contactlist/kopeteaddrbookexportui.ui 
> ec6ec9bc5c693b6df06499062defd1865a0a9c4f 
>   kopete/contactlist/kopetestatusgroupviewitem.h 
> fb4a20648e1b12d464e98c51b8638f7d618ef53f 
>   kopete/contactlist/kopetestatusgroupviewitem.cpp 
> 3eb746fbbcad24a562cb9a224186a316b1c9dfe4 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/124305/diff/4/
> 
> 
> Testing
> ---
> 
> Build succeeded.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

Re: Review Request 124349: Remove kde3 dependencies from gadu protocol

[Pali Rohár]

> On júl 15, 2015, 6:43 dopoludnia, Laurent Montel wrote:
> > protocols/gadu/gadueditcontact.cpp
> > Lines 110 (patched)
> > 
> >
> > So item which is not selectable and disable ?
> 
> R.Harish  Navnit wrote:
> The default value for flags is { Qt::ItemIsSelectable | 
> Qt::ItemIsUserCheckable | Qt::ItemIsEnabled | Qt::ItemIsDragEnabled }. That 
> works better perhaps. Is that what you're saying ?
> 
> Laurent Montel wrote:
> yep but you change flags you don't have new feature you assign just to 
> ItemIsUserCheckable
> 
> R.Harish  Navnit wrote:
> I'm not sure I understood your initial comment here. Were you asking 
> about items that are not selectable and disabled ? In that case setting the 
> flag to Qt::ItemIsCheckable is pointless, yes. right ? 
> 
> In the patch for this, I have done something like this : 
> 
> ```C++
> if (item->isDisabled())
> item->setFlags(Qt::ItemIsUserCheckable);
> ```
> 
> Is that enough ?

@Laurent, is this fixed?


- Pali


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124349/#review82519
---


On okt. 4, 2017, 11:16 popoludní, R.Harish  Navnit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124349/
> ---
> 
> (Updated okt. 4, 2017, 11:16 popoludní)
> 
> 
> Review request for Kopete, Laurent Montel and Pali Rohár.
> 
> 
> Repository: kopete
> 
> 
> Description
> ---
> 
> Q3WidgetStack, Q3ButtonGroup, Q3ListViews and other classes removed.
> 
> 
> Diffs
> -
> 
>   protocols/gadu/gaduaddcontactpage.cpp 
> e55bd301b2bf4a6205c88b02c798b0094ceced5f 
>   protocols/gadu/gadueditaccount.cpp 20635e38b1bb4a99d220830747cc48731c7ccc63 
>   protocols/gadu/gadueditcontact.h 6b93fa3d84f7e54ec7ca3269f423e3b29e117449 
>   protocols/gadu/gadueditcontact.cpp 7475a4954173da0e9aac657cf90f4a3d2986bb4a 
>   protocols/gadu/gadupubdir.cpp c264519c44aa273039f0acb664e1a5df90b1640f 
>   protocols/gadu/gadusession.h 401a8eb16acf8e3263d20a36cd14b7eeb393783e 
>   protocols/gadu/ui/gaduadd.ui fdbe4a63fe1336095479b8f690a039e1652e7195 
>   protocols/gadu/ui/gadusearch.ui 3011347434e10205a390adf872a6a80077afb6b2 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/124349/diff/2/
> 
> 
> Testing
> ---
> 
> Build succeeded.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

Re: Kopete & KF5 switch

[Pali Rohár]

On Monday 07 August 2017 10:43:17 Pali Rohár wrote:
> On Monday 07 August 2017 10:26:46 Luigi Toscano wrote:
> > Il 07 agosto 2017 09:34:37 CEST, "Pali Rohár"  ha 
> > scritto:
> > 
> > >
> > >Anyway, I rebased kf5 branch on top of master with (semi-manual)
> > >conflicts resolution and found out that changes between kf5 branch and
> > >"kf5 rebased on top of master" differs. And I suspect that some merge
> > >commits which was done from master to kf5 were incorrectly.
> > 
> > Do you mean merged, not rebased, right?
> 
> I mean real git rebase but result in new temporary branch.

Hi! Now I rebased current kf5 branch on top of current master and pushed
it into my cloned git repository. Available at:

https://cgit.kde.org/clones/kopete/pali/kopete.git/?h=master-kf5

Reason for it: in kf5 branch are some older version of patches (with
errors) which were properly fixed in version of patches, which then were
integrated into master branch. Having periodical merge from master into
kf5 made 1) git history hard to interpret and 2) inability to use either
git bisect or git blame. It is really a bad idea to have two different
versions of one patch in two different branches in git which are then
merged...

Now diff between above my branch (master-kf5) and kf5 seems to be clean
and I would propose to use this branch which would be merged into master
(instead of original kf5).

-- 
Pali Rohár
pali.ro...@gmail.com