[PATCH] KVM: Automatic user feedback

[Alexander Graf]

We're constantly developing and improving KVM, implementing new awesome
features or simply fixing bugs in the existing code.

But do people actually use that new code? Are we maybe writing it all in
vain? Wouldn't it be nice to have some feeling for the number of users
actually using our code?

This patch enables us to stress test our automated test suite and at
the same time figure out if we actually have users. When using a new
kernel with this patch applied, the user will automatically send feedback,
telling us that there are people out there, trying recent versions!

Signed-off-by: Alexander Graf ag...@suse.de
---
 virt/kvm/kvm_main.c |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 0df522f..45f06f3 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1687,6 +1687,8 @@ static long kvm_vcpu_ioctl(struct file *filp,
vcpu_load(vcpu);
switch (ioctl) {
case KVM_RUN:
+   /* Automatic user feedback */
+   BUG();
r = -EINVAL;
if (arg)
goto out;
-- 
1.7.3.4

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: Automatic user feedback

[Joerg Roedel]

On Fri, Apr 01, 2011 at 10:33:11AM +0200, Alexander Graf wrote:
 We're constantly developing and improving KVM, implementing new awesome
 features or simply fixing bugs in the existing code.
 
 But do people actually use that new code? Are we maybe writing it all in
 vain? Wouldn't it be nice to have some feeling for the number of users
 actually using our code?
 
 This patch enables us to stress test our automated test suite and at
 the same time figure out if we actually have users. When using a new
 kernel with this patch applied, the user will automatically send feedback,
 telling us that there are people out there, trying recent versions!
 
 Signed-off-by: Alexander Graf ag...@suse.de

Great idea :D

Acked-by: Joerg Roedel j...@8bytes.org

 ---
  virt/kvm/kvm_main.c |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
 
 diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
 index 0df522f..45f06f3 100644
 --- a/virt/kvm/kvm_main.c
 +++ b/virt/kvm/kvm_main.c
 @@ -1687,6 +1687,8 @@ static long kvm_vcpu_ioctl(struct file *filp,
   vcpu_load(vcpu);
   switch (ioctl) {
   case KVM_RUN:
 + /* Automatic user feedback */
 + BUG();
   r = -EINVAL;
   if (arg)
   goto out;
 -- 
 1.7.3.4
 
 --
 To unsubscribe from this list: send the line unsubscribe kvm in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: Automatic user feedback

[Stefan Hajnoczi]

On Fri, Apr 1, 2011 at 9:33 AM, Alexander Graf ag...@suse.de wrote:
 We're constantly developing and improving KVM, implementing new awesome
 features or simply fixing bugs in the existing code.

 But do people actually use that new code? Are we maybe writing it all in
 vain? Wouldn't it be nice to have some feeling for the number of users
 actually using our code?

 This patch enables us to stress test our automated test suite and at
 the same time figure out if we actually have users. When using a new
 kernel with this patch applied, the user will automatically send feedback,
 telling us that there are people out there, trying recent versions!

 Signed-off-by: Alexander Graf ag...@suse.de
 ---
  virt/kvm/kvm_main.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

/me migrates to linux-kvm
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html