Re: [PATCH] KVM: PIC: fix use of uninitialised variable.

[Avi Kivity]

On 08/30/2012 01:32 PM, Jamie Iles wrote:
> Commit aea218f3cbbc (KVM: PIC: call ack notifiers for irqs that are
> dropped form irr) used an uninitialised variable to track whether an
> appropriate apic had been found.  This could result in calling the ack
> notifier incorrectly.

Thanks, applied to master for 3.6.


-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] KVM: PIC: fix use of uninitialised variable.

[Jamie Iles]

Commit aea218f3cbbc (KVM: PIC: call ack notifiers for irqs that are
dropped form irr) used an uninitialised variable to track whether an
appropriate apic had been found.  This could result in calling the ack
notifier incorrectly.

Cc: Gleb Natapov 
Cc: Avi Kivity 
Signed-off-by: Jamie Iles 
---
 arch/x86/kvm/i8259.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
index e498b18..9fc9aa7 100644
--- a/arch/x86/kvm/i8259.c
+++ b/arch/x86/kvm/i8259.c
@@ -318,7 +318,7 @@ static void pic_ioport_write(void *opaque, u32 addr, u32 
val)
if (val & 0x10) {
u8 edge_irr = s->irr & ~s->elcr;
int i;
-   bool found;
+   bool found = false;
struct kvm_vcpu *vcpu;
 
s->init4 = val & 1;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html