[PATCH] KVM: x86 emulator: simplify two-byte opcode check

[Wei Yongjun]

Two-byte opcode always start with 0x0F and the decode flags
of opcode 0xF0 is always 0, so remove dup check.

Signed-off-by: Wei Yongjun yj...@cn.fujitsu.com
---
 arch/x86/kvm/emulate.c |   12 +---
 1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 8763708..a465823 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -2405,13 +2405,11 @@ done_prefixes:
 
/* Opcode byte(s). */
opcode = opcode_table[c-b];
-   if (opcode.flags == 0) {
-   /* Two-byte opcode? */
-   if (c-b == 0x0f) {
-   c-twobyte = 1;
-   c-b = insn_fetch(u8, 1, c-eip);
-   opcode = twobyte_table[c-b];
-   }
+   /* Two-byte opcode? */
+   if (c-b == 0x0f) {
+   c-twobyte = 1;
+   c-b = insn_fetch(u8, 1, c-eip);
+   opcode = twobyte_table[c-b];
}
c-d = opcode.flags;
 
-- 
1.7.0.4


--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: x86 emulator: simplify two-byte opcode check

[Avi Kivity]

 On 08/05/2010 11:34 AM, Wei Yongjun wrote:
 Two-byte opcode always start with 0x0F and the decode flags
 of opcode 0xF0 is always 0, so remove dup check.

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html