Re: [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms
On Tue, Jan 31, 2012 at 8:30 AM, Matt Evans m...@ozlabs.org wrote: Commit d3923126a24212f1e746a84a575dadbd9f259418 added a bunch of nice error checking around ioevent__init() but the init may gracefully fail if ioevents simply aren't supported (PPC64 KVM). This commit adds a new return code for the init -- positive, but identifiable as 'not success 0'. Signed-off-by: Matt Evans m...@ozlabs.org Applied, thanks! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] kvm tools: Repair running on non ioeventfd-capable platforms
On Tue, 2012-01-31 at 17:30 +1100, Matt Evans wrote: Commit d3923126a24212f1e746a84a575dadbd9f259418 added a bunch of nice error checking around ioevent__init() but the init may gracefully fail if ioevents simply aren't supported (PPC64 KVM). This commit adds a new return code for the init -- positive, but identifiable as 'not success 0'. Signed-off-by: Matt Evans m...@ozlabs.org --- Sasha, you screwed PPC64! And it took me a month to notice hahaha! I only broke it two days ago :) -- Sasha. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] kvm tools: Repair running on non ioeventfd-capable platforms
Commit d3923126a24212f1e746a84a575dadbd9f259418 added a bunch of nice error checking around ioevent__init() but the init may gracefully fail if ioevents simply aren't supported (PPC64 KVM). This commit adds a new return code for the init -- positive, but identifiable as 'not success 0'. Signed-off-by: Matt Evans m...@ozlabs.org --- Sasha, you screwed PPC64! And it took me a month to notice hahaha! tools/kvm/ioeventfd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/kvm/ioeventfd.c b/tools/kvm/ioeventfd.c index 9133101..f2d5a30 100644 --- a/tools/kvm/ioeventfd.c +++ b/tools/kvm/ioeventfd.c @@ -67,7 +67,7 @@ int ioeventfd__init(struct kvm *kvm) ioeventfd_avail = kvm__supports_extension(kvm, KVM_CAP_IOEVENTFD); if (!ioeventfd_avail) - return -ENOSYS; + return 1; /* Not fatal, but let caller determine no-go. */ epoll_fd = epoll_create(IOEVENTFD_MAX_EVENTS); if (epoll_fd 0) -- 1.7.0.4 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
