Re: [PATCH 0/3] Prepare kvm for lto
On Sun, Sep 16, 2012 at 03:10:56PM +0300, Avi Kivity wrote: vmx.c has an lto-unfriendly bit, fix it up. While there, clean up our asm code. v2: add missing .global in case vmx_return and vmx_set_constant_host_state() become separated by lto Avi Kivity (3): KVM: VMX: Make lto-friendly KVM: VMX: Make use of asm.h KVM: SVM: Make use of asm.h Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] Prepare kvm for lto
vmx.c has an lto-unfriendly bit, fix it up. While there, clean up our asm code. v2: add missing .global in case vmx_return and vmx_set_constant_host_state() become separated by lto Avi Kivity (3): KVM: VMX: Make lto-friendly KVM: VMX: Make use of asm.h KVM: SVM: Make use of asm.h arch/x86/kvm/svm.c | 46 + arch/x86/kvm/vmx.c | 86 ++ 2 files changed, 61 insertions(+), 71 deletions(-) -- 1.7.12 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Prepare kvm for lto
On 09/12/2012 10:17 PM, Andi Kleen wrote: On Wed, Sep 12, 2012 at 05:50:41PM +0300, Avi Kivity wrote: vmx.c has an lto-unfriendly bit, fix it up. While there, clean up our asm code. Avi Kivity (3): KVM: VMX: Make lto-friendly KVM: VMX: Make use of asm.h KVM: SVM: Make use of asm.h Works for me in my LTO build, thanks Avi. I cannot guarantee I always hit the unit splitting case, but it looks good so far. Actually I think patch 1 is missing a .global vmx_return. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Prepare kvm for lto
On Thu, Sep 13, 2012 at 11:27:43AM +0300, Avi Kivity wrote: On 09/12/2012 10:17 PM, Andi Kleen wrote: On Wed, Sep 12, 2012 at 05:50:41PM +0300, Avi Kivity wrote: vmx.c has an lto-unfriendly bit, fix it up. While there, clean up our asm code. Avi Kivity (3): KVM: VMX: Make lto-friendly KVM: VMX: Make use of asm.h KVM: SVM: Make use of asm.h Works for me in my LTO build, thanks Avi. I cannot guarantee I always hit the unit splitting case, but it looks good so far. Actually I think patch 1 is missing a .global vmx_return. Ok can you add it please? It always depends how the LTO partitioner decides to split the subunits. I can run it with randomconfig in a loop over night. That's the best way I know to try to cover these cases. -Andi -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/3] Prepare kvm for lto
vmx.c has an lto-unfriendly bit, fix it up. While there, clean up our asm code. Avi Kivity (3): KVM: VMX: Make lto-friendly KVM: VMX: Make use of asm.h KVM: SVM: Make use of asm.h arch/x86/kvm/svm.c | 46 + arch/x86/kvm/vmx.c | 85 +- 2 files changed, 60 insertions(+), 71 deletions(-) -- 1.7.11.3 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/3] Prepare kvm for lto
On Wed, Sep 12, 2012 at 05:50:41PM +0300, Avi Kivity wrote: vmx.c has an lto-unfriendly bit, fix it up. While there, clean up our asm code. Avi Kivity (3): KVM: VMX: Make lto-friendly KVM: VMX: Make use of asm.h KVM: SVM: Make use of asm.h Works for me in my LTO build, thanks Avi. I cannot guarantee I always hit the unit splitting case, but it looks good so far. I replaced my patches with yours. Acked-by: Andi Kleen a...@linux.intel.com -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html