Re: [PATCH 1/1] kvm/mmu: Resolve compile warning

2009-10-13 Thread Marcelo Tosatti 
javier,

This is fixed in the -next branch of kvm.git. Thanks.

On Sun, Oct 11, 2009 at 02:28:23AM -0400, javier martinez canillas wrote:
 I got this compile warning with today linux-next:
 
 arch/x86/kvm/mmu.c: In function ‘kvm_set_pte_rmapp’:
 arch/x86/kvm/mmu.c:770: warning: cast to pointer from integer of different 
 size
 arch/x86/kvm/mmu.c: In function ‘kvm_set_spte_hva’:
 arch/x86/kvm/mmu.c:849: warning: cast from pointer to integer of different 
 size
 
 This patch solves the issue:
 
 Signed-off-by: Javier Martinez Canillas martinez.jav...@gmail.com

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] kvm/mmu: Resolve compile warning

2009-10-13 Thread Javier Martinez Canillas 
Thank you. Sorry for the noise.

Best regards

-
Javier Martínez Canillas
+595 981 88 66 58



On Tue, Oct 13, 2009 at 1:10 PM, Marcelo Tosatti mtosa...@redhat.com wrote:
 javier,

 This is fixed in the -next branch of kvm.git. Thanks.

 On Sun, Oct 11, 2009 at 02:28:23AM -0400, javier martinez canillas wrote:
 I got this compile warning with today linux-next:

 arch/x86/kvm/mmu.c: In function ‘kvm_set_pte_rmapp’:
 arch/x86/kvm/mmu.c:770: warning: cast to pointer from integer of different 
 size
 arch/x86/kvm/mmu.c: In function ‘kvm_set_spte_hva’:
 arch/x86/kvm/mmu.c:849: warning: cast from pointer to integer of different 
 size

 This patch solves the issue:

 Signed-off-by: Javier Martinez Canillas martinez.jav...@gmail.com


--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] kvm/mmu: Resolve compile warning

2009-10-12 Thread walter harms 


javier martinez canillas schrieb:
 I got this compile warning with today linux-next:
 
 arch/x86/kvm/mmu.c: In function ‘kvm_set_pte_rmapp’:
 arch/x86/kvm/mmu.c:770: warning: cast to pointer from integer of different 
 size
 arch/x86/kvm/mmu.c: In function ‘kvm_set_spte_hva’:
 arch/x86/kvm/mmu.c:849: warning: cast from pointer to integer of different 
 size
 
 This patch solves the issue:
 
 Signed-off-by: Javier Martinez Canillas martinez.jav...@gmail.com
 ---
  arch/x86/kvm/mmu.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
 index 20a2cd1..a0b2610 100644
 --- a/arch/x86/kvm/mmu.c
 +++ b/arch/x86/kvm/mmu.c
 @@ -767,7 +767,7 @@ static int kvm_set_pte_rmapp(struct kvm *kvm, unsigned 
 long *rmapp, u64 data)
  {
   int need_flush = 0;
   u64 *spte, new_spte;
 - pte_t *ptep = (pte_t *)data;
 + pte_t *ptep = (pte_t *)(unsigned long)data;
   pfn_t new_pfn;
  
   WARN_ON(pte_huge(*ptep));
 @@ -846,7 +846,7 @@ int kvm_unmap_hva(struct kvm *kvm, unsigned long hva)
  
  void kvm_set_spte_hva(struct kvm *kvm, unsigned long hva, pte_t pte)
  {
 - kvm_handle_hva(kvm, hva, (u64)pte, kvm_set_pte_rmapp);
 + kvm_handle_hva(kvm, hva, (unsigned long)pte, kvm_set_pte_rmapp);
  }
  
  static int kvm_age_rmapp(struct kvm *kvm, unsigned long *rmapp, u64 data)


Hi javier,
from the part is see in the patch i see the follwing problem:
 in kvm_set_pte_rmapp() you cast an U64 to (unsigned long)
it seems that kvm_set_pte_rmapp is mapped via kvm_handle_hva().
here pte_t pte is casted into (unsigned long).
Does look wired.


btw: there is also cleanup available claiming to fix the same warning
http://article.gmane.org/gmane.linux.kernel/900102

ntl: to much casting points to seroius trouble

re,
 wh
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] kvm/mmu: Resolve compile warning

2009-10-11 Thread javier martinez canillas 
I got this compile warning with today linux-next:

arch/x86/kvm/mmu.c: In function ‘kvm_set_pte_rmapp’:
arch/x86/kvm/mmu.c:770: warning: cast to pointer from integer of different size
arch/x86/kvm/mmu.c: In function ‘kvm_set_spte_hva’:
arch/x86/kvm/mmu.c:849: warning: cast from pointer to integer of different size

This patch solves the issue:

Signed-off-by: Javier Martinez Canillas martinez.jav...@gmail.com
---
 arch/x86/kvm/mmu.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 20a2cd1..a0b2610 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -767,7 +767,7 @@ static int kvm_set_pte_rmapp(struct kvm *kvm, unsigned long 
*rmapp, u64 data)
 {
int need_flush = 0;
u64 *spte, new_spte;
-   pte_t *ptep = (pte_t *)data;
+   pte_t *ptep = (pte_t *)(unsigned long)data;
pfn_t new_pfn;
 
WARN_ON(pte_huge(*ptep));
@@ -846,7 +846,7 @@ int kvm_unmap_hva(struct kvm *kvm, unsigned long hva)
 
 void kvm_set_spte_hva(struct kvm *kvm, unsigned long hva, pte_t pte)
 {
-   kvm_handle_hva(kvm, hva, (u64)pte, kvm_set_pte_rmapp);
+   kvm_handle_hva(kvm, hva, (unsigned long)pte, kvm_set_pte_rmapp);
 }
 
 static int kvm_age_rmapp(struct kvm *kvm, unsigned long *rmapp, u64 data)
-- 
1.6.0.4










--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html