[PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes

2010-12-03 Thread Alex Williamson 
Signed-off-by: Alex Williamson alex.william...@redhat.com
---

 hw/pci.h |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/pci.h b/hw/pci.h
index 34955d8..7c52637 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -124,8 +124,8 @@ enum {
 
 #define PCI_CAPABILITY_CONFIG_MAX_LENGTH 0x60
 #define PCI_CAPABILITY_CONFIG_DEFAULT_START_ADDR 0x40
-#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0x10
-#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x10
+#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0xa
+#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x0c
 
 typedef int (*msix_mask_notifier_func)(PCIDevice *, unsigned vector,
   int masked);

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes

2010-12-03 Thread Chris Wright 
* Alex Williamson (alex.william...@redhat.com) wrote:
 Signed-off-by: Alex Williamson alex.william...@redhat.com
 ---
 
  hw/pci.h |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/hw/pci.h b/hw/pci.h
 index 34955d8..7c52637 100644
 --- a/hw/pci.h
 +++ b/hw/pci.h
 @@ -124,8 +124,8 @@ enum {
  
  #define PCI_CAPABILITY_CONFIG_MAX_LENGTH 0x60
  #define PCI_CAPABILITY_CONFIG_DEFAULT_START_ADDR 0x40
 -#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0x10
 -#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x10
 +#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0xa

This is variable length.

 +#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x0c
  
  typedef int (*msix_mask_notifier_func)(PCIDevice *, unsigned vector,
  int masked);
 
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes

2010-12-03 Thread Alex Williamson 
On Fri, 2010-12-03 at 11:37 -0800, Chris Wright wrote:
 * Alex Williamson (alex.william...@redhat.com) wrote:
  Signed-off-by: Alex Williamson alex.william...@redhat.com
  ---
  
   hw/pci.h |4 ++--
   1 files changed, 2 insertions(+), 2 deletions(-)
  
  diff --git a/hw/pci.h b/hw/pci.h
  index 34955d8..7c52637 100644
  --- a/hw/pci.h
  +++ b/hw/pci.h
  @@ -124,8 +124,8 @@ enum {
   
   #define PCI_CAPABILITY_CONFIG_MAX_LENGTH 0x60
   #define PCI_CAPABILITY_CONFIG_DEFAULT_START_ADDR 0x40
  -#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0x10
  -#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x10
  +#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0xa
 
 This is variable length.

Yes, but this particular #define is only used by device assignment,
which only uses the minimum sized table.  Maybe as a follow-up patch we
should just remove these from pci.h and let device-assignment keep them
private.  Thanks,

Alex



--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] pci: MSI-X capability is 12 bytes, not 16, MSI is 10 bytes

2010-12-03 Thread Chris Wright 
* Alex Williamson (alex.william...@redhat.com) wrote:
 On Fri, 2010-12-03 at 11:37 -0800, Chris Wright wrote:
  * Alex Williamson (alex.william...@redhat.com) wrote:
   Signed-off-by: Alex Williamson alex.william...@redhat.com
   ---
   
hw/pci.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
   
   diff --git a/hw/pci.h b/hw/pci.h
   index 34955d8..7c52637 100644
   --- a/hw/pci.h
   +++ b/hw/pci.h
   @@ -124,8 +124,8 @@ enum {

#define PCI_CAPABILITY_CONFIG_MAX_LENGTH 0x60
#define PCI_CAPABILITY_CONFIG_DEFAULT_START_ADDR 0x40
   -#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0x10
   -#define PCI_CAPABILITY_CONFIG_MSIX_LENGTH 0x10
   +#define PCI_CAPABILITY_CONFIG_MSI_LENGTH 0xa
  
  This is variable length.
 
 Yes, but this particular #define is only used by device assignment,
 which only uses the minimum sized table.  Maybe as a follow-up patch we
 should just remove these from pci.h and let device-assignment keep them
 private.  Thanks,

Just thinking of keeping the ability to use DAC address.  Esp for those
512 way guests ;)
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html