Re: [PATCH 3/4] bitops: Introduce generic set_bit_le()

[Takuya Yoshikawa]

On Mon, 11 Jun 2012 14:10:26 +
Arnd Bergmann a...@arndb.de wrote:

 On Monday 11 June 2012, Takuya Yoshikawa wrote:
  From: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp
  
  Needed to replace test_and_set_bit_le() in virt/kvm/kvm_main.c which is
  being used for this missing function.
  
  Signed-off-by: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp
  Cc: Arnd Bergmann a...@arndb.de
 
 I would recommend adding the corresponding clear_bit_le() along with
 set_bit_le, so the next person who needs that doesn't have to make
 yet another patch.

I will do in the next version.

Now I have also noticed that I need to add the same code to powerpc's
bitops file.

Takuya
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/4] bitops: Introduce generic set_bit_le()

[Takuya Yoshikawa]

From: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp

Needed to replace test_and_set_bit_le() in virt/kvm/kvm_main.c which is
being used for this missing function.

Signed-off-by: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp
Cc: Arnd Bergmann a...@arndb.de
---
 include/asm-generic/bitops/le.h |5 +
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/asm-generic/bitops/le.h b/include/asm-generic/bitops/le.h
index f95c663..3e72143 100644
--- a/include/asm-generic/bitops/le.h
+++ b/include/asm-generic/bitops/le.h
@@ -54,6 +54,11 @@ static inline int test_bit_le(int nr, const void *addr)
return test_bit(nr ^ BITOP_LE_SWIZZLE, addr);
 }
 
+static inline void set_bit_le(int nr, void *addr)
+{
+   set_bit(nr ^ BITOP_LE_SWIZZLE, addr);
+}
+
 static inline void __set_bit_le(int nr, void *addr)
 {
__set_bit(nr ^ BITOP_LE_SWIZZLE, addr);
-- 
1.7.5.4

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] bitops: Introduce generic set_bit_le()

[Arnd Bergmann]

On Monday 11 June 2012, Takuya Yoshikawa wrote:
 From: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp
 
 Needed to replace test_and_set_bit_le() in virt/kvm/kvm_main.c which is
 being used for this missing function.
 
 Signed-off-by: Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp
 Cc: Arnd Bergmann a...@arndb.de

I would recommend adding the corresponding clear_bit_le() along with
set_bit_le, so the next person who needs that doesn't have to make
yet another patch.

Arnd
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html