Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net
From: Jason Wang jasow...@redhat.com Date: Sat, 8 Dec 2012 01:04:54 +0800 This series is an update version (hope the final version) of multiqueue (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were addressed, the work were based on Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the packets reception and transmission. Performance test show the aggregate latency were increased greately but may get some regression in small packet transmission. Due to this, multiqueue were disabled by default. If user want to benefit form the multiqueue, ethtool -L could be used to enable the feature. These changes look fine to me, applied, thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net
From: Jason Wang jasow...@redhat.com Date: Sat, 8 Dec 2012 01:04:54 +0800 This series is an update version (hope the final version) of multiqueue (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were addressed, the work were based on Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the packets reception and transmission. Performance test show the aggregate latency were increased greately but may get some regression in small packet transmission. Due to this, multiqueue were disabled by default. If user want to benefit form the multiqueue, ethtool -L could be used to enable the feature. Please review and comments. A protype implementation of qemu-kvm support could by found in git://github.com/jasowang/qemu-kvm-mq.git. To start a guest with two queues, you could specify the queues parameters to both tap and virtio-net like: ./qemu-kvm -netdev tap,queues=2,... -device virtio-net-pci,queues=2,... then enable the multiqueue through ethtool by: ethtool -L eth0 combined 2 It seems like most, if not all, of the feedback given for this series has been addressed by Jason. Can I get some ACKs? Thanks. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v3 0/3] Multiqueue support in virtio-net
On Fri, 07 Dec 2012 15:35:56 -0500 (EST) David Miller da...@davemloft.net wrote: From: Jason Wang jasow...@redhat.com Date: Sat, 8 Dec 2012 01:04:54 +0800 This series is an update version (hope the final version) of multiqueue (VIRTIO_NET_F_MQ) support in virtio-net driver. All previous comments were addressed, the work were based on Krishna Kumar's work to let virtio-net use multiple rx/tx queues to do the packets reception and transmission. Performance test show the aggregate latency were increased greately but may get some regression in small packet transmission. Due to this, multiqueue were disabled by default. If user want to benefit form the multiqueue, ethtool -L could be used to enable the feature. Please review and comments. A protype implementation of qemu-kvm support could by found in git://github.com/jasowang/qemu-kvm-mq.git. To start a guest with two queues, you could specify the queues parameters to both tap and virtio-net like: ./qemu-kvm -netdev tap,queues=2,... -device virtio-net-pci,queues=2,... then enable the multiqueue through ethtool by: ethtool -L eth0 combined 2 It seems like most, if not all, of the feedback given for this series has been addressed by Jason. Can I get some ACKs? Other than the minor style nit in the first patch, I see no issues. This is really needed by Virtual Routers. Acked-by: Stephen Hemminger shemmin...@vyatta.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
