Re: [PATCH] VT-d: remove useless header inclusion

2008-09-24 Thread Avi Kivity

Han, Weidong wrote:

Currently #include linux/intel-iommu.h is not needed in
virt/kvm/kvm_main.c. What's more, this inclusion may result in
compilation error in other architecture.

  


Applied, but please also fix intel-iommu.h to compile on all archs.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH] VT-d: remove useless header inclusion

2008-09-24 Thread Han, Weidong
Avi Kivity wrote:
 Han, Weidong wrote:
 Currently #include linux/intel-iommu.h is not needed in
 virt/kvm/kvm_main.c. What's more, this inclusion may result in
 compilation error in other architecture.
 
 
 
 Applied, but please also fix intel-iommu.h to compile on all archs.

Avi,

Current intel-iommu.h should be compiled on all archs. On linux-next,
they moved __iommu_clflush_cache() definition to intel-iomm.h, which
results in it cannot pass compilation on some archs, such as IA64.

Randy (Weidong)
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] VT-d: remove useless header inclusion

2008-09-24 Thread Avi Kivity

Han, Weidong wrote:

Avi Kivity wrote:
  

Han, Weidong wrote:


Currently #include linux/intel-iommu.h is not needed in
virt/kvm/kvm_main.c. What's more, this inclusion may result in
compilation error in other architecture.


  

Applied, but please also fix intel-iommu.h to compile on all archs.



Avi,

Current intel-iommu.h should be compiled on all archs. On linux-next,
they moved __iommu_clflush_cache() definition to intel-iomm.h, which
results in it cannot pass compilation on some archs, such as IA64.
  


Well, it still wants fixing, even if it is in linux-next only.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html