Re: [PATCH 1/3] context_tracking: remove duplicate enabled check

2015-11-09 Thread Rik van Riel 
On 10/27/2015 09:39 PM, Paolo Bonzini wrote:
> All calls to context_tracking_enter and context_tracking_exit
> are already checking context_tracking_is_enabled, except the
> context_tracking_user_enter and context_tracking_user_exit
> functions left in for the benefit of assembly calls.
> 
> Pull the check up to those functions, by making them simple
> wrappers around the user_enter and user_exit inline functions.
> 
> Cc: Andy Lutomirski 
> Cc: Frederic Weisbecker 
> Cc: Rik van Riel 
> Cc: Paul McKenney 
> Signed-off-by: Paolo Bonzini 

Reviewed-by: Rik van Riel 
Tested-by: Rik van Riel 

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] context_tracking: remove duplicate enabled check

2015-11-07 Thread Paolo Bonzini 


On 28/10/2015 06:19, Andy Lutomirski wrote:
> On Tue, Oct 27, 2015 at 6:39 PM, Paolo Bonzini  wrote:
>> All calls to context_tracking_enter and context_tracking_exit
>> are already checking context_tracking_is_enabled, except the
>> context_tracking_user_enter and context_tracking_user_exit
>> functions left in for the benefit of assembly calls.
>>
>> Pull the check up to those functions, by making them simple
>> wrappers around the user_enter and user_exit inline functions.
> 
> This makes my brain hurt.  Assuming that this survives a boot with
> CONFIG_CONTEXT_TRACKING_FORCE=y and CONFIG_PROVE_LOCKING=y (with the
> implied CONFIG_PROVE_RCU), then:
> 
> Acked-by: Andy Lutomirski 

Tested now.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] context_tracking: remove duplicate enabled check

2015-10-27 Thread Andy Lutomirski 
On Tue, Oct 27, 2015 at 6:39 PM, Paolo Bonzini  wrote:
> All calls to context_tracking_enter and context_tracking_exit
> are already checking context_tracking_is_enabled, except the
> context_tracking_user_enter and context_tracking_user_exit
> functions left in for the benefit of assembly calls.
>
> Pull the check up to those functions, by making them simple
> wrappers around the user_enter and user_exit inline functions.

This makes my brain hurt.  Assuming that this survives a boot with
CONFIG_CONTEXT_TRACKING_FORCE=y and CONFIG_PROVE_LOCKING=y (with the
implied CONFIG_PROVE_RCU), then:

Acked-by: Andy Lutomirski 
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html