Re: [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool

[pradeep]

On Mon, 27 Sep 2010 18:44:04 -0400
Lucas Meneghel Rodrigues l...@redhat.com wrote:


 +
 +vm = kvm_test_utils.get_living_vm(env, params.get(main_vm))
 +session = kvm_test_utils.wait_for_login(vm,
 +  timeout=int(params.get(login_timeout, 360)))
 +# Let's just error the test if we identify that there's no
 ethtool installed
 +if session.get_command_status(ethtool -h):
 +raise error.TestError(Command ethtool not installed on
 guest)
 +session2 = kvm_test_utils.wait_for_login(vm,
 +  timeout=int(params.get(login_timeout, 360)))
 +mtu = 1514
 +feature_status = {}
 +filename = /tmp/ethtool.dd
 +guest_ip = vm.get_address()
 +ethname = kvm_test_utils.get_linux_ifname(session,
 vm.get_mac_address(0))
 +supported_features = params.get(supported_features).split()

I guess split this expects input.

23:48:03 ERROR| Test failed: AttributeError: 'NoneType' object has no
attribute 'split'

22.12', '00:1a:4a:65:09:09': '192.168.122.66', '9a:52:2f:62:12:63':
'192.168.122.151', '9a:52:2f:62:6b:28': '192.168.122.35'}, 'version':
0, 'tcpdump': kvm_subprocess.kvm_tail instance at 0x27cb200} 23:48:05
INFO | ['iteration.1'] 23:48:05 ERROR| Exception escaping from test:
Traceback (most recent call last): File
/home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 412,
in _exec _call_test_function(self.execute, *p_args, **p_dargs) File
/home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 605,
in _call_test_function raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled AttributeError: 'NoneType' object has no
attribute 'split' Traceback (most recent call last): File
/home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 598,
in _call_test_function return func(*args, **dargs) File
/home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 284,
in execute postprocess_profiled_run, args, dargs) File
/home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 202,
in _call_run_once self.run_once_profiling(postprocess_profiled_run,
*args, **dargs) File
/home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 308,
in run_once_profiling self.run_once(*args, **dargs) File
/home/pradeep/vhost_net/autotest/client/tests/kvm/kvm.py, line 73, in
run_once run_func(self, params, env) File
/home/pradeep/vhost_net/autotest/client/tests/kvm/tests/ethtool.py,
line 185, in run_ethtool supported_features =
params.get(supported_features).split() AttributeError: 'NoneType'
object has no attribute 'split'



--Pradeep
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool

[Ryan Harper]

* pradeep psuri...@linux.vnet.ibm.com [2010-10-06 03:57]:
 On Mon, 27 Sep 2010 18:44:04 -0400
 Lucas Meneghel Rodrigues l...@redhat.com wrote:
 
 
  +
  +vm = kvm_test_utils.get_living_vm(env, params.get(main_vm))
  +session = kvm_test_utils.wait_for_login(vm,
  +  timeout=int(params.get(login_timeout, 360)))
  +# Let's just error the test if we identify that there's no
  ethtool installed
  +if session.get_command_status(ethtool -h):
  +raise error.TestError(Command ethtool not installed on
  guest)
  +session2 = kvm_test_utils.wait_for_login(vm,
  +  timeout=int(params.get(login_timeout, 360)))
  +mtu = 1514
  +feature_status = {}
  +filename = /tmp/ethtool.dd
  +guest_ip = vm.get_address()
  +ethname = kvm_test_utils.get_linux_ifname(session,
  vm.get_mac_address(0))
  +supported_features = params.get(supported_features).split()
 
 I guess split this expects input.
 
 23:48:03 ERROR| Test failed: AttributeError: 'NoneType' object has no
 attribute 'split'

That'll need an update to the tests_base.cfg file to ensure the test
type has that config value set.

Did the patchset miss updating tests_base.cfg.sample with this one ?

 
 22.12', '00:1a:4a:65:09:09': '192.168.122.66', '9a:52:2f:62:12:63':
 '192.168.122.151', '9a:52:2f:62:6b:28': '192.168.122.35'}, 'version':
 0, 'tcpdump': kvm_subprocess.kvm_tail instance at 0x27cb200} 23:48:05
 INFO | ['iteration.1'] 23:48:05 ERROR| Exception escaping from test:
 Traceback (most recent call last): File
 /home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 412,
 in _exec _call_test_function(self.execute, *p_args, **p_dargs) File
 /home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 605,
 in _call_test_function raise error.UnhandledTestFail(e)
 UnhandledTestFail: Unhandled AttributeError: 'NoneType' object has no
 attribute 'split' Traceback (most recent call last): File
 /home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 598,
 in _call_test_function return func(*args, **dargs) File
 /home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 284,
 in execute postprocess_profiled_run, args, dargs) File
 /home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 202,
 in _call_run_once self.run_once_profiling(postprocess_profiled_run,
 *args, **dargs) File
 /home/pradeep/vhost_net/autotest/client/common_lib/test.py, line 308,
 in run_once_profiling self.run_once(*args, **dargs) File
 /home/pradeep/vhost_net/autotest/client/tests/kvm/kvm.py, line 73, in
 run_once run_func(self, params, env) File
 /home/pradeep/vhost_net/autotest/client/tests/kvm/tests/ethtool.py,
 line 185, in run_ethtool supported_features =
 params.get(supported_features).split() AttributeError: 'NoneType'
 object has no attribute 'split'
 
 
 
 --Pradeep
 --
 To unsubscribe from this list: send the line unsubscribe kvm in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ry...@us.ibm.com
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool

[Lucas Meneghel Rodrigues]

On Wed, 2010-10-06 at 10:55 -0500, Ryan Harper wrote:
 * pradeep psuri...@linux.vnet.ibm.com [2010-10-06 03:57]:
  On Mon, 27 Sep 2010 18:44:04 -0400
  Lucas Meneghel Rodrigues l...@redhat.com wrote:
  
  
   +
   +vm = kvm_test_utils.get_living_vm(env, params.get(main_vm))
   +session = kvm_test_utils.wait_for_login(vm,
   +  timeout=int(params.get(login_timeout, 360)))
   +# Let's just error the test if we identify that there's no
   ethtool installed
   +if session.get_command_status(ethtool -h):
   +raise error.TestError(Command ethtool not installed on
   guest)
   +session2 = kvm_test_utils.wait_for_login(vm,
   +  timeout=int(params.get(login_timeout, 360)))
   +mtu = 1514
   +feature_status = {}
   +filename = /tmp/ethtool.dd
   +guest_ip = vm.get_address()
   +ethname = kvm_test_utils.get_linux_ifname(session,
   vm.get_mac_address(0))
   +supported_features = params.get(supported_features).split()
  
  I guess split this expects input.
  
  23:48:03 ERROR| Test failed: AttributeError: 'NoneType' object has no
  attribute 'split'
 
 That'll need an update to the tests_base.cfg file to ensure the test
 type has that config value set.
 
 Did the patchset miss updating tests_base.cfg.sample with this one ?

I think pradeep forgot to update tests_base.cfg indeed. It's working
fine for me.

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html