Re: bad? encoding for KVM_SET_IRQCHIP

2009-10-08 Thread Avi Kivity

On 10/06/2009 12:40 AM, Robert Henry wrote:

I am concerned about an apparent misencoding for ioctl KVM_SET_IRQCHIP

kvm/include/linux/kvm.h defines KVM_SET_IRQCHIP as

#define KVM_SET_IRQCHIP   _IOR(KVMIO,  0x63, struct kvm_irqchip)

But the verb SET in the ioctl name would imply that the ioctl
encoding constructor should be _IOW, not _IOR.

Note also that KVM_SET_PIT seems to have the same encoding issue.

   


Yes, there are some bad encodings for the kvm ioctls.  Unfortunately 
Linux doesn't enforce the directions, so it wasn't discovered in time.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


bad? encoding for KVM_SET_IRQCHIP

2009-10-05 Thread Robert Henry
I am concerned about an apparent misencoding for ioctl KVM_SET_IRQCHIP

kvm/include/linux/kvm.h defines KVM_SET_IRQCHIP as

#define KVM_SET_IRQCHIP   _IOR(KVMIO,  0x63, struct kvm_irqchip)

But the verb SET in the ioctl name would imply that the ioctl
encoding constructor should be _IOW, not _IOR.

Note also that KVM_SET_PIT seems to have the same encoding issue.

Robert Henry
r...@google.com
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html